)]}'
{"tools/tox_install.sh":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"337adde60f8c8e68b837409a561f2e6761442afc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"+#!/usr/bin/env bash"},{"line_number":2,"context_line":"+"},{"line_number":3,"context_line":"+# Client constraint file contains this client version pin that is in conflict"},{"line_number":4,"context_line":"+# with installing the client from source. We should remove the version pin in"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a1ff146_0b83afcd","line":1,"updated":"2017-03-15 00:45:44.000000000","message":"The \"+\" characters from a diff have made it into this script. Please fix.","commit_id":"a92392bbde9f8aea9be192dbbb3786478c3d6a6b"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"501389ac83f5991ad1c3a87feac10a5519f252fd","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# NOTE(tonyb): Place this in the tox enviroment\u0027s log dir so it will get"},{"line_number":13,"context_line":"# published to logs.openstack.org for easy debugging."},{"line_number":14,"context_line":"localfile\u003d\"$VIRTUAL_ENV/log/upper-constraints.txt\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [[ \"$CONSTRAINTS_FILE\" !\u003d http* ]]; then"},{"line_number":17,"context_line":"    CONSTRAINTS_FILE\u003d\"file://$CONSTRAINTS_FILE\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a1ff146_ae41ad0d","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":23},"updated":"2017-03-15 14:35:31.000000000","message":"What if $VIRTUAL_ENV is not set (i.e., we\u0027re not running in a virtual environment)?","commit_id":"06bc219bca05e5d6a952021461d2fb87f9f6f056"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"b9a45d8f90a73d4edfba2c0d61875ca5c730f353","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# NOTE(tonyb): Place this in the tox enviroment\u0027s log dir so it will get"},{"line_number":13,"context_line":"# published to logs.openstack.org for easy debugging."},{"line_number":14,"context_line":"localfile\u003d\"$VIRTUAL_ENV/log/upper-constraints.txt\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [[ \"$CONSTRAINTS_FILE\" !\u003d http* ]]; then"},{"line_number":17,"context_line":"    CONSTRAINTS_FILE\u003d\"file://$CONSTRAINTS_FILE\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a1ff146_623fafd6","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":23},"in_reply_to":"3a1ff146_ae41ad0d","updated":"2017-03-16 01:20:03.000000000","message":"Oops, please disregard this comment. We are always expected to be running in an isolated Python environment created by virtualenv [1].\n\n[1] https://docs.openstack.org/project-team-guide/project-setup/python.html#virtual-environment","commit_id":"06bc219bca05e5d6a952021461d2fb87f9f6f056"}],"tox.ini":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"501389ac83f5991ad1c3a87feac10a5519f252fd","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"   BRANCH_NAME\u003dmaster"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a1ff146_29ae9785","line":8,"updated":"2017-03-15 14:35:31.000000000","message":"Doesn\u0027t this line satisfy what the newly introduced tox_install.sh do?","commit_id":"06bc219bca05e5d6a952021461d2fb87f9f6f056"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"828ad75b67eae53c4dd17e7cbd01815536873c94","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"   BRANCH_NAME\u003dmaster"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1a1ced50_57e2a504","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":160},"updated":"2017-03-17 09:12:22.000000000","message":"If we are not passing the tox_install script here, then where is it being used? Is it meant to be run manually?","commit_id":"06bc219bca05e5d6a952021461d2fb87f9f6f056"}]}