)]}'
{"barbican_tempest_plugin/config.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"52345c191ac516aa5e0cbe001a24292efe013e66","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                                  \"available\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ephemeral_storage_encryption_group \u003d \\"},{"line_number":24,"context_line":"                    cfg.OptGroup(name\u003d\"ephemeral-storage-encryption\","},{"line_number":25,"context_line":"                                 title\u003d\"Ephemeral storage encryption options\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"EphemeralStorageEncryptionGroup \u003d ["},{"line_number":28,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5ff73747_b63e1a27","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":78},"updated":"2017-04-24 17:51:15.000000000","message":"Improper indentation. Will be fixed in next patch.","commit_id":"a803c3a6d308a78b1598702483c4a1e716aabaf0"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"b1bbbd599a39ee3e9115629ec34b2e6c56e63939","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                             help\u003d\"Whether or not barbican is expected to be \""},{"line_number":21,"context_line":"                                  \"available\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ephemeral_storage_encryption_group \u003d \\"},{"line_number":24,"context_line":"    cfg.OptGroup(name\u003d\"ephemeral-storage-encryption\","},{"line_number":25,"context_line":"                 title\u003d\"Ephemeral storage encryption options\")"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_c098b76b","line":23,"updated":"2017-04-24 19:48:02.000000000","message":"There\u0027s a nice way to wrap this without the line continuation:\n\nephemeral_storage_encryption_group \u003d cfg.OptGroup(\n    name\u003d\"ephemeral-storage-encryption\",\n    title\u003d\"Ephemeral storage encryption options\"\n)\n\nAlso the group name should probably contain underscores instead of dashes. Seems to be the convention for config stuff.","commit_id":"cd2e39b7df19c35b46c8ef49676e304766ec3f06"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"58a1fe2240fa412e1b94a9609463312d88477eae","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                             help\u003d\"Whether or not barbican is expected to be \""},{"line_number":21,"context_line":"                                  \"available\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ephemeral_storage_encryption_group \u003d \\"},{"line_number":24,"context_line":"    cfg.OptGroup(name\u003d\"ephemeral-storage-encryption\","},{"line_number":25,"context_line":"                 title\u003d\"Ephemeral storage encryption options\")"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_39ff96ab","line":23,"in_reply_to":"5ff73747_9e945046","updated":"2017-04-24 21:11:09.000000000","message":"But it may make more sense to keep with the underscores to keep consistent with what we have in nova.conf.","commit_id":"cd2e39b7df19c35b46c8ef49676e304766ec3f06"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"fc9c97ac244a987f89aa0e414fd71d5f0e576746","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                             help\u003d\"Whether or not barbican is expected to be \""},{"line_number":21,"context_line":"                                  \"available\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ephemeral_storage_encryption_group \u003d \\"},{"line_number":24,"context_line":"    cfg.OptGroup(name\u003d\"ephemeral-storage-encryption\","},{"line_number":25,"context_line":"                 title\u003d\"Ephemeral storage encryption options\")"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_9e945046","line":23,"in_reply_to":"5ff73747_c098b76b","updated":"2017-04-24 20:40:43.000000000","message":"Thanks for the tip, Dane.\n\nI\u0027m double-checking with #openstack-qa right now, but I think group names standardly use dashes instead of underscores, and their options use underscores [1].\n\n[1] https://docs.openstack.org/developer/tempest/plugin.html","commit_id":"cd2e39b7df19c35b46c8ef49676e304766ec3f06"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"bac98581836a65c9739c105a63df33b74fe9953b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    \"storage, and the name is shorthand for AES encryption \""},{"line_number":37,"context_line":"                    \"using the XTS encryption mode. Available ciphers depend \""},{"line_number":38,"context_line":"                    \"on kernel support. At the command line, type \""},{"line_number":39,"context_line":"                    \"\u0027cyrptsetup benchmark\u0027 to determine the available \""},{"line_number":40,"context_line":"                    \"options (and see benchmark results), or go to \""},{"line_number":41,"context_line":"                    \"/proc/crypto.\"),"},{"line_number":42,"context_line":"    cfg.IntOpt(\u0027key_size\u0027,"}],"source_content_type":"text/x-python","patch_set":27,"id":"1f013ff3_6a9fa7b4","line":39,"range":{"start_line":39,"start_character":22,"end_line":39,"end_character":32},"updated":"2017-05-12 18:20:52.000000000","message":"cryptsetup","commit_id":"032e64799dfe6ca29dff0f9c3e59136f9268bb26"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"68eaeebb3a5715d93fd30cfc75c74a667408c1d1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    \"storage, and the name is shorthand for AES encryption \""},{"line_number":37,"context_line":"                    \"using the XTS encryption mode. Available ciphers depend \""},{"line_number":38,"context_line":"                    \"on kernel support. At the command line, type \""},{"line_number":39,"context_line":"                    \"\u0027cyrptsetup benchmark\u0027 to determine the available \""},{"line_number":40,"context_line":"                    \"options (and see benchmark results), or go to \""},{"line_number":41,"context_line":"                    \"/proc/crypto.\"),"},{"line_number":42,"context_line":"    cfg.IntOpt(\u0027key_size\u0027,"}],"source_content_type":"text/x-python","patch_set":27,"id":"1f013ff3_222beceb","line":39,"range":{"start_line":39,"start_character":22,"end_line":39,"end_character":32},"in_reply_to":"1f013ff3_6a9fa7b4","updated":"2017-05-15 14:27:29.000000000","message":"Done","commit_id":"032e64799dfe6ca29dff0f9c3e59136f9268bb26"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"7404ffe029fe7cdf82138ba75cdd449dc4010f5a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                default\u003dFalse,"},{"line_number":30,"context_line":"                help\u003d\"Does the test environment support ephemeral storage \""},{"line_number":31,"context_line":"                     \"encryption?\"),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027cipher\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027aes-xts-plain64\u0027,"},{"line_number":34,"context_line":"               help\u003d\"The cipher and mode used to encrypt ephemeral storage. \""},{"line_number":35,"context_line":"                    \"AES-XTS is recommended by NIST specifically for disk \""},{"line_number":36,"context_line":"                    \"storage, and the name is shorthand for AES encryption \""},{"line_number":37,"context_line":"                    \"using the XTS encryption mode. Available ciphers depend \""},{"line_number":38,"context_line":"                    \"on kernel support. At the command line, type \""},{"line_number":39,"context_line":"                    \"\u0027cryptsetup benchmark\u0027 to determine the available \""},{"line_number":40,"context_line":"                    \"options (and see benchmark results), or go to \""},{"line_number":41,"context_line":"                    \"/proc/crypto.\"),"},{"line_number":42,"context_line":"    cfg.IntOpt(\u0027key_size\u0027,"},{"line_number":43,"context_line":"               default\u003d256,"},{"line_number":44,"context_line":"               help\u003d\"The key size used to encrypt ephemeral storage.\"),"},{"line_number":45,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":28,"id":"1f013ff3_88d3d138","line":44,"range":{"start_line":32,"start_character":0,"end_line":44,"end_character":71},"updated":"2017-05-16 22:04:11.000000000","message":"I see where these options are checked in the skip_checks method, but other than that I don\u0027t see where these values are being used.  Did you mean to use them in pre_test_hook.sh?","commit_id":"ad9f014597bcab3fa5cb27f541d91548b4d419cb"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"feb7c332ca79433c03a8bca95ba2b3a6fff0b2d4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                default\u003dFalse,"},{"line_number":30,"context_line":"                help\u003d\"Does the test environment support ephemeral storage \""},{"line_number":31,"context_line":"                     \"encryption?\"),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027cipher\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027aes-xts-plain64\u0027,"},{"line_number":34,"context_line":"               help\u003d\"The cipher and mode used to encrypt ephemeral storage. \""},{"line_number":35,"context_line":"                    \"AES-XTS is recommended by NIST specifically for disk \""},{"line_number":36,"context_line":"                    \"storage, and the name is shorthand for AES encryption \""},{"line_number":37,"context_line":"                    \"using the XTS encryption mode. Available ciphers depend \""},{"line_number":38,"context_line":"                    \"on kernel support. At the command line, type \""},{"line_number":39,"context_line":"                    \"\u0027cryptsetup benchmark\u0027 to determine the available \""},{"line_number":40,"context_line":"                    \"options (and see benchmark results), or go to \""},{"line_number":41,"context_line":"                    \"/proc/crypto.\"),"},{"line_number":42,"context_line":"    cfg.IntOpt(\u0027key_size\u0027,"},{"line_number":43,"context_line":"               default\u003d256,"},{"line_number":44,"context_line":"               help\u003d\"The key size used to encrypt ephemeral storage.\"),"},{"line_number":45,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff0f0b1f_7098ad69","line":44,"range":{"start_line":32,"start_character":0,"end_line":44,"end_character":71},"in_reply_to":"1f013ff3_88d3d138","updated":"2017-05-17 16:55:00.000000000","message":"They are used in lines 40-43 of pre_test_hook.sh","commit_id":"ad9f014597bcab3fa5cb27f541d91548b4d419cb"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"53df8b8dbd291d7d3ce65dbc45d98f846df96c01","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                default\u003dFalse,"},{"line_number":30,"context_line":"                help\u003d\"Does the test environment support ephemeral storage \""},{"line_number":31,"context_line":"                     \"encryption?\"),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027cipher\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027aes-xts-plain64\u0027,"},{"line_number":34,"context_line":"               help\u003d\"The cipher and mode used to encrypt ephemeral storage. \""},{"line_number":35,"context_line":"                    \"AES-XTS is recommended by NIST specifically for disk \""},{"line_number":36,"context_line":"                    \"storage, and the name is shorthand for AES encryption \""},{"line_number":37,"context_line":"                    \"using the XTS encryption mode. Available ciphers depend \""},{"line_number":38,"context_line":"                    \"on kernel support. At the command line, type \""},{"line_number":39,"context_line":"                    \"\u0027cryptsetup benchmark\u0027 to determine the available \""},{"line_number":40,"context_line":"                    \"options (and see benchmark results), or go to \""},{"line_number":41,"context_line":"                    \"/proc/crypto.\"),"},{"line_number":42,"context_line":"    cfg.IntOpt(\u0027key_size\u0027,"},{"line_number":43,"context_line":"               default\u003d256,"},{"line_number":44,"context_line":"               help\u003d\"The key size used to encrypt ephemeral storage.\"),"},{"line_number":45,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff0f0b1f_fc901398","line":44,"range":{"start_line":32,"start_character":0,"end_line":44,"end_character":71},"in_reply_to":"ff0f0b1f_7098ad69","updated":"2017-05-17 20:47:57.000000000","message":"Right, ok, I see where you are setting the config values in the $TEMPEST_CONFIG (vs. the $NOVA_CONFIG section), but I don\u0027t think these values, cipher and key_size, are needed, please see my comments on test_ephemeral_disk_encryption.py","commit_id":"ad9f014597bcab3fa5cb27f541d91548b4d419cb"}],"barbican_tempest_plugin/plugin.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"aec4761f3c40dacd52fcc9512f3101916902796b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # Register ephemeral storage encryption options"},{"line_number":37,"context_line":"        conf.register_group(project_config.ephemeral_storage_encryption_group)"},{"line_number":38,"context_line":"        conf.register_opts(project_config.EphemeralStorageEncryptionGroup,"},{"line_number":39,"context_line":"                           project_config.ephemeral_storage_encryption_group)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def get_opt_lists(self):"},{"line_number":42,"context_line":"        return [(\u0027service_available\u0027, [project_config.service_option])]"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f044301_03d1f7cd","line":39,"updated":"2017-05-05 13:52:29.000000000","message":"Why are there two calls to register_group here? Don\u0027t we only need to register the ephemeral opts once?","commit_id":"0a15cfc42956b8d6740466700aeef747fb2d8110"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"372a687a40a3bea0f7b424e50955040d295f3156","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # Register ephemeral storage encryption options"},{"line_number":37,"context_line":"        conf.register_group(project_config.ephemeral_storage_encryption_group)"},{"line_number":38,"context_line":"        conf.register_opts(project_config.EphemeralStorageEncryptionGroup,"},{"line_number":39,"context_line":"                           project_config.ephemeral_storage_encryption_group)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def get_opt_lists(self):"},{"line_number":42,"context_line":"        return [(\u0027service_available\u0027, [project_config.service_option])]"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f044301_51dd7b6e","line":39,"in_reply_to":"3f044301_03d1f7cd","updated":"2017-05-05 21:24:15.000000000","message":"`register_opts` registers the `ephemeral_storage_encryption_group` options to the `EphemeralStorageEncryptionGroup` group [1]. I believe just calling `register_group` will only make Tempest aware of  `EphemeralStorageEncryptionGroup`, but not of its options.\n\n[1] https://docs.openstack.org/developer/tempest/plugin.html#tempest.test_discover.plugins.TempestPlugin.register_opts","commit_id":"0a15cfc42956b8d6740466700aeef747fb2d8110"}],"barbican_tempest_plugin/tests/scenario/test_ephemeral_disk_encryption.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"317497819c9b70275fd0666fbb13230ae3a67f05","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            raise cls.skipException("},{"line_number":60,"context_line":"                \u0027Ephemeral storage encryption is not supported\u0027)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def setup_ephemeral_storage_lvm_device(self):"},{"line_number":63,"context_line":"        # truncate nova-lvm -s 2G"},{"line_number":64,"context_line":"        # sudo losetup /dev/loop1 nova-lvm"},{"line_number":65,"context_line":"        # sudo pvcreate /dev/loop1"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_b04d323c","line":62,"updated":"2017-04-12 17:15:56.000000000","message":"This should all happen in the pre_test stage right? You probably don\u0027t need this function.","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"2a9be2899a76f060d942fd52308aeca7e7ded8ee","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            raise cls.skipException("},{"line_number":60,"context_line":"                \u0027Ephemeral storage encryption is not supported\u0027)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def setup_ephemeral_storage_lvm_device(self):"},{"line_number":63,"context_line":"        # truncate nova-lvm -s 2G"},{"line_number":64,"context_line":"        # sudo losetup /dev/loop1 nova-lvm"},{"line_number":65,"context_line":"        # sudo pvcreate /dev/loop1"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_8ba323b2","line":62,"in_reply_to":"bff0334d_b04d323c","updated":"2017-04-12 17:56:59.000000000","message":"Somewhere these need to get set:     \n\n  export DEVSTACK_LOCAL_CONFIG\u003d\"NOVA_BACKEND\u003dLVM\"\n  export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"LVM_VOLUME_CLEAR\u003dnone\"\n\nIn nova\u0027s lvm gate, these get set in project-config: https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/lvm.yaml","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"c547f46e049c9780930ac13000536d8baf0b4104","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            raise cls.skipException("},{"line_number":60,"context_line":"                \u0027Ephemeral storage encryption is not supported\u0027)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def setup_ephemeral_storage_lvm_device(self):"},{"line_number":63,"context_line":"        # truncate nova-lvm -s 2G"},{"line_number":64,"context_line":"        # sudo losetup /dev/loop1 nova-lvm"},{"line_number":65,"context_line":"        # sudo pvcreate /dev/loop1"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ff52f3f_69cfa27f","line":62,"in_reply_to":"bff0334d_b04d323c","updated":"2017-04-13 15:57:22.000000000","message":"You\u0027re right. I\u0027ll move this chunk to the pre_test_hook.","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"317497819c9b70275fd0666fbb13230ae3a67f05","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # sudo vgcreate nova-lvm /dev"},{"line_number":67,"context_line":"        return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u0027\u0027)"},{"line_number":70,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027, \u0027object_storage\u0027)"},{"line_number":71,"context_line":"    def test_encrypted_ephemeral_lvm_storage(self):"},{"line_number":72,"context_line":"        test_string \u003d \u0027Once upon a time ...\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_9086ae65","line":69,"updated":"2017-04-12 17:15:56.000000000","message":"You need to add an ID for this test. Here\u0027s some instructions on how they work:\n\nhttps://docs.openstack.org/developer/tempest/HACKING.html#test-identification-with-idempotent-id","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"c547f46e049c9780930ac13000536d8baf0b4104","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # sudo vgcreate nova-lvm /dev"},{"line_number":67,"context_line":"        return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u0027\u0027)"},{"line_number":70,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027, \u0027object_storage\u0027)"},{"line_number":71,"context_line":"    def test_encrypted_ephemeral_lvm_storage(self):"},{"line_number":72,"context_line":"        test_string \u003d \u0027Once upon a time ...\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ff52f3f_e9a052a8","line":69,"in_reply_to":"bff0334d_9086ae65","updated":"2017-04-13 15:57:22.000000000","message":"Thanks for the link. I plan on doing this in a later commit.","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"317497819c9b70275fd0666fbb13230ae3a67f05","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u0027\u0027)"},{"line_number":70,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027, \u0027object_storage\u0027)"},{"line_number":71,"context_line":"    def test_encrypted_ephemeral_lvm_storage(self):"},{"line_number":72,"context_line":"        test_string \u003d \u0027Once upon a time ...\u0027"},{"line_number":73,"context_line":"        lvm_path \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_103e1ec0","line":70,"updated":"2017-04-12 17:15:56.000000000","message":"I don\u0027t think you need object_storage for this.","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"c547f46e049c9780930ac13000536d8baf0b4104","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        return"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u0027\u0027)"},{"line_number":70,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027, \u0027object_storage\u0027)"},{"line_number":71,"context_line":"    def test_encrypted_ephemeral_lvm_storage(self):"},{"line_number":72,"context_line":"        test_string \u003d \u0027Once upon a time ...\u0027"},{"line_number":73,"context_line":"        lvm_path \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ff52f3f_099b7672","line":70,"in_reply_to":"bff0334d_103e1ec0","updated":"2017-04-13 15:57:22.000000000","message":"I wasn\u0027t sure what I needed on this line yet. This will be added as tests are added.","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"317497819c9b70275fd0666fbb13230ae3a67f05","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027, \u0027object_storage\u0027)"},{"line_number":71,"context_line":"    def test_encrypted_ephemeral_lvm_storage(self):"},{"line_number":72,"context_line":"        test_string \u003d \u0027Once upon a time ...\u0027"},{"line_number":73,"context_line":"        lvm_path \u003d None"},{"line_number":74,"context_line":"        img_uuid \u003d self.sign_and_upload_image()"},{"line_number":75,"context_line":"        instance \u003d self.create_server(name\u003d\u0027signed_img_server\u0027,"},{"line_number":76,"context_line":"                                      image_id\u003dimg_uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_30cda2b6","line":73,"updated":"2017-04-12 17:15:56.000000000","message":"Is this supposed to be the same path as the volume group on the compute host? The backing files are not accessible from within the instance.","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"317497819c9b70275fd0666fbb13230ae3a67f05","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                      wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":78,"context_line":"        ssh_client \u003d self.get_remote_client(self.get_server_ip(instance))"},{"line_number":79,"context_line":"        ssh_client.exec_command(\u0027echo \"%s\" \u003e %s\u0027 % (test_string, lvm_path))"},{"line_number":80,"context_line":"        self.assertFalse(test_string in open(lvm_path, rb).read())"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_6567ee4e","line":80,"updated":"2017-04-12 17:15:56.000000000","message":"This should be \u0027rb\u0027 instead of rb, right?\n\nIn any case, this check is going to fail, since the instance is able to read its own storage. You\u0027re ssh\u0027d into an instance that\u0027s reading / writing it\u0027s own storage. It\u0027s only from the perspective of the compute host that the backing file (i.e. the instance\u0027s storage) is encrypted.","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"93ee8d4c393821c7986c3f214b836f93dd301827","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def skip_checks(cls):"},{"line_number":44,"context_line":"        super(EphemeralStorageEncryptionTest, cls).skip_checks()"},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        if NOVA_CONF.ephemeral_storage_encryption.enabled:"},{"line_number":47,"context_line":"            if not NOVA_CONF.ephemeral_storage_encryption.cipher:"},{"line_number":48,"context_line":"                raise lib_exc.InvalidConfiguration("},{"line_number":49,"context_line":"                    \u0027cipher must be specified in \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ffa3b31_c9c78945","line":46,"updated":"2017-04-18 20:01:16.000000000","message":"Generally speaking, you can\u0027t reliably access Nova\u0027s (or another service\u0027s) CONF from within tempest or a tempest plugin. You can check the Tempest CONF though, and the Tempest CONF has sections to \"mirror\" how the various core services are enabled.\n\nIf we want a skip check for this test, we would probably have to add an option called \"ephemeral_storage_encryption\" to the \"compute_feature_enabled\" section of the Tempest CONF and then check that option here.","commit_id":"e86a9b417956f466a134011d610d9a36fe204129"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"93ee8d4c393821c7986c3f214b836f93dd301827","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    #@decorators.idempotent_id(\u0027\u0027)"},{"line_number":67,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027)"},{"line_number":68,"context_line":"    def test_encrypted_ephemeral_lvm_storage(self):"},{"line_number":69,"context_line":"        test_string \u003d \u0027Once upon a time ...\u0027"},{"line_number":70,"context_line":"        #lvm_path \u003d None"},{"line_number":71,"context_line":"        img_uuid \u003d self.sign_and_upload_image()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ffa3b31_e96da532","line":68,"updated":"2017-04-18 20:01:16.000000000","message":"I think the best we can do with this test is write to and then read from a file on the instance after checking that the feature is enabled in the skip check. We can\u0027t assume that Tempest can access backing files on the compute host.","commit_id":"e86a9b417956f466a134011d610d9a36fe204129"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"93ee8d4c393821c7986c3f214b836f93dd301827","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                                      image_id\u003dimg_uuid,"},{"line_number":74,"context_line":"                                      wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":75,"context_line":"        ssh_client \u003d self.get_remote_client(self.get_server_ip(instance))"},{"line_number":76,"context_line":"        ssh_client.exec_command(\u0027echo \"%s\" \u003e %s\u0027 % (test_string, lvm_path))"},{"line_number":77,"context_line":"        #self.assertFalse(test_string in open(lvm_path, rb).read())"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ffa3b31_e92805e3","line":76,"updated":"2017-04-18 20:01:16.000000000","message":"The lvm path doesn\u0027t mean anything to the instance itself, it just refers to where the backing files live on the compute host. Writing anything to the instance\u0027s filesystem results in data being written to the lvm on the compute host.","commit_id":"e86a9b417956f466a134011d610d9a36fe204129"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"0b4aabd9bd72b1d12b5e374e2902386a7c5c4492","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        test_string \u003d \u0027Once upon a time ...\u0027"},{"line_number":56,"context_line":"        client_test_path \u003d \u0027/tmp/ephemeral_disk_ecryption_test\u0027"},{"line_number":57,"context_line":"        img_uuid \u003d self.sign_and_upload_image()"},{"line_number":58,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":59,"context_line":"        instance \u003d self.create_server(name\u003d\u0027signed_img_server\u0027,"},{"line_number":60,"context_line":"                                      image_id\u003dimg_uuid,"},{"line_number":61,"context_line":"                                      key_name\u003dkeypair[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f044301_35767ea6","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":15},"updated":"2017-05-04 18:55:19.000000000","message":"It looks like this may need to be \u0027self.keypair\u0027 instead.","commit_id":"6381796255c88aae751ebab84e34d235f3728efa"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"aec4761f3c40dacd52fcc9512f3101916902796b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027)"},{"line_number":54,"context_line":"    def test_encrypted_ephemeral_lvm_storage(self):"},{"line_number":55,"context_line":"        test_string \u003d \u0027Once upon a time ...\u0027"},{"line_number":56,"context_line":"        client_test_path \u003d \u0027/tmp/ephemeral_disk_ecryption_test\u0027"},{"line_number":57,"context_line":"        img_uuid \u003d self.sign_and_upload_image()"},{"line_number":58,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":59,"context_line":"        instance \u003d self.create_server(name\u003d\u0027signed_img_server\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f044301_c3cb0f51","line":56,"updated":"2017-05-05 13:52:29.000000000","message":"s/ephemeral_disk_ecryption_test/ephemeral_disk_encryption_test","commit_id":"0a15cfc42956b8d6740466700aeef747fb2d8110"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"53df8b8dbd291d7d3ce65dbc45d98f846df96c01","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def skip_checks(cls):"},{"line_number":40,"context_line":"        super(EphemeralStorageEncryptionTest, cls).skip_checks()"},{"line_number":41,"context_line":"        if CONF.ephemeral_storage_encryption.enabled:"},{"line_number":42,"context_line":"            if not CONF.ephemeral_storage_encryption.cipher:"},{"line_number":43,"context_line":"                raise lib_exc.InvalidConfiguration("},{"line_number":44,"context_line":"                    \u0027Ephemeral storage encryption cipher not specified\u0027)"},{"line_number":45,"context_line":"            if not CONF.ephemeral_storage_encryption.key_size:"},{"line_number":46,"context_line":"                raise lib_exc.InvalidConfiguration("},{"line_number":47,"context_line":"                    \u0027Ephemeral storage encryption key size not specified\u0027)"},{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            raise cls.skipException("},{"line_number":50,"context_line":"                \u0027Ephemeral storage encryption is not supported\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff0f0b1f_1cf507cc","line":47,"range":{"start_line":42,"start_character":12,"end_line":47,"end_character":74},"updated":"2017-05-17 20:47:57.000000000","message":"I see here that you are checking if CONF.ephemeral_storage_encryption.cipher and CONF.ephemeral_storage_encryption.key_size are set, but I don\u0027t see where these values are actually used below in the test.  Nova uses the values from the $NOVA_CONFIG section, not from $TEMPEST_CONFIG section.  Sorry if I am missing something.","commit_id":"ad9f014597bcab3fa5cb27f541d91548b4d419cb"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"7b592c562b3acf2dc19dcf63adfd04bbb2d288d7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest.lib import decorators"},{"line_number":18,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":19,"context_line":"from tempest import test"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from barbican_tempest_plugin.tests.scenario import barbican_manager"}],"source_content_type":"text/x-python","patch_set":29,"id":"ff0f0b1f_8271deaa","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":45},"updated":"2017-05-24 21:04:37.000000000","message":"This isn\u0027t used anymore","commit_id":"8a0485c3ac8f27f1854ede71f5b04b2679d11b50"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"be4d623cc774dca9311857630408d4b1569d831c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest.lib import decorators"},{"line_number":18,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":19,"context_line":"from tempest import test"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from barbican_tempest_plugin.tests.scenario import barbican_manager"}],"source_content_type":"text/x-python","patch_set":29,"id":"ff0f0b1f_68e90be4","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":45},"in_reply_to":"ff0f0b1f_8271deaa","updated":"2017-05-24 22:18:31.000000000","message":"Woops! Fixed.","commit_id":"8a0485c3ac8f27f1854ede71f5b04b2679d11b50"}],"tools/pre_test_hook.sh":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"317497819c9b70275fd0666fbb13230ae3a67f05","unresolved":false,"context_lines":[{"line_number":22,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF libvirt images_type \"lvm\"\u0027 $NOVACONF_PATH"},{"line_number":23,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF ephemeral_storage_encryption key_size \"256\"\u0027 $NOVACONF_PATH"},{"line_number":24,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF ephemeral_storage_encryption cipher \"aes-xts-plain64\"\u0027 $NOVACONF_PATH"},{"line_number":25,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF ephemeral_storage_encryption enabled \"True\"\u0027 $NOVACONF_PATH"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Allow dynamically created tempest users to create secrets"},{"line_number":28,"context_line":"# in barbican"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bff0334d_b0977245","line":25,"updated":"2017-04-12 17:15:56.000000000","message":"This should probably be done in devstack in lib/nova or in barbican in some of the scripts that modify devstack when barbican is enabled. Here\u0027s an example of modifying the config based on an env variable:\n\nhttps://review.openstack.org/#/c/383293/2/lib/nova","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"c547f46e049c9780930ac13000536d8baf0b4104","unresolved":false,"context_lines":[{"line_number":22,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF libvirt images_type \"lvm\"\u0027 $NOVACONF_PATH"},{"line_number":23,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF ephemeral_storage_encryption key_size \"256\"\u0027 $NOVACONF_PATH"},{"line_number":24,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF ephemeral_storage_encryption cipher \"aes-xts-plain64\"\u0027 $NOVACONF_PATH"},{"line_number":25,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF ephemeral_storage_encryption enabled \"True\"\u0027 $NOVACONF_PATH"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Allow dynamically created tempest users to create secrets"},{"line_number":28,"context_line":"# in barbican"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9ff52f3f_e904d2c8","line":25,"in_reply_to":"bff0334d_7051ea35","updated":"2017-04-13 15:57:22.000000000","message":"@Kaitlin, does it make a difference where we set the libvirt configurations?","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"2a9be2899a76f060d942fd52308aeca7e7ded8ee","unresolved":false,"context_lines":[{"line_number":22,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF libvirt images_type \"lvm\"\u0027 $NOVACONF_PATH"},{"line_number":23,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF ephemeral_storage_encryption key_size \"256\"\u0027 $NOVACONF_PATH"},{"line_number":24,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF ephemeral_storage_encryption cipher \"aes-xts-plain64\"\u0027 $NOVACONF_PATH"},{"line_number":25,"context_line":"sed -i \u0027/rm -f $NOVA_CONF/a \\\\tiniset $NOVA_CONF ephemeral_storage_encryption enabled \"True\"\u0027 $NOVACONF_PATH"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Allow dynamically created tempest users to create secrets"},{"line_number":28,"context_line":"# in barbican"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bff0334d_7051ea35","line":25,"in_reply_to":"bff0334d_b0977245","updated":"2017-04-12 17:56:59.000000000","message":"I agree that it would be nice to create an env variable in devstack to modify the configuration specifically for encrypted ephemeral storage, but we\u0027ll probably need to modify the configurations here until such a change goes through.\n\nJackie, you can probably use the [[post-config|$NOVA_CONF]] section above instead of using sed.  That would look like:\n\n  # If you were starting these configurations from scratch,\n  # you\u0027d need this line, but you can skip it because it was already added\n  # for image signature verification tests above and\n  # there hasn\u0027t been a new section started yet\n  # echo -e \u0027[[post-config|$NOVA_CONF]]\u0027 \u003e\u003e $LOCALCONF_PATH\n\n\n  # If you can set export DEVSTACK_LOCAL_CONFIG\u003d\"NOVA_BACKEND\u003dLVM\",\n  # (see my other comment, on the test file)\n  # then you won\u0027t need this section, as it will already be configured\n  # echo -e \u0027[libvirt]\u0027 \u003e\u003e $LOCALCONF_PATH\n  # echo -e \u0027images_volume_group \u003d nova-lvm\u0027 \u003e\u003e $LOCALCONF_PATH\n  # echo -e \u0027images_type \u003d lvm\u0027 \u003e\u003e $LOCALCONF_PATH\n\n\n  echo -e \u0027[ephemeral_storage_encryption]\u0027 \u003e\u003e $LOCALCONF_PATH\n  echo -e \u0027key_size \u003d 256\u0027 \u003e\u003e $LOCALCONF_PATH\n  echo -e \u0027cipher \u003d aes-xts-plain64\u0027 \u003e\u003e $LOCALCONF_PATH\n  echo -e \u0027enabled \u003d True\u0027 \u003e\u003e $LOCALCONF_PATH\n\nMore info about local.conf here: https://docs.openstack.org/developer/devstack/configuration.html#local-conf","commit_id":"a4ee7ae4540c1fe669c95e9e8afe8adde9a08f41"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"bac98581836a65c9739c105a63df33b74fe9953b","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Enable ephemeral storage encryption in Tempest"},{"line_number":40,"context_line":"echo -e \u0027[ephemeral_storage_encryption]\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":41,"context_line":"echo -e \u0027enabled \u003d True\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":42,"context_line":"echo -e \u0027key_size \u003d 256\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":43,"context_line":"echo -e \u0027cipher \u003d aes-xts-plain64\u0027 \u003e\u003e $LOCALCONF_PATH"}],"source_content_type":"text/x-sh","patch_set":27,"id":"1f013ff3_ea93b7a2","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":53},"updated":"2017-05-12 18:20:52.000000000","message":"nit: it would be nice if these three were in the same order as in lines 26-28","commit_id":"032e64799dfe6ca29dff0f9c3e59136f9268bb26"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"68eaeebb3a5715d93fd30cfc75c74a667408c1d1","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Enable ephemeral storage encryption in Tempest"},{"line_number":40,"context_line":"echo -e \u0027[ephemeral_storage_encryption]\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":41,"context_line":"echo -e \u0027enabled \u003d True\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":42,"context_line":"echo -e \u0027key_size \u003d 256\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":43,"context_line":"echo -e \u0027cipher \u003d aes-xts-plain64\u0027 \u003e\u003e $LOCALCONF_PATH"}],"source_content_type":"text/x-sh","patch_set":27,"id":"1f013ff3_0230f055","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":53},"in_reply_to":"1f013ff3_ea93b7a2","updated":"2017-05-15 14:27:29.000000000","message":"Done","commit_id":"032e64799dfe6ca29dff0f9c3e59136f9268bb26"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"7404ffe029fe7cdf82138ba75cdd449dc4010f5a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Glance v1 doesn\u0027t do signature verification on image upload"},{"line_number":36,"context_line":"echo -e \u0027[image-feature-enabled]\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":37,"context_line":"echo -e \u0027api_v1\u003dFalse\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Enable ephemeral storage encryption in Tempest"},{"line_number":40,"context_line":"echo -e \u0027[ephemeral_storage_encryption]\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":41,"context_line":"echo -e \u0027key_size \u003d 256\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":42,"context_line":"echo -e \u0027cipher \u003d aes-xts-plain64\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":43,"context_line":"echo -e \u0027enabled \u003d True\u0027 \u003e\u003e $LOCALCONF_PATH"}],"source_content_type":"text/x-sh","patch_set":28,"id":"1f013ff3_28871d12","line":43,"range":{"start_line":38,"start_character":0,"end_line":43,"end_character":43},"updated":"2017-05-16 22:04:11.000000000","message":"This is a duplicate of the section above in lines 23-28?","commit_id":"ad9f014597bcab3fa5cb27f541d91548b4d419cb"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"feb7c332ca79433c03a8bca95ba2b3a6fff0b2d4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Glance v1 doesn\u0027t do signature verification on image upload"},{"line_number":36,"context_line":"echo -e \u0027[image-feature-enabled]\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":37,"context_line":"echo -e \u0027api_v1\u003dFalse\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Enable ephemeral storage encryption in Tempest"},{"line_number":40,"context_line":"echo -e \u0027[ephemeral_storage_encryption]\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":41,"context_line":"echo -e \u0027key_size \u003d 256\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":42,"context_line":"echo -e \u0027cipher \u003d aes-xts-plain64\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":43,"context_line":"echo -e \u0027enabled \u003d True\u0027 \u003e\u003e $LOCALCONF_PATH"}],"source_content_type":"text/x-sh","patch_set":28,"id":"ff0f0b1f_b08e4525","line":43,"range":{"start_line":38,"start_character":0,"end_line":43,"end_character":43},"in_reply_to":"1f013ff3_28871d12","updated":"2017-05-17 16:55:00.000000000","message":"This is written to the Tempest configurations (see line 32), whereas lines 23-28 are written to the Nova configurations (see line 20)","commit_id":"ad9f014597bcab3fa5cb27f541d91548b4d419cb"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"33eef05893fe73dd6d183178331eedb075796e50","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Glance v1 doesn\u0027t do signature verification on image upload"},{"line_number":36,"context_line":"echo -e \u0027[image-feature-enabled]\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":37,"context_line":"echo -e \u0027api_v1\u003dFalse\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Enable ephemeral storage encryption in Tempest"},{"line_number":40,"context_line":"echo -e \u0027[ephemeral_storage_encryption]\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":41,"context_line":"echo -e \u0027key_size \u003d 256\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":42,"context_line":"echo -e \u0027cipher \u003d aes-xts-plain64\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":43,"context_line":"echo -e \u0027enabled \u003d True\u0027 \u003e\u003e $LOCALCONF_PATH"}],"source_content_type":"text/x-sh","patch_set":28,"id":"ff0f0b1f_74a68c11","line":43,"range":{"start_line":38,"start_character":0,"end_line":43,"end_character":43},"in_reply_to":"ff0f0b1f_5cf7fff6","updated":"2017-05-24 20:04:39.000000000","message":"Our only motivation to set ephemeral_storage_encryption settings in the $TEMPEST_CONFIG section is so that users have the option to enable/disable ephemeral storage encryption Tempest tests. I agree that we don\u0027t really need cipher and key_size. I will update this in my next commit unless someone objects.","commit_id":"ad9f014597bcab3fa5cb27f541d91548b4d419cb"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"53df8b8dbd291d7d3ce65dbc45d98f846df96c01","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Glance v1 doesn\u0027t do signature verification on image upload"},{"line_number":36,"context_line":"echo -e \u0027[image-feature-enabled]\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":37,"context_line":"echo -e \u0027api_v1\u003dFalse\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Enable ephemeral storage encryption in Tempest"},{"line_number":40,"context_line":"echo -e \u0027[ephemeral_storage_encryption]\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":41,"context_line":"echo -e \u0027key_size \u003d 256\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":42,"context_line":"echo -e \u0027cipher \u003d aes-xts-plain64\u0027 \u003e\u003e $LOCALCONF_PATH"},{"line_number":43,"context_line":"echo -e \u0027enabled \u003d True\u0027 \u003e\u003e $LOCALCONF_PATH"}],"source_content_type":"text/x-sh","patch_set":28,"id":"ff0f0b1f_5cf7fff6","line":43,"range":{"start_line":38,"start_character":0,"end_line":43,"end_character":43},"in_reply_to":"ff0f0b1f_b08e4525","updated":"2017-05-17 20:47:57.000000000","message":"Oh, I see.  Though I don\u0027t think you need cipher and key_size here in the $TEMPEST_CONFIG section. I don\u0027t see where those values are used.","commit_id":"ad9f014597bcab3fa5cb27f541d91548b4d419cb"}]}
