)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"00fe7a24fe2044c2d1f49a3339a18dee079102b8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This is essentially a duplicate of"},{"line_number":10,"context_line":"Ifb193b17b8d13f7a6d280b12fffd3dc2feeb47c4 for the Barbican plugin"},{"line_number":11,"context_line":"ensuring that we also test booting from an encrypted volume as the"},{"line_number":12,"context_line":"codepaths differ greatly in the Nova\u0027s libvirt driver at present."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifc7b115864806081fb63771d1daacdf42dd1f928"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff0f0b1f_f420b5ae","line":12,"range":{"start_line":12,"start_character":28,"end_line":12,"end_character":31},"updated":"2017-05-25 10:15:53.000000000","message":"I\u0027ll remove and respin once CI is green.","commit_id":"3fd1a4064c821b6af940ef069a2d61d34913172f"}],"barbican_tempest_plugin/tests/scenario/test_volume_encryption.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"eb14353008ae13a9fef748506890179c9d693064","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        LOG.info(\"Creating keypair and security group\")"},{"line_number":98,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":99,"context_line":"        security_group \u003d self._create_security_group()"},{"line_number":100,"context_line":"        self.create_server("},{"line_number":101,"context_line":"            name\u003d\u0027signed_img_server\u0027,"},{"line_number":102,"context_line":"            key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":103,"context_line":"            security_groups\u003d[{\u0027name\u0027: security_group[\u0027name\u0027]}],"},{"line_number":104,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":105,"context_line":"            **bdm"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @decorators.idempotent_id(\u0027afc012ce-5054-4b33-819a-b1567cdde1e1\u0027)"},{"line_number":109,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_1734f2dc","line":106,"range":{"start_line":100,"start_character":0,"end_line":106,"end_character":9},"updated":"2017-05-24 20:34:19.000000000","message":"I think image_id needs to be specified as an empty string (\u0027\u0027) to indicate that we are booting from a volume [1].\n\n[1] https://github.com/openstack/tempest/blob/master/tempest/common/compute.py#L60-L77","commit_id":"3fd1a4064c821b6af940ef069a2d61d34913172f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"00fe7a24fe2044c2d1f49a3339a18dee079102b8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        LOG.info(\"Creating keypair and security group\")"},{"line_number":98,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":99,"context_line":"        security_group \u003d self._create_security_group()"},{"line_number":100,"context_line":"        self.create_server("},{"line_number":101,"context_line":"            name\u003d\u0027signed_img_server\u0027,"},{"line_number":102,"context_line":"            key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":103,"context_line":"            security_groups\u003d[{\u0027name\u0027: security_group[\u0027name\u0027]}],"},{"line_number":104,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":105,"context_line":"            **bdm"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @decorators.idempotent_id(\u0027afc012ce-5054-4b33-819a-b1567cdde1e1\u0027)"},{"line_number":109,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_11806cf4","line":106,"range":{"start_line":100,"start_character":0,"end_line":106,"end_character":9},"in_reply_to":"ff0f0b1f_1734f2dc","updated":"2017-05-25 10:15:53.000000000","message":"Yeah good catch, this doesn\u0027t result in us booting from a image but it does reference an image in the domain XML [1]. I\u0027ll add this now.\n\n[1] http://logs.openstack.org/82/466782/1/check/gate-barbican-simple-crypto-dsvm-tempest-ubuntu-xenial-nv/2e1cc68/logs/screen-n-cpu.txt.gz#_May_22_16_18_41_172677","commit_id":"3fd1a4064c821b6af940ef069a2d61d34913172f"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"eb14353008ae13a9fef748506890179c9d693064","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        LOG.info(\"Creating keypair and security group\")"},{"line_number":121,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":122,"context_line":"        security_group \u003d self._create_security_group()"},{"line_number":123,"context_line":"        self.create_server("},{"line_number":124,"context_line":"            name\u003d\u0027signed_img_server\u0027,"},{"line_number":125,"context_line":"            key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":126,"context_line":"            security_groups\u003d[{\u0027name\u0027: security_group[\u0027name\u0027]}],"},{"line_number":127,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":128,"context_line":"            **bdm"},{"line_number":129,"context_line":"        )"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @decorators.idempotent_id(\u002789165fb4-5534-4b9d-8429-97ccffb8f86f\u0027)"},{"line_number":132,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_f72e1e8a","line":129,"range":{"start_line":123,"start_character":0,"end_line":129,"end_character":9},"updated":"2017-05-24 20:34:19.000000000","message":"I think image_id needs to be specified as an empty string (\u0027\u0027) to indicate that we are booting from a volume [1].\n\n[1] https://github.com/openstack/tempest/blob/master/tempest/common/compute.py#L60-L77","commit_id":"3fd1a4064c821b6af940ef069a2d61d34913172f"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"6d92e9d157fc2ed5de4a64cfac5e0a71e3e4fb18","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                 \"destination_type\": \"volume\","},{"line_number":94,"context_line":"                 \"delete_on_termination\": False,"},{"line_number":95,"context_line":"                 \"boot_index\": 0,"},{"line_number":96,"context_line":"                 \"uuid\": volume[\u0027id\u0027]}]}"},{"line_number":97,"context_line":"        LOG.info(\"Creating keypair and security group\")"},{"line_number":98,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":99,"context_line":"        security_group \u003d self._create_security_group()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_112057b0","line":96,"range":{"start_line":96,"start_character":25,"end_line":96,"end_character":37},"updated":"2017-06-07 01:08:02.000000000","message":"Should this be volume[\u0027volume\u0027][\u0027id\u0027] ?","commit_id":"1695e91e943a0e1741557042997ca89cc7f05302"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"39ab425378386dc732071ce9a8b5a8bc50809e47","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                 \"destination_type\": \"volume\","},{"line_number":94,"context_line":"                 \"delete_on_termination\": False,"},{"line_number":95,"context_line":"                 \"boot_index\": 0,"},{"line_number":96,"context_line":"                 \"uuid\": volume[\u0027id\u0027]}]}"},{"line_number":97,"context_line":"        LOG.info(\"Creating keypair and security group\")"},{"line_number":98,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":99,"context_line":"        security_group \u003d self._create_security_group()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_74abe41c","line":96,"range":{"start_line":96,"start_character":25,"end_line":96,"end_character":37},"in_reply_to":"df140735_112057b0","updated":"2017-06-12 09:45:26.000000000","message":"Nope, ScenarioTest.create_volume only returns the volume dict from the volume client so this works :\n\nhttps://github.com/openstack/barbican-tempest-plugin/blob/53f4fea68b111452ec54774649dadeb3ba4b52cd/barbican_tempest_plugin/tests/scenario/manager.py#L241-L242\n\nThe volume isn\u0027t bootable thus the failures in CI, that\u0027s weird as I was sure this was working a few weeks ago. I\u0027ll try to find some time this week to work on this.\n\nhttp://logs.openstack.org/82/466782/2/check/gate-barbican-simple-crypto-dsvm-tempest-ubuntu-xenial-nv/6d984e7/console.html#_2017-06-06_09_14_29_604711","commit_id":"1695e91e943a0e1741557042997ca89cc7f05302"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"6d92e9d157fc2ed5de4a64cfac5e0a71e3e4fb18","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                 \"destination_type\": \"volume\","},{"line_number":118,"context_line":"                 \"delete_on_termination\": False,"},{"line_number":119,"context_line":"                 \"boot_index\": 0,"},{"line_number":120,"context_line":"                 \"uuid\": volume[\u0027id\u0027]}]}"},{"line_number":121,"context_line":"        LOG.info(\"Creating keypair and security group\")"},{"line_number":122,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":123,"context_line":"        security_group \u003d self._create_security_group()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_7139d3f0","line":120,"range":{"start_line":120,"start_character":25,"end_line":120,"end_character":37},"updated":"2017-06-07 01:08:02.000000000","message":"Should this be volume[\u0027volume\u0027][\u0027id\u0027] ?","commit_id":"1695e91e943a0e1741557042997ca89cc7f05302"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"39ab425378386dc732071ce9a8b5a8bc50809e47","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                 \"destination_type\": \"volume\","},{"line_number":118,"context_line":"                 \"delete_on_termination\": False,"},{"line_number":119,"context_line":"                 \"boot_index\": 0,"},{"line_number":120,"context_line":"                 \"uuid\": volume[\u0027id\u0027]}]}"},{"line_number":121,"context_line":"        LOG.info(\"Creating keypair and security group\")"},{"line_number":122,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":123,"context_line":"        security_group \u003d self._create_security_group()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_54a8e81d","line":120,"range":{"start_line":120,"start_character":25,"end_line":120,"end_character":37},"in_reply_to":"df140735_7139d3f0","updated":"2017-06-12 09:45:26.000000000","message":"As above.","commit_id":"1695e91e943a0e1741557042997ca89cc7f05302"}]}
