)]}'
{"barbican_tempest_plugin/tests/scenario/barbican_manager.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"476cacb09d79c54845e223c43f99ad58f4d2a2fb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class BarbicanScenarioTest(mgr.NetworkScenarioTest):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    credentials \u003d (\u0027primary\u0027, \u0027admin\u0027)"},{"line_number":42,"context_line":"    manager \u003d clients.Manager()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_0e3289f2","line":39,"range":{"start_line":39,"start_character":31,"end_line":39,"end_character":50},"updated":"2018-01-25 01:59:01.000000000","message":"This class exists in tempest.scenario.manager not barbican_tempest_plugin.tests.scenario.manager","commit_id":"c6c2df6ea2317f111b5b2e7d87c5c21c10ab48e4"}],"barbican_tempest_plugin/tests/scenario/test_volume_encryption.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"014527c5a0dece8d474fa8ff3796d8099d62d867","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                    control_location\u003d\u0027front-end\u0027)"},{"line_number":55,"context_line":"        return self.create_volume(volume_type\u003dvolume_type[\u0027name\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def attach_detach_volume(self, server, volume, keypair):"},{"line_number":58,"context_line":"        # Attach volume"},{"line_number":59,"context_line":"        attached_volume \u003d self.nova_volume_attach(server, volume)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_994b4c5e","line":57,"updated":"2018-01-19 15:14:07.000000000","message":"The other option is to add a call to get_remote_client() here -- this call checks the ssh connection before the volume is attached.  The call would look like:\n\nserver_ip \u003d self.get_server_ip(server)\nclient \u003d self.get_remote_client(\n    server_ip, \n    private_key\u003dkeypair(\u0027private_key\u0027))\n\nIf it fails here, we know the server fails even before the volume is attached.\n\nIf the test magically passes after adding this, then maybe we\u0027re trying to add the volume before the instance is fully up?","commit_id":"e8fb44cf0d41f3f917b1c12211ed46562fbcc1f1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"37b9f11c0df45f72485b91c4cd66a984ed3c5f72","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":84,"context_line":"        security_group \u003d self._create_security_group()"},{"line_number":85,"context_line":"        server \u003d self.create_server("},{"line_number":86,"context_line":"            validatable\u003dTrue,"},{"line_number":87,"context_line":"            name\u003d\u0027signed_img_server\u0027,"},{"line_number":88,"context_line":"            image_id\u003dimg_uuid,"},{"line_number":89,"context_line":"            key_name\u003dkeypair[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_e802bc0b","line":86,"updated":"2018-01-19 13:51:22.000000000","message":"Guess you need to:\n\nvalidation_resources \u003d self.get_test_validation_resources(\n            self.os_primary)\n\nand pass it along","commit_id":"e8fb44cf0d41f3f917b1c12211ed46562fbcc1f1"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"b6e2a9ed310f317adc222918695c98ccbf7d9b45","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def attach_detach_volume(self, server, volume, keypair):"},{"line_number":58,"context_line":"        # test if server is accessible"},{"line_number":59,"context_line":"        server_ip \u003d self.get_server_ip(server)"},{"line_number":60,"context_line":"        self.get_remote_client("},{"line_number":61,"context_line":"            server_ip,"},{"line_number":62,"context_line":"            private_key\u003dkeypair[\u0027private_key\u0027]"},{"line_number":63,"context_line":"        )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # Attach volume"},{"line_number":66,"context_line":"        attached_volume \u003d self.nova_volume_attach(server, volume)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_b0c49092","line":63,"range":{"start_line":60,"start_character":9,"end_line":63,"end_character":9},"updated":"2018-01-30 18:10:16.000000000","message":"You can remove this code here - which was a temporary workaround to do exactly the type of connectivity testing you are doing in this patch.","commit_id":"c958823567fd547a17f6ddc3639f8423e69a4268"}]}