)]}'
{"barbican_tempest_plugin/tests/scenario/barbican_manager.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"7bb521c48e73830f66df896f274fa56a9e48013d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if CONF.compute_feature_enabled.attach_encrypted_volume:"},{"line_number":84,"context_line":"            if (CONF.volume_feature_enabled.api_v2 or"},{"line_number":85,"context_line":"               CONF.volume_feature_enabled.api_v3):"},{"line_number":86,"context_line":"                cls.admin_volume_types_client \u003d\\"},{"line_number":87,"context_line":"                    os_adm.volume_types_v2_client"},{"line_number":88,"context_line":"                cls.admin_encryption_types_client \u003d\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2ffccc0a","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":51},"updated":"2018-07-03 06:14:09.000000000","message":"Why not just remove this if-statement?","commit_id":"b8bf147bdcdd33f3ad276ca8815fd253ec9b24af"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"71bfcc6845d79633f781184a62a1bf1ee2a5cf15","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if CONF.compute_feature_enabled.attach_encrypted_volume:"},{"line_number":84,"context_line":"            if (CONF.volume_feature_enabled.api_v2 or"},{"line_number":85,"context_line":"               CONF.volume_feature_enabled.api_v3):"},{"line_number":86,"context_line":"                cls.admin_volume_types_client \u003d\\"},{"line_number":87,"context_line":"                    os_adm.volume_types_v2_client"},{"line_number":88,"context_line":"                cls.admin_encryption_types_client \u003d\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4e3c972f","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":51},"in_reply_to":"5f7c97a3_2ffccc0a","updated":"2018-07-04 00:32:05.000000000","message":"we can remove when there will be only single endpoints without any config options. \n\nCurrently Tempest set the these service clients alias based on same condition[1] so we should keep these condition. as long term, once i will cleanup the config and alias then we should not have any condition to check here.    \n\n[1] https://github.com/openstack/tempest/blob/5e83c8d399fb0d1fb71300508fc0352291808f92/tempest/clients.py#L242","commit_id":"b8bf147bdcdd33f3ad276ca8815fd253ec9b24af"}],"barbican_tempest_plugin/tests/scenario/manager.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"7bb521c48e73830f66df896f274fa56a9e48013d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        cls.security_group_rules_client \u003d ("},{"line_number":76,"context_line":"            cls.os_primary.security_group_rules_client)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if (CONF.volume_feature_enabled.api_v2 or"},{"line_number":79,"context_line":"           CONF.volume_feature_enabled.api_v3):"},{"line_number":80,"context_line":"            cls.volumes_client \u003d cls.os_primary.volumes_client_latest"},{"line_number":81,"context_line":"            cls.snapshots_client \u003d cls.os_primary.snapshots_client_latest"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ef057411","line":79,"range":{"start_line":78,"start_character":0,"end_line":79,"end_character":47},"updated":"2018-07-03 06:14:09.000000000","message":"ditto","commit_id":"b8bf147bdcdd33f3ad276ca8815fd253ec9b24af"}]}