)]}'
{"id":"openstack%2Fbarbican-tempest-plugin~649670","triplet_id":"openstack%2Fbarbican-tempest-plugin~master~Ibb5c06ce2773e0ee13bda97717e8e18e77e0be7c","project":"openstack/barbican-tempest-plugin","branch":"master","topic":"toggle-signature-verification","hashtags":[],"change_id":"Ibb5c06ce2773e0ee13bda97717e8e18e77e0be7c","subject":"Add option to toggle validation of signed image","status":"MERGED","created":"2019-04-03 16:36:21.000000000","updated":"2019-05-03 23:06:25.000000000","submitted":"2019-05-03 23:06:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"649670-1556924785497-22df3888","meta_rev_id":"d04e75b8a1e89d81fcfca2ec326f89faa3809ccb","_number":649670,"virtual_id_number":649670,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},{"value":2,"date":"2019-05-03 23:06:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"all":[{"value":2,"date":"2019-05-03 22:12:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"all":[{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":1,"date":"2019-05-03 22:14:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-03 22:12:55.000000000","updated_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"reviewer":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"state":"REVIEWER"},{"updated":"2019-05-03 22:14:09.000000000","updated_by":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"reviewer":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"state":"REVIEWER"},{"updated":"2019-05-03 23:06:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1de2defb10feeaf930bc8749b81c62936a3c716e","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-04-03 16:36:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"763506484688b5143c954c3a9bb25afe79ac6e28","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-03 17:24:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/70/649670/1/check/openstack-tox-pep8/58fcc1f/ : SUCCESS in 4m 39s\n- barbican-simple-crypto-devstack-tempest http://logs.openstack.org/70/649670/1/check/barbican-simple-crypto-devstack-tempest/5acefee/ : SUCCESS in 43m 10s","accounts_in_message":[],"_revision_number":1},{"id":"7294617f5512015a299d018e2f8fef393f1bf899","author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"date":"2019-05-03 22:12:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"222022224b306fe1894b940de3ed8ecc5be54d9c","author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"date":"2019-05-03 22:14:09.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"18c5d1396730d3040f60b3788730477a50ea1293","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-03 22:14:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d0d91fe2af3ba68ea1844998494a23687ec18d2f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-03 23:06:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"070404393421c7b05ec9cd7f0813f1a937c9f71e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-03 23:06:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/70/649670/1/gate/openstack-tox-pep8/f68c846/ : SUCCESS in 4m 08s\n- barbican-simple-crypto-devstack-tempest http://logs.openstack.org/70/649670/1/gate/barbican-simple-crypto-devstack-tempest/347baea/ : SUCCESS in 46m 16s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"62ec85c79f8e487f9ef12ff771070a1e7f1a818e","revisions":{"62ec85c79f8e487f9ef12ff771070a1e7f1a818e":{"kind":"REWORK","_number":1,"created":"2019-04-03 16:36:21.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/70/649670/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/barbican-tempest-plugin","ref":"refs/changes/70/649670/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/barbican-tempest-plugin refs/changes/70/649670/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/barbican-tempest-plugin refs/changes/70/649670/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/barbican-tempest-plugin refs/changes/70/649670/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/barbican-tempest-plugin refs/changes/70/649670/1"}}},"commit":{"parents":[{"commit":"123dd7d4162c39a1cb4b4c1b09a5dceaee127eb6","subject":"import zuul job settings from project-config","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/barbican-tempest-plugin/commit/123dd7d4162c39a1cb4b4c1b09a5dceaee127eb6"}]}],"author":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2019-04-03 16:27:05.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2019-04-03 16:36:20.000000000","tz":-420},"subject":"Add option to toggle validation of signed image","message":"Add option to toggle validation of signed image\n\nWithout this patch, if the barbican tempest plugin is installed in an\nenvironment running with `[glance]/verify_glance_signatures] set to\nfalse in nova.conf, which is the default value, the test will fail.\nEnabling glance signature verification unconditionally in order to\nsupport this test is not realistic, as it then prevents users from\nbooting from unsigned images which may not always be desired. This patch\nadds a configuration option to allow for disabling the\n`test_signed_image_upload_boot_failure` test, so that we can still run\nthe majority of the plugin tests for a standard environment with default\nnova configuration. The new option defaults to `True`, meaning assume\nthat nova\u0027s configuration has been overrridden to enforce image\nverification, which allows the barbican CI to run as normal with no\nconfiguration changes, but it allows operators to explicitly disable the\ntest as needed.\n\nChange-Id: Ibb5c06ce2773e0ee13bda97717e8e18e77e0be7c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/barbican-tempest-plugin/commit/62ec85c79f8e487f9ef12ff771070a1e7f1a818e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/barbican-tempest-plugin/commit/62ec85c79f8e487f9ef12ff771070a1e7f1a818e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}