)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"0574451029150d4ab717ee823166cf90d2777c9b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add secure-rbac tests for Containers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds basic RBAC testing for the Containers resource for"},{"line_number":10,"context_line":"reader, member and admin personas."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: I6879f566117db5ec0099ddad35ba649a3c674bd1"},{"line_number":13,"context_line":"Change-Id: I2272f5cd2385df15cc7761e8b858dfd39be955d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"70dce463_ad53bfc7","line":10,"updated":"2021-04-01 20:36:00.000000000","message":"NIT: add for project scope","commit_id":"01e76036127e36d7b983b39144cfea3f47a01827"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"2114f2af254245d1243e023f8904bb051d97c322","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add secure-rbac tests for Containers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds basic RBAC testing for the Containers resource for"},{"line_number":10,"context_line":"reader, member and admin personas."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: I6879f566117db5ec0099ddad35ba649a3c674bd1"},{"line_number":13,"context_line":"Change-Id: I2272f5cd2385df15cc7761e8b858dfd39be955d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"12b51e4c_ff7049a8","line":10,"in_reply_to":"70dce463_ad53bfc7","updated":"2021-04-01 21:54:56.000000000","message":"Done","commit_id":"01e76036127e36d7b983b39144cfea3f47a01827"}],"barbican_tempest_plugin/tests/rbac/v1/test_containers.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"938ccfe0f9df39eed224837e697f742075cb204a","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_list_containers(self):"},{"line_number":95,"context_line":"        self.do_request(\u0027create_container\u0027, cleanup\u003d\u0027container\u0027,"},{"line_number":96,"context_line":"                        name\u003d\u0027list_containers\u0027, type\u003d\u0027generic\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        resp \u003d self.do_request(\u0027list_containers\u0027)"},{"line_number":99,"context_line":"        containers \u003d resp[\u0027containers\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"b6c19fd2_42a1203b","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":46},"updated":"2021-04-05 18:14:55.000000000","message":"Will this conflict if two different classes attempt to run this test at the same time?","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"2b5a74ce3761c0b48da9f49a99c481dcdf0befd5","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_list_containers(self):"},{"line_number":95,"context_line":"        self.do_request(\u0027create_container\u0027, cleanup\u003d\u0027container\u0027,"},{"line_number":96,"context_line":"                        name\u003d\u0027list_containers\u0027, type\u003d\u0027generic\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        resp \u003d self.do_request(\u0027list_containers\u0027)"},{"line_number":99,"context_line":"        containers \u003d resp[\u0027containers\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"a2128e5d_249efed4","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":46},"in_reply_to":"b6c19fd2_42a1203b","updated":"2021-04-06 13:35:18.000000000","message":"No, it should be fine.  Barbican doesn\u0027t enforce name uniqueness.","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"938ccfe0f9df39eed224837e697f742075cb204a","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        self.do_request(\u0027create_container\u0027, cleanup\u003d\u0027container\u0027,"},{"line_number":96,"context_line":"                        name\u003d\u0027list_containers\u0027, type\u003d\u0027generic\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        resp \u003d self.do_request(\u0027list_containers\u0027)"},{"line_number":99,"context_line":"        containers \u003d resp[\u0027containers\u0027]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertGreaterEqual(len(containers), 1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"be75f049_dc481ac2","line":98,"updated":"2021-04-05 18:14:55.000000000","message":"Should this test also assert that a project-member of one project can\u0027t list containers for another project?","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"2b5a74ce3761c0b48da9f49a99c481dcdf0befd5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.do_request(\u0027create_container\u0027, cleanup\u003d\u0027container\u0027,"},{"line_number":96,"context_line":"                        name\u003d\u0027list_containers\u0027, type\u003d\u0027generic\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        resp \u003d self.do_request(\u0027list_containers\u0027)"},{"line_number":99,"context_line":"        containers \u003d resp[\u0027containers\u0027]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertGreaterEqual(len(containers), 1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5929f9_c56db40d","line":98,"in_reply_to":"be75f049_dc481ac2","updated":"2021-04-06 13:35:18.000000000","message":"Yeah, I\u0027ve still got negatvie tests on my TODO list.  This patch is just for positive tests.","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"938ccfe0f9df39eed224837e697f742075cb204a","unresolved":true,"context_lines":[{"line_number":109,"context_line":"                               name\u003d\u0027get_container\u0027, type\u003d\u0027generic\u0027)"},{"line_number":110,"context_line":"        container_id \u003d self.ref_to_uuid(resp[\u0027container_ref\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        resp \u003d self.do_request(\u0027get_container\u0027, container_id\u003dcontainer_id)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        self.assertEqual(container_id, self.ref_to_uuid(resp[\u0027container_ref\u0027]))"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"c767fbee_c7559f98","line":112,"updated":"2021-04-05 18:14:55.000000000","message":"Should this test assert that a project-member can\u0027t GET containers for other projects?","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"2b5a74ce3761c0b48da9f49a99c481dcdf0befd5","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                               name\u003d\u0027get_container\u0027, type\u003d\u0027generic\u0027)"},{"line_number":110,"context_line":"        container_id \u003d self.ref_to_uuid(resp[\u0027container_ref\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        resp \u003d self.do_request(\u0027get_container\u0027, container_id\u003dcontainer_id)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        self.assertEqual(container_id, self.ref_to_uuid(resp[\u0027container_ref\u0027]))"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e6c2b9cc_6884196d","line":112,"in_reply_to":"c767fbee_c7559f98","updated":"2021-04-06 13:35:18.000000000","message":"Will be doing that in a follow-up patch.","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"938ccfe0f9df39eed224837e697f742075cb204a","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    def test_delete_container(self):"},{"line_number":117,"context_line":"        resp \u003d self.do_request(\u0027create_container\u0027, name\u003d\u0027delete_container\u0027,"},{"line_number":118,"context_line":"                               type\u003d\u0027generic\u0027)"},{"line_number":119,"context_line":"        container_id \u003d self.ref_to_uuid(resp[\u0027container_ref\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        resp \u003d self.do_request(\u0027delete_container\u0027, container_id\u003dcontainer_id)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"92d24a81_cfa837f1","line":119,"updated":"2021-04-05 18:14:55.000000000","message":"Similar comment here as the above comments. Do we want to assert that project-members can\u0027t delete containers outside their project?","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"2b5a74ce3761c0b48da9f49a99c481dcdf0befd5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def test_delete_container(self):"},{"line_number":117,"context_line":"        resp \u003d self.do_request(\u0027create_container\u0027, name\u003d\u0027delete_container\u0027,"},{"line_number":118,"context_line":"                               type\u003d\u0027generic\u0027)"},{"line_number":119,"context_line":"        container_id \u003d self.ref_to_uuid(resp[\u0027container_ref\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        resp \u003d self.do_request(\u0027delete_container\u0027, container_id\u003dcontainer_id)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e56feb4a_e9f272da","line":119,"in_reply_to":"92d24a81_cfa837f1","updated":"2021-04-06 13:35:18.000000000","message":"Same answer as above. 😊","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"938ccfe0f9df39eed224837e697f742075cb204a","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        )"},{"line_number":138,"context_line":"        secret_id \u003d self.ref_to_uuid(resp[\u0027secret_ref\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        resp \u003d self.do_request(\u0027add_secret_to_container\u0027,"},{"line_number":141,"context_line":"                               container_id\u003dcontainer_id,"},{"line_number":142,"context_line":"                               secret_id\u003dsecret_id)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2a6aebdd_36c21a5c","line":140,"range":{"start_line":140,"start_character":32,"end_line":140,"end_character":55},"updated":"2021-04-05 18:14:55.000000000","message":"A project-member can only add secrets to containers in their project, right? Do we want to assert this user can\u0027t slip secrets into the container of another project?","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"2b5a74ce3761c0b48da9f49a99c481dcdf0befd5","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        )"},{"line_number":138,"context_line":"        secret_id \u003d self.ref_to_uuid(resp[\u0027secret_ref\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        resp \u003d self.do_request(\u0027add_secret_to_container\u0027,"},{"line_number":141,"context_line":"                               container_id\u003dcontainer_id,"},{"line_number":142,"context_line":"                               secret_id\u003dsecret_id)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9b3d98c7_bb16ce19","line":140,"range":{"start_line":140,"start_character":32,"end_line":140,"end_character":55},"in_reply_to":"2a6aebdd_36c21a5c","updated":"2021-04-06 13:35:18.000000000","message":"Yup, still have a ways to go to call this fully tested.","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"938ccfe0f9df39eed224837e697f742075cb204a","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        self.do_request(\u0027add_secret_to_container\u0027,"},{"line_number":162,"context_line":"                        container_id\u003dcontainer_id,"},{"line_number":163,"context_line":"                        secret_id\u003dsecret_id)"},{"line_number":164,"context_line":"        resp \u003d self.do_request(\u0027delete_secret_from_container\u0027,"},{"line_number":165,"context_line":"                               container_id\u003dcontainer_id,"},{"line_number":166,"context_line":"                               secret_id\u003dsecret_id)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5c685dc4_2f5014b5","line":164,"range":{"start_line":164,"start_character":32,"end_line":164,"end_character":60},"updated":"2021-04-05 18:14:55.000000000","message":"Similar comment here, do we want to make sure project-members can\u0027t delete secrets in containers outside their project?","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"2b5a74ce3761c0b48da9f49a99c481dcdf0befd5","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.do_request(\u0027add_secret_to_container\u0027,"},{"line_number":162,"context_line":"                        container_id\u003dcontainer_id,"},{"line_number":163,"context_line":"                        secret_id\u003dsecret_id)"},{"line_number":164,"context_line":"        resp \u003d self.do_request(\u0027delete_secret_from_container\u0027,"},{"line_number":165,"context_line":"                               container_id\u003dcontainer_id,"},{"line_number":166,"context_line":"                               secret_id\u003dsecret_id)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4d0b87b9_b761a784","line":164,"range":{"start_line":164,"start_character":32,"end_line":164,"end_character":60},"in_reply_to":"5c685dc4_2f5014b5","updated":"2021-04-06 13:35:18.000000000","message":"Yup.  I want to keep these patches small-ish for ease of reviews.  Negative tests still incoming.","commit_id":"db9b512ead907f42a8a767a73cc44a240437e542"}]}