)]}'
{"barbican_tempest_plugin/tests/rbac/v1/base.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2f2292cbe9c6b84d8d7abd919340849e9f18ef5a","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        other_project_id \u003d cls.os_system_admin.projects_client.create_project("},{"line_number":82,"context_line":"            data_utils.rand_name())[\u0027project\u0027][\u0027id\u0027]"},{"line_number":83,"context_line":"        cls._created_projects.append(other_project_id)"},{"line_number":84,"context_line":"        setattr(cls, \u0027other_project_admin\u0027,"},{"line_number":85,"context_line":"                cls._setup_new_user_client(other_project_id, \u0027admin\u0027))"},{"line_number":86,"context_line":"        setattr(cls, \u0027other_project_member\u0027,"},{"line_number":87,"context_line":"                cls._setup_new_user_client(other_project_id, \u0027member\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"729d70d4_68139f55","line":84,"updated":"2021-04-09 21:11:31.000000000","message":"You might be able to re-use the alternative credentials available from tempest, which will cut down on some of the plumbing here.\n\nhttps://docs.openstack.org/tempest/latest/keystone_scopes_and_roles_support.html#project-scoped-personas","commit_id":"cd35cc28cd08c8fbacf8999a0283bce9d14ad230"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"fb3bb3faac44f0ea9fb6e7eadfd3a91f7dd90d69","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        other_project_id \u003d cls.os_system_admin.projects_client.create_project("},{"line_number":82,"context_line":"            data_utils.rand_name())[\u0027project\u0027][\u0027id\u0027]"},{"line_number":83,"context_line":"        cls._created_projects.append(other_project_id)"},{"line_number":84,"context_line":"        setattr(cls, \u0027other_project_admin\u0027,"},{"line_number":85,"context_line":"                cls._setup_new_user_client(other_project_id, \u0027admin\u0027))"},{"line_number":86,"context_line":"        setattr(cls, \u0027other_project_member\u0027,"},{"line_number":87,"context_line":"                cls._setup_new_user_client(other_project_id, \u0027member\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ff9ac9a_c534fb78","line":84,"in_reply_to":"729d70d4_68139f55","updated":"2021-04-13 12:48:49.000000000","message":"Thanks for pointing those out.  It\u0027s definitely better to reuse personas provided by tempest.","commit_id":"cd35cc28cd08c8fbacf8999a0283bce9d14ad230"}],"barbican_tempest_plugin/tests/rbac/v1/test_secrets.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2f2292cbe9c6b84d8d7abd919340849e9f18ef5a","unresolved":true,"context_lines":[{"line_number":395,"context_line":"        pass"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def test_get_other_secret(self):"},{"line_number":398,"context_line":"        pass"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_get_other_secret_payload(self):"},{"line_number":401,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"0992f98d_b15c1ba3","line":398,"updated":"2021-04-09 21:11:31.000000000","message":"Are we going to fill these in or is that coming in a subsequent patch?","commit_id":"cd35cc28cd08c8fbacf8999a0283bce9d14ad230"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"fb3bb3faac44f0ea9fb6e7eadfd3a91f7dd90d69","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        pass"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def test_get_other_secret(self):"},{"line_number":398,"context_line":"        pass"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_get_other_secret_payload(self):"},{"line_number":401,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"06b44ae7_eb1a318c","line":398,"in_reply_to":"0992f98d_b15c1ba3","updated":"2021-04-13 12:48:49.000000000","message":"Yeah, system-scope things will be done in a future patch.  My plan right now is to do a round of patches for testing alt-project access, then another round to test ACLs, and then finally get to system-scope since those will likely need barbican-api changes.","commit_id":"cd35cc28cd08c8fbacf8999a0283bce9d14ad230"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"98a9b72d5cd4a549a988d1964482927e4af37737","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        raise NotImplementedError"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @abc.abstractmethod"},{"line_number":90,"context_line":"    def test_get_other_secret(self):"},{"line_number":91,"context_line":"        \"\"\"Test get_secrets policy"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Testing: GET /v1/secrets/{secret_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c016fd4_c9ce4be0","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":29},"updated":"2021-04-12 18:27:17.000000000","message":"Nice - but lets make this a little more explicit in the method name:\n\ntest_get_other_project_secret()  instead of test_get_other_secret()\n\nSame change for the other methods","commit_id":"89cdbf6cc85ba21547896a23efdd3bdc57d18ace"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"fb3bb3faac44f0ea9fb6e7eadfd3a91f7dd90d69","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        raise NotImplementedError"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @abc.abstractmethod"},{"line_number":90,"context_line":"    def test_get_other_secret(self):"},{"line_number":91,"context_line":"        \"\"\"Test get_secrets policy"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Testing: GET /v1/secrets/{secret_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"29888341_6af79c2b","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":29},"in_reply_to":"1c016fd4_c9ce4be0","updated":"2021-04-13 12:48:49.000000000","message":"Done","commit_id":"89cdbf6cc85ba21547896a23efdd3bdc57d18ace"}]}