)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"c527811ab7bef6e566cc4a37d4737685aa8e42e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad84e25a_8389fd63","updated":"2021-10-14 20:47:18.000000000","message":"LGTM","commit_id":"b7ba9d0ccf581179fa34da8480e434a3d68da951"}],"barbican_tempest_plugin/tests/rbac/v1/test_secrets.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"a2bd1a8facdb3151660e84f02be2f78fab5b82ba","unresolved":true,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def test_get_secret_acl(self):"},{"line_number":488,"context_line":"        acl \u003d self.client.get_secret_acl(self.secret_id)"},{"line_number":489,"context_line":"        self.assertIn(\"read\", acl.keys())"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def test_put_secret_acl(self):"},{"line_number":492,"context_line":"        _ \u003d self.client.put_secret_acl(self.secret_id, self.valid_acl)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7181c617_23ef6fda","line":489,"updated":"2021-10-12 18:48:58.000000000","message":"So, we expect this to return a dict with \"read\", \"write\" etc. with no content?\nWhats the expected return here given that a acl was never added, and can we document it?","commit_id":"b7ba9d0ccf581179fa34da8480e434a3d68da951"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"318f0ed0bd9164b501da5a5273db0a1f34b7e923","unresolved":true,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def test_get_secret_acl(self):"},{"line_number":488,"context_line":"        acl \u003d self.client.get_secret_acl(self.secret_id)"},{"line_number":489,"context_line":"        self.assertIn(\"read\", acl.keys())"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def test_put_secret_acl(self):"},{"line_number":492,"context_line":"        _ \u003d self.client.put_secret_acl(self.secret_id, self.valid_acl)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6b52a680_c3253a9a","line":489,"in_reply_to":"7181c617_23ef6fda","updated":"2021-10-12 20:09:12.000000000","message":"This is already documented in the API reference: https://docs.openstack.org/barbican/latest/api/reference/acls.html#request-response-with-no-acl-defined","commit_id":"b7ba9d0ccf581179fa34da8480e434a3d68da951"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"a2bd1a8facdb3151660e84f02be2f78fab5b82ba","unresolved":true,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        acl \u003d self.client.get_secret_acl(self.secret_id)"},{"line_number":518,"context_line":"        self.assertNotIn(\u0027users\u0027, acl[\u0027read\u0027].keys())"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"class ProjectAdminTests(ProjectMemberTests):"},{"line_number":522,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"9d0d8808_7e438c9e","line":519,"updated":"2021-10-12 18:48:58.000000000","message":"My question above is related to what we\u0027d expect to see here if the acl is deleted.","commit_id":"b7ba9d0ccf581179fa34da8480e434a3d68da951"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"318f0ed0bd9164b501da5a5273db0a1f34b7e923","unresolved":true,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        acl \u003d self.client.get_secret_acl(self.secret_id)"},{"line_number":518,"context_line":"        self.assertNotIn(\u0027users\u0027, acl[\u0027read\u0027].keys())"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"class ProjectAdminTests(ProjectMemberTests):"},{"line_number":522,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"6e9fc68b_46cca994","line":519,"in_reply_to":"9d0d8808_7e438c9e","updated":"2021-10-12 20:09:12.000000000","message":"You can think of DELETE-ing the ACL like \"undefining\" it.  A GET after a DELETE results in the same response as a GET before any ACL was defined.  So, in both cases the response we expect is what is documented in the API docs.\n\nIf you\u0027re curious why the asserts are different is because in the test above I just wanted to make sure that we could get a response, but in this test I\u0027m making sure that the \"users\" was actually removed from the response.","commit_id":"b7ba9d0ccf581179fa34da8480e434a3d68da951"}]}