)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6630bc1343980668b2d9748cb696e400e14f925f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-02-16 08:29:14 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces barbican tempest plugin manager methods with tempest methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replaced methods:"},{"line_number":10,"context_line":"\t* _create_port"},{"line_number":11,"context_line":"\t* create_keypair"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c169883a_30933e7e","line":8,"updated":"2022-02-16 08:56:49.000000000","message":"you can add more descriptive msg like:\nAs tempest.scenario.manager was announced stable interface in Tempest 27.0.0 [1] it can be now reused in plugins.\n\n[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0","commit_id":"ca12d1a2f0a96a17508cb4c047cad274d611fce8"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"cae009ca93e6a9afec12e9ec7dfa4abf87df282c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-02-16 08:29:14 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces barbican tempest plugin manager methods with tempest methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replaced methods:"},{"line_number":10,"context_line":"\t* _create_port"},{"line_number":11,"context_line":"\t* create_keypair"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4dea44bf_3f515122","line":8,"in_reply_to":"c169883a_30933e7e","updated":"2022-02-22 11:17:10.000000000","message":"Ack","commit_id":"ca12d1a2f0a96a17508cb4c047cad274d611fce8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6630bc1343980668b2d9748cb696e400e14f925f","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Replaced methods:"},{"line_number":10,"context_line":"\t* _create_port"},{"line_number":11,"context_line":"\t* create_keypair"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2f96cf7b5f85f2a1297eb7a1aafdfd88485eaebe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"68ac6f98_67b4670e","line":12,"updated":"2022-02-16 08:56:49.000000000","message":"you can also link the etherpad so that the effort is easily found:\nhttps://etherpad.opendev.org/p/tempest-scenario-manager-cleanup","commit_id":"ca12d1a2f0a96a17508cb4c047cad274d611fce8"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"cae009ca93e6a9afec12e9ec7dfa4abf87df282c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Replaced methods:"},{"line_number":10,"context_line":"\t* _create_port"},{"line_number":11,"context_line":"\t* create_keypair"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2f96cf7b5f85f2a1297eb7a1aafdfd88485eaebe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ce7637a6_cd5fed7f","line":12,"in_reply_to":"68ac6f98_67b4670e","updated":"2022-02-22 11:17:10.000000000","message":"Ack","commit_id":"ca12d1a2f0a96a17508cb4c047cad274d611fce8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"3b7e3d8fabc8bdff60e7eb36ddffd3d28d87ae4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ad293917_7d9c35f6","updated":"2022-03-01 10:26:47.000000000","message":"LGTM!","commit_id":"cec4eee4547ff7f230978aa9387ad6b1c66c07e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e1456957c07f14bc036dcd4d5669f2903c7f7e8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"aea5b194_5dc21733","updated":"2022-03-15 20:42:36.000000000","message":"lgtm, even if you remove the internal used method like create_server which was using _create_port also in same patch then you do not need to first change the usage and then remove that method itself.\n\nBut anyways this lgtm thanks for working on this.","commit_id":"6e39d991c8892f40d9df67849ec99ede6e66224e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0e56add3b75a551e49b8f78e9ccaef73665970b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"97ee378c_2bc6624f","updated":"2022-03-15 17:03:47.000000000","message":"lgtm, thanks","commit_id":"6e39d991c8892f40d9df67849ec99ede6e66224e"}],"barbican_tempest_plugin/tests/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6630bc1343980668b2d9748cb696e400e14f925f","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    # The create_[resource] functions only return body and discard the"},{"line_number":84,"context_line":"    # resp part which is not used in scenario tests"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _create_port(self, network_id, client\u003dNone, namestart\u003d\u0027port-quotatest\u0027,"},{"line_number":87,"context_line":"                     **kwargs):"},{"line_number":88,"context_line":"        return super().create_port(network_id\u003dnetwork_id,"},{"line_number":89,"context_line":"                                   client\u003dclient,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c5785791_0a96a317","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":20},"updated":"2022-02-16 08:56:49.000000000","message":"maybe we could edit all parts of the barbican-tempest-plugin code which calls this method so that it calls the method from tempest instead? that way we could remove this definition entirely.","commit_id":"ca12d1a2f0a96a17508cb4c047cad274d611fce8"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"cae009ca93e6a9afec12e9ec7dfa4abf87df282c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    # The create_[resource] functions only return body and discard the"},{"line_number":84,"context_line":"    # resp part which is not used in scenario tests"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _create_port(self, network_id, client\u003dNone, namestart\u003d\u0027port-quotatest\u0027,"},{"line_number":87,"context_line":"                     **kwargs):"},{"line_number":88,"context_line":"        return super().create_port(network_id\u003dnetwork_id,"},{"line_number":89,"context_line":"                                   client\u003dclient,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6b5c93ba_2f35644a","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":20},"in_reply_to":"c5785791_0a96a317","updated":"2022-02-22 11:17:10.000000000","message":"Ack","commit_id":"ca12d1a2f0a96a17508cb4c047cad274d611fce8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6630bc1343980668b2d9748cb696e400e14f925f","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                                   namestart\u003dnamestart,"},{"line_number":91,"context_line":"                                   **kwargs)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def create_keypair(self, client\u003dNone):"},{"line_number":94,"context_line":"        return super().create_keypair(client\u003dclient)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"97476f3c_a87ab360","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":22},"updated":"2022-02-16 08:56:49.000000000","message":"maybe we could edit all parts of the barbican-tempest-plugin code which calls this method so that it calls the method from tempest instead? that way we could remove this definition entirely.","commit_id":"ca12d1a2f0a96a17508cb4c047cad274d611fce8"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"cae009ca93e6a9afec12e9ec7dfa4abf87df282c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                   namestart\u003dnamestart,"},{"line_number":91,"context_line":"                                   **kwargs)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def create_keypair(self, client\u003dNone):"},{"line_number":94,"context_line":"        return super().create_keypair(client\u003dclient)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6aefa2d6_b926bcfb","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":22},"in_reply_to":"97476f3c_a87ab360","updated":"2022-02-22 11:17:10.000000000","message":"Ack","commit_id":"ca12d1a2f0a96a17508cb4c047cad274d611fce8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0e56add3b75a551e49b8f78e9ccaef73665970b7","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    # The create_[resource] functions only return body and discard the"},{"line_number":84,"context_line":"    # resp part which is not used in scenario tests"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _create_port(self, network_id, client\u003dNone, namestart\u003d\u0027port-quotatest\u0027,"},{"line_number":87,"context_line":"                     **kwargs):"},{"line_number":88,"context_line":"        if not client:"},{"line_number":89,"context_line":"            client \u003d self.ports_client"}],"source_content_type":"text/x-python","patch_set":7,"id":"eb7bc081_ada39731","side":"PARENT","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":20},"updated":"2022-03-15 17:03:47.000000000","message":"in the create_port method in tempest, we don\u0027t have a specific namestart argument, but that\u0027s ok, because create_port pops it from the kwargs - see https://opendev.org/openstack/tempest/src/tag/27.0.0/tempest/scenario/manager.py#L140\n\nother than that it\u0027s the same (tempest\u0027s version of the method contains a few additional kwargs based on the user\u0027s vnic configuration, but that shouldn\u0027t be an issue, it\u0027s more like an improvement)","commit_id":"b998aeff30809288700a20cce850ac022d7c41de"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"0b2b2bb68be7139cb9bdf7d0b141fd2cf97f3928","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    # The create_[resource] functions only return body and discard the"},{"line_number":84,"context_line":"    # resp part which is not used in scenario tests"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _create_port(self, network_id, client\u003dNone, namestart\u003d\u0027port-quotatest\u0027,"},{"line_number":87,"context_line":"                     **kwargs):"},{"line_number":88,"context_line":"        if not client:"},{"line_number":89,"context_line":"            client \u003d self.ports_client"}],"source_content_type":"text/x-python","patch_set":7,"id":"e4f23c0f_30bb06fd","side":"PARENT","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":20},"in_reply_to":"eb7bc081_ada39731","updated":"2022-04-01 08:21:35.000000000","message":"Ack","commit_id":"b998aeff30809288700a20cce850ac022d7c41de"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0e56add3b75a551e49b8f78e9ccaef73665970b7","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                        client.delete_port, port[\u0027id\u0027])"},{"line_number":99,"context_line":"        return port"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def create_keypair(self, client\u003dNone):"},{"line_number":102,"context_line":"        if not client:"},{"line_number":103,"context_line":"            client \u003d self.keypairs_client"},{"line_number":104,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__)"}],"source_content_type":"text/x-python","patch_set":7,"id":"6c179ba9_432c1d63","side":"PARENT","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":22},"updated":"2022-03-15 17:03:47.000000000","message":"the exact same copy is in tempest (at least since 27.0.0) - https://opendev.org/openstack/tempest/src/tag/27.0.0/tempest/scenario/manager.py#L169","commit_id":"b998aeff30809288700a20cce850ac022d7c41de"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"0b2b2bb68be7139cb9bdf7d0b141fd2cf97f3928","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                        client.delete_port, port[\u0027id\u0027])"},{"line_number":99,"context_line":"        return port"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def create_keypair(self, client\u003dNone):"},{"line_number":102,"context_line":"        if not client:"},{"line_number":103,"context_line":"            client \u003d self.keypairs_client"},{"line_number":104,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3c3ca233_9c13b320","side":"PARENT","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":22},"in_reply_to":"6c179ba9_432c1d63","updated":"2022-04-01 08:21:35.000000000","message":"Ack","commit_id":"b998aeff30809288700a20cce850ac022d7c41de"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0e56add3b75a551e49b8f78e9ccaef73665970b7","unresolved":true,"context_lines":[{"line_number":179,"context_line":"            for net in networks:"},{"line_number":180,"context_line":"                net_id \u003d net.get(\u0027uuid\u0027, net.get(\u0027id\u0027))"},{"line_number":181,"context_line":"                if \u0027port\u0027 not in net:"},{"line_number":182,"context_line":"                    port \u003d self._create_port(network_id\u003dnet_id,"},{"line_number":183,"context_line":"                                             client\u003dclients.ports_client,"},{"line_number":184,"context_line":"                                             **create_port_body)"},{"line_number":185,"context_line":"                    ports.append({\u0027port\u0027: port[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":7,"id":"55dfd3c7_b84c514d","side":"PARENT","line":182,"range":{"start_line":182,"start_character":32,"end_line":182,"end_character":44},"updated":"2022-03-15 17:03:47.000000000","message":"this is the only occurrence of _create_port in the plugin","commit_id":"b998aeff30809288700a20cce850ac022d7c41de"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"0b2b2bb68be7139cb9bdf7d0b141fd2cf97f3928","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            for net in networks:"},{"line_number":180,"context_line":"                net_id \u003d net.get(\u0027uuid\u0027, net.get(\u0027id\u0027))"},{"line_number":181,"context_line":"                if \u0027port\u0027 not in net:"},{"line_number":182,"context_line":"                    port \u003d self._create_port(network_id\u003dnet_id,"},{"line_number":183,"context_line":"                                             client\u003dclients.ports_client,"},{"line_number":184,"context_line":"                                             **create_port_body)"},{"line_number":185,"context_line":"                    ports.append({\u0027port\u0027: port[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":7,"id":"8bd2b5c3_958a7f6d","side":"PARENT","line":182,"range":{"start_line":182,"start_character":32,"end_line":182,"end_character":44},"in_reply_to":"55dfd3c7_b84c514d","updated":"2022-04-01 08:21:35.000000000","message":"Ack","commit_id":"b998aeff30809288700a20cce850ac022d7c41de"}]}