)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c4e06c481ace31b680c07e572fd8fac45acff70b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a67cf187_e0fa73fb","updated":"2022-03-15 16:48:19.000000000","message":"i\u0027ve notice one small detail, although i\u0027m not sure how to approach this, see the inline comment","commit_id":"c04e82af23baa1842c3c49d64b33ee547ced0833"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6aaae16a00dd86aa03cac936a2e4ebc588f4f7a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9490fbc5_a19dd607","updated":"2022-03-15 20:51:09.000000000","message":"lgtm","commit_id":"c04e82af23baa1842c3c49d64b33ee547ced0833"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"26dd7e475b16ee8cb2408d724e90f85712a0d326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"000e3f04_733138c6","updated":"2022-04-12 13:41:42.000000000","message":"recheck","commit_id":"a273bdfd9fe96c525783ac67fbf8a0817757ff7c"}],"barbican_tempest_plugin/tests/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c4e06c481ace31b680c07e572fd8fac45acff70b","unresolved":true,"context_lines":[{"line_number":362,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":363,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        volume \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":366,"context_line":"        self.assertEqual(\u0027available\u0027, volume[\u0027status\u0027])"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def create_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":369,"context_line":"                         private_key\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"33186cd2_6788f875","side":"PARENT","line":366,"range":{"start_line":365,"start_character":8,"end_line":366,"end_character":55},"updated":"2022-03-15 16:48:19.000000000","message":"seems like the plugin verifies whether the volume is in available state after the detach, that\u0027s something tempest doesn\u0027t do:\nhttps://opendev.org/openstack/tempest/src/tag/27.0.0/tempest/scenario/manager.py#L866\n\nThat means that if we merge this, attach_detach_volume test (https://github.com/openstack/barbican-tempest-plugin/blob/08985fa8be44c9c78fbcc00cfa97df42efb790ce/barbican_tempest_plugin/tests/scenario/test_volume_encryption.py#L74) which calls nova_volume_attach, will loose one small check - the assert for available state","commit_id":"9fe096e1422c7c884b94166763b4857b5abcea30"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"40fb85aedaf315734294de571fca5e4dbd6e4cb2","unresolved":true,"context_lines":[{"line_number":362,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":363,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        volume \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":366,"context_line":"        self.assertEqual(\u0027available\u0027, volume[\u0027status\u0027])"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def create_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":369,"context_line":"                         private_key\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"e5d532fd_464eaf6e","side":"PARENT","line":366,"range":{"start_line":365,"start_character":8,"end_line":366,"end_character":55},"in_reply_to":"2623c3c4_55afbd54","updated":"2022-03-31 13:48:23.000000000","message":"right","commit_id":"9fe096e1422c7c884b94166763b4857b5abcea30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6aaae16a00dd86aa03cac936a2e4ebc588f4f7a0","unresolved":true,"context_lines":[{"line_number":362,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":363,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        volume \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":366,"context_line":"        self.assertEqual(\u0027available\u0027, volume[\u0027status\u0027])"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def create_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":369,"context_line":"                         private_key\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2623c3c4_55afbd54","side":"PARENT","line":366,"range":{"start_line":365,"start_character":8,"end_line":366,"end_character":55},"in_reply_to":"33186cd2_6788f875","updated":"2022-03-15 20:51:09.000000000","message":"these are not required as such because wait_for_volume_resource_status() at L362 will verify that status is \u0027available\u0027.","commit_id":"9fe096e1422c7c884b94166763b4857b5abcea30"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"e17e9ca7cc1c7231c181e70d0e19d9ca371bf217","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":363,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        volume \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":366,"context_line":"        self.assertEqual(\u0027available\u0027, volume[\u0027status\u0027])"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def create_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":369,"context_line":"                         private_key\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"55306ca3_566c7673","side":"PARENT","line":366,"range":{"start_line":365,"start_character":8,"end_line":366,"end_character":55},"in_reply_to":"e5d532fd_464eaf6e","updated":"2022-04-12 11:31:14.000000000","message":"Done","commit_id":"9fe096e1422c7c884b94166763b4857b5abcea30"}]}