)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b0e78133a7c248b808f0cac68e77cd892ed82747","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     millevy \u003cmillevy@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-10-31 10:00:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Intreduce a new test for \"cve_2022_3100\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The exploit is that a malicious user with a Keystone account is able to decrypt"},{"line_number":10,"context_line":"any secret as long as they know the secret\u0027s ID by using a specifically crafted"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"cc81a1ae_7b8d8ffb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2022-11-22 14:42:48.000000000","message":"Little typo: Introduce","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d435c21128dae33a7bc8860203a97229af114c23","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     millevy \u003cmillevy@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-10-31 10:00:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Intreduce a new test for \"cve_2022_3100\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The exploit is that a malicious user with a Keystone account is able to decrypt"},{"line_number":10,"context_line":"any secret as long as they know the secret\u0027s ID by using a specifically crafted"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"05b382e3_43c3b2a8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"in_reply_to":"cc81a1ae_7b8d8ffb","updated":"2022-12-08 13:46:43.000000000","message":"Done","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b0e78133a7c248b808f0cac68e77cd892ed82747","unresolved":true,"context_lines":[{"line_number":11,"context_line":"query string:"},{"line_number":12,"context_line":"GET /v1/secrets/{secret-id}/payload?target.secret.read\u003dread"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-bug: #2125404"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5e00a188268ef1c25eed8bf3a37197918e529427"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"00f5dd1b_087c8ec7","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":21},"updated":"2022-11-22 14:42:48.000000000","message":"The link does not work.","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d435c21128dae33a7bc8860203a97229af114c23","unresolved":false,"context_lines":[{"line_number":11,"context_line":"query string:"},{"line_number":12,"context_line":"GET /v1/secrets/{secret-id}/payload?target.secret.read\u003dread"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-bug: #2125404"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5e00a188268ef1c25eed8bf3a37197918e529427"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1f13d9d8_3230dd39","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":21},"in_reply_to":"00f5dd1b_087c8ec7","updated":"2022-12-08 13:46:43.000000000","message":"Done","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"a88746f70a49b73dae216a00fbf3f7e6907587c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fed292e6_d88cccca","updated":"2022-11-14 12:28:44.000000000","message":"Please review the test. Thank you.","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b0e78133a7c248b808f0cac68e77cd892ed82747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"812eb82a_501b0315","updated":"2022-11-22 14:42:48.000000000","message":"The test worked for me and also passed in the secure-rbac job [1].\n\nI tested the patch on my environment with the CVE-2022-3100 (barbican tag/12.0.0) and without it (barbican master). On each environment the test passed/failed as expected. \n\nI added a few comments and recommendations.\n\n[1] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c39/862796/7/check/barbican-tempest-plugin-simple-crypto-secure-rbac/c3931b7/job-output.txt","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"eb67d6c01087c2926054e4af91ec682d1f739ceb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"25e05303_4fa28731","updated":"2022-12-06 15:25:03.000000000","message":"You can run \u0027tox -epep8` to check whether the code follows PEP8:).","commit_id":"77f004f4edce7443455af4d21f836addee08bfd7"}],"barbican_tempest_plugin/services/key_manager/json/secret_client.py":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"4c72a3b6e5c55a668eee146b985ee45f04d41bc5","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        return self._parse_resp(body)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_secret_payload(self, secret_id, **kwargs):"},{"line_number":77,"context_line":"        \"\"\" GET /v1/secrets/{secret_id}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        Retrieve the payload.If kwargs are provided they are added"},{"line_number":80,"context_line":"        to the request as query string parameters."}],"source_content_type":"text/x-python","patch_set":1,"id":"3d4630ab_9cee8801","line":77,"range":{"start_line":77,"start_character":16,"end_line":77,"end_character":39},"updated":"2022-10-27 14:10:12.000000000","message":"This should be \"GET /v1/secrets/{secret_id}/payload\"","commit_id":"116c54a5296d3812c25a6e089775c8f26bfe6d95"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"fce3d52c7f85aa93f81f0e108a6b97d8fa554f0e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        return self._parse_resp(body)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_secret_payload(self, secret_id, **kwargs):"},{"line_number":77,"context_line":"        \"\"\" GET /v1/secrets/{secret_id}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        Retrieve the payload.If kwargs are provided they are added"},{"line_number":80,"context_line":"        to the request as query string parameters."}],"source_content_type":"text/x-python","patch_set":1,"id":"0451c6f7_1c2789bb","line":77,"range":{"start_line":77,"start_character":16,"end_line":77,"end_character":39},"in_reply_to":"3d4630ab_9cee8801","updated":"2022-10-31 10:14:46.000000000","message":"Done","commit_id":"116c54a5296d3812c25a6e089775c8f26bfe6d95"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"4c72a3b6e5c55a668eee146b985ee45f04d41bc5","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        content_headers \u003d {"},{"line_number":83,"context_line":"            \"Accept\": \"application/octet-stream\""},{"line_number":84,"context_line":"        }"},{"line_number":85,"context_line":"        uri \u003d \"v1/secrets/{secret_id}/payload\".format(secret_id)"},{"line_number":86,"context_line":"        if kwargs:"},{"line_number":87,"context_line":"            uri +\u003d \u0027?\u0027"},{"line_number":88,"context_line":"            uri +\u003d \u0027,\u0027.join([\"{}\u003d{}\".format(k, kwargs[k]) for k in kwargs]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ede49f8e_841aeb08","line":85,"range":{"start_line":85,"start_character":27,"end_line":85,"end_character":36},"updated":"2022-10-27 14:10:12.000000000","message":"either remove `secret_id` from the string or change the format call to `.format(secret_id\u003dsecret_id)`","commit_id":"116c54a5296d3812c25a6e089775c8f26bfe6d95"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"fce3d52c7f85aa93f81f0e108a6b97d8fa554f0e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        content_headers \u003d {"},{"line_number":83,"context_line":"            \"Accept\": \"application/octet-stream\""},{"line_number":84,"context_line":"        }"},{"line_number":85,"context_line":"        uri \u003d \"v1/secrets/{secret_id}/payload\".format(secret_id)"},{"line_number":86,"context_line":"        if kwargs:"},{"line_number":87,"context_line":"            uri +\u003d \u0027?\u0027"},{"line_number":88,"context_line":"            uri +\u003d \u0027,\u0027.join([\"{}\u003d{}\".format(k, kwargs[k]) for k in kwargs]"}],"source_content_type":"text/x-python","patch_set":1,"id":"025e3527_27f3276b","line":85,"range":{"start_line":85,"start_character":27,"end_line":85,"end_character":36},"in_reply_to":"ede49f8e_841aeb08","updated":"2022-10-31 10:14:46.000000000","message":"Done","commit_id":"116c54a5296d3812c25a6e089775c8f26bfe6d95"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"4c72a3b6e5c55a668eee146b985ee45f04d41bc5","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        uri \u003d \"v1/secrets/{secret_id}/payload\".format(secret_id)"},{"line_number":86,"context_line":"        if kwargs:"},{"line_number":87,"context_line":"            uri +\u003d \u0027?\u0027"},{"line_number":88,"context_line":"            uri +\u003d \u0027,\u0027.join([\"{}\u003d{}\".format(k, kwargs[k]) for k in kwargs]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        resp, body \u003d self.get(uri, headers\u003dcontent_headers)"},{"line_number":91,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"11e6f6f7_3d175853","line":88,"updated":"2022-10-27 14:10:12.000000000","message":"missing a closing parenthesis at the end of this line.","commit_id":"116c54a5296d3812c25a6e089775c8f26bfe6d95"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"fce3d52c7f85aa93f81f0e108a6b97d8fa554f0e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        uri \u003d \"v1/secrets/{secret_id}/payload\".format(secret_id)"},{"line_number":86,"context_line":"        if kwargs:"},{"line_number":87,"context_line":"            uri +\u003d \u0027?\u0027"},{"line_number":88,"context_line":"            uri +\u003d \u0027,\u0027.join([\"{}\u003d{}\".format(k, kwargs[k]) for k in kwargs]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        resp, body \u003d self.get(uri, headers\u003dcontent_headers)"},{"line_number":91,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a3d0b9a3_3391b260","line":88,"in_reply_to":"11e6f6f7_3d175853","updated":"2022-10-31 10:14:46.000000000","message":"Done","commit_id":"116c54a5296d3812c25a6e089775c8f26bfe6d95"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"bffe172b4085ff4a240d8dfc296d75b512116cf1","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        uri \u003d \"v1/secrets/{}/payload\".format(secret_id)"},{"line_number":86,"context_line":"        if kwargs:"},{"line_number":87,"context_line":"            uri +\u003d \u0027?\u0027"},{"line_number":88,"context_line":"            uri +\u003d \u0027,\u0027.join([\"{}\u003d{}\".format(k, kwargs[k]) for k in kwargs])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        resp, body \u003d self.get(uri, headers\u003dcontent_headers)"},{"line_number":91,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5beaae92_b2572670","line":88,"range":{"start_line":88,"start_character":20,"end_line":88,"end_character":21},"updated":"2022-11-08 08:27:53.000000000","message":"Shouldn\u0027t this be \u0027\u0026\u0027? You can use urllib.parse.urlunparse for constructing the uri","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b0e78133a7c248b808f0cac68e77cd892ed82747","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        uri \u003d \"v1/secrets/{}/payload\".format(secret_id)"},{"line_number":86,"context_line":"        if kwargs:"},{"line_number":87,"context_line":"            uri +\u003d \u0027?\u0027"},{"line_number":88,"context_line":"            uri +\u003d \u0027,\u0027.join([\"{}\u003d{}\".format(k, kwargs[k]) for k in kwargs])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        resp, body \u003d self.get(uri, headers\u003dcontent_headers)"},{"line_number":91,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1bf09fc1_bd1ea64d","line":88,"range":{"start_line":88,"start_character":20,"end_line":88,"end_character":21},"in_reply_to":"039cb840_b065a948","updated":"2022-11-22 14:42:48.000000000","message":"I agree that usage of some python built-in function might be cleaner here. For example urlencode [1].\n\n```\nimport urllib.parse\n\nuri \u003d \"v1/secrets/{}/payload?\".format(secret_id)\nuri +\u003d urllib.parse.urlencode(kwargs)\n```\n\n[1] https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlencode","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d435c21128dae33a7bc8860203a97229af114c23","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        uri \u003d \"v1/secrets/{}/payload\".format(secret_id)"},{"line_number":86,"context_line":"        if kwargs:"},{"line_number":87,"context_line":"            uri +\u003d \u0027?\u0027"},{"line_number":88,"context_line":"            uri +\u003d \u0027,\u0027.join([\"{}\u003d{}\".format(k, kwargs[k]) for k in kwargs])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        resp, body \u003d self.get(uri, headers\u003dcontent_headers)"},{"line_number":91,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":7,"id":"b1da46ee_118204bf","line":88,"range":{"start_line":88,"start_character":20,"end_line":88,"end_character":21},"in_reply_to":"1bf09fc1_bd1ea64d","updated":"2022-12-08 13:46:43.000000000","message":"Done","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"a88746f70a49b73dae216a00fbf3f7e6907587c4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        uri \u003d \"v1/secrets/{}/payload\".format(secret_id)"},{"line_number":86,"context_line":"        if kwargs:"},{"line_number":87,"context_line":"            uri +\u003d \u0027?\u0027"},{"line_number":88,"context_line":"            uri +\u003d \u0027,\u0027.join([\"{}\u003d{}\".format(k, kwargs[k]) for k in kwargs])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        resp, body \u003d self.get(uri, headers\u003dcontent_headers)"},{"line_number":91,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":7,"id":"039cb840_b065a948","line":88,"range":{"start_line":88,"start_character":20,"end_line":88,"end_character":21},"in_reply_to":"5beaae92_b2572670","updated":"2022-11-14 12:28:44.000000000","message":"Both \",\" and \"\u0026\" will produce the same string. Just checked.","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"}],"barbican_tempest_plugin/tests/api/test_cve_2022_3100.py":[{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"fce3d52c7f85aa93f81f0e108a6b97d8fa554f0e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"from oslo_log import log as logging"},{"line_number":13,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":14,"context_line":"from tempest.lib import exceptions"},{"line_number":15,"context_line":"from tempest import config"},{"line_number":16,"context_line":"from barbican_tempest_plugin.tests.rbac.v1 import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"c9cafd0f_25955f93","line":15,"in_reply_to":"64620603_829dcbe5","updated":"2022-10-31 10:14:46.000000000","message":"\u003e pep8: H306: imports not in alphabetical order (tempest.lib.exceptions, tempest.config)\n\nPlease fix.","commit_id":"dc7d4f42567f9fa880bfe05593834cf404d8832b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b0e78133a7c248b808f0cac68e77cd892ed82747","unresolved":false,"context_lines":[{"line_number":12,"context_line":"from oslo_log import log as logging"},{"line_number":13,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":14,"context_line":"from tempest.lib import exceptions"},{"line_number":15,"context_line":"from tempest import config"},{"line_number":16,"context_line":"from barbican_tempest_plugin.tests.rbac.v1 import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"439054e5_359f2f51","line":15,"in_reply_to":"c9cafd0f_25955f93","updated":"2022-11-22 14:42:48.000000000","message":"Done","commit_id":"dc7d4f42567f9fa880bfe05593834cf404d8832b"},{"author":{"_account_id":34637,"name":"Milana Levy","email":"millevy@redhat.com","username":"millevy"},"change_message_id":"fce3d52c7f85aa93f81f0e108a6b97d8fa554f0e","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":14,"context_line":"from tempest.lib import exceptions"},{"line_number":15,"context_line":"from tempest import config"},{"line_number":16,"context_line":"from barbican_tempest_plugin.tests.rbac.v1 import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"CONF \u003d config.CONF"},{"line_number":19,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d37a05eb_b22608b0","line":16,"in_reply_to":"5a3a20ac_30ec6860","updated":"2022-10-31 10:14:46.000000000","message":"\u003e pep8: H306: imports not in alphabetical order (tempest.config, barbican_tempest_plugin.tests.rbac.v1.base)\n\nPlease fix.","commit_id":"dc7d4f42567f9fa880bfe05593834cf404d8832b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b0e78133a7c248b808f0cac68e77cd892ed82747","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":14,"context_line":"from tempest.lib import exceptions"},{"line_number":15,"context_line":"from tempest import config"},{"line_number":16,"context_line":"from barbican_tempest_plugin.tests.rbac.v1 import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"CONF \u003d config.CONF"},{"line_number":19,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e3ee9440_fe963846","line":16,"in_reply_to":"d37a05eb_b22608b0","updated":"2022-11-22 14:42:48.000000000","message":"Done","commit_id":"dc7d4f42567f9fa880bfe05593834cf404d8832b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"b0e78133a7c248b808f0cac68e77cd892ed82747","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class CVE20223100Test(base.BarbicanV1RbacBase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_cve_2022_3100(self):"},{"line_number":26,"context_line":"        # create a secret that belongs to Project B"},{"line_number":27,"context_line":"        secret_id \u003d self.create_test_secret("},{"line_number":28,"context_line":"            self.other_secret_client,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ce79e096_e259f33b","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":33},"updated":"2022-11-22 14:42:48.000000000","message":"We should add idempotent_id to this test [1].\n\n[1] https://opendev.org/openstack/barbican-tempest-plugin/src/commit/dc14cae0ebd620d30be0cd9784394f8d775a7557/barbican_tempest_plugin/tests/api/test_consumers.py#L23","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d435c21128dae33a7bc8860203a97229af114c23","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class CVE20223100Test(base.BarbicanV1RbacBase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_cve_2022_3100(self):"},{"line_number":26,"context_line":"        # create a secret that belongs to Project B"},{"line_number":27,"context_line":"        secret_id \u003d self.create_test_secret("},{"line_number":28,"context_line":"            self.other_secret_client,"}],"source_content_type":"text/x-python","patch_set":7,"id":"e638a9dd_e8e84e3e","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":33},"in_reply_to":"479ba65f_3099144b","updated":"2022-12-08 13:46:43.000000000","message":"Done","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"eb67d6c01087c2926054e4af91ec682d1f739ceb","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class CVE20223100Test(base.BarbicanV1RbacBase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_cve_2022_3100(self):"},{"line_number":26,"context_line":"        # create a secret that belongs to Project B"},{"line_number":27,"context_line":"        secret_id \u003d self.create_test_secret("},{"line_number":28,"context_line":"            self.other_secret_client,"}],"source_content_type":"text/x-python","patch_set":7,"id":"479ba65f_3099144b","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":33},"in_reply_to":"ce79e096_e259f33b","updated":"2022-12-06 15:25:03.000000000","message":"I\u0027m sorry I wasn\u0027t more specific. The idempotent_id in the link should have served only as an example. Each test has to have a unique identifier [1]. \n\n[1] https://docs.openstack.org/tempest/latest/HACKING.html#test-identification-with-idempotent-id","commit_id":"6d173e6740caeff3fc7aa584542a5308e4011eba"}]}
