)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"28add41cc92a2f2218558f01e9a364745b1f82bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4b19e97b_ef7a9dd0","updated":"2023-05-03 14:12:35.000000000","message":"LGTM","commit_id":"bf80ee01bb9aa9366eac533ea32e44ab0729906b"}],"barbican_tempest_plugin/config.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"16d1b8c48831720ebb7adee29610092f974a13dd","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                default\u003dTrue,"},{"line_number":91,"context_line":"                help\u003d\"Does the test environment enforce glance image \""},{"line_number":92,"context_line":"                     \"verification?\"),"},{"line_number":93,"context_line":"    cfg.BoolOpt(\u0027enable_certificate_validation\u0027,"},{"line_number":94,"context_line":"                default\u003dTrue,"},{"line_number":95,"context_line":"                help\u003d\"Does the test environment enforce image signature\""},{"line_number":96,"context_line":"                     \"certificate validation?\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdc0db5_6914970e","line":93,"range":{"start_line":93,"start_character":17,"end_line":93,"end_character":46},"updated":"2023-05-02 12:11:12.000000000","message":"I think we usually don\u0027t use enable_\u003cfoo\u003e as pattern, couldn\u0027t this be just \u0027certificate_validation\u0027 ? I understand \u0027enable_certificate_validation\u0027 is the corresponding nova configuration but the option here doesn\u0027t need to map directly to the service-specific configuration (I think?)","commit_id":"870b6264f541ae9c518bdd059f49bf517fbea701"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"482bd92c190b96e7a9735c7a6268143cad3adebf","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                default\u003dTrue,"},{"line_number":91,"context_line":"                help\u003d\"Does the test environment enforce glance image \""},{"line_number":92,"context_line":"                     \"verification?\"),"},{"line_number":93,"context_line":"    cfg.BoolOpt(\u0027enable_certificate_validation\u0027,"},{"line_number":94,"context_line":"                default\u003dTrue,"},{"line_number":95,"context_line":"                help\u003d\"Does the test environment enforce image signature\""},{"line_number":96,"context_line":"                     \"certificate validation?\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc020610_6ae144e0","line":93,"range":{"start_line":93,"start_character":17,"end_line":93,"end_character":46},"in_reply_to":"3124207b_7490de15","updated":"2023-05-03 12:47:35.000000000","message":"Yes, I\u0027ve seen that variable... but the fact it\u0027s alone says something :)","commit_id":"870b6264f541ae9c518bdd059f49bf517fbea701"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"bfd6a37a31977c2762c027d5bbca90c47180cee9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                default\u003dTrue,"},{"line_number":91,"context_line":"                help\u003d\"Does the test environment enforce glance image \""},{"line_number":92,"context_line":"                     \"verification?\"),"},{"line_number":93,"context_line":"    cfg.BoolOpt(\u0027enable_certificate_validation\u0027,"},{"line_number":94,"context_line":"                default\u003dTrue,"},{"line_number":95,"context_line":"                help\u003d\"Does the test environment enforce image signature\""},{"line_number":96,"context_line":"                     \"certificate validation?\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3124207b_7490de15","line":93,"range":{"start_line":93,"start_character":17,"end_line":93,"end_character":46},"in_reply_to":"9fdc0db5_6914970e","updated":"2023-05-03 12:45:23.000000000","message":"Ok, I will change it to \u0027certificate_validation\u0027. I think that the config option name does not need to map directly to the service config option here. I know for example about this [1] config option in tempest that starts with enable. But it was introduced a few years ago.\n\n[1] https://opendev.org/openstack/tempest/src/commit/cb008e2167826ad0950b4fd694f344c639413c91/tempest/config.py#L557","commit_id":"870b6264f541ae9c518bdd059f49bf517fbea701"}]}