)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"1449d00b9c1a3933a4efd05db6e9306f162e8635","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8e44ec10_b4ae437c","updated":"2023-10-05 11:19:01.000000000","message":"Barbican client failed in barbican-tempest-plugin-simple-crypto-secure-rbac gate","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"903fa8ff519caed03f7ecb83dbb9eb8adf65e187","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"171ab4f8_c2159585","updated":"2023-10-09 08:45:58.000000000","message":"recheck","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ca7bb6bdc5d6a5dd647e654295d1adb088e2d73a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0599a054_7cdb930e","updated":"2023-11-14 11:14:22.000000000","message":"I just quickly went to through the patch:).","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"e73a721df6e28dd8da24da764f599aa843a67d79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"47edf117_5efbf7fd","updated":"2023-12-14 13:27:46.000000000","message":"The barbican-tempest-plugin-simple-crypto-secure-rbac is blocked by this bug: https://bugs.launchpad.net/barbican/+bug/2043457. I think we should remove the testing of multiple secret stores in the srbac job until the bug gets resolved.","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"1045ef2c79a57dcbee2f92bdbac2af3ae780f863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8f008eaa_a01f4414","in_reply_to":"47edf117_5efbf7fd","updated":"2023-12-14 13:35:01.000000000","message":"This patch should unblock the jobs: https://review.opendev.org/c/openstack/barbican-tempest-plugin/+/903678. Let\u0027s wait for the results.","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"81b67771e3d32eba9173c92745d864b1cb83cb21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a69a66f6_881c8aa3","updated":"2024-01-18 15:38:45.000000000","message":"recheck\nhttps://review.opendev.org/c/openstack/barbican-tempest-plugin/+/903678 is merged","commit_id":"5558bcb784c6b91e6db0358c6dc6911c8bc86124"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4b3c62e5b5b5e2c78967a883b462ac6686aef543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a84530ab_88628439","updated":"2023-11-22 20:48:44.000000000","message":"technically it looks ok to me, the purpose of the test needs to be reviewed by someone who is more familiar with barbican thoug","commit_id":"5558bcb784c6b91e6db0358c6dc6911c8bc86124"}],"barbican_tempest_plugin/tests/scenario/test_image_signing.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c7f202b4813efcefa108839c230c4ca761e2b890","unresolved":true,"context_lines":[{"line_number":25,"context_line":"from tempest.lib.common import api_version_utils"},{"line_number":26,"context_line":"from tempest.lib import decorators"},{"line_number":27,"context_line":"from tempest.scenario import manager as tempest_manager"},{"line_number":28,"context_line":"from typing import Optional"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import testtools"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7960e3de_5bda5e6e","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":27},"updated":"2023-10-11 08:32:34.000000000","message":"If we support version less than python 3.5 it won\u0027t work.","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"ab00f630209c88aac80e5a3209ebf8ace08fdd31","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from tempest.lib.common import api_version_utils"},{"line_number":26,"context_line":"from tempest.lib import decorators"},{"line_number":27,"context_line":"from tempest.scenario import manager as tempest_manager"},{"line_number":28,"context_line":"from typing import Optional"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import testtools"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"315e7136_21583104","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":27},"in_reply_to":"7960e3de_5bda5e6e","updated":"2023-11-13 20:23:56.000000000","message":"Removed","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c7f202b4813efcefa108839c230c4ca761e2b890","unresolved":true,"context_lines":[{"line_number":182,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":183,"context_line":"                cls.min_microversion,"},{"line_number":184,"context_line":"                CONF.compute.min_microversion))"},{"line_number":185,"context_line":"        cls.secret_client \u003d cls.os.secret_v1.SecretClient()"},{"line_number":186,"context_line":"        cls.admin_volumes_client \u003d cls.os_admin.volumes_client_latest"},{"line_number":187,"context_line":"        cls.admin_encryption_types_client \u003d \\"},{"line_number":188,"context_line":"            cls.os_adm.encryption_types_v2_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"41f6f40e_4fcca646","line":185,"range":{"start_line":185,"start_character":8,"end_line":185,"end_character":59},"updated":"2023-10-11 08:32:34.000000000","message":"It\u0027s not used.","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"ab00f630209c88aac80e5a3209ebf8ace08fdd31","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":183,"context_line":"                cls.min_microversion,"},{"line_number":184,"context_line":"                CONF.compute.min_microversion))"},{"line_number":185,"context_line":"        cls.secret_client \u003d cls.os.secret_v1.SecretClient()"},{"line_number":186,"context_line":"        cls.admin_volumes_client \u003d cls.os_admin.volumes_client_latest"},{"line_number":187,"context_line":"        cls.admin_encryption_types_client \u003d \\"},{"line_number":188,"context_line":"            cls.os_adm.encryption_types_v2_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"bb54701e_eb2dc2ff","line":185,"range":{"start_line":185,"start_character":8,"end_line":185,"end_character":59},"in_reply_to":"41f6f40e_4fcca646","updated":"2023-11-13 20:23:56.000000000","message":"Done","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c7f202b4813efcefa108839c230c4ca761e2b890","unresolved":true,"context_lines":[{"line_number":184,"context_line":"                CONF.compute.min_microversion))"},{"line_number":185,"context_line":"        cls.secret_client \u003d cls.os.secret_v1.SecretClient()"},{"line_number":186,"context_line":"        cls.admin_volumes_client \u003d cls.os_admin.volumes_client_latest"},{"line_number":187,"context_line":"        cls.admin_encryption_types_client \u003d \\"},{"line_number":188,"context_line":"            cls.os_adm.encryption_types_v2_client"},{"line_number":189,"context_line":"        cls.volumes_client \u003d cls.os_primary.volumes_client_latest"},{"line_number":190,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"}],"source_content_type":"text/x-python","patch_set":4,"id":"703876ca_41d28134","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":41},"updated":"2023-10-11 08:32:34.000000000","message":"Same","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"ab00f630209c88aac80e5a3209ebf8ace08fdd31","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                CONF.compute.min_microversion))"},{"line_number":185,"context_line":"        cls.secret_client \u003d cls.os.secret_v1.SecretClient()"},{"line_number":186,"context_line":"        cls.admin_volumes_client \u003d cls.os_admin.volumes_client_latest"},{"line_number":187,"context_line":"        cls.admin_encryption_types_client \u003d \\"},{"line_number":188,"context_line":"            cls.os_adm.encryption_types_v2_client"},{"line_number":189,"context_line":"        cls.volumes_client \u003d cls.os_primary.volumes_client_latest"},{"line_number":190,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"}],"source_content_type":"text/x-python","patch_set":4,"id":"fe4bebc7_3768ca20","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":41},"in_reply_to":"703876ca_41d28134","updated":"2023-11-13 20:23:56.000000000","message":"Done","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c7f202b4813efcefa108839c230c4ca761e2b890","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        cls.admin_volumes_client \u003d cls.os_admin.volumes_client_latest"},{"line_number":187,"context_line":"        cls.admin_encryption_types_client \u003d \\"},{"line_number":188,"context_line":"            cls.os_adm.encryption_types_v2_client"},{"line_number":189,"context_line":"        cls.volumes_client \u003d cls.os_primary.volumes_client_latest"},{"line_number":190,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"},{"line_number":191,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":192,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"55f78bf5_38dc586a","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":65},"updated":"2023-10-11 08:32:34.000000000","message":"You can remove it as it\u0027s already initialized in BaseV2ComputeTest.","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"ab00f630209c88aac80e5a3209ebf8ace08fdd31","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        cls.admin_volumes_client \u003d cls.os_admin.volumes_client_latest"},{"line_number":187,"context_line":"        cls.admin_encryption_types_client \u003d \\"},{"line_number":188,"context_line":"            cls.os_adm.encryption_types_v2_client"},{"line_number":189,"context_line":"        cls.volumes_client \u003d cls.os_primary.volumes_client_latest"},{"line_number":190,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"},{"line_number":191,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":192,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"00ac4326_bc4a7a81","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":65},"in_reply_to":"55f78bf5_38dc586a","updated":"2023-11-13 20:23:56.000000000","message":"Done","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c7f202b4813efcefa108839c230c4ca761e2b890","unresolved":true,"context_lines":[{"line_number":187,"context_line":"        cls.admin_encryption_types_client \u003d \\"},{"line_number":188,"context_line":"            cls.os_adm.encryption_types_v2_client"},{"line_number":189,"context_line":"        cls.volumes_client \u003d cls.os_primary.volumes_client_latest"},{"line_number":190,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"},{"line_number":191,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":192,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"6a291733_89b08db4","line":190,"range":{"start_line":190,"start_character":8,"end_line":190,"end_character":57},"updated":"2023-10-11 08:32:34.000000000","message":"You can remove it as it\u0027s already initialized in BaseV2ComputeTest.","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"51941e6dbd2ad79230674d1fd6cc3acb0dcccc32","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        cls.admin_encryption_types_client \u003d \\"},{"line_number":188,"context_line":"            cls.os_adm.encryption_types_v2_client"},{"line_number":189,"context_line":"        cls.volumes_client \u003d cls.os_primary.volumes_client_latest"},{"line_number":190,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"},{"line_number":191,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":192,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"af20c13f_7b51011b","line":190,"range":{"start_line":190,"start_character":8,"end_line":190,"end_character":57},"in_reply_to":"6a291733_89b08db4","updated":"2023-11-13 20:26:55.000000000","message":"Done","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c7f202b4813efcefa108839c230c4ca761e2b890","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        cls.volumes_client \u003d cls.os_primary.volumes_client_latest"},{"line_number":190,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"},{"line_number":191,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":192,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def _volume_create(self,"},{"line_number":195,"context_line":"                       volume_type: Optional[str] \u003d None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f0fb3274_6f53768c","line":192,"range":{"start_line":192,"start_character":8,"end_line":192,"end_character":58},"updated":"2023-10-11 08:32:34.000000000","message":"You can remove it as it\u0027s already initialized in BaseV2ComputeTest.","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"ab00f630209c88aac80e5a3209ebf8ace08fdd31","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        cls.volumes_client \u003d cls.os_primary.volumes_client_latest"},{"line_number":190,"context_line":"        cls.image_client \u003d cls.os_primary.image_client_v2"},{"line_number":191,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":192,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def _volume_create(self,"},{"line_number":195,"context_line":"                       volume_type: Optional[str] \u003d None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"952016ab_950c8a15","line":192,"range":{"start_line":192,"start_character":8,"end_line":192,"end_character":58},"in_reply_to":"f0fb3274_6f53768c","updated":"2023-11-13 20:23:56.000000000","message":"Done","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c7f202b4813efcefa108839c230c4ca761e2b890","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    @decorators.idempotent_id(\u002772ca044d-39a4-4966-b302-f53a446d3e29\u0027)"},{"line_number":237,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":238,"context_line":"    @utils.services(\u0027compute\u0027, \u0027image\u0027, \u0027volume\u0027)"},{"line_number":239,"context_line":"    def test_extend_encrypted_volume_attach_to_instance(self):"},{"line_number":240,"context_line":"        \"\"\"Create instance from signed image and"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        attach encrypted extended volume"}],"source_content_type":"text/x-python","patch_set":4,"id":"b02bc054_f0ebfa96","line":239,"range":{"start_line":239,"start_character":8,"end_line":239,"end_character":55},"updated":"2023-10-11 08:32:34.000000000","message":"I\u0027m not sure about the need for this test.\nAs I understood from the bug, the bug is related to extension of encrypted volume.","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"ab00f630209c88aac80e5a3209ebf8ace08fdd31","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    @decorators.idempotent_id(\u002772ca044d-39a4-4966-b302-f53a446d3e29\u0027)"},{"line_number":237,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":238,"context_line":"    @utils.services(\u0027compute\u0027, \u0027image\u0027, \u0027volume\u0027)"},{"line_number":239,"context_line":"    def test_extend_encrypted_volume_attach_to_instance(self):"},{"line_number":240,"context_line":"        \"\"\"Create instance from signed image and"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        attach encrypted extended volume"}],"source_content_type":"text/x-python","patch_set":4,"id":"71b51e2b_38a2a468","line":239,"range":{"start_line":239,"start_character":8,"end_line":239,"end_character":55},"in_reply_to":"b02bc054_f0ebfa96","updated":"2023-11-13 20:23:56.000000000","message":"The test rewrited","commit_id":"a5c607a79fd93f52608e8b9bca8079f939c85d16"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ca7bb6bdc5d6a5dd647e654295d1adb088e2d73a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from barbican_tempest_plugin.tests.scenario import barbican_manager"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_log import log as logging"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a383d24_a7f0345b","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":1},"updated":"2023-11-14 11:14:22.000000000","message":"Usually we want to follow this order of imports:\n1. standard libraries\n2. third party imports\n3. local imports","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4b3c62e5b5b5e2c78967a883b462ac6686aef543","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from barbican_tempest_plugin.tests.scenario import barbican_manager"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_log import log as logging"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"b32b3b18_60fc346a","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":1},"in_reply_to":"7a383d24_a7f0345b","updated":"2023-11-22 20:48:44.000000000","message":"Done","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ca7bb6bdc5d6a5dd647e654295d1adb088e2d73a","unresolved":true,"context_lines":[{"line_number":174,"context_line":"        if not CONF.volume_feature_enabled.extend_attached_volume:"},{"line_number":175,"context_line":"            raise cls.skipException(\"Extend attached volume not supported\")"},{"line_number":176,"context_line":"        if not CONF.volume_feature_enabled.extend_attached_encrypted_volume:"},{"line_number":177,"context_line":"            raise cls.skipException(\"Extend attached \\"},{"line_number":178,"context_line":"                                    encrypted volume not supported\")"},{"line_number":179,"context_line":"        if not CONF.service_available.nova:"},{"line_number":180,"context_line":"            raise cls.skipException(\"Nova service not available\")"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3401a6ee_6f073ebc","line":178,"range":{"start_line":177,"start_character":36,"end_line":178,"end_character":67},"updated":"2023-11-14 11:14:22.000000000","message":"I think this should be replace with:\n```\nraise cls.skipException(\"Extend attached \"\n                        \"encrypted volume not supported\")\n```\n\nOtherwise, this would be printed out to stdout:\n```\nExtend attached                        encrypted volume not suported.\n```","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"3bf31e8540d502e00cffeec2f5d52efbf5e4adfe","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        if not CONF.volume_feature_enabled.extend_attached_volume:"},{"line_number":175,"context_line":"            raise cls.skipException(\"Extend attached volume not supported\")"},{"line_number":176,"context_line":"        if not CONF.volume_feature_enabled.extend_attached_encrypted_volume:"},{"line_number":177,"context_line":"            raise cls.skipException(\"Extend attached \\"},{"line_number":178,"context_line":"                                    encrypted volume not supported\")"},{"line_number":179,"context_line":"        if not CONF.service_available.nova:"},{"line_number":180,"context_line":"            raise cls.skipException(\"Nova service not available\")"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"4482ac95_c8df8148","line":178,"range":{"start_line":177,"start_character":36,"end_line":178,"end_character":67},"in_reply_to":"3401a6ee_6f073ebc","updated":"2023-11-16 12:24:51.000000000","message":"Done","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ca7bb6bdc5d6a5dd647e654295d1adb088e2d73a","unresolved":true,"context_lines":[{"line_number":182,"context_line":"    @classmethod"},{"line_number":183,"context_line":"    def resource_setup(cls):"},{"line_number":184,"context_line":"        super(ImageSigningVolumeTest, cls).resource_setup()"},{"line_number":185,"context_line":"        cls.request_microversion \u003d ("},{"line_number":186,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":187,"context_line":"                cls.min_microversion,"},{"line_number":188,"context_line":"                CONF.compute.min_microversion))"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"},{"line_number":191,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"47739d69_8f16e7fe","line":188,"range":{"start_line":185,"start_character":7,"end_line":188,"end_character":47},"updated":"2023-11-14 11:14:22.000000000","message":"I think, this should not be necessary as it is already defined in the parent class here, but maybe I\u0027m missing something:). [1]\n\n[1] https://opendev.org/openstack/tempest/src/commit/cc0e9b18170bc796fd8516e41d2ec09236b168aa/tempest/api/compute/base.py#L125","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"3bf31e8540d502e00cffeec2f5d52efbf5e4adfe","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    @classmethod"},{"line_number":183,"context_line":"    def resource_setup(cls):"},{"line_number":184,"context_line":"        super(ImageSigningVolumeTest, cls).resource_setup()"},{"line_number":185,"context_line":"        cls.request_microversion \u003d ("},{"line_number":186,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":187,"context_line":"                cls.min_microversion,"},{"line_number":188,"context_line":"                CONF.compute.min_microversion))"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"},{"line_number":191,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"b8b76dff_c5351dab","line":188,"range":{"start_line":185,"start_character":7,"end_line":188,"end_character":47},"in_reply_to":"47739d69_8f16e7fe","updated":"2023-11-16 12:24:51.000000000","message":"Done","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ca7bb6bdc5d6a5dd647e654295d1adb088e2d73a","unresolved":true,"context_lines":[{"line_number":188,"context_line":"                CONF.compute.min_microversion))"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"},{"line_number":191,"context_line":"    def setup_clients(cls):"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        super(ImageSigningVolumeTest, cls).setup_clients()"},{"line_number":194,"context_line":"        cls.request_microversion \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"35620ace_4231c998","line":191,"range":{"start_line":191,"start_character":4,"end_line":191,"end_character":27},"updated":"2023-11-14 11:14:22.000000000","message":"nit: an empty line (192)","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"3bf31e8540d502e00cffeec2f5d52efbf5e4adfe","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                CONF.compute.min_microversion))"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"},{"line_number":191,"context_line":"    def setup_clients(cls):"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        super(ImageSigningVolumeTest, cls).setup_clients()"},{"line_number":194,"context_line":"        cls.request_microversion \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"2548eb56_7f50ef63","line":191,"range":{"start_line":191,"start_character":4,"end_line":191,"end_character":27},"in_reply_to":"35620ace_4231c998","updated":"2023-11-16 12:24:51.000000000","message":"Done","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ca7bb6bdc5d6a5dd647e654295d1adb088e2d73a","unresolved":true,"context_lines":[{"line_number":191,"context_line":"    def setup_clients(cls):"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        super(ImageSigningVolumeTest, cls).setup_clients()"},{"line_number":194,"context_line":"        cls.request_microversion \u003d ("},{"line_number":195,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":196,"context_line":"                cls.min_microversion,"},{"line_number":197,"context_line":"                CONF.compute.min_microversion))"},{"line_number":198,"context_line":"        cls.admin_volumes_client \u003d cls.os_admin.volumes_client_latest"},{"line_number":199,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"e386778d_05e70b3b","line":197,"range":{"start_line":194,"start_character":5,"end_line":197,"end_character":47},"updated":"2023-11-14 11:14:22.000000000","message":"I think this should be required only in the resource_setup(). [1]\n\n[1] https://docs.openstack.org/tempest/latest/microversion_testing.html#step2-selected-api-request-microversion","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"3bf31e8540d502e00cffeec2f5d52efbf5e4adfe","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    def setup_clients(cls):"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        super(ImageSigningVolumeTest, cls).setup_clients()"},{"line_number":194,"context_line":"        cls.request_microversion \u003d ("},{"line_number":195,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":196,"context_line":"                cls.min_microversion,"},{"line_number":197,"context_line":"                CONF.compute.min_microversion))"},{"line_number":198,"context_line":"        cls.admin_volumes_client \u003d cls.os_admin.volumes_client_latest"},{"line_number":199,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"cc095003_72e8d17c","line":197,"range":{"start_line":194,"start_character":5,"end_line":197,"end_character":47},"in_reply_to":"e386778d_05e70b3b","updated":"2023-11-16 12:24:51.000000000","message":"Done","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ca7bb6bdc5d6a5dd647e654295d1adb088e2d73a","unresolved":true,"context_lines":[{"line_number":195,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":196,"context_line":"                cls.min_microversion,"},{"line_number":197,"context_line":"                CONF.compute.min_microversion))"},{"line_number":198,"context_line":"        cls.admin_volumes_client \u003d cls.os_admin.volumes_client_latest"},{"line_number":199,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _create_encrypted_signed_volume(self,"},{"line_number":202,"context_line":"                                        encryption_provider,"}],"source_content_type":"text/x-python","patch_set":7,"id":"99af83ea_c6e8eacc","line":199,"range":{"start_line":198,"start_character":8,"end_line":199,"end_character":62},"updated":"2023-11-14 11:14:22.000000000","message":"Why do we need to rename the clients?","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"3bf31e8540d502e00cffeec2f5d52efbf5e4adfe","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":196,"context_line":"                cls.min_microversion,"},{"line_number":197,"context_line":"                CONF.compute.min_microversion))"},{"line_number":198,"context_line":"        cls.admin_volumes_client \u003d cls.os_admin.volumes_client_latest"},{"line_number":199,"context_line":"        cls.admin_servers_client \u003d cls.os_admin.servers_client"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _create_encrypted_signed_volume(self,"},{"line_number":202,"context_line":"                                        encryption_provider,"}],"source_content_type":"text/x-python","patch_set":7,"id":"06c1b470_72b18e9d","line":199,"range":{"start_line":198,"start_character":8,"end_line":199,"end_character":62},"in_reply_to":"99af83ea_c6e8eacc","updated":"2023-11-16 12:24:51.000000000","message":"Done","commit_id":"ac35e7df5af0190f5816e5d87ff578794ff6f06a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4b3c62e5b5b5e2c78967a883b462ac6686aef543","unresolved":true,"context_lines":[{"line_number":260,"context_line":"            resized_volume[\u0027id\u0027],"},{"line_number":261,"context_line":"            instance_observed[\u0027os-extended-volumes:volumes_attached\u0027][0][\u0027id\u0027])"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self.delete_server(instance_observed[\u0027id\u0027])"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    @decorators.idempotent_id(\u002772ca044d-39a4-4966-b302-f53a446d3e29\u0027)"},{"line_number":266,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"55fd52a4_cd70a205","line":263,"range":{"start_line":263,"start_character":13,"end_line":263,"end_character":26},"updated":"2023-11-22 20:48:44.000000000","message":"you probably don\u0027t need to delete the server, the server was created using create_server method that is defined in tempest/scenario/manager.py (the interface that all plugins reuse) - https://opendev.org/openstack/tempest/src/commit/8def25cbb5885e91899793f8575d3919816a0d12/tempest/scenario/manager.py#L192\nand at the end of that method there is a delete_server call:\nhttps://opendev.org/openstack/tempest/src/commit/8def25cbb5885e91899793f8575d3919816a0d12/tempest/scenario/manager.py#L350","commit_id":"5558bcb784c6b91e6db0358c6dc6911c8bc86124"}]}