)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3f5354f954d903d89af2637fa22caa76caac3e70","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"cf88526a_9c5c42bc","updated":"2024-02-16 15:52:12.000000000","message":"Also, I wonder if this plugin is the right place (at least as the first stage) to add this. IIUC Oauth 2.0 support is not very specific to barbican and can be used in any services using keystone auth. Then Can\u0027t we add it to tempest first, and then reuse that base implementation in each plugin ?","commit_id":"37e72817912982ee49d4068724ca5a8d9a6f6d00"}],"barbican_tempest_plugin/config.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe6411e604d08df88a4dae340908ebd77618a480","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    name\u003d\u0027barbican_external_oauth2_scenario\u0027,"},{"line_number":115,"context_line":"    title\u003d\u0027Barbican External OAuth2.0 Scenario Tests Options\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"BarbicanExternalOAuth2ScenarioGroup \u003d ["},{"line_number":118,"context_line":"    cfg.StrOpt(\u0027keycloak_host\u0027,"},{"line_number":119,"context_line":"               help\u003d\u0027The host name or IP address of the Keycloak server.\u0027),"},{"line_number":120,"context_line":"    cfg.IntOpt(\u0027keycloak_http_port\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"732591e9_d3f931df","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":35},"updated":"2024-02-16 15:34:55.000000000","message":"IIUC the tests should be run in a specific deployment with the feature enabled. Can we add a toggle to enable testing oauth2, which is disabled by default.","commit_id":"37e72817912982ee49d4068724ca5a8d9a6f6d00"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe6411e604d08df88a4dae340908ebd77618a480","unresolved":true,"context_lines":[{"line_number":117,"context_line":"BarbicanExternalOAuth2ScenarioGroup \u003d ["},{"line_number":118,"context_line":"    cfg.StrOpt(\u0027keycloak_host\u0027,"},{"line_number":119,"context_line":"               help\u003d\u0027The host name or IP address of the Keycloak server.\u0027),"},{"line_number":120,"context_line":"    cfg.IntOpt(\u0027keycloak_http_port\u0027,"},{"line_number":121,"context_line":"               help\u003d\u0027The HTTP service port of the Keycloak server.\u0027),"},{"line_number":122,"context_line":"    cfg.IntOpt(\u0027keycloak_ssl_port\u0027,"},{"line_number":123,"context_line":"               help\u003d\u0027The HTTPS service port of the Keycloak server.\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"c7a80a56_f5c30d27","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":14},"updated":"2024-02-16 15:34:55.000000000","message":"Use PortOpt. Also, I wonder if we can pick up a default value if there is a popular one used.","commit_id":"37e72817912982ee49d4068724ca5a8d9a6f6d00"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe6411e604d08df88a4dae340908ebd77618a480","unresolved":true,"context_lines":[{"line_number":119,"context_line":"               help\u003d\u0027The host name or IP address of the Keycloak server.\u0027),"},{"line_number":120,"context_line":"    cfg.IntOpt(\u0027keycloak_http_port\u0027,"},{"line_number":121,"context_line":"               help\u003d\u0027The HTTP service port of the Keycloak server.\u0027),"},{"line_number":122,"context_line":"    cfg.IntOpt(\u0027keycloak_ssl_port\u0027,"},{"line_number":123,"context_line":"               help\u003d\u0027The HTTPS service port of the Keycloak server.\u0027),"},{"line_number":124,"context_line":"    cfg.StrOpt(\u0027keycloak_admin_user_name\u0027,"},{"line_number":125,"context_line":"               help\u003d\u0027The administrator account of the keycloak server\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"7fa400e0_765fc5e2","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":14},"updated":"2024-02-16 15:34:55.000000000","message":"ditto","commit_id":"37e72817912982ee49d4068724ca5a8d9a6f6d00"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe6411e604d08df88a4dae340908ebd77618a480","unresolved":true,"context_lines":[{"line_number":149,"context_line":"    cfg.StrOpt(\u0027sys_mapping_role_key\u0027,"},{"line_number":150,"context_line":"               help\u003d\u0027The field name in the token used to store \u0027"},{"line_number":151,"context_line":"                    \u0027roles information.\u0027),"},{"line_number":152,"context_line":"    cfg.StrOpt(\u0027barbican_http_schema\u0027,"},{"line_number":153,"context_line":"               default\u003d\u0027http\u0027,"},{"line_number":154,"context_line":"               choices\u003d(\u0027http\u0027, \u0027https\u0027),"},{"line_number":155,"context_line":"               help\u003d\u0027The protocol for accessing the barbican server.\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"1208faa2_2aa9bb9a","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":14},"updated":"2024-02-16 15:34:55.000000000","message":"why can\u0027t we detect bacriban endpoint from keystone catalog ? I think that\u0027s how barbican endpoint is discovered in the other tests like API tests.","commit_id":"37e72817912982ee49d4068724ca5a8d9a6f6d00"}],"barbican_tempest_plugin/tests/scenario/test_ext_oauth2.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe6411e604d08df88a4dae340908ebd77618a480","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            LOG.debug(f\"Cannot clear keycloak data. {error}\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @classmethod"},{"line_number":121,"context_line":"    def init_config(cls):"},{"line_number":122,"context_line":"        \"\"\"Load configure information from tempest config.\"\"\""},{"line_number":123,"context_line":"        ex_conf \u003d CONF.barbican_external_oauth2_scenario"},{"line_number":124,"context_line":"        cls.realm_name \u003d ex_conf.sys_realm_name"}],"source_content_type":"text/x-python","patch_set":12,"id":"fb130295_fb9bf92d","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":19},"updated":"2024-02-16 15:34:55.000000000","message":"you probably have to validate values in setUp.","commit_id":"37e72817912982ee49d4068724ca5a8d9a6f6d00"}]}