)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"8420ced13045076b8925d4d24ce1542d700d16c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"91dddf99_0b48a992","updated":"2024-05-14 06:14:31.000000000","message":"I think the client used for the deletion needs to be changed (if the point of the test is to delete the volume with admin)","commit_id":"cec7bcf190eb07bc37a31e01ce49ed7bf8b6aa0e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4c29685e358f5dce3b59bf874ef8085fe1e16aaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ce7f0662_d9231b4d","updated":"2024-05-22 08:01:53.000000000","message":"locally this works for me, the rest like potential changes in the jobs voting here, is up to the cores","commit_id":"255f44270828faa3168af1f464cd42c7df39ef44"}],"barbican_tempest_plugin/tests/scenario/test_volume_encryption.py":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"8420ced13045076b8925d4d24ce1542d700d16c9","unresolved":true,"context_lines":[{"line_number":249,"context_line":"                                                  user_id)"},{"line_number":250,"context_line":"        self.os_admin.projects_client.delete_project(project_id)"},{"line_number":251,"context_line":"        # delete the volume with admin user - it has to succeed"},{"line_number":252,"context_line":"        self.volumes_client.delete_volume(volume[\u0027id\u0027])"},{"line_number":253,"context_line":"        self.volumes_client.wait_for_resource_deletion("},{"line_number":254,"context_line":"            volume[\u0027id\u0027])"},{"line_number":255,"context_line":"        volume \u003d self.volumes_client.show_volume("}],"source_content_type":"text/x-python","patch_set":7,"id":"40f1ad99_1594eb79","line":252,"range":{"start_line":252,"start_character":0,"end_line":252,"end_character":2},"updated":"2024-05-14 06:14:31.000000000","message":"`self.volumes_client` should be a member [1]. Maybe `self.os_admin.volumes_client_latest`?\n\n[1] https://opendev.org/openstack/tempest/src/commit/ccd034eb3a916ce4d3955fa11fe905aa50cbc15d/tempest/scenario/manager.py#L139","commit_id":"cec7bcf190eb07bc37a31e01ce49ed7bf8b6aa0e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ce3a9e902bab80593b4b8627adf9e946659e1673","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                                                  user_id)"},{"line_number":250,"context_line":"        self.os_admin.projects_client.delete_project(project_id)"},{"line_number":251,"context_line":"        # delete the volume with admin user - it has to succeed"},{"line_number":252,"context_line":"        self.volumes_client.delete_volume(volume[\u0027id\u0027])"},{"line_number":253,"context_line":"        self.volumes_client.wait_for_resource_deletion("},{"line_number":254,"context_line":"            volume[\u0027id\u0027])"},{"line_number":255,"context_line":"        volume \u003d self.volumes_client.show_volume("}],"source_content_type":"text/x-python","patch_set":7,"id":"2b5e7a16_265a704a","line":252,"range":{"start_line":252,"start_character":0,"end_line":252,"end_character":2},"in_reply_to":"40f1ad99_1594eb79","updated":"2024-05-14 09:23:13.000000000","message":"Done","commit_id":"cec7bcf190eb07bc37a31e01ce49ed7bf8b6aa0e"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"8420ced13045076b8925d4d24ce1542d700d16c9","unresolved":true,"context_lines":[{"line_number":252,"context_line":"        self.volumes_client.delete_volume(volume[\u0027id\u0027])"},{"line_number":253,"context_line":"        self.volumes_client.wait_for_resource_deletion("},{"line_number":254,"context_line":"            volume[\u0027id\u0027])"},{"line_number":255,"context_line":"        volume \u003d self.volumes_client.show_volume("},{"line_number":256,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":257,"context_line":"        self.assertEqual(volume, {})"}],"source_content_type":"text/x-python","patch_set":7,"id":"10de311d_1c5da2ce","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":2},"updated":"2024-05-14 06:14:31.000000000","message":"This will throw 404 after the volume is deleted [1].\n\n[1] https://docs.openstack.org/api-ref/block-storage/v3/#show-a-volume-s-details (preconditions)","commit_id":"cec7bcf190eb07bc37a31e01ce49ed7bf8b6aa0e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ce3a9e902bab80593b4b8627adf9e946659e1673","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        self.volumes_client.delete_volume(volume[\u0027id\u0027])"},{"line_number":253,"context_line":"        self.volumes_client.wait_for_resource_deletion("},{"line_number":254,"context_line":"            volume[\u0027id\u0027])"},{"line_number":255,"context_line":"        volume \u003d self.volumes_client.show_volume("},{"line_number":256,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":257,"context_line":"        self.assertEqual(volume, {})"}],"source_content_type":"text/x-python","patch_set":7,"id":"09c07df5_08aee97b","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":2},"in_reply_to":"10de311d_1c5da2ce","updated":"2024-05-14 09:23:13.000000000","message":"Done","commit_id":"cec7bcf190eb07bc37a31e01ce49ed7bf8b6aa0e"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"af068526ba0da47fe25f3cc9199ca5aca3773e3a","unresolved":true,"context_lines":[{"line_number":251,"context_line":"                                              clients\u003dnew_admin)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        # delete the project and the user that created the volume"},{"line_number":254,"context_line":"        self.os_admin.users_v3_client.delete_user(new_admin.credentials."},{"line_number":255,"context_line":"                                                  user_id)"},{"line_number":256,"context_line":"        self.os_admin.projects_client.delete_project(project_id)"},{"line_number":257,"context_line":"        # delete the volume with admin user - it has to succeed"},{"line_number":258,"context_line":"        self.os_admin.volumes_client_latest.delete_volume(volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"8a69b496_b2b804ce","line":255,"range":{"start_line":254,"start_character":50,"end_line":255,"end_character":57},"updated":"2024-05-14 15:14:40.000000000","message":"[nit] Can\u0027t this be rewritten differently? I\u0027m surprised pep8 passed with this. But this is really small thing.","commit_id":"c74415bc8fbf4862b24af027508deea78a14d149"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"178e99cc3e6635de48607a10bfdd76544840f831","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                                              clients\u003dnew_admin)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        # delete the project and the user that created the volume"},{"line_number":254,"context_line":"        self.os_admin.users_v3_client.delete_user(new_admin.credentials."},{"line_number":255,"context_line":"                                                  user_id)"},{"line_number":256,"context_line":"        self.os_admin.projects_client.delete_project(project_id)"},{"line_number":257,"context_line":"        # delete the volume with admin user - it has to succeed"},{"line_number":258,"context_line":"        self.os_admin.volumes_client_latest.delete_volume(volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"6d501dbf_5ca8c4af","line":255,"range":{"start_line":254,"start_character":50,"end_line":255,"end_character":57},"in_reply_to":"8a69b496_b2b804ce","updated":"2024-05-22 07:50:12.000000000","message":"Done","commit_id":"c74415bc8fbf4862b24af027508deea78a14d149"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"29771806f331ea3bf75809cff949ef50fd5c6592","unresolved":true,"context_lines":[{"line_number":259,"context_line":"        self.os_admin.volumes_client_latest.wait_for_resource_deletion("},{"line_number":260,"context_line":"            volume[\u0027id\u0027])"},{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            volume \u003d self.os_admin.volumes_client_latest.show_volume("},{"line_number":263,"context_line":"                volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":264,"context_line":"        except lib_exc.NotFound:"},{"line_number":265,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"04763814_e930a621","line":263,"range":{"start_line":262,"start_character":12,"end_line":263,"end_character":39},"updated":"2024-05-14 15:10:36.000000000","message":"I think assertRaises would be better here [1].\n\n[1] https://opendev.org/openstack/tempest/src/commit/ccd034eb3a916ce4d3955fa11fe905aa50cbc15d/tempest/api/network/test_networks.py#L287","commit_id":"c74415bc8fbf4862b24af027508deea78a14d149"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"178e99cc3e6635de48607a10bfdd76544840f831","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        self.os_admin.volumes_client_latest.wait_for_resource_deletion("},{"line_number":260,"context_line":"            volume[\u0027id\u0027])"},{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            volume \u003d self.os_admin.volumes_client_latest.show_volume("},{"line_number":263,"context_line":"                volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":264,"context_line":"        except lib_exc.NotFound:"},{"line_number":265,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"d97c4751_d8b8b0af","line":263,"range":{"start_line":262,"start_character":12,"end_line":263,"end_character":39},"in_reply_to":"04763814_e930a621","updated":"2024-05-22 07:50:12.000000000","message":"Done","commit_id":"c74415bc8fbf4862b24af027508deea78a14d149"}]}