)]}'
{"bin/versionbuild.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"11670fce39af0a7913e60b2e8c2377faf1f1f82b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    base \u003d version_info.version_string()"},{"line_number":68,"context_line":"    full \u003d version_info.release_string()"},{"line_number":69,"context_line":"    if base !\u003d full:"},{"line_number":70,"context_line":"        extension \u003d full[len(base) + 1:]  # Everything after base (minus \u0027.\u0027)"},{"line_number":71,"context_line":"        if extension.startswith(\u0027b\u0027):"},{"line_number":72,"context_line":"            return base, extension.split(\u0027.\u0027)[0]"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_f7560804","line":70,"updated":"2014-07-28 06:39:46.000000000","message":"This could be separated to another function, such as \"_trim_base\" or something of the sort, to make this more explicit. And thus, the comment wouldn\u0027t be needed","commit_id":"8f810929588b72f9541a760fc6ad0a8eddf78e88"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"11670fce39af0a7913e60b2e8c2377faf1f1f82b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    full \u003d version_info.release_string()"},{"line_number":69,"context_line":"    if base !\u003d full:"},{"line_number":70,"context_line":"        extension \u003d full[len(base) + 1:]  # Everything after base (minus \u0027.\u0027)"},{"line_number":71,"context_line":"        if extension.startswith(\u0027b\u0027):"},{"line_number":72,"context_line":"            return base, extension.split(\u0027.\u0027)[0]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    return base, None"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_b750100b","line":71,"updated":"2014-07-28 06:39:46.000000000","message":"I would rather have this as a separate function, such as:\n\ndef _is_milestone_release(release_string):\n    return release_string.startswith(\u0027b\u0027)\n\nThat way it\u0027s more explicity.","commit_id":"8f810929588b72f9541a760fc6ad0a8eddf78e88"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"11670fce39af0a7913e60b2e8c2377faf1f1f82b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if extension.startswith(\u0027b\u0027):"},{"line_number":72,"context_line":"            return base, extension.split(\u0027.\u0027)[0]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    return base, None"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # print version_info.version_string()"},{"line_number":77,"context_line":"    # version_list \u003d version_info.release_string().split(\u0027.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_373c00bf","line":74,"updated":"2014-07-28 06:39:46.000000000","message":"So, from this function, the gitsha wouldn\u0027t be returned?","commit_id":"8f810929588b72f9541a760fc6ad0a8eddf78e88"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"b02d3683a26afcbd81733337e1f3399f7c56f132","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if extension.startswith(\u0027b\u0027):"},{"line_number":72,"context_line":"            return base, extension.split(\u0027.\u0027)[0]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    return base, None"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # print version_info.version_string()"},{"line_number":77,"context_line":"    # version_list \u003d version_info.release_string().split(\u0027.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_f88342a6","line":74,"in_reply_to":"baada198_373c00bf","updated":"2014-07-28 17:54:52.000000000","message":"No, because PBR will supply that for us. I\u0027ll beef up the docstring in addition to fixing your other concerns.","commit_id":"8f810929588b72f9541a760fc6ad0a8eddf78e88"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"11670fce39af0a7913e60b2e8c2377faf1f1f82b","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    return base, None"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # print version_info.version_string()"},{"line_number":77,"context_line":"    # version_list \u003d version_info.release_string().split(\u0027.\u0027)"},{"line_number":78,"context_line":"    # print version_list"},{"line_number":79,"context_line":"    # return \u0027.\u0027.join(version_list[:2]), \u0027.\u0027.join(version_list[2:])"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_d7058410","line":76,"updated":"2014-07-28 06:39:46.000000000","message":"please don\u0027t leave commented code.","commit_id":"8f810929588b72f9541a760fc6ad0a8eddf78e88"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"11670fce39af0a7913e60b2e8c2377faf1f1f82b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                    file_new.write(line)"},{"line_number":117,"context_line":"        is_success \u003d True"},{"line_number":118,"context_line":"    finally:"},{"line_number":119,"context_line":"        if is_success:"},{"line_number":120,"context_line":"            file_new.close()"},{"line_number":121,"context_line":"            os.rename(temp_name, VERSIONFILE)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_7742f83b","line":119,"updated":"2014-07-28 06:39:46.000000000","message":"The is_success flag could be replaced with an else statement.","commit_id":"8f810929588b72f9541a760fc6ad0a8eddf78e88"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"ace193bd4794c9429d8e2d1b2d6d4a636c5e17b9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    try:"},{"line_number":73,"context_line":"        with open(VERSIONFILE, \u0027r\u0027) as file_old:"},{"line_number":74,"context_line":"            for line in file_old:"},{"line_number":75,"context_line":"                if line.startswith(\u0027name \u003d barbican\u0027):"},{"line_number":76,"context_line":"                    file_new.write(line)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"                    # Add a \u0027version \u003d\u0027 line to override the version info."}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_7ac4310e","line":75,"updated":"2014-07-30 14:39:51.000000000","message":"as long as editing this file will be done programmatically then this should be fine.  Otherwise a regex to allow optional spaces around the \u003d would be better so that someone could have name\u003dbarbican in setup.cfg and it would match.","commit_id":"77af82462ac58efaa8fa652695428d4cff98636d"},{"author":{"_account_id":994,"name":"Arvind Tiwari","email":"arvindt7@gmail.com","username":"arvind-tiwari"},"change_message_id":"0cfbfa41b2caec82b174583910fd9d4ed999d7cd","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        file_new.close()"},{"line_number":96,"context_line":"        os.rename(temp_name, VERSIONFILE)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _get_pbr_version():"},{"line_number":100,"context_line":"    \"\"\"Returns the version stamp from PBR."}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_8453c014","line":97,"updated":"2014-07-28 19:04:50.000000000","message":"John, instead of this can we do template approach?\ne.g. have a setup.cfg.template file with line \"version \u003d $version\"\nThis was we can just create new setup.cfg file just by substituting the version string generate by \"_get_pbr_version()\".\n\nThis was we can save the entire reading and coping the files, which is kind of messy.\n\nthoughts?","commit_id":"77af82462ac58efaa8fa652695428d4cff98636d"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"139a87acecca79e5c4ab5f648aa955e9612c76a8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        file_new.close()"},{"line_number":96,"context_line":"        os.rename(temp_name, VERSIONFILE)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _get_pbr_version():"},{"line_number":100,"context_line":"    \"\"\"Returns the version stamp from PBR."}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_5266c629","line":97,"in_reply_to":"baada198_8453c014","updated":"2014-07-28 20:08:47.000000000","message":"Well, part of the problem is that for the PBR version to retrieved properly, the \u0027version \u003d\u0027 line can\u0027t be there, because if it was there it would override the version PBR returns. I think inject that timestamp into the version info and \u0027override\u0027 that in setup.cfg. This way the sdist process uses the right version stamp.  So in the raw setup.cfg file, that version line has to be removed.","commit_id":"77af82462ac58efaa8fa652695428d4cff98636d"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"caf1ef784600a49c078dfdd6ea5f41d5d55bf911","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \"\"\"Update the version information in setup.cfg per the provided patch."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    PBR will generate a version stamp per the docstring of _get_pbr_version()"},{"line_number":62,"context_line":"    above, which then stamps the version on source tarballs used for"},{"line_number":63,"context_line":"    packaging. This version stamp is not packaging friendly as it is not"},{"line_number":64,"context_line":"    monotonically increasing alphabetically. If a \u0027version\u0027 attribute is added"},{"line_number":65,"context_line":"    to setup.cfg, PBR will override the output major, minor and build"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_b8e24700","line":62,"updated":"2014-08-07 04:51:29.000000000","message":"s/above/below","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"dec72346e4f36adfd671122305c98c393bf09dfa","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \"\"\"Update the version information in setup.cfg per the provided patch."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    PBR will generate a version stamp per the docstring of _get_pbr_version()"},{"line_number":62,"context_line":"    above, which then stamps the version on source tarballs used for"},{"line_number":63,"context_line":"    packaging. This version stamp is not packaging friendly as it is not"},{"line_number":64,"context_line":"    monotonically increasing alphabetically. If a \u0027version\u0027 attribute is added"},{"line_number":65,"context_line":"    to setup.cfg, PBR will override the output major, minor and build"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_e39212fb","line":62,"in_reply_to":"baada198_b8e24700","updated":"2014-08-08 17:04:03.000000000","message":"Sounds good. I\u0027ll upload another patch after more commentary on the comments below though....","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"b0e4fd1abcbda3c413025e4cf0a54eafb76c2d68","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    be created."},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":"    temp_name \u003d VERSIONFILE + \u0027~\u0027"},{"line_number":71,"context_line":"    file_new \u003d open(temp_name, \u0027w\u0027)"},{"line_number":72,"context_line":"    try:"},{"line_number":73,"context_line":"        with open(VERSIONFILE, \u0027r\u0027) as file_old:"},{"line_number":74,"context_line":"            for line in file_old:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_7ea16cf6","line":71,"updated":"2014-08-07 13:06:03.000000000","message":"should this be within the try?  for example, what happens if we run out of handles or the volume is full?","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"dec72346e4f36adfd671122305c98c393bf09dfa","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    be created."},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":"    temp_name \u003d VERSIONFILE + \u0027~\u0027"},{"line_number":71,"context_line":"    file_new \u003d open(temp_name, \u0027w\u0027)"},{"line_number":72,"context_line":"    try:"},{"line_number":73,"context_line":"        with open(VERSIONFILE, \u0027r\u0027) as file_old:"},{"line_number":74,"context_line":"            for line in file_old:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_e301326e","line":71,"in_reply_to":"baada198_7ea16cf6","updated":"2014-08-08 17:04:03.000000000","message":"It would be ok for this to raise such exceptions...no harm no foul, as this is a script to deal with versions in a build process, and if this fails here that would terminate the build process as expected. The main purpose of the try/except/else below is to close resources that successfully were opened.","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"b0e4fd1abcbda3c413025e4cf0a54eafb76c2d68","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                    else:"},{"line_number":85,"context_line":"                        file_new.write(\u0027version \u003d {0}.{1}\\n\u0027.format(base, patch))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"                elif line.startswith(\u0027version\u0027):"},{"line_number":88,"context_line":"                    raise ValueError(\"The file \u0027setup.cfg\u0027 must not already \""},{"line_number":89,"context_line":"                                     \"contain a \u0027version \u003d\u0027 line.\")"},{"line_number":90,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_5e04a8c4","line":87,"updated":"2014-08-07 13:06:03.000000000","message":"is it possible that the file could ever contain some other key such as version_something_else?  Don\u0027t want to get to rewriting java.util.property here :-) but just want to be sure we think about these things.","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"dec72346e4f36adfd671122305c98c393bf09dfa","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                    else:"},{"line_number":85,"context_line":"                        file_new.write(\u0027version \u003d {0}.{1}\\n\u0027.format(base, patch))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"                elif line.startswith(\u0027version\u0027):"},{"line_number":88,"context_line":"                    raise ValueError(\"The file \u0027setup.cfg\u0027 must not already \""},{"line_number":89,"context_line":"                                     \"contain a \u0027version \u003d\u0027 line.\")"},{"line_number":90,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_633c4231","line":87,"in_reply_to":"baada198_5e04a8c4","updated":"2014-08-08 17:04:03.000000000","message":"Well, only \u0027version\u0027 means something to pbr, and that is what generates the version we care about here. Adding other \u0027yyy_version_xxx\u0027 variants is OK with this script as pbr doesn\u0027t care about them, and so this script can happily ignore them :)","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"caf1ef784600a49c078dfdd6ea5f41d5d55bf911","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                else:"},{"line_number":91,"context_line":"                    file_new.write(line)"},{"line_number":92,"context_line":"    except:"},{"line_number":93,"context_line":"        raise"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        file_new.close()"},{"line_number":96,"context_line":"        os.rename(temp_name, VERSIONFILE)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_f89aff6d","line":93,"updated":"2014-08-07 04:51:29.000000000","message":"Why would we catch the exception just to reraise?","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"b0e4fd1abcbda3c413025e4cf0a54eafb76c2d68","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                else:"},{"line_number":91,"context_line":"                    file_new.write(line)"},{"line_number":92,"context_line":"    except:"},{"line_number":93,"context_line":"        raise"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        file_new.close()"},{"line_number":96,"context_line":"        os.rename(temp_name, VERSIONFILE)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_be6304dd","line":93,"updated":"2014-08-07 13:06:03.000000000","message":"maybe put out a msg or raise an exception with a msg here","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"dec72346e4f36adfd671122305c98c393bf09dfa","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                else:"},{"line_number":91,"context_line":"                    file_new.write(line)"},{"line_number":92,"context_line":"    except:"},{"line_number":93,"context_line":"        raise"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        file_new.close()"},{"line_number":96,"context_line":"        os.rename(temp_name, VERSIONFILE)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_430bbe7b","line":93,"in_reply_to":"baada198_be6304dd","updated":"2014-08-08 17:04:03.000000000","message":"To use the \u0027else:\u0027 form for try/except, there must be an \u0027except:\u0027 section. I\u0027m not sure it makes much sense to wrap the root cause exception with another one, esp. in a script like this?","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"6dd7b9428c6ee4470f56c96cc67cb02074e5f3fb","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    except:"},{"line_number":93,"context_line":"        raise"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        file_new.close()"},{"line_number":96,"context_line":"        os.rename(temp_name, VERSIONFILE)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_b57033db","line":95,"updated":"2014-08-10 17:18:57.000000000","message":"shouldn\u0027t this close be in a \"finally\" clause ?\n\nIMO there is no need for a try/except/else block at all. What do you think about the following ?\n\nAdd the following line after #73:\n\nwith open(temp_name, \u0027w\u0027) as file_new:\n\nthen, #71 could be removed\n\nAgreed, the second \"with\" would add to one more level of indentation, but would be balanced by removing the \"try\" :)","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"d5e58ef791540f0f0071debf1aa891841f879e0c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    except:"},{"line_number":93,"context_line":"        raise"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        file_new.close()"},{"line_number":96,"context_line":"        os.rename(temp_name, VERSIONFILE)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_22ada8ea","line":95,"in_reply_to":"baada198_b57033db","updated":"2014-08-11 17:37:04.000000000","message":"I like that, putting up change shortly...","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"018b682ec3a3f10eeb8906f2a87b28b279218fdb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    be created."},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":"    temp_name \u003d VERSIONFILE + \u0027~\u0027"},{"line_number":71,"context_line":"    with open(VERSIONFILE, \u0027r\u0027) as file_old:"},{"line_number":72,"context_line":"        with open(temp_name, \u0027w\u0027) as file_new:"},{"line_number":73,"context_line":"            for line in file_old:"},{"line_number":74,"context_line":"                if line.startswith(\u0027[metadata]\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_82daf4e3","line":71,"updated":"2014-08-11 17:54:06.000000000","message":"looks great!","commit_id":"07be222b3728565ddcbe8b8d1615885aed81fc14"}],"setup.cfg":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"b0e4fd1abcbda3c413025e4cf0a54eafb76c2d68","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[metadata]"},{"line_number":2,"context_line":"name \u003d barbican"},{"line_number":3,"context_line":"description \u003d Service for storing sensitive client information for OpenStack"},{"line_number":4,"context_line":"description-file \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"baada198_fe8bbc66","line":1,"updated":"2014-08-07 13:06:03.000000000","message":"is thie file ever supposed to be edited by hand?  If not a comment stating that its machine generated might be a good idea.  For example if someone accidently indents [metadata] by a space then its broken.","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"640e85af3ba1d77a1a3f73d7fd4ee61d2d8dd0cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[metadata]"},{"line_number":2,"context_line":"name \u003d barbican"},{"line_number":3,"context_line":"description \u003d Service for storing sensitive client information for OpenStack"},{"line_number":4,"context_line":"description-file \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"baada198_cefc550f","line":1,"in_reply_to":"baada198_8376b63d","updated":"2014-08-08 17:06:41.000000000","message":"...I\u0027d also add that if folks are modifying group sections this way, and the version bump script crashes, that is ok as we would notice that on the Jenkins build process as a broken job, and we would then investigate that and then thump whoever modified this file that way. :)","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"dec72346e4f36adfd671122305c98c393bf09dfa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[metadata]"},{"line_number":2,"context_line":"name \u003d barbican"},{"line_number":3,"context_line":"description \u003d Service for storing sensitive client information for OpenStack"},{"line_number":4,"context_line":"description-file \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"baada198_8376b63d","line":1,"in_reply_to":"baada198_fe8bbc66","updated":"2014-08-08 17:04:03.000000000","message":"I think adding spaces in front of any config groups will break general parsing, and is in general bad form anyway. I\u0027d -1 any attempts to do so in this file or the barbican-xxxx.conf files for example.","commit_id":"201ab38f991ac342ba3cfca4751d75086f481271"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"018b682ec3a3f10eeb8906f2a87b28b279218fdb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[metadata]"},{"line_number":2,"context_line":"version \u003d 2014.2.1407778462.b2"},{"line_number":3,"context_line":"name \u003d barbican"},{"line_number":4,"context_line":"description \u003d Service for storing sensitive client information for OpenStack"},{"line_number":5,"context_line":"description-file \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"baada198_e2cbb01a","line":2,"updated":"2014-08-11 17:54:06.000000000","message":"may be this line got accidentally added in this patch ?\n\nas this conflicts with the lines that parse this file:\n\nraise ValueError(\"The file \u0027setup.cfg\u0027 must not already \"\t\n                                     \"contain a \u0027version \u003d\u0027 line.\")","commit_id":"07be222b3728565ddcbe8b8d1615885aed81fc14"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"e805803ea94fd6c2ba6651ea0f9ffc1204663705","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[metadata]"},{"line_number":2,"context_line":"version \u003d 2014.2.1407778462.b2"},{"line_number":3,"context_line":"name \u003d barbican"},{"line_number":4,"context_line":"description \u003d Service for storing sensitive client information for OpenStack"},{"line_number":5,"context_line":"description-file \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"baada198_6814e1e9","line":2,"in_reply_to":"baada198_e2cbb01a","updated":"2014-08-11 18:35:42.000000000","message":"Ugh! Thanks for that....will correct.","commit_id":"07be222b3728565ddcbe8b8d1615885aed81fc14"}]}