)]}'
{"barbican/model/models.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"f57f13482a83734f12cfca64842636c95268f94c","unresolved":false,"context_lines":[{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def _do_extra_dict_fields(self):"},{"line_number":469,"context_line":"        \"\"\"Sub-class hook method: return dict of fields.\"\"\""},{"line_number":470,"context_line":"        if not self.meta:"},{"line_number":471,"context_line":"            expiration \u003d ("},{"line_number":472,"context_line":"                self.secret_expiration.isoformat()"},{"line_number":473,"context_line":"                if self.secret_expiration else self.secret_expiration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_ccc43894","line":470,"updated":"2014-08-29 02:06:37.000000000","message":"the logic here is different - is that intentional?  Previous version returned secret, type, meta and order_id regardless of self.meta where the new version returns different fields depending on self.meta being None or not.","commit_id":"f9cc0e4f418dc5bd3e950843592e4c97cbaa2fc0"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"cc2d175207533788d673f5778ea7e2d1ec6855f8","unresolved":false,"context_lines":[{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def _do_extra_dict_fields(self):"},{"line_number":469,"context_line":"        \"\"\"Sub-class hook method: return dict of fields.\"\"\""},{"line_number":470,"context_line":"        if not self.meta:"},{"line_number":471,"context_line":"            expiration \u003d ("},{"line_number":472,"context_line":"                self.secret_expiration.isoformat()"},{"line_number":473,"context_line":"                if self.secret_expiration else self.secret_expiration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_4f42b9ab","line":470,"in_reply_to":"1abeadc6_aa7fd2a9","updated":"2014-08-29 15:19:22.000000000","message":"Ah, dang rebases.  Thx!","commit_id":"f9cc0e4f418dc5bd3e950843592e4c97cbaa2fc0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"9733d13dd3c0641ab1174cfc32f722e0d07e17b7","unresolved":false,"context_lines":[{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def _do_extra_dict_fields(self):"},{"line_number":469,"context_line":"        \"\"\"Sub-class hook method: return dict of fields.\"\"\""},{"line_number":470,"context_line":"        if not self.meta:"},{"line_number":471,"context_line":"            expiration \u003d ("},{"line_number":472,"context_line":"                self.secret_expiration.isoformat()"},{"line_number":473,"context_line":"                if self.secret_expiration else self.secret_expiration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_aa7fd2a9","line":470,"in_reply_to":"1abeadc6_ccc43894","updated":"2014-08-29 06:42:12.000000000","message":"I believe that was just due to the rebase -- if you compare to base instead of patchset 1, there was no change here.","commit_id":"f9cc0e4f418dc5bd3e950843592e4c97cbaa2fc0"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"f57f13482a83734f12cfca64842636c95268f94c","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                    \u0027expiration\u0027: expiration,"},{"line_number":481,"context_line":"                    \u0027payload_content_type\u0027: self.secret_payload_content_type"},{"line_number":482,"context_line":"                },"},{"line_number":483,"context_line":"                \u0027order_id\u0027: self.id"},{"line_number":484,"context_line":"            }"},{"line_number":485,"context_line":"        else:"},{"line_number":486,"context_line":"            ret \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_4c0668cf","line":483,"updated":"2014-08-29 02:06:37.000000000","message":"this is set regardless of self.meta so maybe move out to line 490.5 ?","commit_id":"f9cc0e4f418dc5bd3e950843592e4c97cbaa2fc0"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"7bc1f64ae125f4a289a4d750eac130fff7524c76","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                    \u0027expiration\u0027: expiration,"},{"line_number":481,"context_line":"                    \u0027payload_content_type\u0027: self.secret_payload_content_type"},{"line_number":482,"context_line":"                },"},{"line_number":483,"context_line":"                \u0027order_id\u0027: self.id"},{"line_number":484,"context_line":"            }"},{"line_number":485,"context_line":"        else:"},{"line_number":486,"context_line":"            ret \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_326a4281","line":483,"in_reply_to":"1abeadc6_4c0668cf","updated":"2014-08-29 15:33:50.000000000","message":"This can be fixed in a later CR.","commit_id":"f9cc0e4f418dc5bd3e950843592e4c97cbaa2fc0"}]}
