)]}'
{".coveragerc":[{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"f8ab1ae9d4379da47c468ad8a4458c5f02356e25","unresolved":false,"context_lines":[{"line_number":4,"context_line":"       functionaltests/*,contrib/*,"},{"line_number":5,"context_line":"       barbican/model/migration/alembic_migrations/versions/*,"},{"line_number":6,"context_line":"       barbican/plugin/dogtag.py, barbican/plugin/kmip_secret_store.py,"},{"line_number":7,"context_line":"       barbican/plugin/symantec.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[report]"},{"line_number":10,"context_line":"ignore_errors \u003d True"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"3a961159_39b9e1cb","line":7,"updated":"2014-12-17 17:55:30.000000000","message":"Why are we omitting coverage on these? I\u0027m not sure I feel very comfortable about this. We discussed in Paris that if we couldn\u0027t get the coverage up on the plugins when we would move them out.","commit_id":"0a3552e5e74ba726ee7a124bd6a6ce88326d8c06"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"4d711d3d09b4d75c02bd3db3cd8338f7044013c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"       functionaltests/*,contrib/*,"},{"line_number":5,"context_line":"       barbican/model/migration/alembic_migrations/versions/*,"},{"line_number":6,"context_line":"       barbican/plugin/dogtag.py, barbican/plugin/kmip_secret_store.py,"},{"line_number":7,"context_line":"       barbican/plugin/symantec.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[report]"},{"line_number":10,"context_line":"ignore_errors \u003d True"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"3a961159_df80bd8d","line":7,"in_reply_to":"3a961159_39b9e1cb","updated":"2014-12-17 21:08:23.000000000","message":"We discussed having a marketplace document to track plugins, internal or external to the repository. I don\u0027t recall discussing the removal of plugins however. Until we do remove them, we need to remove from coverage modules that have non-global-requirements dependencies as they can not be unit tested via the gate jobs.","commit_id":"0a3552e5e74ba726ee7a124bd6a6ce88326d8c06"}],"barbican/model/models.py":[{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"f8ab1ae9d4379da47c468ad8a4458c5f02356e25","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        super(ContainerConsumerMetadatum, self).__init__()"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        if container_id:"},{"line_number":646,"context_line":"            self.container_id \u003d container_id"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        if parsed_request:"},{"line_number":649,"context_line":"            self.name \u003d parsed_request.get(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a961159_590ced94","line":646,"updated":"2014-12-17 17:55:30.000000000","message":"Shouldn\u0027t this always be set? We use self.container_id on line 651. If it\u0027s not defined it\u0027ll raise an exception; probably not ideal for what is suppose to be a optional param.","commit_id":"0a3552e5e74ba726ee7a124bd6a6ce88326d8c06"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"4d711d3d09b4d75c02bd3db3cd8338f7044013c9","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        super(ContainerConsumerMetadatum, self).__init__()"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        if container_id:"},{"line_number":646,"context_line":"            self.container_id \u003d container_id"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        if parsed_request:"},{"line_number":649,"context_line":"            self.name \u003d parsed_request.get(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a961159_4a096d2b","line":646,"in_reply_to":"3a961159_590ced94","updated":"2014-12-17 21:08:23.000000000","message":"Good point, though passing None as container_id in the old code would have the same result. Ugh...looking at this class, it really needs to be immutable to make sure that hash value doesn\u0027t change :\\ Ok, for this CR, I\u0027ll revert back to the way it was, but we really need to revisit making this an immutable class.","commit_id":"0a3552e5e74ba726ee7a124bd6a6ce88326d8c06"}],"barbican/tests/model/repositories/test_repositories_secrets.py":[{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"f8ab1ae9d4379da47c468ad8a4458c5f02356e25","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        super(WhenTestingSecretRepository, self).setUp()"},{"line_number":23,"context_line":"        self.repo \u003d repositories.SecretRepo()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_get_by_create_date(self):"},{"line_number":26,"context_line":"        session \u003d self.repo.get_session()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        secret \u003d self.repo.create_from(models.Secret(), session\u003dsession)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a961159_79a2894c","line":25,"updated":"2014-12-17 17:55:30.000000000","message":"Just a suggestion, but you might be able to make this a little cleaner by switching to parameterized tests for a number of these.","commit_id":"0a3552e5e74ba726ee7a124bd6a6ce88326d8c06"}],"barbican/tests/tasks/test_resources.py":[{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"f8ab1ae9d4379da47c468ad8a4458c5f02356e25","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                             \u0027site administrator.\u0027), self.order.error_reason)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"class WhenBeginningAsymmetricTypeOrder(BaseOrderTestCase):"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def setUp(self):"},{"line_number":230,"context_line":"        super(WhenBeginningAsymmetricTypeOrder, self).setUp()"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a961159_593b0deb","line":227,"updated":"2014-12-17 17:55:30.000000000","message":"Forgive me blindness here, but where did all of the tests go that were related to this class?","commit_id":"0a3552e5e74ba726ee7a124bd6a6ce88326d8c06"}]}