)]}'
{"barbican/plugin/resources.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"6ee7fce551e9d0e0d6444cef342a86a1233c5eb4","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        # Locate a suitable plugin to delete the secret from."},{"line_number":269,"context_line":"        plugin_manager \u003d secret_store.SecretStorePluginManager()"},{"line_number":270,"context_line":"        delete_plugin \u003d plugin_manager.get_plugin_retrieve_delete("},{"line_number":271,"context_line":"            secret_metadata.get(\u0027plugin_name\u0027))"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # Delete the secret from plugin storage."},{"line_number":274,"context_line":"        delete_plugin.delete_secret(secret_metadata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e51c2ec4","line":271,"updated":"2014-12-16 21:48:14.000000000","message":"is it possible to return None as the delete_plugin?  If so then line 274 below will go boom.","commit_id":"a91986aa7a524e68fb7b1899fb0fe4814562c216"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a3922f2943018c15c95a502700cee60ab4846cf2","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        # Locate a suitable plugin to delete the secret from."},{"line_number":269,"context_line":"        plugin_manager \u003d secret_store.SecretStorePluginManager()"},{"line_number":270,"context_line":"        delete_plugin \u003d plugin_manager.get_plugin_retrieve_delete("},{"line_number":271,"context_line":"            secret_metadata.get(\u0027plugin_name\u0027))"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # Delete the secret from plugin storage."},{"line_number":274,"context_line":"        delete_plugin.delete_secret(secret_metadata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_2817eda4","line":271,"in_reply_to":"3a961159_082cf149","updated":"2014-12-16 22:15:49.000000000","message":"Actually, the current way stevedore works is that if the plugin fails to load, it will not issue an exception (unless a callback for this is specified), so, what it will do is that it will just not append that plugin into the extensions list.","commit_id":"a91986aa7a524e68fb7b1899fb0fe4814562c216"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"32e22120a9be0d1bd14377e0e867ffb5620cd2db","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        # Locate a suitable plugin to delete the secret from."},{"line_number":269,"context_line":"        plugin_manager \u003d secret_store.SecretStorePluginManager()"},{"line_number":270,"context_line":"        delete_plugin \u003d plugin_manager.get_plugin_retrieve_delete("},{"line_number":271,"context_line":"            secret_metadata.get(\u0027plugin_name\u0027))"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # Delete the secret from plugin storage."},{"line_number":274,"context_line":"        delete_plugin.delete_secret(secret_metadata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_3644aa73","line":271,"in_reply_to":"3a961159_2817eda4","updated":"2014-12-16 23:49:21.000000000","message":"I believe that\u0027s the case Juan...I would expect plugin_name to be specified here.","commit_id":"a91986aa7a524e68fb7b1899fb0fe4814562c216"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"baacd94a49f6381938d310697f7df69d8e6f8d66","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        # Locate a suitable plugin to delete the secret from."},{"line_number":269,"context_line":"        plugin_manager \u003d secret_store.SecretStorePluginManager()"},{"line_number":270,"context_line":"        delete_plugin \u003d plugin_manager.get_plugin_retrieve_delete("},{"line_number":271,"context_line":"            secret_metadata.get(\u0027plugin_name\u0027))"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # Delete the secret from plugin storage."},{"line_number":274,"context_line":"        delete_plugin.delete_secret(secret_metadata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_082cf149","line":271,"in_reply_to":"3a961159_e51c2ec4","updated":"2014-12-16 22:07:54.000000000","message":"Not that I know of. at least on the barbican side, if there is not a valid plugin, or something wrong with the extensions it would raise an exception. The stevedore part (whether stevedore can actually return an invalid extension) is not very clear to me though.","commit_id":"a91986aa7a524e68fb7b1899fb0fe4814562c216"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"a61912a1a9e2f1ca9a4fc7fe1af7f6d3083c60c1","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            secret_metadata.get(\u0027plugin_name\u0027))"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # Delete the secret from plugin storage."},{"line_number":274,"context_line":"        delete_plugin.delete_secret(secret_metadata)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Delete the secret from data model."},{"line_number":277,"context_line":"    repos.secret_repo.delete_entity_by_id(entity_id\u003dsecret_model.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_1d532a3a","line":274,"updated":"2014-12-17 22:24:07.000000000","message":"The diff cover job doesn\u0027t think that these lines are getting covered. Could we get these added lines covered with tests? I would hate to regress on this issue. Thanks!","commit_id":"a91986aa7a524e68fb7b1899fb0fe4814562c216"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"6ee7fce551e9d0e0d6444cef342a86a1233c5eb4","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        delete_plugin.delete_secret(secret_metadata)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Delete the secret from data model."},{"line_number":277,"context_line":"    repos.secret_repo.delete_entity_by_id(entity_id\u003dsecret_model.id,"},{"line_number":278,"context_line":"                                          keystone_id\u003dproject_id)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_25655645","line":277,"updated":"2014-12-16 21:48:14.000000000","message":"should this be within the \"if secret_metadata\" line 267?","commit_id":"a91986aa7a524e68fb7b1899fb0fe4814562c216"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"baacd94a49f6381938d310697f7df69d8e6f8d66","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        delete_plugin.delete_secret(secret_metadata)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Delete the secret from data model."},{"line_number":277,"context_line":"    repos.secret_repo.delete_entity_by_id(entity_id\u003dsecret_model.id,"},{"line_number":278,"context_line":"                                          keystone_id\u003dproject_id)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c8c74963","line":277,"in_reply_to":"3a961159_25655645","updated":"2014-12-16 22:07:54.000000000","message":"I didn\u0027t add it here because of the bug description, which describes the possibility of the secret existing without an entry in the metadata table. Thus, even if there is no metadata, which is what the if above is for, we still delete the secret from the database.","commit_id":"a91986aa7a524e68fb7b1899fb0fe4814562c216"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"32e22120a9be0d1bd14377e0e867ffb5620cd2db","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        delete_plugin.delete_secret(secret_metadata)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Delete the secret from data model."},{"line_number":277,"context_line":"    repos.secret_repo.delete_entity_by_id(entity_id\u003dsecret_model.id,"},{"line_number":278,"context_line":"                                          keystone_id\u003dproject_id)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_56177651","line":277,"in_reply_to":"3a961159_8b945b45","updated":"2014-12-16 23:49:21.000000000","message":"The secret metadata here is only for plugins to use...and those are only involved if there is an actual secret to encrypt/store. The secret entity on the other hand is always created, so must be deleted here.","commit_id":"a91986aa7a524e68fb7b1899fb0fe4814562c216"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"30bf493fcdbdbcee0a06b5a60a466b165a410414","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        delete_plugin.delete_secret(secret_metadata)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Delete the secret from data model."},{"line_number":277,"context_line":"    repos.secret_repo.delete_entity_by_id(entity_id\u003dsecret_model.id,"},{"line_number":278,"context_line":"                                          keystone_id\u003dproject_id)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_8b945b45","line":277,"in_reply_to":"3a961159_c8c74963","updated":"2014-12-16 22:38:16.000000000","message":"Anyway, this is actually possible, as every attribute from the secret is indeed optional. If a secret without any data whatsoever is created, no entry in the metadata table will be written. As far as I\u0027ve seen.","commit_id":"a91986aa7a524e68fb7b1899fb0fe4814562c216"}]}
