)]}'
{"functionaltests/api/v1/behaviors/base_behaviors.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"3dc3f223c5bce396f1c8484aadbc2cb78dcb4972","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            json_data \u003d response.json()"},{"line_number":33,"context_line":"        except ValueError, e:"},{"line_number":34,"context_line":"            self.LOG.error(\"Error converting response to JSON: %s\", e.message)"},{"line_number":35,"context_line":"            self.LOG.error(\"Response Content: %s\", response.content)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_ca740400","line":33,"updated":"2015-01-07 21:29:43.000000000","message":"You might want to add self.LOG.exception() here, to make sure the root cause stack is output.","commit_id":"80cf517ad6d56cbbd05a255585ff37c92a6fe672"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"a8d238cfd6f0185833e9f4269d2879d0d76940f5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        except ValueError as e:"},{"line_number":34,"context_line":"            self.LOG.error(\"Error converting response to JSON: %s\", e.message)"},{"line_number":35,"context_line":"            self.LOG.error(\"Response Content: %s\", response.content)"},{"line_number":36,"context_line":"            self.LOG.exception(e)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        return json_data"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_86fe7404","line":36,"updated":"2015-01-07 23:28:19.000000000","message":"This is good, but consider moving this up to right after #33. Why you say? Because I have seen where the stack logging behavior does not work if other logging lines (or even non-logging lines) are run before the .exception call is run. I\u0027d hate to lose this info given how sporadically this error occurs. :\\","commit_id":"2e2e9077ba4ea8a9debabd3914194255d168d7b4"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"1b6032c8ed9de31366a40500dd6df4f7a2eea04f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        except ValueError as e:"},{"line_number":34,"context_line":"            self.LOG.error(\"Error converting response to JSON: %s\", e.message)"},{"line_number":35,"context_line":"            self.LOG.error(\"Response Content: %s\", response.content)"},{"line_number":36,"context_line":"            self.LOG.exception(e)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        return json_data"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_5f899824","line":36,"in_reply_to":"3a961159_86fe7404","updated":"2015-01-08 16:49:44.000000000","message":"As we have two +2s already and we need to get something in, I tossed up a dependent CR to address your comment: https://review.openstack.org/#/c/145835/","commit_id":"2e2e9077ba4ea8a9debabd3914194255d168d7b4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"0625f7f29acf80e22b76ff2a427063bbe31e3b61","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            self.LOG.exception(e)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        return json_data"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_id_from_href(self, href):"},{"line_number":41,"context_line":"        \"\"\"Returns the id from reference."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_7f649448","line":39,"updated":"2015-01-08 16:58:24.000000000","message":"Does this function need to be this verbose?\nWe could do:\n\n    def get_json(self, response):\n        try:\n            return response.json()\n        except ValueError as e:\n            ....","commit_id":"2e2e9077ba4ea8a9debabd3914194255d168d7b4"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"2d50538b4200bf42334ddf535a076eb501b28f91","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            self.LOG.exception(e)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        return json_data"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_id_from_href(self, href):"},{"line_number":41,"context_line":"        \"\"\"Returns the id from reference."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_c2092f2c","line":39,"in_reply_to":"3a961159_7f649448","updated":"2015-01-08 17:08:29.000000000","message":"If I do that, we\u0027ll have two return paths for a single flow. With that in mind, I think it makes sense to have a single return path with a default.","commit_id":"2e2e9077ba4ea8a9debabd3914194255d168d7b4"}]}
