)]}'
{"barbican/plugin/dogtag.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"b5ad0c8ed208d2dc3eb961b3277402d86ed7ac39","unresolved":false,"context_lines":[{"line_number":555,"context_line":"                cm.CertificateStatus.CLIENT_DATA_ISSUE_SEEN,"},{"line_number":556,"context_line":"                status_message\u003de.message)"},{"line_number":557,"context_line":"        except pki.PKIException as e:"},{"line_number":558,"context_line":"            raise cm.CertificateGeneralException("},{"line_number":559,"context_line":"                u._(\"Exception thrown by enroll_cert: {message}\").format("},{"line_number":560,"context_line":"                    message\u003de.message))"},{"line_number":561,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_5bbb07e5","line":558,"updated":"2015-01-28 22:08:13.000000000","message":"Could this operation be reattempted in the future, or is it a fatal error? If the latter, then you return a retry ResultDTO, otherwise this exception will mark the order as ERROR and terminate it.","commit_id":"a083f4ee1367c07f71f60af2bf86ef094c6a3dca"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"49bd3cf7dde1288b012a52ea9e3782f412091a6d","unresolved":false,"context_lines":[{"line_number":555,"context_line":"                cm.CertificateStatus.CLIENT_DATA_ISSUE_SEEN,"},{"line_number":556,"context_line":"                status_message\u003de.message)"},{"line_number":557,"context_line":"        except pki.PKIException as e:"},{"line_number":558,"context_line":"            raise cm.CertificateGeneralException("},{"line_number":559,"context_line":"                u._(\"Exception thrown by enroll_cert: {message}\").format("},{"line_number":560,"context_line":"                    message\u003de.message))"},{"line_number":561,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_8b4c2672","line":558,"in_reply_to":"fa81d914_5bbb07e5","updated":"2015-01-29 15:06:45.000000000","message":"We discussed this on IRC.  The exception here is a catch-all exception returned by the server.  Most likely it is a fatal error, which would mean that rethrowing the exception here is the correct behavior.","commit_id":"a083f4ee1367c07f71f60af2bf86ef094c6a3dca"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c88d0681bc5831fabfbdd93ac71bceda8a183373","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        if request_type not in jump_table:"},{"line_number":706,"context_line":"            raise DogtagPluginNotSupportedException("},{"line_number":707,"context_line":"                \"Dogtag plugin does not support %s request type\".format("},{"line_number":708,"context_line":"                    request_type))"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        return jump_table[request_type](order_id, order_meta, plugin_meta)"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_f6849ed5","line":708,"updated":"2015-01-29 19:27:41.000000000","message":"Instead of doing this check, I would just try to access the key and then catch the exception (a bit more pythonic).","commit_id":"a083f4ee1367c07f71f60af2bf86ef094c6a3dca"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c88d0681bc5831fabfbdd93ac71bceda8a183373","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                        \"request_id {request_id}\").format("},{"line_number":825,"context_line":"                            status\u003drequest_status,"},{"line_number":826,"context_line":"                            request_id\u003drequest.request_id)"},{"line_number":827,"context_line":"                )"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        return cm.ResultDTO("},{"line_number":830,"context_line":"            cm.CertificateStatus.CERTIFICATE_GENERATED,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_964a82aa","line":827,"updated":"2015-01-29 19:27:41.000000000","message":"It would be more readable it move this block to its own function.","commit_id":"a083f4ee1367c07f71f60af2bf86ef094c6a3dca"}]}