)]}'
{"barbican/tasks/certificate_resources.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"82a26f4057ff9d08cb293065223a5379b2543d3b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ldap"},{"line_number":17,"context_line":"from OpenSSL import crypto"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from barbican.common import exception as excep"},{"line_number":20,"context_line":"from barbican.common import hrefs"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_f891219b","line":17,"updated":"2015-01-28 21:50:41.000000000","message":"The \u0027crypto\u0027 package might be confusing, as we refer to the HSM plugin stuff in other modules as \u0027crypto\u0027. Hmm, but maybe that is an issue in those other modules? :)  I think this is fine to leave as is.","commit_id":"6a6a486b3ca4c149122ee2b542a3bca16a00bfb7"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"82a26f4057ff9d08cb293065223a5379b2543d3b","unresolved":false,"context_lines":[{"line_number":247,"context_line":"def _generate_csr(order_model, repos):"},{"line_number":248,"context_line":"    \"\"\"Generate a CSR from the public key and add to the order metadata.\"\"\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    container_ref \u003d order_model.meta.get(\u0027container_ref\u0027)"},{"line_number":251,"context_line":"    container_id \u003d container_ref.rsplit(\u0027/\u0027, 1)[1]"},{"line_number":252,"context_line":"    container \u003d repos.container_repo.get(container_id)"},{"line_number":253,"context_line":"    if not container:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_f83cc1c1","line":250,"updated":"2015-01-28 21:50:41.000000000","message":"I had been thinking folks would specify a private key directly (via secret), but I see below that sometimes there is a passphrase...this would just have to be clarified in documentation. Also, I presume we create a new container for the generated certificate...but again good to put in docs someplace. :)","commit_id":"6a6a486b3ca4c149122ee2b542a3bca16a00bfb7"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"82a26f4057ff9d08cb293065223a5379b2543d3b","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    for cs in container.container_secrets:"},{"line_number":258,"context_line":"        if cs.name \u003d\u003d \u0027private_key\u0027:"},{"line_number":259,"context_line":"            private_key \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":260,"context_line":"        elif cs.name \u003d\u003d \u0027private_key_passphrase\u0027:"},{"line_number":261,"context_line":"            passphrase \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if not private_key:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_58006d01","line":260,"updated":"2015-01-28 21:50:41.000000000","message":"elif -\u003e if, I think","commit_id":"6a6a486b3ca4c149122ee2b542a3bca16a00bfb7"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"82a26f4057ff9d08cb293065223a5379b2543d3b","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        pass"},{"line_number":288,"context_line":"    req.sign(pkey, \u0027sha256\u0027)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    order_model.meta[\u0027request\u0027] \u003d crypto.dump_certificate_request("},{"line_number":291,"context_line":"        crypto.FILETYPE_PEM, req)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_98d2e5d0","line":290,"updated":"2015-01-28 21:50:41.000000000","message":"I\u0027m generally a bit leery about attaching things to the order metadata, as they are retrievable by clients when they retrieve an order later. That said, maybe this is a desirable feature, to see that generated CSR when I pull the order info? \nWe do however need to have a barbican metadata concept though, to store components of a certificate container as it is built up. So in the fully auto order we will put in a blueprint for, we will probably create a Container and private key Secret on this Container, and then store this Container id in barbican metadata (assoc to the order). Then when the cert is generated, we add that to the Container. So I guess I\u0027m still thinking it is better to put this CSR in a barbican metadata object. :)","commit_id":"6a6a486b3ca4c149122ee2b542a3bca16a00bfb7"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f5003f8014afa81d45e953dcbecce468f09defe8","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    \"\"\"Generate a CSR from the public key and add to the order metadata.\"\"\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    container_ref \u003d order_model.meta.get(\u0027container_ref\u0027)"},{"line_number":251,"context_line":"    container_id \u003d container_ref.rsplit(\u0027/\u0027, 1)[1]"},{"line_number":252,"context_line":"    container \u003d repos.container_repo.get(container_id)"},{"line_number":253,"context_line":"    if not container:"},{"line_number":254,"context_line":"        raise excep.StoredKeyContainerNotFound(container_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_f4114a5e","line":251,"updated":"2015-02-09 06:59:34.000000000","message":"Well, if you are receiving the order_model already, can\u0027t you get the container_id from there? instead of doing this string manipulation which is not very intuitive to the reader?\n\nsomething such as:\n\ncontainer_id \u003d order_model.container_id ?","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"08e75d7f114f5599a6cae7470056b56ce4af54fe","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    \"\"\"Generate a CSR from the public key and add to the order metadata.\"\"\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    container_ref \u003d order_model.meta.get(\u0027container_ref\u0027)"},{"line_number":251,"context_line":"    container_id \u003d container_ref.rsplit(\u0027/\u0027, 1)[1]"},{"line_number":252,"context_line":"    container \u003d repos.container_repo.get(container_id)"},{"line_number":253,"context_line":"    if not container:"},{"line_number":254,"context_line":"        raise excep.StoredKeyContainerNotFound(container_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_76864b18","line":251,"in_reply_to":"da86d52c_eabb4c0c","updated":"2015-02-13 18:44:03.000000000","message":"ok, I would be alright with a comment or another function.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"8b048628b49ca9de8fbad4f638ac78a369d18264","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    \"\"\"Generate a CSR from the public key and add to the order metadata.\"\"\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    container_ref \u003d order_model.meta.get(\u0027container_ref\u0027)"},{"line_number":251,"context_line":"    container_id \u003d container_ref.rsplit(\u0027/\u0027, 1)[1]"},{"line_number":252,"context_line":"    container \u003d repos.container_repo.get(container_id)"},{"line_number":253,"context_line":"    if not container:"},{"line_number":254,"context_line":"        raise excep.StoredKeyContainerNotFound(container_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_eabb4c0c","line":251,"in_reply_to":"da86d52c_f4114a5e","updated":"2015-02-13 04:47:58.000000000","message":"We tend to pass complete references back and forth, rather than just ids.  After all, thats what is returned when the container is created to begin with.  The client would need to extract the container_id doing a similar string manipulation.\n\nIf folks agree to pass in the order_id instead - we can do that.  Although this might be inconsistent with other inputs.\n\nAlternatively, if the issue is simply that this is confusing code, I can add a comment like:\n\n# extract the container_id as last part of url\n\nOr we can define a new function:\n\nhrefs.href_to_id(container_ref)\n\nsimply does the above.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f5003f8014afa81d45e953dcbecce468f09defe8","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    for cs in container.container_secrets:"},{"line_number":258,"context_line":"        if cs.name \u003d\u003d \u0027private_key\u0027:"},{"line_number":259,"context_line":"            private_key \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":260,"context_line":"        elif cs.name \u003d\u003d \u0027private_key_passphrase\u0027:"},{"line_number":261,"context_line":"            passphrase \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if not private_key:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_7f1c536b","line":260,"updated":"2015-02-09 06:59:34.000000000","message":"uh... shouldn\u0027t this be an if? Thought it would be possible for these two (\u0027private_key\u0027 and \u0027private_key_passphrase\u0027) to be in the structure.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"8b048628b49ca9de8fbad4f638ac78a369d18264","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    for cs in container.container_secrets:"},{"line_number":258,"context_line":"        if cs.name \u003d\u003d \u0027private_key\u0027:"},{"line_number":259,"context_line":"            private_key \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":260,"context_line":"        elif cs.name \u003d\u003d \u0027private_key_passphrase\u0027:"},{"line_number":261,"context_line":"            passphrase \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if not private_key:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_8a59f0fe","line":260,"in_reply_to":"da86d52c_7f1c536b","updated":"2015-02-13 04:47:58.000000000","message":"We\u0027re iterating through the secrets in the structure.  At each pass, the name is one of these.\n\n\"if\" instead of \"elif\" makes the secret go through an unnecessary conditional.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"08e75d7f114f5599a6cae7470056b56ce4af54fe","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    for cs in container.container_secrets:"},{"line_number":258,"context_line":"        if cs.name \u003d\u003d \u0027private_key\u0027:"},{"line_number":259,"context_line":"            private_key \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":260,"context_line":"        elif cs.name \u003d\u003d \u0027private_key_passphrase\u0027:"},{"line_number":261,"context_line":"            passphrase \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if not private_key:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_3674d335","line":260,"in_reply_to":"da86d52c_8a59f0fe","updated":"2015-02-13 18:44:03.000000000","message":"fair enough","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f5003f8014afa81d45e953dcbecce468f09defe8","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        elif cs.name \u003d\u003d \u0027private_key_passphrase\u0027:"},{"line_number":261,"context_line":"            passphrase \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if not private_key:"},{"line_number":264,"context_line":"        raise excep.StoredKeyPrivateKeyNotFound(container_id)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    pkey \u003d crypto.load_privatekey("}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_345da249","line":263,"updated":"2015-02-09 06:59:34.000000000","message":"seems to me that private_key should have been defined just beside passphrase. The absense of \u0027private_key\u0027 in \"container_secrets\" will cause an exception which is probably not expected above (well, it probably is expected, but not the right exception)","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"8b048628b49ca9de8fbad4f638ac78a369d18264","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        elif cs.name \u003d\u003d \u0027private_key_passphrase\u0027:"},{"line_number":261,"context_line":"            passphrase \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if not private_key:"},{"line_number":264,"context_line":"        raise excep.StoredKeyPrivateKeyNotFound(container_id)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    pkey \u003d crypto.load_privatekey("}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_8ab570ee","line":263,"in_reply_to":"da86d52c_345da249","updated":"2015-02-13 04:47:58.000000000","message":"The user defines the container_ref to be passed in.  Conceivably, that container might not contain some needed fields.  That does not make them bad containers - just containers that are not suitable for this operation.\n\nAt some point, we will likely allow users to create other kinds of containers.\n\nWe need to let them know they need a container that includes a private key.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"08e75d7f114f5599a6cae7470056b56ce4af54fe","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        elif cs.name \u003d\u003d \u0027private_key_passphrase\u0027:"},{"line_number":261,"context_line":"            passphrase \u003d repos.secret_repo.get(cs.secret_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    if not private_key:"},{"line_number":264,"context_line":"        raise excep.StoredKeyPrivateKeyNotFound(container_id)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    pkey \u003d crypto.load_privatekey("}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_56bf87aa","line":263,"in_reply_to":"da86d52c_8ab570ee","updated":"2015-02-13 18:44:03.000000000","message":"uh... yeah, but I was talking about the private_key variable definition.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f5003f8014afa81d45e953dcbecce468f09defe8","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        passphrase)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    subject_name \u003d order_model.meta.get(\u0027subject_name\u0027)"},{"line_number":272,"context_line":"    subject_name_dns \u003d ldap.dn.str2dn(subject_name, 0)"},{"line_number":273,"context_line":"    extensions \u003d order_model.meta.get(\u0027extensions\u0027, None)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    req \u003d crypto.X509Req()"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_1ff8b7e4","line":272,"updated":"2015-02-09 06:59:34.000000000","message":"well, the default value for \"flags\" is already 0. Would you mind getting that parameter off? Or if you really want to have it there, at least have it in the more verbose format:\n\nldap.dn.str2dn(subject_name, flags\u003d0)\n\nSo it\u0027s easier to read without needing to go back much to the documentation.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"8b048628b49ca9de8fbad4f638ac78a369d18264","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        passphrase)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    subject_name \u003d order_model.meta.get(\u0027subject_name\u0027)"},{"line_number":272,"context_line":"    subject_name_dns \u003d ldap.dn.str2dn(subject_name, 0)"},{"line_number":273,"context_line":"    extensions \u003d order_model.meta.get(\u0027extensions\u0027, None)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    req \u003d crypto.X509Req()"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_eac50c5c","line":272,"in_reply_to":"da86d52c_1ff8b7e4","updated":"2015-02-13 04:47:58.000000000","message":"I\u0027ll leave it off","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f5003f8014afa81d45e953dcbecce468f09defe8","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    # TODO(alee-3) For now, we store the CSR in the order_meta.  We need"},{"line_number":291,"context_line":"    # to revisit whether this is the right place to store this data as it"},{"line_number":292,"context_line":"    # is not data that was provided by the client.  We may end up storing"},{"line_number":293,"context_line":"    # it in the barbican_metadata structure."},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    order_model.meta[\u0027request\u0027] \u003d crypto.dump_certificate_request("},{"line_number":296,"context_line":"        crypto.FILETYPE_PEM, req)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_5f6eaf97","line":293,"updated":"2015-02-09 06:59:34.000000000","message":"I can live with this for now, but we do need to revisit this later. I would expect there to be a separate foreign key in the database to a proper structure, or something of the sort. Mind adding this as a topic (if it\u0027s not there already) in the etherpad for the mid-cycle?","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"8b048628b49ca9de8fbad4f638ac78a369d18264","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    # TODO(alee-3) For now, we store the CSR in the order_meta.  We need"},{"line_number":291,"context_line":"    # to revisit whether this is the right place to store this data as it"},{"line_number":292,"context_line":"    # is not data that was provided by the client.  We may end up storing"},{"line_number":293,"context_line":"    # it in the barbican_metadata structure."},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    order_model.meta[\u0027request\u0027] \u003d crypto.dump_certificate_request("},{"line_number":296,"context_line":"        crypto.FILETYPE_PEM, req)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_8aac90a0","line":293,"in_reply_to":"da86d52c_5f6eaf97","updated":"2015-02-13 04:47:58.000000000","message":"right - we\u0027ll discuss at the midcycle.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"84f928112071ec6dcfa1c4603d42aedfb8f5208a","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    # TODO(alee-3) For now, we store the CSR in the order_meta.  We need"},{"line_number":291,"context_line":"    # to revisit whether this is the right place to store this data as it"},{"line_number":292,"context_line":"    # is not data that was provided by the client.  We may end up storing"},{"line_number":293,"context_line":"    # it in the barbican_metadata structure."},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    order_model.meta[\u0027request\u0027] \u003d crypto.dump_certificate_request("},{"line_number":296,"context_line":"        crypto.FILETYPE_PEM, req)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_05e22f01","line":293,"in_reply_to":"da86d52c_8aac90a0","updated":"2015-02-13 22:39:47.000000000","message":"Ha, I just added it.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f5003f8014afa81d45e953dcbecce468f09defe8","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    # it in the barbican_metadata structure."},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    order_model.meta[\u0027request\u0027] \u003d crypto.dump_certificate_request("},{"line_number":296,"context_line":"        crypto.FILETYPE_PEM, req)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"def _notify_ca_unavailable(order_model, result):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_1f2b5731","line":296,"updated":"2015-02-09 06:59:34.000000000","message":"As a first glimpse I think this will only be loaded in the object, but will not be persistently stored. Is this the intent? You would need to call:\n\norder_model.save()\n\nin order to persist this.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"8b048628b49ca9de8fbad4f638ac78a369d18264","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    # it in the barbican_metadata structure."},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    order_model.meta[\u0027request\u0027] \u003d crypto.dump_certificate_request("},{"line_number":296,"context_line":"        crypto.FILETYPE_PEM, req)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"def _notify_ca_unavailable(order_model, result):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_2a8ac41a","line":296,"in_reply_to":"da86d52c_1f2b5731","updated":"2015-02-13 04:47:58.000000000","message":"agreed -- will add this.","commit_id":"74c49c3d200d45f55b38fdbbe398e41119a2895f"},{"author":{"_account_id":11970,"name":"Chelsea Winfree","email":"chelsea.winfree@gmail.com","username":"chellygel"},"change_message_id":"0d219e0472fa136abd6ff042332c2ff981fce291","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"def _generate_csr(order_model, repos):"},{"line_number":248,"context_line":"    \"\"\"Generate a CSR from the public key and add to the order metadata.\"\"\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    container_ref \u003d order_model.meta.get(\u0027container_ref\u0027)"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_4884095d","line":248,"updated":"2015-02-16 17:12:01.000000000","message":"I feel like we need to add the params in the docstring with a brief explanation. I know that had been a requirement in the past. Is that still the case?","commit_id":"ab9f4dba4b0d345ecbd05e840a7a964d4defd4a8"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"10ff74d5ba510e2f459d67e62d54ad44ed8260f2","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    pkey \u003d crypto.load_privatekey("},{"line_number":272,"context_line":"        crypto.FILETYPE_PEM,"},{"line_number":273,"context_line":"        private_key,"},{"line_number":274,"context_line":"        passphrase)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    subject_name \u003d order_model.meta.get(\u0027subject_name\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_cb29058b","line":273,"updated":"2015-02-13 22:51:38.000000000","message":"The private_key is a Secret model instance...I\u0027m thinking you really want the payload here?","commit_id":"ab9f4dba4b0d345ecbd05e840a7a964d4defd4a8"},{"author":{"_account_id":11970,"name":"Chelsea Winfree","email":"chelsea.winfree@gmail.com","username":"chellygel"},"change_message_id":"0d219e0472fa136abd6ff042332c2ff981fce291","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        passphrase)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    subject_name \u003d order_model.meta.get(\u0027subject_name\u0027)"},{"line_number":277,"context_line":"    subject_name_dns \u003d ldap.dn.str2dn(subject_name)"},{"line_number":278,"context_line":"    extensions \u003d order_model.meta.get(\u0027extensions\u0027, None)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    req \u003d crypto.X509Req()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_88b601f8","line":277,"updated":"2015-02-16 17:12:01.000000000","message":"for alternate names? curious.","commit_id":"ab9f4dba4b0d345ecbd05e840a7a964d4defd4a8"},{"author":{"_account_id":8004,"name":"Paul Kehrer","email":"paul.l.kehrer@gmail.com","username":"reaperhulk"},"change_message_id":"3c384946e12c89626092f9e7913cf075226271a4","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    subj \u003d req.get_subject()"},{"line_number":282,"context_line":"    for ava in subject_name_dns:"},{"line_number":283,"context_line":"        for key, val, extra in ava:"},{"line_number":284,"context_line":"            setattr(subj, key.upper(), val)"},{"line_number":285,"context_line":"    req.set_pubkey(pkey)"},{"line_number":286,"context_line":"    if extensions:"},{"line_number":287,"context_line":"        # TODO(alee-3) We need code here to parse the encoded extensions and"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_6891fff0","line":284,"updated":"2015-02-13 22:45:50.000000000","message":"This is only safe if there is at most one of each DN attribute. Are we enforcing that when the user supplies the requested subject?","commit_id":"ab9f4dba4b0d345ecbd05e840a7a964d4defd4a8"}]}
