)]}'
{"barbican/api/controllers/secrets.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"68e9437abf132ef7eaf3b5d89a697822ba536693","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            return self._on_get_secret_payload(secret, external_project_id,"},{"line_number":103,"context_line":"                                               **kwargs)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _on_get_secret_metadata(self, secret, **kwargs):"},{"line_number":106,"context_line":"        \"\"\"GET Metadata-only for a secret.\"\"\""},{"line_number":107,"context_line":"        pecan.override_template(\u0027json\u0027, \u0027application/json\u0027)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_6be750e5","line":105,"updated":"2015-01-31 03:51:45.000000000","message":"would you consider renaming this to just \"_get_secret_metadata\"?","commit_id":"ae6e26d07b0494b051ee6382767c39e1a29a5239"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"454703123dae293f9ced42b8f0a6c663b97a6d6e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            return self._on_get_secret_payload(secret, external_project_id,"},{"line_number":103,"context_line":"                                               **kwargs)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _on_get_secret_metadata(self, secret, **kwargs):"},{"line_number":106,"context_line":"        \"\"\"GET Metadata-only for a secret.\"\"\""},{"line_number":107,"context_line":"        pecan.override_template(\u0027json\u0027, \u0027application/json\u0027)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_d640d758","line":105,"in_reply_to":"da86d52c_6be750e5","updated":"2015-02-01 15:53:09.000000000","message":"Well, I actually named it _on_get_... since I thought it would reflect that it\u0027s what the controller does on the case that it gets an HTTP GET request.","commit_id":"ae6e26d07b0494b051ee6382767c39e1a29a5239"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"68e9437abf132ef7eaf3b5d89a697822ba536693","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        transport_key_id \u003d self._get_transport_key_id_if_needed("},{"line_number":113,"context_line":"            kwargs.get(\u0027transport_key_needed\u0027, \u0027false\u0027), secret)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        if transport_key_id is not None:"},{"line_number":116,"context_line":"            secret_fields[\u0027transport_key_id\u0027] \u003d transport_key_id"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        return hrefs.convert_to_hrefs(secret_fields)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_8b87240f","line":115,"updated":"2015-01-31 03:51:45.000000000","message":"is the \"is not None\" needed here?","commit_id":"ae6e26d07b0494b051ee6382767c39e1a29a5239"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"454703123dae293f9ced42b8f0a6c663b97a6d6e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        transport_key_id \u003d self._get_transport_key_id_if_needed("},{"line_number":113,"context_line":"            kwargs.get(\u0027transport_key_needed\u0027, \u0027false\u0027), secret)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        if transport_key_id is not None:"},{"line_number":116,"context_line":"            secret_fields[\u0027transport_key_id\u0027] \u003d transport_key_id"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        return hrefs.convert_to_hrefs(secret_fields)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_16226fb9","line":115,"in_reply_to":"da86d52c_8b87240f","updated":"2015-02-01 15:53:09.000000000","message":"I guess it would also be a bit problematic if the parameter was provided and was empty. You\u0027re right, I\u0027ll get this off.","commit_id":"ae6e26d07b0494b051ee6382767c39e1a29a5239"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"68e9437abf132ef7eaf3b5d89a697822ba536693","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        return hrefs.convert_to_hrefs(secret_fields)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def _get_transport_key_id_if_needed(self, transport_key_needed, secret):"},{"line_number":121,"context_line":"        if transport_key_needed.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":122,"context_line":"            return plugin.get_transport_key_id_for_retrieval(secret)"},{"line_number":123,"context_line":"        return None"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_ebf0a0cb","line":121,"updated":"2015-01-31 03:51:45.000000000","message":"I see above (line 113) we ensure that a non-None is passed in for transport_key_needed, but what about someone else who later wants to use this function? \n\nShould we be extra-careful and ensure that transport_key_needed is not None before hitting it with lower()?","commit_id":"ae6e26d07b0494b051ee6382767c39e1a29a5239"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"68e9437abf132ef7eaf3b5d89a697822ba536693","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            return plugin.get_transport_key_id_for_retrieval(secret)"},{"line_number":123,"context_line":"        return None"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _on_get_secret_payload(self, secret, external_project_id, **kwargs):"},{"line_number":126,"context_line":"        \"\"\"GET actual payload containing the secret.\"\"\""},{"line_number":127,"context_line":"        project \u003d res.get_or_create_project(external_project_id,"},{"line_number":128,"context_line":"                                            self.repos.project_repo)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_8bec84c9","line":125,"updated":"2015-01-31 03:51:45.000000000","message":"would you consider renaming this to just \"_get_secret_payload\"\"?","commit_id":"ae6e26d07b0494b051ee6382767c39e1a29a5239"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"68e9437abf132ef7eaf3b5d89a697822ba536693","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        twsk \u003d kwargs.get(\u0027trans_wrapped_session_key\u0027, None)"},{"line_number":133,"context_line":"        transport_key \u003d None"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if twsk is not None:"},{"line_number":136,"context_line":"            transport_key \u003d self._get_transport_key("},{"line_number":137,"context_line":"                kwargs.get(\u0027transport_key_id\u0027, None))"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_4b09ac94","line":135,"updated":"2015-01-31 03:51:45.000000000","message":"do we need the \"is not None\"?","commit_id":"ae6e26d07b0494b051ee6382767c39e1a29a5239"}]}