)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"cece83f2d0c64e042afdea21bdc834b3540dc5fa","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"GET \u003chost\u003e/v1/secrets/\u003csecret ID\u003e/payload"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The relevant tests were changed to use this new scheme, yet, support"},{"line_number":15,"context_line":"for the other scheme cannot be dropped until this lands to the client"},{"line_number":16,"context_line":"code."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_82d83954","line":14,"updated":"2015-02-18 21:20:14.000000000","message":"actually you ADDED the tests to handle the old scheme","commit_id":"62c62e1483fd065ebae215aafb86fa740e9a004b"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"82dc31f15132a21a2d04a7bc11b5ed6635e90c90","unresolved":false,"context_lines":[{"line_number":16,"context_line":"code."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Blueprint api-change-get-secrets-decrypted"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I2c3a885b11f86014c0111ccac10ca7e23b7f710f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba7be1f8_e96651ec","line":19,"updated":"2015-02-25 04:13:09.000000000","message":"These kind of changes should have the APIImpact flag.","commit_id":"8eadc7f6ac02799255ee410e3812599b1d66bb18"}],"barbican/tests/api/test_resources.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"c5a0d5e0f1ebc419e0835933197f4e63a7f69327","unresolved":false,"context_lines":[{"line_number":930,"context_line":"            \u0027text/plain\u0027,"},{"line_number":931,"context_line":"            self.secret,"},{"line_number":932,"context_line":"            self.project,"},{"line_number":933,"context_line":"            mock.ANY,"},{"line_number":934,"context_line":"            None,"},{"line_number":935,"context_line":"            None"},{"line_number":936,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_400b8b7c","line":933,"updated":"2015-03-04 02:13:53.000000000","message":"mock.ANY is causing several tests to fail - why is that in there?","commit_id":"65fc0f60d0d7f67844a450ef1470f4b4a4467960"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"cb27e5da0b060965218a15f007fd7ea30ae95cde","unresolved":false,"context_lines":[{"line_number":930,"context_line":"            \u0027text/plain\u0027,"},{"line_number":931,"context_line":"            self.secret,"},{"line_number":932,"context_line":"            self.project,"},{"line_number":933,"context_line":"            mock.ANY,"},{"line_number":934,"context_line":"            None,"},{"line_number":935,"context_line":"            None"},{"line_number":936,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_73410b0b","line":933,"in_reply_to":"ba7be1f8_400b8b7c","updated":"2015-03-04 10:16:21.000000000","message":"yeah, because I had removed this parameter in another commit, had forgotten about that. thanks!","commit_id":"65fc0f60d0d7f67844a450ef1470f4b4a4467960"}],"functionaltests/api/v1/behaviors/secret_behaviors.py":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"82dc31f15132a21a2d04a7bc11b5ed6635e90c90","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        headers \u003d {\u0027Accept\u0027: payload_content_type,"},{"line_number":57,"context_line":"                   \u0027Accept-Encoding\u0027: payload_content_encoding}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        return self.client.get(os.path.join(secret_ref, \u0027payload\u0027),"},{"line_number":60,"context_line":"                               extra_headers\u003dheaders)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_secret_based_on_content_type(self, secret_ref,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_893f9586","line":59,"updated":"2015-02-25 04:13:09.000000000","message":"It would be better if this join used urlparse.urljoin() instead of os.path, since this is not a file path.","commit_id":"8eadc7f6ac02799255ee410e3812599b1d66bb18"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"6cf6c13d99a0a31fd51faa60ce5b293f76ee4f16","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        headers \u003d {\u0027Accept\u0027: payload_content_type,"},{"line_number":57,"context_line":"                   \u0027Accept-Encoding\u0027: payload_content_encoding}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        return self.client.get(os.path.join(secret_ref, \u0027payload\u0027),"},{"line_number":60,"context_line":"                               extra_headers\u003dheaders)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_secret_based_on_content_type(self, secret_ref,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_b6a6df51","line":59,"updated":"2015-02-27 20:39:12.000000000","message":"On a Windows machine the above would stick a backwards slash (\u0027\\\u0027) in the middle. If all you are trying to do is return \u0027secret_ref/payload\u0027 to be used in a URL, could you just do \u0027/\u0027.join([secret_ref, \u0027payload\u0027]) or something similar?","commit_id":"f5a6cfc3d58411f8cfa352cefd861fc507380186"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"3709ea004eeb88bc2b666207235f29ef8df4a199","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        headers \u003d {\u0027Accept\u0027: payload_content_type,"},{"line_number":57,"context_line":"                   \u0027Accept-Encoding\u0027: payload_content_encoding}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        return self.client.get(os.path.join(secret_ref, \u0027payload\u0027),"},{"line_number":60,"context_line":"                               extra_headers\u003dheaders)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_secret_based_on_content_type(self, secret_ref,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_f334e2e0","line":59,"in_reply_to":"ba7be1f8_b6a6df51","updated":"2015-02-27 23:24:41.000000000","message":"+1.  Just had the same thing with https://review.openstack.org/#/c/127865/.  Might be good to create a utils common function to do url manipulations such as this?","commit_id":"f5a6cfc3d58411f8cfa352cefd861fc507380186"}],"functionaltests/api/v1/functional/test_secrets.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"54f4b4d27cac695fd39ec2d0451aaba3f5f2d196","unresolved":false,"context_lines":[{"line_number":616,"context_line":"            \u0027payload_content_encoding\u0027: \u0027base64\u0027}"},{"line_number":617,"context_line":"    })"},{"line_number":618,"context_line":"    @testcase.attr(\u0027positive\u0027, \u0027deprecated\u0027)"},{"line_number":619,"context_line":"    def test_secret_create_defaults_valid_types_and_encoding_old_way(self,"},{"line_number":620,"context_line":"                                                                     **kwargs):"},{"line_number":621,"context_line":"        \"\"\"Creates secrets with various content types and encodings.\"\"\""},{"line_number":622,"context_line":"        test_model \u003d secret_models.SecretModel(**secret_create_defaults_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_823cb994","line":619,"range":{"start_line":619,"start_character":8,"end_line":619,"end_character":68},"updated":"2015-02-18 21:19:20.000000000","message":"can we change \"old_way\" to \"using_accept\"? Or did that run over the line length limit?","commit_id":"62c62e1483fd065ebae215aafb86fa740e9a004b"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"183616fa22d4dbbf560391b02a559ea77820f05e","unresolved":false,"context_lines":[{"line_number":616,"context_line":"            \u0027payload_content_encoding\u0027: \u0027base64\u0027}"},{"line_number":617,"context_line":"    })"},{"line_number":618,"context_line":"    @testcase.attr(\u0027positive\u0027, \u0027deprecated\u0027)"},{"line_number":619,"context_line":"    def test_secret_create_defaults_valid_types_and_encoding_old_way(self,"},{"line_number":620,"context_line":"                                                                     **kwargs):"},{"line_number":621,"context_line":"        \"\"\"Creates secrets with various content types and encodings.\"\"\""},{"line_number":622,"context_line":"        test_model \u003d secret_models.SecretModel(**secret_create_defaults_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_560523c0","line":619,"in_reply_to":"da86d52c_823cb994","updated":"2015-02-18 22:51:46.000000000","message":"yup, character limit problem.","commit_id":"62c62e1483fd065ebae215aafb86fa740e9a004b"}]}