)]}'
{"barbican/plugin/dogtag.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"7cf28cee49839aff6153c405bfa0a4190646b437","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        :param barbican_meta_dto:"},{"line_number":726,"context_line":"        :return: cm.ResultDTO"},{"line_number":727,"context_line":"        \"\"\""},{"line_number":728,"context_line":"        if barbican_meta_dto.generated_csr is not None:"},{"line_number":729,"context_line":"            csr \u003d barbican_meta_dto.generated_csr"},{"line_number":730,"context_line":"        else:"},{"line_number":731,"context_line":"            csr \u003d order_meta.get(\u0027request_data\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_217e00e5","line":728,"updated":"2015-02-23 22:17:13.000000000","message":"do you need the \"is not None\"?","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"7be72382181e24f14140b8e7ad60b1870719d865","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        :param barbican_meta_dto:"},{"line_number":726,"context_line":"        :return: cm.ResultDTO"},{"line_number":727,"context_line":"        \"\"\""},{"line_number":728,"context_line":"        if barbican_meta_dto.generated_csr is not None:"},{"line_number":729,"context_line":"            csr \u003d barbican_meta_dto.generated_csr"},{"line_number":730,"context_line":"        else:"},{"line_number":731,"context_line":"            csr \u003d order_meta.get(\u0027request_data\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_04002066","line":728,"in_reply_to":"ba7be1f8_217e00e5","updated":"2015-02-24 14:21:15.000000000","message":"Surprisingly,\n\nif X: and if X is not None: is actually not equivalent.\n\nhttp://stackoverflow.com/questions/7816363/if-a-vs-if-a-is-not-none\n\nIn this case, I wanted to check if something was defined or if its taking the default None.  So the code is correct.","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"7cf28cee49839aff6153c405bfa0a4190646b437","unresolved":false,"context_lines":[{"line_number":809,"context_line":"        \"\"\"Process results received from Dogtag CA for enrollment"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"        :param enrollment_results: list of CertEnrollmentResult objects"},{"line_number":812,"context_line":"        :param plugin_meta: metadata dict for storing plugin specific data"},{"line_number":813,"context_line":"        :return: cm.ResultDTO"},{"line_number":814,"context_line":"        \"\"\""},{"line_number":815,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_21652045","line":812,"updated":"2015-02-23 22:17:13.000000000","message":":param for barbican_meta_dto","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"}],"barbican/plugin/interface/certificate_manager.py":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"8d336b36baaa9c3dee6b19d293e4ec6c12f8bb85","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                            information here which Barbican will persist"},{"line_number":223,"context_line":"                            on their behalf"},{"line_number":224,"context_line":"        :param barbican_meta_dto:"},{"line_number":225,"context_line":"            Data transfer object (BarbicanMetaDTO) containing data added"},{"line_number":226,"context_line":"            to the request by the Barbican server to provide additional"},{"line_number":227,"context_line":"            context for processing, but which are not in"},{"line_number":228,"context_line":"            the original request.  For example, the plugin_ca_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_13006f66","line":225,"updated":"2015-02-23 22:44:58.000000000","message":"Please change (BarbicanMetaDTO) to :class:`BarbicanMetaDTO` so that it will render as a link in the docs.","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"cbfd438590868a957879fc3a6b39792084091d85","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                            information here which Barbican will persist"},{"line_number":223,"context_line":"                            on their behalf"},{"line_number":224,"context_line":"        :param barbican_meta_dto:"},{"line_number":225,"context_line":"            Data transfer object (BarbicanMetaDTO) containing data added"},{"line_number":226,"context_line":"            to the request by the Barbican server to provide additional"},{"line_number":227,"context_line":"            context for processing, but which are not in"},{"line_number":228,"context_line":"            the original request.  For example, the plugin_ca_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_7378cb2b","line":225,"updated":"2015-02-23 22:34:07.000000000","message":"Please replace:\n\n(BarbicanMetaDTO)\n\nwith:\n\n:class:`BarbicanMetaDTO`","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"f3e65f84c7b9b566ff895d16869cdf7e85a4d466","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                            information here which Barbican will persist"},{"line_number":223,"context_line":"                            on their behalf"},{"line_number":224,"context_line":"        :param barbican_meta_dto:"},{"line_number":225,"context_line":"            Data transfer object (BarbicanMetaDTO) containing data added"},{"line_number":226,"context_line":"            to the request by the Barbican server to provide additional"},{"line_number":227,"context_line":"            context for processing, but which are not in"},{"line_number":228,"context_line":"            the original request.  For example, the plugin_ca_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_49695abd","line":225,"in_reply_to":"ba7be1f8_13006f66","updated":"2015-02-23 23:06:00.000000000","message":"That\u0027s a great idea Douglas! :)","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"8d336b36baaa9c3dee6b19d293e4ec6c12f8bb85","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                            information here which Barbican will persist"},{"line_number":245,"context_line":"                            on their behalf"},{"line_number":246,"context_line":"        :param barbican_meta_dto:"},{"line_number":247,"context_line":"            Data transfer object (BarbicanMetaDTO) containing data added"},{"line_number":248,"context_line":"            to the request by the Barbican server to provide additional"},{"line_number":249,"context_line":"            context for processing, but which are not in"},{"line_number":250,"context_line":"            the original request.  For example, the plugin_ca_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_53f9077f","line":247,"updated":"2015-02-23 22:44:58.000000000","message":"Ditto","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"8d336b36baaa9c3dee6b19d293e4ec6c12f8bb85","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                            information here which Barbican will persist"},{"line_number":267,"context_line":"                            on their behalf"},{"line_number":268,"context_line":"        :param barbican_meta_dto:"},{"line_number":269,"context_line":"            Data transfer object (BarbicanMetaDTO) containing data added"},{"line_number":270,"context_line":"            to the request by the Barbican server to provide additional"},{"line_number":271,"context_line":"            context for processing, but which are not in"},{"line_number":272,"context_line":"            the original request.  For example, the plugin_ca_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_73f44b87","line":269,"updated":"2015-02-23 22:44:58.000000000","message":"And here.","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"8d336b36baaa9c3dee6b19d293e4ec6c12f8bb85","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                            this plugin. Plugins may also update/add"},{"line_number":288,"context_line":"                            information here which Barbican will persist"},{"line_number":289,"context_line":"                            on their behalf"},{"line_number":290,"context_line":"        :param barbican_meta_dto:"},{"line_number":291,"context_line":"            Data transfer object (BarbicanMetaDTO) containing data added"},{"line_number":292,"context_line":"            to the request by the Barbican server to provide additional"},{"line_number":293,"context_line":"            context for processing, but which are not in"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_333ad336","line":290,"updated":"2015-02-23 22:44:58.000000000","message":"Uno mas.","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"}],"barbican/tasks/certificate_resources.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"cbfd438590868a957879fc3a6b39792084091d85","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cert_plugin \u003d cert.CertificatePluginManager().get_plugin(order_model.meta)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    request_type \u003d order_model.meta.get(cert.REQUEST_TYPE)"},{"line_number":84,"context_line":"    if request_type \u003d\u003d cert.CertificateRequestType.STORED_KEY_REQUEST:"},{"line_number":85,"context_line":"        csr \u003d _generate_csr(order_model, repos)"},{"line_number":86,"context_line":"        order_model.order_barbican_metadata[\u0027generated_csr\u0027] \u003d csr"},{"line_number":87,"context_line":"        order_model.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b3732314","line":84,"updated":"2015-02-23 22:34:07.000000000","message":"Please also add a check that the CSR is not already in the order_barbican_metadata. If the CA is not available (below) then this flow will be executed again in the future, but now the CSR from the previous time should be available to use here.","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"cbfd438590868a957879fc3a6b39792084091d85","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    request_type \u003d order_model.meta.get(cert.REQUEST_TYPE)"},{"line_number":84,"context_line":"    if request_type \u003d\u003d cert.CertificateRequestType.STORED_KEY_REQUEST:"},{"line_number":85,"context_line":"        csr \u003d _generate_csr(order_model, repos)"},{"line_number":86,"context_line":"        order_model.order_barbican_metadata[\u0027generated_csr\u0027] \u003d csr"},{"line_number":87,"context_line":"        order_model.save()"},{"line_number":88,"context_line":"        barbican_meta_dto.generated_csr \u003d csr"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_33bbb373","line":86,"updated":"2015-02-23 22:34:07.000000000","message":"I do like the separation of the order_barbican_metadata from the plugin-specific metadata via the DTO as not everything in the order barb meta will be appropriate for a plugin to \u0027see\u0027. Will the similar names be confusing though? I don\u0027t think so, but throwing that as food for thought.","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"7cf28cee49839aff6153c405bfa0a4190646b437","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"def _generate_csr(order_model, repos):"},{"line_number":255,"context_line":"    \"\"\"Generate a CSR from the public key.\"\"\""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    container_ref \u003d order_model.meta.get(\u0027container_ref\u0027)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_6140f856","line":255,"updated":"2015-02-23 22:17:13.000000000","message":"might be good to add :param, :raise and :return here (especially :return since we now return a csr)","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"8d336b36baaa9c3dee6b19d293e4ec6c12f8bb85","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"def _generate_csr(order_model, repos):"},{"line_number":255,"context_line":"    \"\"\"Generate a CSR from the public key.\"\"\""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    container_ref \u003d order_model.meta.get(\u0027container_ref\u0027)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_36e2c103","line":255,"in_reply_to":"ba7be1f8_6140f856","updated":"2015-02-23 22:44:58.000000000","message":"+1","commit_id":"d3ceffe02d46ec2705a5779692022f6ca7008d24"}]}