)]}'
{"functionaltests/common/client.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"9510813d23945a6840fdf8ac9467e60bcb7abe63","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        if model and hasattr(model, \u0027obj_to_json\u0027):"},{"line_number":127,"context_line":"            return model.obj_to_json()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def get_base_url(self, include_version\u003dTrue):"},{"line_number":130,"context_line":"        if CONF.keymanager.override_url:"},{"line_number":131,"context_line":"            if include_version:"},{"line_number":132,"context_line":"                return os.path.join(CONF.keymanager.override_url,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_82a09944","line":129,"updated":"2015-02-23 16:54:52.000000000","message":"it seems that we are using include_version for two different things here.  It was added initially to support the call on line 142 to use (or not use) the version when searching for the base URL.  Not sure that\u0027s the same as including (or not including it) on the base URL itself.","commit_id":"e4161ae87d44ef52535dd30d838f0a63e2cb8645"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"3d3eae094fef7a79e7c184f49d017ec98fc5a560","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        if model and hasattr(model, \u0027obj_to_json\u0027):"},{"line_number":127,"context_line":"            return model.obj_to_json()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def get_base_url(self, include_version\u003dTrue):"},{"line_number":130,"context_line":"        if CONF.keymanager.override_url:"},{"line_number":131,"context_line":"            if include_version:"},{"line_number":132,"context_line":"                return os.path.join(CONF.keymanager.override_url,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_cecc7a64","line":129,"in_reply_to":"ba7be1f8_82a09944","updated":"2015-02-23 18:29:36.000000000","message":"In the mainline case, _auth_provder.base_url will return a URL that includes/excludes /v1 at the end of the path.  My patch mimics this behavior for the override-url case.\n\nfunctionaltests/api/v1/smoke/test_versions.py:34 passes include_version\u003dFalse and expects a URL to be returned without /v1, so it can request a supported version list from keystone.","commit_id":"e4161ae87d44ef52535dd30d838f0a63e2cb8645"}]}