)]}'
{"barbican/tests/api/controllers/test_orders.py":[{"author":{"_account_id":8004,"name":"Paul Kehrer","email":"paul.l.kehrer@gmail.com","username":"reaperhulk"},"change_message_id":"f8beb5cfea4c75918ea7081d78985052e5ebc1aa","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        order \u003d order_repo.get(order_uuid, self.project_id)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.assertIsNotNone(order)"},{"line_number":48,"context_line":"        self.assertIsInstance(order, models.Order)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_order_creation_should_allow_unsupported_algorithm(self):"},{"line_number":51,"context_line":"        meta \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_c8241d62","line":48,"updated":"2015-03-08 03:59:33.000000000","message":"This assert obviates the need for the previous.","commit_id":"fa1697f17d1d4660e28d0a6faeb048011c5cdbe0"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"3a6a86574fc0da0610bb71006a02e89e0a149f21","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.assertEqual(resp.status_int, 400)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_order_creation_should_with_unsupported_payload_content_type(self):"},{"line_number":82,"context_line":"        meta \u003d {"},{"line_number":83,"context_line":"            \u0027bit_length\u0027: 128,"},{"line_number":84,"context_line":"            \u0027algorithm\u0027: \u0027aes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_481bcd72","line":81,"updated":"2015-03-08 02:22:22.000000000","message":"Should the name include \"fail\"?  Would of course need to be trimmed down to fit.","commit_id":"fa1697f17d1d4660e28d0a6faeb048011c5cdbe0"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"57a8d76fe78ce67e76914874fb2a9a650334a5f3","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        order \u003d order_repo.get(order_uuid, self.project_id)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.assertIsInstance(order, models.Order)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_order_creation_should_allow_unsupported_algorithm(self):"},{"line_number":50,"context_line":"        meta \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_d53ee428","line":47,"updated":"2015-03-11 16:56:12.000000000","message":"Should we retrieve the key and test the properties of it? For instance if I create an order for a symmetric key then I should be able to retrieve it and use it for encryption.\n\nKaitlin and I added a useful test, in our view, that creates an order for an asymmetric key pair. Then it tests that it can retrieve the keys and encrypt/decrypt some data. That proves the keys are related. I think that might be a good test here. See Kaitlin\u0027s patch on this. I don\u0027t have the link handy, but it is dependent upon the content type patch.\n\nFor symmetric we could verify key length or something. I don\u0027t know how much testing is needed for this to be accepted.","commit_id":"effe754e9b9a38379414dda72d19100bbadde8e2"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"5b6fe3ac702d824faca0288cdf99ede48ac362a8","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        order \u003d order_repo.get(order_uuid, self.project_id)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.assertIsInstance(order, models.Order)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_order_creation_should_allow_unsupported_algorithm(self):"},{"line_number":50,"context_line":"        meta \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_0c392541","line":47,"in_reply_to":"9a80dd14_d53ee428","updated":"2015-03-12 15:21:38.000000000","message":"I agree that this test could be improved; however, this is not a new test. I\u0027ve split this test out from test_resources. My assumption is that once we get the mocks removed and a bunch of this stuff split out, we\u0027ll need to come back around for a second pass, reduce duplication and make the tests themselves better.","commit_id":"effe754e9b9a38379414dda72d19100bbadde8e2"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"57a8d76fe78ce67e76914874fb2a9a650334a5f3","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.assertIsInstance(order, models.Order)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_order_creation_should_allow_unsupported_algorithm(self):"},{"line_number":50,"context_line":"        meta \u003d {"},{"line_number":51,"context_line":"            \u0027bit_length\u0027: 128,"},{"line_number":52,"context_line":"            \u0027algorithm\u0027: \u0027not supported\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_b5aed096","line":49,"updated":"2015-03-11 16:56:12.000000000","message":"Test name seems a little funny to me. If it is not supported then should probably raise an error. Maybe change it to unknown algorithm?","commit_id":"effe754e9b9a38379414dda72d19100bbadde8e2"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"5b6fe3ac702d824faca0288cdf99ede48ac362a8","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.assertIsInstance(order, models.Order)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_order_creation_should_allow_unsupported_algorithm(self):"},{"line_number":50,"context_line":"        meta \u003d {"},{"line_number":51,"context_line":"            \u0027bit_length\u0027: 128,"},{"line_number":52,"context_line":"            \u0027algorithm\u0027: \u0027not supported\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_6c770103","line":49,"in_reply_to":"9a80dd14_b5aed096","updated":"2015-03-12 15:21:38.000000000","message":"This was the name in test_resources, but yeah I wasn\u0027t a fan of the name either. I\u0027ll change it.","commit_id":"effe754e9b9a38379414dda72d19100bbadde8e2"}]}