)]}'
{"functionaltests/api/v1/functional/test_secrets.py":[{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"d8da9539fbf82fd08a840a472ea8640e4f51fd5f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"payload_content_encoding\": \"base64\","},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"default_secret_create_all_none_data \u003d {"},{"line_number":43,"context_line":"    \"name\": None,"},{"line_number":44,"context_line":"    \"expiration\": None,"},{"line_number":45,"context_line":"    \"algorithm\": None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_33b8bd10","line":42,"updated":"2015-03-13 19:55:41.000000000","message":"+1 I like name changes to default_*","commit_id":"4b791b6f587f8ab2495336658dd03f7e02c654ce"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"d8da9539fbf82fd08a840a472ea8640e4f51fd5f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # make a local mutable copies of the default data to prevent"},{"line_number":81,"context_line":"        # possible data contamination if (when?) the data contains"},{"line_number":82,"context_line":"        # any nested dicts."},{"line_number":83,"context_line":"        self.create_default_data \u003d copy.deepcopy(default_secret_create_data)"},{"line_number":84,"context_line":"        self.create_all_none_data \u003d copy.deepcopy("},{"line_number":85,"context_line":"            default_secret_create_all_none_data)"},{"line_number":86,"context_line":"        self.create_emptystrings \u003d copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_53837155","line":83,"updated":"2015-03-13 19:55:41.000000000","message":"nit: Above you changed names to default_* and here you change it back to create_default_data. It seems odd because all of the other instance variables drop the default.","commit_id":"4b791b6f587f8ab2495336658dd03f7e02c654ce"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"d8da9539fbf82fd08a840a472ea8640e4f51fd5f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.create_default_data \u003d copy.deepcopy(default_secret_create_data)"},{"line_number":84,"context_line":"        self.create_all_none_data \u003d copy.deepcopy("},{"line_number":85,"context_line":"            default_secret_create_all_none_data)"},{"line_number":86,"context_line":"        self.create_emptystrings \u003d copy.deepcopy("},{"line_number":87,"context_line":"            default_secret_create_emptystrings_data)"},{"line_number":88,"context_line":"        self.create_two_phase_data \u003d copy.deepcopy("},{"line_number":89,"context_line":"            default_secret_create_two_phase_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_53d1b155","line":86,"updated":"2015-03-13 19:55:41.000000000","message":"nit: All the other instance variables are *_data but not this one. Seems like it would be better to make consistent.","commit_id":"4b791b6f587f8ab2495336658dd03f7e02c654ce"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"d8da9539fbf82fd08a840a472ea8640e4f51fd5f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                         test_model.payload_content_type)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":121,"context_line":"    def test_secret_create_all_none(self):"},{"line_number":122,"context_line":"        \"\"\"Covers case of a POST request with no JSON data.\"\"\""},{"line_number":123,"context_line":"        test_model \u003d secret_models.SecretModel(**self.create_all_none_data)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1352d9dd","line":121,"updated":"2015-03-13 19:55:41.000000000","message":"I did not understand the old name of *_nones. Now I get it :)","commit_id":"4b791b6f587f8ab2495336658dd03f7e02c654ce"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"d8da9539fbf82fd08a840a472ea8640e4f51fd5f","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        test_model \u003d secret_models.SecretModel(**self.create_two_phase_data)"},{"line_number":382,"context_line":"        test_model.payload_content_encoding \u003d \u0027base64\u0027"},{"line_number":383,"context_line":"        test_model.payload_content_type \u003d \u0027application/octet-stream\u0027"},{"line_number":384,"context_line":"        test_model.payload \u003d base64.b64encode(\u0027abcdef\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        resp, secret_ref \u003d self.behaviors.create_secret(test_model)"},{"line_number":387,"context_line":"        self.assertEqual(resp.status_code, 201)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_534e1170","line":384,"updated":"2015-03-13 19:55:41.000000000","message":"+1 much easier to read","commit_id":"4b791b6f587f8ab2495336658dd03f7e02c654ce"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"f42aea56d0ed9860bd9c5dd26708756271458036","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.default_secret_create_emptystrings_data \u003d copy.deepcopy("},{"line_number":131,"context_line":"            default_secret_create_emptystrings_data)"},{"line_number":132,"context_line":"        self.default_secret_create_two_phase_data \u003d copy.deepcopy("},{"line_number":133,"context_line":"            default_secret_create_two_phase_data)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def tearDown(self):"},{"line_number":136,"context_line":"        self.behaviors.delete_all_created_secrets()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_6253e939","line":133,"updated":"2015-03-17 03:52:05.000000000","message":"Couldn\u0027t this be avoided by just moving the literals into this setUp function?","commit_id":"9514dd107c95f047504f26bc84ea939575194bf9"}]}