)]}'
{"barbican/api/controllers/secrets.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"10551be2a5698ac2457778a7bdb9d0f59ecc8d14","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                payload_sample_url +\u003d \u0027/payload\u0027"},{"line_number":89,"context_line":"            LOG.warning(\u0027The decryption of secrets using a path such as this \u0027"},{"line_number":90,"context_line":"                        \u0027one is being deprecated. We recommend appending \u0027"},{"line_number":91,"context_line":"                        \u0027\\\u0027payload\\\u0027 to the path to decrypt secrets.\\n\u0027"},{"line_number":92,"context_line":"                        \u0027e.g. {0}\u0027.format(payload_sample_url))"},{"line_number":93,"context_line":"            return self._on_get_secret_payload(self.secret,"},{"line_number":94,"context_line":"                                               external_project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_84c66566","line":91,"updated":"2015-03-16 01:18:42.000000000","message":"should this say /payload and not just payload?","commit_id":"eb67b30f53a73e28ed851e92101e8a2bcf59715a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"28190b145c559d14dbc7f5a04ede46f9ae02ebe7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                payload_sample_url +\u003d \u0027/payload\u0027"},{"line_number":89,"context_line":"            LOG.warning(\u0027The decryption of secrets using a path such as this \u0027"},{"line_number":90,"context_line":"                        \u0027one is being deprecated. We recommend appending \u0027"},{"line_number":91,"context_line":"                        \u0027\\\u0027payload\\\u0027 to the path to decrypt secrets.\\n\u0027"},{"line_number":92,"context_line":"                        \u0027e.g. {0}\u0027.format(payload_sample_url))"},{"line_number":93,"context_line":"            return self._on_get_secret_payload(self.secret,"},{"line_number":94,"context_line":"                                               external_project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_64a6ccac","line":91,"in_reply_to":"9a80dd14_84c66566","updated":"2015-03-16 06:31:17.000000000","message":"Well, it says \"append \u0027payload\u0027 to the path\" which I would assume it implies the slash. Then again that\u0027s why I print out also an example.","commit_id":"eb67b30f53a73e28ed851e92101e8a2bcf59715a"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"ae722667c16977b2381171a886379a7bf3135160","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            else:"},{"line_number":88,"context_line":"                payload_sample_url +\u003d \u0027/payload/\u0027"},{"line_number":89,"context_line":"            LOG.warning(\u0027The decryption of secrets using a path such as this \u0027"},{"line_number":90,"context_line":"                        \u0027one is being deprecated. We recommend appending \u0027"},{"line_number":91,"context_line":"                        \u0027\\\u0027payload\\\u0027 to the path to decrypt secrets.\\n\u0027"},{"line_number":92,"context_line":"                        \u0027e.g. {0}\u0027.format(payload_sample_url))"},{"line_number":93,"context_line":"            return self._on_get_secret_payload(self.secret,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_cf9f7a4e","line":90,"updated":"2015-03-16 15:55:31.000000000","message":"nit: /is being deprecated/is deprecated/.","commit_id":"0e31a5b1326830e4199bd32085e90245ac9efd19"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"67b692432691e4a309582e5b52e33a9d961f3cda","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.warning(\u0027The decryption of secrets using a path such as this \u0027"},{"line_number":90,"context_line":"                        \u0027one is being deprecated. We recommend appending \u0027"},{"line_number":91,"context_line":"                        \u0027\\\u0027payload\\\u0027 to the path to decrypt secrets.\\n\u0027"},{"line_number":92,"context_line":"                        \u0027e.g. {0}\u0027.format(payload_sample_url))"},{"line_number":93,"context_line":"            return self._on_get_secret_payload(self.secret,"},{"line_number":94,"context_line":"                                               external_project_id,"},{"line_number":95,"context_line":"                                               **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1618d41c","line":92,"updated":"2015-03-16 13:37:12.000000000","message":"A static sample link here would be fine I think,but this is fine.","commit_id":"0e31a5b1326830e4199bd32085e90245ac9efd19"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"4717fa07a84a60a1e03b74f6665b6aacf9435712","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.warning(\u0027The decryption of secrets using a path such as this \u0027"},{"line_number":90,"context_line":"                        \u0027one is being deprecated. We recommend appending \u0027"},{"line_number":91,"context_line":"                        \u0027\\\u0027payload\\\u0027 to the path to decrypt secrets.\\n\u0027"},{"line_number":92,"context_line":"                        \u0027e.g. {0}\u0027.format(payload_sample_url))"},{"line_number":93,"context_line":"            return self._on_get_secret_payload(self.secret,"},{"line_number":94,"context_line":"                                               external_project_id,"},{"line_number":95,"context_line":"                                               **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_5697aceb","line":92,"in_reply_to":"9a80dd14_1618d41c","updated":"2015-03-16 13:43:12.000000000","message":"haha yeah... this might be an overkill","commit_id":"0e31a5b1326830e4199bd32085e90245ac9efd19"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"ae722667c16977b2381171a886379a7bf3135160","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.warning(\u0027The decryption of secrets using a path such as this \u0027"},{"line_number":90,"context_line":"                        \u0027one is being deprecated. We recommend appending \u0027"},{"line_number":91,"context_line":"                        \u0027\\\u0027payload\\\u0027 to the path to decrypt secrets.\\n\u0027"},{"line_number":92,"context_line":"                        \u0027e.g. {0}\u0027.format(payload_sample_url))"},{"line_number":93,"context_line":"            return self._on_get_secret_payload(self.secret,"},{"line_number":94,"context_line":"                                               external_project_id,"},{"line_number":95,"context_line":"                                               **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_cfacda37","line":92,"in_reply_to":"9a80dd14_19280096","updated":"2015-03-16 15:55:31.000000000","message":"This is a nit, but who is this log message for? It seems like it is for internal server admin. A message like (\"decrypted secret {0} requested using deprecated API call\", secret_id) would be better. That lets admin know someone is calling API with old API, and they can likely figure out which project is doing that based upon the secret ID.","commit_id":"0e31a5b1326830e4199bd32085e90245ac9efd19"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"eda64d98bd1d79fcbbebf23b72ae01f6df618437","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.warning(\u0027The decryption of secrets using a path such as this \u0027"},{"line_number":90,"context_line":"                        \u0027one is being deprecated. We recommend appending \u0027"},{"line_number":91,"context_line":"                        \u0027\\\u0027payload\\\u0027 to the path to decrypt secrets.\\n\u0027"},{"line_number":92,"context_line":"                        \u0027e.g. {0}\u0027.format(payload_sample_url))"},{"line_number":93,"context_line":"            return self._on_get_secret_payload(self.secret,"},{"line_number":94,"context_line":"                                               external_project_id,"},{"line_number":95,"context_line":"                                               **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_999a3060","line":92,"in_reply_to":"9a80dd14_5697aceb","updated":"2015-03-16 15:22:08.000000000","message":"Prefer modulo (%) interpolation for logs.","commit_id":"0e31a5b1326830e4199bd32085e90245ac9efd19"},{"author":{"_account_id":7136,"name":"Chad Lung","email":"chad.lung@gmail.com","username":"chadlung"},"change_message_id":"7423e323d410bf08b9111dc4f28ea254a680f3c3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.warning(\u0027The decryption of secrets using a path such as this \u0027"},{"line_number":90,"context_line":"                        \u0027one is being deprecated. We recommend appending \u0027"},{"line_number":91,"context_line":"                        \u0027\\\u0027payload\\\u0027 to the path to decrypt secrets.\\n\u0027"},{"line_number":92,"context_line":"                        \u0027e.g. {0}\u0027.format(payload_sample_url))"},{"line_number":93,"context_line":"            return self._on_get_secret_payload(self.secret,"},{"line_number":94,"context_line":"                                               external_project_id,"},{"line_number":95,"context_line":"                                               **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_19280096","line":92,"in_reply_to":"9a80dd14_999a3060","updated":"2015-03-16 15:27:07.000000000","message":"Does OpenStack in general prefer modulo over format? I prefer format but haven\u0027t every come across any OpenStack preferences here to back up either.","commit_id":"0e31a5b1326830e4199bd32085e90245ac9efd19"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"161c581d56403d8941df16dfa64457fa114c18fb","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.warning(\u0027The decryption of secrets using a path such as this \u0027"},{"line_number":90,"context_line":"                        \u0027one is being deprecated. We recommend appending \u0027"},{"line_number":91,"context_line":"                        \u0027\\\u0027payload\\\u0027 to the path to decrypt secrets.\\n\u0027"},{"line_number":92,"context_line":"                        \u0027e.g. {0}\u0027.format(payload_sample_url))"},{"line_number":93,"context_line":"            return self._on_get_secret_payload(self.secret,"},{"line_number":94,"context_line":"                                               external_project_id,"},{"line_number":95,"context_line":"                                               **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_e6f9bb4f","line":92,"in_reply_to":"9a80dd14_cfacda37","updated":"2015-03-16 20:27:34.000000000","message":"To be honest I\u0027m not sure what the conclusion is here... should I leave it like this or change it?","commit_id":"0e31a5b1326830e4199bd32085e90245ac9efd19"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"98b85b5175c7f469149c58051792c41f9fe4fb40","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.warning(\u0027The decryption of secrets using a path such as this \u0027"},{"line_number":90,"context_line":"                        \u0027one is being deprecated. We recommend appending \u0027"},{"line_number":91,"context_line":"                        \u0027\\\u0027payload\\\u0027 to the path to decrypt secrets.\\n\u0027"},{"line_number":92,"context_line":"                        \u0027e.g. {0}\u0027.format(payload_sample_url))"},{"line_number":93,"context_line":"            return self._on_get_secret_payload(self.secret,"},{"line_number":94,"context_line":"                                               external_project_id,"},{"line_number":95,"context_line":"                                               **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_552f873e","line":92,"in_reply_to":"9a80dd14_e6f9bb4f","updated":"2015-03-16 22:09:33.000000000","message":"Chad, in general .format() is preferred.\n\nUsing modulo addresses a performance issue with logging. In logging, especially LOG.debug statements, if you use .format() then the string interpolation will be done before the logging logic figures out what the log level is, and whether the log statement is needed at all.  In debug logging this is an issue because often debug is turned off, so your app always performs the string interpolation, but never needs the resulting string, so it\u0027s a lot of wasted processing.\n\nThis is why all the logging methods take *args to let you defer interpolation to the logging logic.  Unfortunately this feature pre-dates the .format() way of interpolating, so it only works with modulo (%) interpolation.  Note that you shouldn\u0027t actually use the (%) operator.  You should only write the string with \"%s\" placeholders and then pass the values as additional args to the log function.\n\nIn this case, it would look like:\n\nLOG.warning(\"DEPRECATION WARNING: something something this %s url\", payload_sample_url)","commit_id":"0e31a5b1326830e4199bd32085e90245ac9efd19"}],"doc/source/api.rst":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"10551be2a5698ac2457778a7bdb9d0f59ecc8d14","unresolved":false,"context_lines":[{"line_number":311,"context_line":"GET - Decrypted Secret Data"},{"line_number":312,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"To retrieve the decrypted secret information, one must append \u0027payload\u0027 to the"},{"line_number":315,"context_line":"path of the desired secret, and  perform a GET with the `Accept` header set to"},{"line_number":316,"context_line":"one of the `content_types` specified in the GET metadata call."},{"line_number":317,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_04aa7584","line":314,"updated":"2015-03-16 01:18:42.000000000","message":"Should we say \"/payload\" or just \"payload\"?  Personally I like /payload better.","commit_id":"eb67b30f53a73e28ed851e92101e8a2bcf59715a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"8817e2141cc5940203e49f8d6c7ad73b07a6f42a","unresolved":false,"context_lines":[{"line_number":311,"context_line":"GET - Decrypted Secret Data"},{"line_number":312,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"To retrieve the decrypted secret information, one must append \u0027payload\u0027 to the"},{"line_number":315,"context_line":"path of the desired secret, and  perform a GET with the `Accept` header set to"},{"line_number":316,"context_line":"one of the `content_types` specified in the GET metadata call."},{"line_number":317,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_1360e6cd","line":314,"in_reply_to":"9a80dd14_04aa7584","updated":"2015-03-16 13:11:40.000000000","message":"I only mentioned \u0027payload\u0027 as that is the real \"entity\" (in REST terms) that is being accessed. So the slashes are just a separator, which is why I don\u0027t really mention it when refering to the payload \"entity\". If slashes were to be added, I would actually argue to add them in the end. So then I would refer to \u0027payload\u0027 as \u0027payload/\u0027, since that would reflect the directory-like structure on which URLs were based on.","commit_id":"eb67b30f53a73e28ed851e92101e8a2bcf59715a"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"10551be2a5698ac2457778a7bdb9d0f59ecc8d14","unresolved":false,"context_lines":[{"line_number":346,"context_line":"| GET    | Gets the information for the specified secret. For the            |"},{"line_number":347,"context_line":"|        | `application/json` accept type, only metadata about the secret is |"},{"line_number":348,"context_line":"|        | returned.                                                         |"},{"line_number":349,"context_line":"|        |  _The following is to be deprecated:_ If one of the               |"},{"line_number":350,"context_line":"|        | \u0027content_types\u0027 accept types is specified, that portion of the    |"},{"line_number":351,"context_line":"|        | secret will be decrypted and returned.                            |"},{"line_number":352,"context_line":"+--------+-------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_2484d909","line":349,"updated":"2015-03-16 01:18:42.000000000","message":"nit - don\u0027t need to \"to be\"...just \"The following is deprecated:\"","commit_id":"eb67b30f53a73e28ed851e92101e8a2bcf59715a"}]}