)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"3d61426285687c1c3e494efee7d280459dae166d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add retry server and functional tests to DevStack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a retry scheduler server process to the DevStack start/stop"},{"line_number":10,"context_line":"processes. This includes adding a PBR entry point and barbican.cmd"},{"line_number":11,"context_line":"script for the retry scheduler process, as other projects such as"},{"line_number":12,"context_line":"Glance and Nova are doing now. Eventually we\u0027ll want to move over all"},{"line_number":13,"context_line":"our boot scripts to the entry point approach. Verify functional test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"ba3cc151_424847b3","line":10,"updated":"2015-07-08 17:57:27.000000000","message":"Is a pbr entry point added?  It looks like one of the scripts is renamed to have a shorter name, that is all?","commit_id":"d418be8ade3312430a22a42d922a4b2d64de891d"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"94880aec96caffd1337f0763f43a03ad7cb00488","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add retry server and functional tests to DevStack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a retry scheduler server process to the DevStack start/stop"},{"line_number":10,"context_line":"processes. This includes adding a PBR entry point and barbican.cmd"},{"line_number":11,"context_line":"script for the retry scheduler process, as other projects such as"},{"line_number":12,"context_line":"Glance and Nova are doing now. Eventually we\u0027ll want to move over all"},{"line_number":13,"context_line":"our boot scripts to the entry point approach. Verify functional test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"ba3cc151_3bef621f","line":10,"in_reply_to":"ba3cc151_424847b3","updated":"2015-07-08 22:35:34.000000000","message":"Well this CR has been here for a while, and another commit (https://github.com/openstack/barbican/commit/63102c02dca5fc066bc0a68fde008bab26152405#diff-199fdc09815453236784b52f114da4c2) actually moved things to the cmd folder from bin.","commit_id":"d418be8ade3312430a22a42d922a4b2d64de891d"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"3d61426285687c1c3e494efee7d280459dae166d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a retry scheduler server process to the DevStack start/stop"},{"line_number":10,"context_line":"processes. This includes adding a PBR entry point and barbican.cmd"},{"line_number":11,"context_line":"script for the retry scheduler process, as other projects such as"},{"line_number":12,"context_line":"Glance and Nova are doing now. Eventually we\u0027ll want to move over all"},{"line_number":13,"context_line":"our boot scripts to the entry point approach. Verify functional test"},{"line_number":14,"context_line":"for generating a simple certificate order, which is the first of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"ba3cc151_82d96ff5","line":11,"updated":"2015-07-08 17:57:27.000000000","message":"Looks like a white space line is removed, not adding the script?","commit_id":"d418be8ade3312430a22a42d922a4b2d64de891d"}],"barbican/cmd/db_manage.py":[{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"3d61426285687c1c3e494efee7d280459dae166d","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class DatabaseManager(object):"},{"line_number":30,"context_line":"    \"\"\"Database Manager class."},{"line_number":31,"context_line":"    \"\"\"Builds and executes a CLI parser to manage the Barbican"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    This extends the Alembic commands."}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_428da7d1","line":30,"updated":"2015-07-08 17:57:27.000000000","message":"Is this needed?","commit_id":"d418be8ade3312430a22a42d922a4b2d64de891d"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"94880aec96caffd1337f0763f43a03ad7cb00488","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class DatabaseManager(object):"},{"line_number":30,"context_line":"    \"\"\"Database Manager class."},{"line_number":31,"context_line":"    \"\"\"Builds and executes a CLI parser to manage the Barbican"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    This extends the Alembic commands."}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_a87d6a1d","line":30,"in_reply_to":"ba3cc151_428da7d1","updated":"2015-07-08 22:35:34.000000000","message":"Looks like a merge glitch?","commit_id":"d418be8ade3312430a22a42d922a4b2d64de891d"}],"barbican/queue/retry_scheduler.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"82d2e5930fc8ac3aa63e0f054f477fc56a6a8573","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        return check_again_in_seconds"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _process_retry_tasks(self):"},{"line_number":110,"context_line":"        \"\"\"Scan for an then re-queue tasks that are ready to retry.\"\"\""},{"line_number":111,"context_line":"        LOG.info(u._LI(\"Processing scheduled retry tasks:\"))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # Retrieve tasks to retry."}],"source_content_type":"text/x-python","patch_set":20,"id":"3afb71cf_91bf7460","line":110,"updated":"2015-06-10 16:19:42.000000000","message":"c/an/and?","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9d0ca273c0cb923553f80e71ab40b89bfbb1de43","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        return check_again_in_seconds"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _process_retry_tasks(self):"},{"line_number":110,"context_line":"        \"\"\"Scan for an then re-queue tasks that are ready to retry.\"\"\""},{"line_number":111,"context_line":"        LOG.info(u._LI(\"Processing scheduled retry tasks:\"))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # Retrieve tasks to retry."}],"source_content_type":"text/x-python","patch_set":20,"id":"3afb71cf_8b7f3cdf","line":110,"in_reply_to":"3afb71cf_91bf7460","updated":"2015-06-10 19:51:58.000000000","message":"Yes, thanks.","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"82d2e5930fc8ac3aa63e0f054f477fc56a6a8573","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        entities, total \u003d self._retrieve_tasks()"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Create RPC tasks for each retry task found."},{"line_number":117,"context_line":"        if total \u003e 0:"},{"line_number":118,"context_line":"            for task in entities:"},{"line_number":119,"context_line":"                self._enqueue_task(task)"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3afb71cf_716998f8","line":117,"updated":"2015-06-10 16:19:42.000000000","message":"is total *always* the size of entities?  if so then probably don\u0027t need the test for total \u003e 0","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9d0ca273c0cb923553f80e71ab40b89bfbb1de43","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        entities, total \u003d self._retrieve_tasks()"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Create RPC tasks for each retry task found."},{"line_number":117,"context_line":"        if total \u003e 0:"},{"line_number":118,"context_line":"            for task in entities:"},{"line_number":119,"context_line":"                self._enqueue_task(task)"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3afb71cf_cb1ad4c5","line":117,"in_reply_to":"3afb71cf_716998f8","updated":"2015-06-10 19:51:58.000000000","message":"This if is needed as \u0027entities\u0027 may be None from 114.","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7facda37171b70cdcead3d279b553b636d4a48b3","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        retry_task_name \u003d \u0027N/A\u0027"},{"line_number":138,"context_line":"        retry_args \u003d \u0027N/A\u0027"},{"line_number":139,"context_line":"        retry_kwargs \u003d \u0027N/A\u0027"},{"line_number":140,"context_line":"        repositories.start()"},{"line_number":141,"context_line":"        try:"},{"line_number":142,"context_line":"            # Invoke queue client to place retried RPC task on queue."},{"line_number":143,"context_line":"            retry_task_name \u003d task.retry_task"}],"source_content_type":"text/x-python","patch_set":20,"id":"3afb71cf_51c9fcaa","line":140,"updated":"2015-06-10 15:30:12.000000000","message":"Why is the repo started here?","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9d0ca273c0cb923553f80e71ab40b89bfbb1de43","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        retry_task_name \u003d \u0027N/A\u0027"},{"line_number":138,"context_line":"        retry_args \u003d \u0027N/A\u0027"},{"line_number":139,"context_line":"        retry_kwargs \u003d \u0027N/A\u0027"},{"line_number":140,"context_line":"        repositories.start()"},{"line_number":141,"context_line":"        try:"},{"line_number":142,"context_line":"            # Invoke queue client to place retried RPC task on queue."},{"line_number":143,"context_line":"            retry_task_name \u003d task.retry_task"}],"source_content_type":"text/x-python","patch_set":20,"id":"3afb71cf_8b0a9c88","line":140,"in_reply_to":"3afb71cf_51c9fcaa","updated":"2015-06-10 19:51:58.000000000","message":"I\u0027m trying to isolate the db transaction to an individual task here so already-processed tasks are not rolled back. Performance on the worker side is also not as big a concern as on the API side, so separate transactions shouldn\u0027t be a significant load on the system.","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"3d61426285687c1c3e494efee7d280459dae166d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            LOG.exception("},{"line_number":95,"context_line":"                u._LE(\"Problem seen processing scheduled retry tasks\")"},{"line_number":96,"context_line":"            )"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Return the next delay before this method is invoked again."},{"line_number":99,"context_line":"        check_again_in_seconds \u003d _compute_next_periodic_interval()"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_e24abb82","line":96,"updated":"2015-07-08 17:57:27.000000000","message":"This change looks much nicer and easier to read!","commit_id":"d418be8ade3312430a22a42d922a4b2d64de891d"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"94880aec96caffd1337f0763f43a03ad7cb00488","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            LOG.exception("},{"line_number":95,"context_line":"                u._LE(\"Problem seen processing scheduled retry tasks\")"},{"line_number":96,"context_line":"            )"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Return the next delay before this method is invoked again."},{"line_number":99,"context_line":"        check_again_in_seconds \u003d _compute_next_periodic_interval()"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_68d8c21e","line":96,"in_reply_to":"ba3cc151_e24abb82","updated":"2015-07-08 22:35:34.000000000","message":"Agreed!","commit_id":"d418be8ade3312430a22a42d922a4b2d64de891d"}],"barbican/tests/cmd/test_cmd.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"82d2e5930fc8ac3aa63e0f054f477fc56a6a8573","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class WhenInvokingRetryServiceCommand(utils.BaseTestCase):"},{"line_number":22,"context_line":"    \"\"\"Test the barbican.cmd.retry_scheduler.py module.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def setUp(self):"},{"line_number":25,"context_line":"        super(WhenInvokingRetryServiceCommand, self).setUp()"}],"source_content_type":"text/x-python","patch_set":20,"id":"3afb71cf_b44ffe32","line":22,"updated":"2015-06-10 16:19:42.000000000","message":"nit - if we ever rename that file then this comment gets out of sync.  Maybe just say that it tests the retry scheduler functionality?","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9d0ca273c0cb923553f80e71ab40b89bfbb1de43","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class WhenInvokingRetryServiceCommand(utils.BaseTestCase):"},{"line_number":22,"context_line":"    \"\"\"Test the barbican.cmd.retry_scheduler.py module.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def setUp(self):"},{"line_number":25,"context_line":"        super(WhenInvokingRetryServiceCommand, self).setUp()"}],"source_content_type":"text/x-python","patch_set":20,"id":"3afb71cf_cb71b40d","line":22,"in_reply_to":"3afb71cf_b44ffe32","updated":"2015-06-10 19:51:58.000000000","message":"Sounds good.","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"}],"barbican/tests/queue/test_retry_scheduler.py":[{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"4e81c16ae0e350632792dfd519b46c40ddaaaa38","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def test_should_perform_retry_processing_no_tasks(self):"},{"line_number":70,"context_line":"        interval \u003d self.periodic_server._check_retry_tasks()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.assertEqual(True, is_interval_in_expected_range(interval))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_should_perform_retry_processing_one_task(self):"},{"line_number":75,"context_line":"        # Add one retry task."}],"source_content_type":"text/x-python","patch_set":29,"id":"ba3cc151_b9678cb6","line":72,"updated":"2015-07-10 17:40:02.000000000","message":"I\u0027m not gonna -1 for this, but in the future self.assertTrue() should be used.","commit_id":"39db605d2d4dd3b1bb13425f01965dc5b6f6b60a"}],"contrib/devstack/lib/barbican":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7facda37171b70cdcead3d279b553b636d4a48b3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Install and start **Barbican** service"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To enable a minimal set of Barbican features, add the following to localrc:"},{"line_number":5,"context_line":"#   enable_service barbican-svc barbican-retry"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Dependencies:"},{"line_number":8,"context_line":"# - functions"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_d1196c23","line":5,"updated":"2015-06-10 15:30:12.000000000","message":"what does barbican-svc stand for?","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"af634ddc2481e32199a2bb934229bcc6099ec9f1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Install and start **Barbican** service"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To enable a minimal set of Barbican features, add the following to localrc:"},{"line_number":5,"context_line":"#   enable_service barbican-svc barbican-retry"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Dependencies:"},{"line_number":8,"context_line":"# - functions"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_d4f03acb","line":5,"in_reply_to":"3afb71cf_d1196c23","updated":"2015-06-10 15:45:46.000000000","message":"\"svc\" is \"service\"?  What\u0027s the benefit of the rename?  Is it possible to run barbican-svc without barbican-retry, or vice versa?","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9d0ca273c0cb923553f80e71ab40b89bfbb1de43","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Install and start **Barbican** service"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To enable a minimal set of Barbican features, add the following to localrc:"},{"line_number":5,"context_line":"#   enable_service barbican-svc barbican-retry"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Dependencies:"},{"line_number":8,"context_line":"# - functions"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_2b060852","line":5,"in_reply_to":"3afb71cf_d4f03acb","updated":"2015-06-10 19:51:58.000000000","message":"The shortened service name suffix is a naming convention I\u0027ve seen with other openstack projects. So \u0027svc\u0027 is the main barbican server service, and \u0027barbican-retry\u0027 is the retry scheduler process that runs in parallel to the service (so is run separately). The retry process is only needed for long-running orders like public CA certificate generation.","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"af634ddc2481e32199a2bb934229bcc6099ec9f1","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    iniset $BARBICAN_CONF DEFAULT verbose True"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Do not set to DEBUG"},{"line_number":128,"context_line":"    #iniset $BARBICAN_CONF DEFAULT debug False"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # Set the log file location"},{"line_number":131,"context_line":"    iniset $BARBICAN_CONF DEFAULT log_file \"$BARBICAN_API_LOG_DIR/barbican.log\""}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_54f20a07","line":128,"updated":"2015-06-10 15:45:46.000000000","message":"dead code?","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9d0ca273c0cb923553f80e71ab40b89bfbb1de43","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    iniset $BARBICAN_CONF DEFAULT verbose True"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Do not set to DEBUG"},{"line_number":128,"context_line":"    #iniset $BARBICAN_CONF DEFAULT debug False"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # Set the log file location"},{"line_number":131,"context_line":"    iniset $BARBICAN_CONF DEFAULT log_file \"$BARBICAN_API_LOG_DIR/barbican.log\""}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_6b6c0008","line":128,"in_reply_to":"3afb71cf_54f20a07","updated":"2015-06-10 19:51:58.000000000","message":"Not dead enough! I\u0027ll remove it on the next version.","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"82d2e5930fc8ac3aa63e0f054f477fc56a6a8573","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # Start the Barbican service up."},{"line_number":204,"context_line":"    # TOOD(john-wood-) I\u0027ve noticed movement from \u0027screen_it\u0027 to"},{"line_number":205,"context_line":"    # \u0027run_process\u0027 in several OpenStack project commits to Devstack. My first"},{"line_number":206,"context_line":"    # attempt to just replace screen_it with run_process did not work though."},{"line_number":207,"context_line":"    run_process barbican-svc \"uwsgi --master --emperor $BARBICAN_CONF_DIR/vassals\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    # Pause while the barbican-svc populates the database, otherwise the retry"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_179a54b9","line":206,"updated":"2015-06-10 16:19:42.000000000","message":"confused by that comment - does it work now?  looks like we did replace screen_it with run_process...","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9d0ca273c0cb923553f80e71ab40b89bfbb1de43","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # Start the Barbican service up."},{"line_number":204,"context_line":"    # TOOD(john-wood-) I\u0027ve noticed movement from \u0027screen_it\u0027 to"},{"line_number":205,"context_line":"    # \u0027run_process\u0027 in several OpenStack project commits to Devstack. My first"},{"line_number":206,"context_line":"    # attempt to just replace screen_it with run_process did not work though."},{"line_number":207,"context_line":"    run_process barbican-svc \"uwsgi --master --emperor $BARBICAN_CONF_DIR/vassals\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    # Pause while the barbican-svc populates the database, otherwise the retry"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_043e9927","line":206,"in_reply_to":"3afb71cf_179a54b9","updated":"2015-06-10 19:51:58.000000000","message":"Ha yeah, these comments need to be removed.","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"82d2e5930fc8ac3aa63e0f054f477fc56a6a8573","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    # Pause while the barbican-svc populates the database, otherwise the retry"},{"line_number":210,"context_line":"    # service below might try to do this at the same time, leading to race"},{"line_number":211,"context_line":"    # conditions."},{"line_number":212,"context_line":"    sleep 10"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    # Start the retry scheduler server up."},{"line_number":215,"context_line":"    run_process barbican-retry \"$BARBICAN_BIN_DIR/barbican-retry --config-file\u003d$BARBICAN_CONF_DIR/barbican-api.conf\""}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_b7eb80db","line":212,"updated":"2015-06-10 16:19:42.000000000","message":"yikes - seems scary.  What happens if 10 secs isn\u0027t enough?  Any way to synchronize this process?","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9d0ca273c0cb923553f80e71ab40b89bfbb1de43","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    # Pause while the barbican-svc populates the database, otherwise the retry"},{"line_number":210,"context_line":"    # service below might try to do this at the same time, leading to race"},{"line_number":211,"context_line":"    # conditions."},{"line_number":212,"context_line":"    sleep 10"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    # Start the retry scheduler server up."},{"line_number":215,"context_line":"    run_process barbican-retry \"$BARBICAN_BIN_DIR/barbican-retry --config-file\u003d$BARBICAN_CONF_DIR/barbican-api.conf\""}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_4e0b9224","line":212,"in_reply_to":"3afb71cf_b7eb80db","updated":"2015-06-10 19:51:58.000000000","message":"The right way to do this is to start the database process first, and then run the migration script, and then run the processes. Unfortunately all of that coordination is done this start function, so not sure what other choices we have?","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"82d2e5930fc8ac3aa63e0f054f477fc56a6a8573","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    sleep 10"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    # Start the retry scheduler server up."},{"line_number":215,"context_line":"    run_process barbican-retry \"$BARBICAN_BIN_DIR/barbican-retry --config-file\u003d$BARBICAN_CONF_DIR/barbican-api.conf\""},{"line_number":216,"context_line":"}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"# stop_barbican - Stop running processes"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_b7702041","line":215,"updated":"2015-06-10 16:19:42.000000000","message":"https://review.openstack.org/#/c/189434/ changes the name of the config file.  Sounds like we might want a dependency here?","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9d0ca273c0cb923553f80e71ab40b89bfbb1de43","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    sleep 10"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    # Start the retry scheduler server up."},{"line_number":215,"context_line":"    run_process barbican-retry \"$BARBICAN_BIN_DIR/barbican-retry --config-file\u003d$BARBICAN_CONF_DIR/barbican-api.conf\""},{"line_number":216,"context_line":"}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"# stop_barbican - Stop running processes"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"3afb71cf_4e7ef26a","line":215,"in_reply_to":"3afb71cf_b7702041","updated":"2015-06-10 19:51:58.000000000","message":"If that CR lands before this one, this will have to be updated for sure. I\u0027m hoping I beat that one in though! :)","commit_id":"5e451f4d9e26225d319c8cd78481a22d946a35e4"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"0774d18b06c7f8b9c304d6eaaf9f57990ffe5bf6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"## is_barbican_enabled"},{"line_number":78,"context_line":"#function is_barbican_enabled {"},{"line_number":79,"context_line":"#    [[ ,${ENABLED_SERVICES} \u003d~ ,\"barbican-\" ]] \u0026\u0026 return 0"},{"line_number":80,"context_line":"#    return 1"},{"line_number":81,"context_line":"#}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# cleanup_barbican - Remove residual data files, anything left over from previous"}],"source_content_type":"application/octet-stream","patch_set":29,"id":"9a41bdd9_ad7444cf","line":80,"updated":"2015-07-12 05:59:13.000000000","message":"Could you remove this commented code?","commit_id":"39db605d2d4dd3b1bb13425f01965dc5b6f6b60a"}]}
