)]}'
{"barbican/api/controllers/quotas.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"49c9b138ac0f9faab17c65e49f518e6df897f93c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from barbican.common import quota"},{"line_number":20,"context_line":"from barbican.common import utils"},{"line_number":21,"context_line":"from barbican.common import validators"},{"line_number":22,"context_line":"from barbican import i18n as u"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d utils.getLogger(__name__)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_986dcd34","line":22,"updated":"2015-07-06 21:15:12.000000000","message":"should this one be between lines 17 and 18 ?","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"6e3e87daf04947f0788dc5ad78dd84f395bb6c1d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from barbican.common import quota"},{"line_number":20,"context_line":"from barbican.common import utils"},{"line_number":21,"context_line":"from barbican.common import validators"},{"line_number":22,"context_line":"from barbican import i18n as u"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d utils.getLogger(__name__)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_f493a4f8","line":22,"in_reply_to":"ba3cc151_986dcd34","updated":"2015-07-07 13:27:37.000000000","message":"I tried, but the pep8 checker likes it here.  i after c: barbican.i18n after barbican.common.","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"49c9b138ac0f9faab17c65e49f518e6df897f93c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\"Handles quota retrieval requests.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, quota_repo\u003dNone):"},{"line_number":31,"context_line":"        LOG.debug(\u0027\u003d\u003d\u003d Creating QuotaController \u003d\u003d\u003d\u0027)"},{"line_number":32,"context_line":"        self.repo \u003d quota_repo"},{"line_number":33,"context_line":"        self.quota_driver \u003d quota.QuotaDriver()"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_584e65c2","line":31,"updated":"2015-07-06 21:15:12.000000000","message":"plural QuotasController to match class name","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"6e3e87daf04947f0788dc5ad78dd84f395bb6c1d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\"Handles quota retrieval requests.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, quota_repo\u003dNone):"},{"line_number":31,"context_line":"        LOG.debug(\u0027\u003d\u003d\u003d Creating QuotaController \u003d\u003d\u003d\u0027)"},{"line_number":32,"context_line":"        self.repo \u003d quota_repo"},{"line_number":33,"context_line":"        self.quota_driver \u003d quota.QuotaDriver()"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_34b10c90","line":31,"in_reply_to":"ba3cc151_584e65c2","updated":"2015-07-07 13:27:37.000000000","message":"Done","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"49c9b138ac0f9faab17c65e49f518e6df897f93c","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @index.when(method\u003d\u0027POST\u0027, template\u003d\u0027json\u0027)"},{"line_number":73,"context_line":"    @controllers.handle_exceptions(u._(\u0027Project Quotas\u0027))"},{"line_number":74,"context_line":"    @controllers.enforce_rbac(\u0027project_quotas:put\u0027)"},{"line_number":75,"context_line":"    def on_post(self, external_project_id, **kwargs):"},{"line_number":76,"context_line":"        LOG.debug(\u0027\u003d\u003d\u003d ProjectQuotasController POST \u003d\u003d\u003d\u0027)"},{"line_number":77,"context_line":"        api.load_body(pecan.request,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_3866012a","line":74,"updated":"2015-07-06 21:15:12.000000000","message":"should this project_quotas:post ?  I see put in the policy.json file but its only used for post.","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"6e3e87daf04947f0788dc5ad78dd84f395bb6c1d","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @index.when(method\u003d\u0027POST\u0027, template\u003d\u0027json\u0027)"},{"line_number":73,"context_line":"    @controllers.handle_exceptions(u._(\u0027Project Quotas\u0027))"},{"line_number":74,"context_line":"    @controllers.enforce_rbac(\u0027project_quotas:put\u0027)"},{"line_number":75,"context_line":"    def on_post(self, external_project_id, **kwargs):"},{"line_number":76,"context_line":"        LOG.debug(\u0027\u003d\u003d\u003d ProjectQuotasController POST \u003d\u003d\u003d\u0027)"},{"line_number":77,"context_line":"        api.load_body(pecan.request,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_f42f249f","line":74,"in_reply_to":"ba3cc151_3866012a","updated":"2015-07-07 13:27:37.000000000","message":"Done","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"49c9b138ac0f9faab17c65e49f518e6df897f93c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def __init__(self, project_quota_repo\u003dNone):"},{"line_number":105,"context_line":"        LOG.debug(\u0027\u003d\u003d\u003d Creating ProjectsQuotaController \u003d\u003d\u003d\u0027)"},{"line_number":106,"context_line":"        self.repo \u003d project_quota_repo"},{"line_number":107,"context_line":"        self.validator \u003d validators.ProjectQuotaValidator()"},{"line_number":108,"context_line":"        self.quota_driver \u003d quota.QuotaDriver()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @pecan.expose()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_384da199","line":107,"updated":"2015-07-06 21:15:12.000000000","message":"same validator as singluar ProjectQuotasController?","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"6e3e87daf04947f0788dc5ad78dd84f395bb6c1d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def __init__(self, project_quota_repo\u003dNone):"},{"line_number":105,"context_line":"        LOG.debug(\u0027\u003d\u003d\u003d Creating ProjectsQuotaController \u003d\u003d\u003d\u0027)"},{"line_number":106,"context_line":"        self.repo \u003d project_quota_repo"},{"line_number":107,"context_line":"        self.validator \u003d validators.ProjectQuotaValidator()"},{"line_number":108,"context_line":"        self.quota_driver \u003d quota.QuotaDriver()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @pecan.expose()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_f71de666","line":107,"in_reply_to":"ba3cc151_384da199","updated":"2015-07-07 13:27:37.000000000","message":"removed.  no validator needed here.","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027orders\u0027: 20,"},{"line_number":83,"context_line":"            \u0027containers\u0027: 10,"},{"line_number":84,"context_line":"            \u0027transport_keys\u0027: 10,"},{"line_number":85,"context_line":"            \u0027consumers\u0027: -1}"},{"line_number":86,"context_line":"        }"},{"line_number":87,"context_line":"        LOG.info(u._LI(\u0027Post Project Quotas\u0027))"},{"line_number":88,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_3c38e6ed","line":85,"updated":"2015-07-08 09:10:35.000000000","message":"why is there some sort of hard-coded response here instead of the \"get_defaults\", like it\u0027s implemented above?","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027orders\u0027: 20,"},{"line_number":83,"context_line":"            \u0027containers\u0027: 10,"},{"line_number":84,"context_line":"            \u0027transport_keys\u0027: 10,"},{"line_number":85,"context_line":"            \u0027consumers\u0027: -1}"},{"line_number":86,"context_line":"        }"},{"line_number":87,"context_line":"        LOG.info(u._LI(\u0027Post Project Quotas\u0027))"},{"line_number":88,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_b1479c76","line":85,"in_reply_to":"ba3cc151_3c38e6ed","updated":"2015-07-10 21:36:02.000000000","message":"This is just a stub until I implement the repository code.  It\u0027s marked above \"TODO(dave) implement\".","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        project1 \u003d {\u0027project_id\u0027: \"1234\","},{"line_number":125,"context_line":"                    \u0027project_quotas\u0027: self.quota_driver.get_defaults()}"},{"line_number":126,"context_line":"        project2 \u003d {\u0027project_id\u0027: \"5678\","},{"line_number":127,"context_line":"                    \u0027project_quotas\u0027: self.quota_driver.get_defaults()}"},{"line_number":128,"context_line":"        project_quotas \u003d {\"project_quotas\": [project1, project2]}"},{"line_number":129,"context_line":"        resp \u003d project_quotas"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_a227f0b4","line":127,"updated":"2015-07-08 09:10:35.000000000","message":"honestly I\u0027m not very keen on these hard-coded responses. I would rather have it not return anything, as if there were no quotas to get. Than to have fake project_id\u0027s. if you would still like to discuss how the responses should look like then you could write some documentation and it could be furtherly discussed there. Of course, if there\u0027s something you disagree that\u0027s in the blueprint.","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        project1 \u003d {\u0027project_id\u0027: \"1234\","},{"line_number":125,"context_line":"                    \u0027project_quotas\u0027: self.quota_driver.get_defaults()}"},{"line_number":126,"context_line":"        project2 \u003d {\u0027project_id\u0027: \"5678\","},{"line_number":127,"context_line":"                    \u0027project_quotas\u0027: self.quota_driver.get_defaults()}"},{"line_number":128,"context_line":"        project_quotas \u003d {\"project_quotas\": [project1, project2]}"},{"line_number":129,"context_line":"        resp \u003d project_quotas"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_b13ebcd8","line":127,"in_reply_to":"ba3cc151_a227f0b4","updated":"2015-07-10 21:36:02.000000000","message":"Just a temporary stub.  I\u0027ll remove it with next commit.","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"baba342a9ccf1aae8d6c8baf42558b3325717a44","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def __init__(self, quota_repo\u003dNone):"},{"line_number":31,"context_line":"        LOG.debug(\u0027\u003d\u003d\u003d Creating QuotasController \u003d\u003d\u003d\u0027)"},{"line_number":32,"context_line":"        self.repo \u003d quota_repo"},{"line_number":33,"context_line":"        self.quota_driver \u003d quota.QuotaDriver()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @pecan.expose(generic\u003dTrue)"},{"line_number":36,"context_line":"    def index(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_c11292b4","line":33,"updated":"2015-07-20 18:22:04.000000000","message":"Why do the controllers take a driver and a repo? I was expecting the driver to contain the repo reference and the controller would not have a reference. I was thinking a QuotaDriver is responsible for finding the quoatas. A specific quota driver would use the repo to find this information. Does that make sense?\n\nIs the QuotaDriver just for defaults?","commit_id":"ce5b32ac13de3bc0436e7836897d028ec1119171"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"8c347176a4e8d4da219eac62f3b94a449239cb06","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def __init__(self, quota_repo\u003dNone):"},{"line_number":31,"context_line":"        LOG.debug(\u0027\u003d\u003d\u003d Creating QuotasController \u003d\u003d\u003d\u0027)"},{"line_number":32,"context_line":"        self.repo \u003d quota_repo"},{"line_number":33,"context_line":"        self.quota_driver \u003d quota.QuotaDriver()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @pecan.expose(generic\u003dTrue)"},{"line_number":36,"context_line":"    def index(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_12ef63e9","line":33,"in_reply_to":"3a50d1a3_c11292b4","updated":"2015-07-20 19:44:30.000000000","message":"Yes, that\u0027s a better approach.  I\u0027d like to merge this for now, and implement this suggestion in my next commit where I implement the repository code.","commit_id":"ce5b32ac13de3bc0436e7836897d028ec1119171"}],"barbican/api/controllers/versions.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"49c9b138ac0f9faab17c65e49f518e6df897f93c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.transport_keys \u003d transportkeys.TransportKeysController()"},{"line_number":94,"context_line":"        self.cas \u003d cas.CertificateAuthoritiesController()"},{"line_number":95,"context_line":"        self.quotas \u003d quotas.QuotasController()"},{"line_number":96,"context_line":"        self.project_quotas \u003d quotas.ProjectsQuotasController()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        self.__controllers \u003d ["},{"line_number":99,"context_line":"            self.secrets,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_1831bd0b","line":96,"updated":"2015-07-06 21:15:12.000000000","message":"to be consistent should this be self.projects_quotas (plural)?  Or was this supposed to be the singular ProjectQuotasController?","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"6e3e87daf04947f0788dc5ad78dd84f395bb6c1d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.transport_keys \u003d transportkeys.TransportKeysController()"},{"line_number":94,"context_line":"        self.cas \u003d cas.CertificateAuthoritiesController()"},{"line_number":95,"context_line":"        self.quotas \u003d quotas.QuotasController()"},{"line_number":96,"context_line":"        self.project_quotas \u003d quotas.ProjectsQuotasController()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        self.__controllers \u003d ["},{"line_number":99,"context_line":"            self.secrets,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_77ab168a","line":96,"in_reply_to":"ba3cc151_1831bd0b","updated":"2015-07-07 13:27:37.000000000","message":"I think it should be like it is.  The variable (\"project_quotas\") always matches the URL resource (\"project-quotas\").  The top level controller needs to be the \"plural one\".","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c043e9c43bb16cba1ef1fd1d97661d5dc83587db","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            \u0027transport_keys\u0027: self.transport_keys,"},{"line_number":114,"context_line":"            \u0027cas\u0027: self.cas,"},{"line_number":115,"context_line":"            \u0027quotas\u0027: self.quotas,"},{"line_number":116,"context_line":"            \u0027project-quotas\u0027: self.project_quotas"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        if name in route_table:"},{"line_number":119,"context_line":"            return route_table[name]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_e808a7db","line":116,"updated":"2015-07-07 13:46:32.000000000","message":"I\u0027m a bit confused, hadn\u0027t you changed the blueprint to actually be \u0027project_quotas\u0027?","commit_id":"42f600e4207ffc83a10246a92bd6783c41c1ed8e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"ba4c9218dde9b29254fe78fd700e07ace07e5001","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            \u0027transport_keys\u0027: self.transport_keys,"},{"line_number":114,"context_line":"            \u0027cas\u0027: self.cas,"},{"line_number":115,"context_line":"            \u0027quotas\u0027: self.quotas,"},{"line_number":116,"context_line":"            \u0027project-quotas\u0027: self.project_quotas"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        if name in route_table:"},{"line_number":119,"context_line":"            return route_table[name]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_03784cf1","line":116,"in_reply_to":"ba3cc151_e808a7db","updated":"2015-07-07 14:10:50.000000000","message":"I changed the spec to use the hyphen for the URL resource, and underscores in the JSON fields.  This matches the OpenStack API-WG guidelines.","commit_id":"42f600e4207ffc83a10246a92bd6783c41c1ed8e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9f62368c049b992cb37ed3a501dd8b0c11c206aa","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.transport_keys \u003d transportkeys.TransportKeysController()"},{"line_number":94,"context_line":"        self.cas \u003d cas.CertificateAuthoritiesController()"},{"line_number":95,"context_line":"        self.quotas \u003d quotas.QuotasController()"},{"line_number":96,"context_line":"        self.project_quotas \u003d quotas.ProjectsQuotasController()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        self.__controllers \u003d ["},{"line_number":99,"context_line":"            self.secrets,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_49275512","line":96,"updated":"2015-07-07 14:40:17.000000000","message":"Actually... An alternative could be to do the following code bellow the declaration of self.project_quotas:\n\nsetattr(self, \u0027project-quotas\u0027, project_quotas)\n\nI think this would actually replace the need for the __getattr__ definition","commit_id":"0f196b1359102bf480068db4d8114982debb0e7f"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"b53e36903bcaf2d137c2d5bc3a9904bc8ee1efe3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.transport_keys \u003d transportkeys.TransportKeysController()"},{"line_number":94,"context_line":"        self.cas \u003d cas.CertificateAuthoritiesController()"},{"line_number":95,"context_line":"        self.quotas \u003d quotas.QuotasController()"},{"line_number":96,"context_line":"        self.project_quotas \u003d quotas.ProjectsQuotasController()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        self.__controllers \u003d ["},{"line_number":99,"context_line":"            self.secrets,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_41b717f5","line":96,"in_reply_to":"ba3cc151_49275512","updated":"2015-07-07 21:45:24.000000000","message":"Done","commit_id":"0f196b1359102bf480068db4d8114982debb0e7f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.transport_keys \u003d transportkeys.TransportKeysController()"},{"line_number":94,"context_line":"        self.cas \u003d cas.CertificateAuthoritiesController()"},{"line_number":95,"context_line":"        self.quotas \u003d quotas.QuotasController()"},{"line_number":96,"context_line":"        setattr(self, \u0027project-quotas\u0027, quotas.ProjectsQuotasController())"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @pecan.expose(generic\u003dTrue)"},{"line_number":99,"context_line":"    def index(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_a24e106d","line":96,"updated":"2015-07-08 09:10:35.000000000","message":"thanks for deleting the __controllers variable. I think I left it there cause it was gonna be used for the json-home stuff. But in the end I didn\u0027t need it.","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.transport_keys \u003d transportkeys.TransportKeysController()"},{"line_number":94,"context_line":"        self.cas \u003d cas.CertificateAuthoritiesController()"},{"line_number":95,"context_line":"        self.quotas \u003d quotas.QuotasController()"},{"line_number":96,"context_line":"        setattr(self, \u0027project-quotas\u0027, quotas.ProjectsQuotasController())"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @pecan.expose(generic\u003dTrue)"},{"line_number":99,"context_line":"    def index(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_d116e057","line":96,"in_reply_to":"ba3cc151_a24e106d","updated":"2015-07-10 21:36:02.000000000","message":"Done","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"}],"barbican/common/quota.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"49c9b138ac0f9faab17c65e49f518e6df897f93c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"quota_opts \u003d ["},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"},{"line_number":31,"context_line":"                help\u003d\u0027When True, quotas are enforced per project.\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027quota_secrets\u0027,"},{"line_number":33,"context_line":"               default\u003d500,"},{"line_number":34,"context_line":"               help\u003d\u0027Number of secrets allowed per project\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_f814194e","line":31,"updated":"2015-07-06 21:15:12.000000000","message":"is just per-project, or in general that quotas are enforced?  I thought it was the latter.","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"6e3e87daf04947f0788dc5ad78dd84f395bb6c1d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"quota_opts \u003d ["},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"},{"line_number":31,"context_line":"                help\u003d\u0027When True, quotas are enforced per project.\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027quota_secrets\u0027,"},{"line_number":33,"context_line":"               default\u003d500,"},{"line_number":34,"context_line":"               help\u003d\u0027Number of secrets allowed per project\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_77feb66c","line":31,"in_reply_to":"ba3cc151_f814194e","updated":"2015-07-07 13:27:37.000000000","message":"In general.  Enforcement is enabled for all by this boolean.  Done.","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        }"},{"line_number":66,"context_line":"        return quotas"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _is_unlimited_value(self, v):"},{"line_number":69,"context_line":"        \"\"\"A helper method to check for unlimited value.\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        return v \u003c\u003d UNLIMITED_VALUE"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_42406434","line":68,"updated":"2015-07-08 09:10:35.000000000","message":"I dig this method. Even if it\u0027s simple; the name is very descriptive. Good style! :D","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        }"},{"line_number":66,"context_line":"        return quotas"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _is_unlimited_value(self, v):"},{"line_number":69,"context_line":"        \"\"\"A helper method to check for unlimited value.\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        return v \u003c\u003d UNLIMITED_VALUE"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_5412be59","line":68,"in_reply_to":"ba3cc151_42406434","updated":"2015-07-10 21:36:02.000000000","message":"Done","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"}],"barbican/common/validators.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":865,"context_line":"                        \u0027containers\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":866,"context_line":"                        \u0027transport_keys\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":867,"context_line":"                        \u0027consumers\u0027: {\u0027type\u0027: \u0027integer\u0027}"},{"line_number":868,"context_line":"                    },"},{"line_number":869,"context_line":"                    \u0027additionalProperties\u0027: False"},{"line_number":870,"context_line":"                }"},{"line_number":871,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_62a248fe","line":868,"updated":"2015-07-08 09:10:35.000000000","message":"so, all of these properties are optional? I would have thought that \u0027project_quotas\u0027 be set as required, at least.","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":865,"context_line":"                        \u0027containers\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":866,"context_line":"                        \u0027transport_keys\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":867,"context_line":"                        \u0027consumers\u0027: {\u0027type\u0027: \u0027integer\u0027}"},{"line_number":868,"context_line":"                    },"},{"line_number":869,"context_line":"                    \u0027additionalProperties\u0027: False"},{"line_number":870,"context_line":"                }"},{"line_number":871,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_5495de85","line":868,"in_reply_to":"ba3cc151_62a248fe","updated":"2015-07-10 21:36:02.000000000","message":"Done","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"}],"barbican/tests/api/controllers/test_quotas.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        resp \u003d self.app.get(\u0027/quotas\u0027, params)"},{"line_number":26,"context_line":"        self.assertIn(\u0027quotas\u0027, resp.namespace)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_should_get_project_quotas(self):"},{"line_number":29,"context_line":"        params \u003d {}"},{"line_number":30,"context_line":"        resp \u003d self.app.get("},{"line_number":31,"context_line":"            \u0027/project-quotas/{0}\u0027.format(self.project_id),"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_8243cc12","line":28,"updated":"2015-07-08 09:10:35.000000000","message":"I think it would make it a bit more precise, if you re-name this to be \"test_shouuld_get_specific_project_quotas\"","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        resp \u003d self.app.get(\u0027/quotas\u0027, params)"},{"line_number":26,"context_line":"        self.assertIn(\u0027quotas\u0027, resp.namespace)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_should_get_project_quotas(self):"},{"line_number":29,"context_line":"        params \u003d {}"},{"line_number":30,"context_line":"        resp \u003d self.app.get("},{"line_number":31,"context_line":"            \u0027/project-quotas/{0}\u0027.format(self.project_id),"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_5494fe42","line":28,"in_reply_to":"ba3cc151_8243cc12","updated":"2015-07-10 21:36:02.000000000","message":"Done","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.assertEqual(200, resp.status_int)"},{"line_number":40,"context_line":"        self.assertIn(\u0027project_quotas\u0027, resp.namespace)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_should_post_project_quotas(self):"},{"line_number":43,"context_line":"        params \u003d {}"},{"line_number":44,"context_line":"        resp \u003d self.app.post_json("},{"line_number":45,"context_line":"            \u0027/project-quotas/{0}\u0027.format(self.project_id), params)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_02501cd3","line":42,"updated":"2015-07-08 09:10:35.000000000","message":"same here.","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.assertEqual(200, resp.status_int)"},{"line_number":40,"context_line":"        self.assertIn(\u0027project_quotas\u0027, resp.namespace)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_should_post_project_quotas(self):"},{"line_number":43,"context_line":"        params \u003d {}"},{"line_number":44,"context_line":"        resp \u003d self.app.post_json("},{"line_number":45,"context_line":"            \u0027/project-quotas/{0}\u0027.format(self.project_id), params)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_74910252","line":42,"in_reply_to":"ba3cc151_02501cd3","updated":"2015-07-10 21:36:02.000000000","message":"Done","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            \u0027/project-quotas/{0}\u0027.format(self.project_id), params)"},{"line_number":52,"context_line":"        self.assertEqual(204, resp.status_int)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_should_405_post_quotas(self):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        resp \u003d self.app.post(\u0027/quotas/\u0027, params, expect_errors\u003dTrue)"},{"line_number":57,"context_line":"        self.assertEqual(405, resp.status_int)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_c23234a7","line":54,"updated":"2015-07-08 09:10:35.000000000","message":"This test name is not very descriptive. why is it throwing \"not allowed\"? Perhaps you should rephrase the name to specify what\u0027s actually going on.","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            \u0027/project-quotas/{0}\u0027.format(self.project_id), params)"},{"line_number":52,"context_line":"        self.assertEqual(204, resp.status_int)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_should_405_post_quotas(self):"},{"line_number":55,"context_line":"        params \u003d {}"},{"line_number":56,"context_line":"        resp \u003d self.app.post(\u0027/quotas/\u0027, params, expect_errors\u003dTrue)"},{"line_number":57,"context_line":"        self.assertEqual(405, resp.status_int)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_149e7663","line":54,"in_reply_to":"ba3cc151_c23234a7","updated":"2015-07-10 21:36:02.000000000","message":"Done","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"}],"barbican/tests/common/test_quota.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        self.quota_driver \u003d quota.QuotaDriver()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_get_defaults(self):"},{"line_number":27,"context_line":"        self.quota_driver.get_defaults()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_is_unlimited_true(self):"},{"line_number":30,"context_line":"        self.assertTrue(self.quota_driver._is_unlimited_value(-1))"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_8228ac34","line":27,"updated":"2015-07-08 09:10:35.000000000","message":"what\u0027s actually being tested here?","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        self.quota_driver \u003d quota.QuotaDriver()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_get_defaults(self):"},{"line_number":27,"context_line":"        self.quota_driver.get_defaults()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_is_unlimited_true(self):"},{"line_number":30,"context_line":"        self.assertTrue(self.quota_driver._is_unlimited_value(-1))"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_f73af497","line":27,"in_reply_to":"ba3cc151_8228ac34","updated":"2015-07-10 21:36:02.000000000","message":"Done","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"}],"barbican/tests/common/test_validators.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":1360,"context_line":"    def test_should_raise_bad_data(self):"},{"line_number":1361,"context_line":"        self.assertRaises(excep.InvalidObject,"},{"line_number":1362,"context_line":"                          self.validator.validate,"},{"line_number":1363,"context_line":"                          self.bad_project_quotas)"},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_82df4c39","line":1363,"updated":"2015-07-08 09:10:35.000000000","message":"What about a test that receives a dict like this? {}","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":1360,"context_line":"    def test_should_raise_bad_data(self):"},{"line_number":1361,"context_line":"        self.assertRaises(excep.InvalidObject,"},{"line_number":1362,"context_line":"                          self.validator.validate,"},{"line_number":1363,"context_line":"                          self.bad_project_quotas)"},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_f77c34ed","line":1363,"in_reply_to":"ba3cc151_82df4c39","updated":"2015-07-10 21:36:02.000000000","message":"Done","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"}],"etc/barbican/barbican.conf":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"49c9b138ac0f9faab17c65e49f518e6df897f93c","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# number of containers allowed per project"},{"line_number":207,"context_line":"quota_containers \u003d -1"},{"line_number":208,"context_line":"# Note, a negative value signifies unlimited"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"# number of transport_keys allowed per project"},{"line_number":211,"context_line":"quota_transport_keys \u003d 100"}],"source_content_type":"text/plain","patch_set":2,"id":"ba3cc151_f8009968","line":208,"updated":"2015-07-06 21:15:12.000000000","message":"would be nice to have a comment up at the top of the Quotas section to say:\n\n1) all values are per-project\n2) negative value means unlimited","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"6e3e87daf04947f0788dc5ad78dd84f395bb6c1d","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# number of containers allowed per project"},{"line_number":207,"context_line":"quota_containers \u003d -1"},{"line_number":208,"context_line":"# Note, a negative value signifies unlimited"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"# number of transport_keys allowed per project"},{"line_number":211,"context_line":"quota_transport_keys \u003d 100"}],"source_content_type":"text/plain","patch_set":2,"id":"ba3cc151_fa906d97","line":208,"in_reply_to":"ba3cc151_f8009968","updated":"2015-07-07 13:27:37.000000000","message":"Done","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"}],"etc/barbican/policy.json":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"49c9b138ac0f9faab17c65e49f518e6df897f93c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"container_acls:get\": \"rule:all_but_audit and rule:container_project_match\","},{"line_number":70,"context_line":"    \"quotas:get\": \"rule:all_users\","},{"line_number":71,"context_line":"    \"project_quotas:get\": \"rule:admin\","},{"line_number":72,"context_line":"    \"project_quotas:put\": \"rule:admin\","},{"line_number":73,"context_line":"    \"project_quotas:delete\": \"rule:admin\""},{"line_number":74,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"ba3cc151_bb3c4bc0","line":72,"updated":"2015-07-06 21:15:12.000000000","message":"confusing that this one is used for post","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"6e3e87daf04947f0788dc5ad78dd84f395bb6c1d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"container_acls:get\": \"rule:all_but_audit and rule:container_project_match\","},{"line_number":70,"context_line":"    \"quotas:get\": \"rule:all_users\","},{"line_number":71,"context_line":"    \"project_quotas:get\": \"rule:admin\","},{"line_number":72,"context_line":"    \"project_quotas:put\": \"rule:admin\","},{"line_number":73,"context_line":"    \"project_quotas:delete\": \"rule:admin\""},{"line_number":74,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"ba3cc151_bad0a554","line":72,"in_reply_to":"ba3cc151_bb3c4bc0","updated":"2015-07-07 13:27:37.000000000","message":"fixed. changed to post.","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6af72c82d74a8d39950bc1e47b87ff2dcbe47917","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"container_acls:put_patch\": \"rule:container_project_admin or rule:container_project_creator\","},{"line_number":68,"context_line":"    \"container_acls:delete\": \"rule:container_project_admin or rule:container_project_creator\","},{"line_number":69,"context_line":"    \"container_acls:get\": \"rule:all_but_audit and rule:container_project_match\","},{"line_number":70,"context_line":"    \"quotas:get\": \"rule:all_users\","},{"line_number":71,"context_line":"    \"project_quotas:get\": \"rule:admin\","},{"line_number":72,"context_line":"    \"project_quotas:post\": \"rule:admin\","},{"line_number":73,"context_line":"    \"project_quotas:delete\": \"rule:admin\""}],"source_content_type":"application/json","patch_set":5,"id":"ba3cc151_42e62416","line":70,"updated":"2015-07-08 09:10:35.000000000","message":"was it in the blueprint that everybody can see the quotas?","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"1de967ce201adfffb805b91729b2da47d4666430","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"container_acls:put_patch\": \"rule:container_project_admin or rule:container_project_creator\","},{"line_number":68,"context_line":"    \"container_acls:delete\": \"rule:container_project_admin or rule:container_project_creator\","},{"line_number":69,"context_line":"    \"container_acls:get\": \"rule:all_but_audit and rule:container_project_match\","},{"line_number":70,"context_line":"    \"quotas:get\": \"rule:all_users\","},{"line_number":71,"context_line":"    \"project_quotas:get\": \"rule:admin\","},{"line_number":72,"context_line":"    \"project_quotas:post\": \"rule:admin\","},{"line_number":73,"context_line":"    \"project_quotas:delete\": \"rule:admin\""}],"source_content_type":"application/json","patch_set":5,"id":"ba3cc151_14051613","line":70,"in_reply_to":"ba3cc151_42e62416","updated":"2015-07-10 21:36:02.000000000","message":"yes.\nhttps://github.com/openstack/barbican-specs/blame/master/specs/liberty/quota-support-for-barbican-resources.rst#L202","commit_id":"282e9ba5d21bf3580794564f282089a0b199f24e"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"baba342a9ccf1aae8d6c8baf42558b3325717a44","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"container_acls:put_patch\": \"rule:container_project_admin or rule:container_project_creator\","},{"line_number":68,"context_line":"    \"container_acls:delete\": \"rule:container_project_admin or rule:container_project_creator\","},{"line_number":69,"context_line":"    \"container_acls:get\": \"rule:all_but_audit and rule:container_project_match\","},{"line_number":70,"context_line":"    \"quotas:get\": \"rule:all_users\","},{"line_number":71,"context_line":"    \"project_quotas:get\": \"rule:admin\","},{"line_number":72,"context_line":"    \"project_quotas:post\": \"rule:admin\","},{"line_number":73,"context_line":"    \"project_quotas:delete\": \"rule:admin\""}],"source_content_type":"application/json","patch_set":7,"id":"3a50d1a3_ecbb05c3","line":70,"updated":"2015-07-20 18:22:04.000000000","message":"The quotas controller simply returns the default quota limits for all projects, correct? I think the rule is correct but just want to verify because it has been a while since I saw the spec.","commit_id":"ce5b32ac13de3bc0436e7836897d028ec1119171"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"8c347176a4e8d4da219eac62f3b94a449239cb06","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"container_acls:put_patch\": \"rule:container_project_admin or rule:container_project_creator\","},{"line_number":68,"context_line":"    \"container_acls:delete\": \"rule:container_project_admin or rule:container_project_creator\","},{"line_number":69,"context_line":"    \"container_acls:get\": \"rule:all_but_audit and rule:container_project_match\","},{"line_number":70,"context_line":"    \"quotas:get\": \"rule:all_users\","},{"line_number":71,"context_line":"    \"project_quotas:get\": \"rule:admin\","},{"line_number":72,"context_line":"    \"project_quotas:post\": \"rule:admin\","},{"line_number":73,"context_line":"    \"project_quotas:delete\": \"rule:admin\""}],"source_content_type":"application/json","patch_set":7,"id":"3a50d1a3_32a4dfa4","line":70,"in_reply_to":"3a50d1a3_ecbb05c3","updated":"2015-07-20 19:44:30.000000000","message":"Per the spec, it returns the effective quota limits for the project derived from the scope of the token.  So, either the global defaults or set values for the user\u0027s project.","commit_id":"ce5b32ac13de3bc0436e7836897d028ec1119171"}],"functionaltests/api/v1/behaviors/quota_behaviors.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"49c9b138ac0f9faab17c65e49f518e6df897f93c","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def delete_project_quotas(self, project_id, extra_headers\u003dNone,"},{"line_number":98,"context_line":"                              use_auth\u003dTrue, user_name\u003dNone):"},{"line_number":99,"context_line":"        \"\"\"Handles getting default quotas"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        :param project_id: id of project whose quotas are to be deleted"},{"line_number":102,"context_line":"        :param extra_headers: extra HTTP headers for the REST request"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_5b909f95","line":99,"updated":"2015-07-06 21:15:12.000000000","message":"I think you mean \"Handles deleting project quotas\"","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"6e3e87daf04947f0788dc5ad78dd84f395bb6c1d","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def delete_project_quotas(self, project_id, extra_headers\u003dNone,"},{"line_number":98,"context_line":"                              use_auth\u003dTrue, user_name\u003dNone):"},{"line_number":99,"context_line":"        \"\"\"Handles getting default quotas"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        :param project_id: id of project whose quotas are to be deleted"},{"line_number":102,"context_line":"        :param extra_headers: extra HTTP headers for the REST request"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_9a5b61f6","line":99,"in_reply_to":"ba3cc151_5b909f95","updated":"2015-07-07 13:27:37.000000000","message":"Done","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"}],"functionaltests/api/v1/functional/test_quotas.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"49c9b138ac0f9faab17c65e49f518e6df897f93c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertEqual(-1, resp.model.quotas[\u0027containers\u0027])"},{"line_number":48,"context_line":"        self.assertEqual(100, resp.model.quotas[\u0027consumers\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_get_project_quota_list(self):"},{"line_number":51,"context_line":"        \"\"\"Get list of all project quotas\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        resp, project_quotas_list \u003d self.behaviors.get_project_quotas_list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_3b3a7b99","line":50,"updated":"2015-07-06 21:15:12.000000000","message":"for testing lists we have a class that makes it very easy - see https://github.com/openstack/barbican/blob/master/functionaltests/api/base.py#L65\n\nAlso, this would need some way to filter (by some type of name).  That would go (later, I assume) into the controller(s).","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"6e3e87daf04947f0788dc5ad78dd84f395bb6c1d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertEqual(-1, resp.model.quotas[\u0027containers\u0027])"},{"line_number":48,"context_line":"        self.assertEqual(100, resp.model.quotas[\u0027consumers\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_get_project_quota_list(self):"},{"line_number":51,"context_line":"        \"\"\"Get list of all project quotas\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        resp, project_quotas_list \u003d self.behaviors.get_project_quotas_list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_7ab69d8b","line":50,"in_reply_to":"ba3cc151_3b3a7b99","updated":"2015-07-07 13:27:37.000000000","message":"Thanks.  I\u0027ll use this when I add paging support to the controller.  Filtering is not part of the design, though.","commit_id":"ab6d3f4cdcc814983f8f23c384d457eea1b21417"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"baba342a9ccf1aae8d6c8baf42558b3325717a44","unresolved":false,"context_lines":[{"line_number":25,"context_line":"             \"containers\": 20}}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class QuotasTestCase(base.TestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(QuotasTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_6c529569","line":28,"updated":"2015-07-20 18:22:04.000000000","message":"What are your thoughts on having a different test class per controller? I thought it would make it easier to read because then it clearly demarcates each big test component.","commit_id":"ce5b32ac13de3bc0436e7836897d028ec1119171"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"8c347176a4e8d4da219eac62f3b94a449239cb06","unresolved":false,"context_lines":[{"line_number":25,"context_line":"             \"containers\": 20}}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class QuotasTestCase(base.TestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(QuotasTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_92ecd3c8","line":28,"in_reply_to":"3a50d1a3_6c529569","updated":"2015-07-20 19:44:30.000000000","message":"I like it.  I\u0027d like to merge this for now, though.  In this commit the quota code being exercised by these tests is mostly stubs.  I\u0027ll have better tests with better organization in the next commit.","commit_id":"ce5b32ac13de3bc0436e7836897d028ec1119171"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"baba342a9ccf1aae8d6c8baf42558b3325717a44","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.assertEqual(-1, resp.model.project_quotas[\u0027containers\u0027])"},{"line_number":74,"context_line":"        self.assertEqual(100, resp.model.project_quotas[\u0027consumers\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_set_project_quotas(self):"},{"line_number":77,"context_line":"        \"\"\"Get project quota information\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        request_model \u003d quota_models.ProjectQuotaRequestModel("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_acd65dc3","line":76,"updated":"2015-07-20 18:22:04.000000000","message":"For setter test cases I like to see the following steps.\n\n1. get current value and assert not what setting it to\n2. set the value\n3. get the value again and assert that it is equal to the set value","commit_id":"ce5b32ac13de3bc0436e7836897d028ec1119171"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"8c347176a4e8d4da219eac62f3b94a449239cb06","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.assertEqual(-1, resp.model.project_quotas[\u0027containers\u0027])"},{"line_number":74,"context_line":"        self.assertEqual(100, resp.model.project_quotas[\u0027consumers\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_set_project_quotas(self):"},{"line_number":77,"context_line":"        \"\"\"Get project quota information\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        request_model \u003d quota_models.ProjectQuotaRequestModel("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_12f0c38f","line":76,"in_reply_to":"3a50d1a3_acd65dc3","updated":"2015-07-20 19:44:30.000000000","message":"I like it. I\u0027d like to merge this for now, though. In this commit the setting code is stubbed out.  When I implement the setting code for real, I\u0027ll have real unit tests to go with it.","commit_id":"ce5b32ac13de3bc0436e7836897d028ec1119171"}]}
