)]}'
{"barbican/plugin/kmip_secret_store.py":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"0aafe84ab1ed1f2784d88d0abf01df6946c8ae8b","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            if (key_value_type \u003d\u003d KeyMaterialStruct or"},{"line_number":571,"context_line":"                    key_value_type \u003d\u003d KeyMaterial):"},{"line_number":572,"context_line":"                secret_value \u003d secret_block.key_value.key_material.value"},{"line_number":573,"context_line":"            else:"},{"line_number":574,"context_line":"                msg \u003d u._("},{"line_number":575,"context_line":"                    \"Unknown key value type received from KMIP \""},{"line_number":576,"context_line":"                    \"server, expected {key_value_struct} or \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_903a4b97","line":573,"updated":"2015-07-07 20:47:07.000000000","message":"Can you please add the LE here, too?","commit_id":"2e90701331676dccefb8d4139269c427c9ba34c7"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"4a4e143bf83b8dac4038153bae2b6b217f37be21","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            if (key_value_type \u003d\u003d KeyMaterialStruct or"},{"line_number":571,"context_line":"                    key_value_type \u003d\u003d KeyMaterial):"},{"line_number":572,"context_line":"                secret_value \u003d secret_block.key_value.key_material.value"},{"line_number":573,"context_line":"            else:"},{"line_number":574,"context_line":"                msg \u003d u._("},{"line_number":575,"context_line":"                    \"Unknown key value type received from KMIP \""},{"line_number":576,"context_line":"                    \"server, expected {key_value_struct} or \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_a1814391","line":573,"in_reply_to":"ba3cc151_903a4b97","updated":"2015-07-07 22:28:00.000000000","message":"Hey Kaitlin, since the \u0027msg\u0027 below is being reported up via line #584, then line #574 needs to use the more generic u._ form (i.e. so no change needed here)","commit_id":"2e90701331676dccefb8d4139269c427c9ba34c7"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"0aafe84ab1ed1f2784d88d0abf01df6946c8ae8b","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                return ss_alg"},{"line_number":720,"context_line":"        return None"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    def _raise_secret_general_exception(self, result):"},{"line_number":723,"context_line":"        msg \u003d u._("},{"line_number":724,"context_line":"            \"Status: {status}, Reason: {reason}, \""},{"line_number":725,"context_line":"            \"Message: {message}\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_902fab3d","line":722,"updated":"2015-07-07 20:47:07.000000000","message":"And here?","commit_id":"2e90701331676dccefb8d4139269c427c9ba34c7"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"4a4e143bf83b8dac4038153bae2b6b217f37be21","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                return ss_alg"},{"line_number":720,"context_line":"        return None"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    def _raise_secret_general_exception(self, result):"},{"line_number":723,"context_line":"        msg \u003d u._("},{"line_number":724,"context_line":"            \"Status: {status}, Reason: {reason}, \""},{"line_number":725,"context_line":"            \"Message: {message}\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_a1586357","line":722,"in_reply_to":"ba3cc151_902fab3d","updated":"2015-07-07 22:28:00.000000000","message":"See comments above","commit_id":"2e90701331676dccefb8d4139269c427c9ba34c7"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"0aafe84ab1ed1f2784d88d0abf01df6946c8ae8b","unresolved":false,"context_lines":[{"line_number":727,"context_line":"            status\u003dresult.result_status,"},{"line_number":728,"context_line":"            reason\u003dresult.result_reason,"},{"line_number":729,"context_line":"            message\u003dresult.result_message"},{"line_number":730,"context_line":"        )"},{"line_number":731,"context_line":"        LOG.debug(\"ERROR from KMIP server: %s\", msg)"},{"line_number":732,"context_line":"        raise ss.SecretGeneralException(msg)"},{"line_number":733,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_50e043fa","line":730,"updated":"2015-07-07 20:47:07.000000000","message":"Can you please change this to an error message instead?","commit_id":"2e90701331676dccefb8d4139269c427c9ba34c7"}]}
