)]}'
{"functionaltests/api/v1/functional/test_acls_rbac.py":[{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"2d3acac91ac215cfb8371a459dca7fd960dbd16e","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        status \u003d self.set_secret_acl(secret_ref, get_an_acl())"},{"line_number":139,"context_line":"        self.assertEqual(200, status)"},{"line_number":140,"context_line":"        resp \u003d self.acl_behaviors.get_acl(secret_ref + \u0027/acl\u0027, user_name\u003duser)"},{"line_number":141,"context_line":"        self.assertEqual(expected_return, resp.status_code)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @utils.parameterized_dataset(test_data_update_secret_acl)"},{"line_number":144,"context_line":"    def test_update_secret_acl(self, user, expected_return):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_bb4a7053","line":141,"updated":"2015-07-15 22:24:02.000000000","message":"I think a check to make sure that the returned ACL string is what you expect would also be good. That way you know you correctly received it and not just a good status code.","commit_id":"569c3f3771a5d8550288261ce758da29f5b66687"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"fafd2f565e30240563c5a6cddb383081e56f99c9","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        status \u003d self.set_secret_acl(secret_ref, get_an_acl())"},{"line_number":139,"context_line":"        self.assertEqual(200, status)"},{"line_number":140,"context_line":"        resp \u003d self.acl_behaviors.get_acl(secret_ref + \u0027/acl\u0027, user_name\u003duser)"},{"line_number":141,"context_line":"        self.assertEqual(expected_return, resp.status_code)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @utils.parameterized_dataset(test_data_update_secret_acl)"},{"line_number":144,"context_line":"    def test_update_secret_acl(self, user, expected_return):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_859b5472","line":141,"in_reply_to":"9a41bdd9_bb4a7053","updated":"2015-07-16 20:39:11.000000000","message":"Done","commit_id":"569c3f3771a5d8550288261ce758da29f5b66687"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"2d3acac91ac215cfb8371a459dca7fd960dbd16e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self.assertEqual(200, status)"},{"line_number":148,"context_line":"        status \u003d self.update_secret_acl(secret_ref, get_an_acl(),"},{"line_number":149,"context_line":"                                        user_name\u003duser)"},{"line_number":150,"context_line":"        self.assertEqual(expected_return, status)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    @utils.parameterized_dataset(test_data_delete_secret_acl)"},{"line_number":153,"context_line":"    def test_delete_secret_acl(self, user, expected_return):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_7b7708a0","line":150,"updated":"2015-07-15 22:24:02.000000000","message":"Similar comment to above in that it would be good to get it and then check that it was actually updated.","commit_id":"569c3f3771a5d8550288261ce758da29f5b66687"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"fafd2f565e30240563c5a6cddb383081e56f99c9","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self.assertEqual(200, status)"},{"line_number":148,"context_line":"        status \u003d self.update_secret_acl(secret_ref, get_an_acl(),"},{"line_number":149,"context_line":"                                        user_name\u003duser)"},{"line_number":150,"context_line":"        self.assertEqual(expected_return, status)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    @utils.parameterized_dataset(test_data_delete_secret_acl)"},{"line_number":153,"context_line":"    def test_delete_secret_acl(self, user, expected_return):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_c5915c54","line":150,"in_reply_to":"9a41bdd9_7b7708a0","updated":"2015-07-16 20:39:11.000000000","message":"Done","commit_id":"569c3f3771a5d8550288261ce758da29f5b66687"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"2d3acac91ac215cfb8371a459dca7fd960dbd16e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.assertEqual(200, status)"},{"line_number":157,"context_line":"        resp \u003d self.acl_behaviors.delete_acl(secret_ref + \u0027/acl\u0027,"},{"line_number":158,"context_line":"                                             user_name\u003duser)"},{"line_number":159,"context_line":"        self.assertEqual(expected_return, resp.status_code)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @utils.parameterized_dataset(test_data_set_container_acl)"},{"line_number":162,"context_line":"    def test_set_container_acl(self, user, expected_return):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_5b7004a4","line":159,"updated":"2015-07-15 22:24:02.000000000","message":"Here you could add check to try and get ACL and verify that nothing is returned.","commit_id":"569c3f3771a5d8550288261ce758da29f5b66687"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"fafd2f565e30240563c5a6cddb383081e56f99c9","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.assertEqual(200, status)"},{"line_number":157,"context_line":"        resp \u003d self.acl_behaviors.delete_acl(secret_ref + \u0027/acl\u0027,"},{"line_number":158,"context_line":"                                             user_name\u003duser)"},{"line_number":159,"context_line":"        self.assertEqual(expected_return, resp.status_code)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @utils.parameterized_dataset(test_data_set_container_acl)"},{"line_number":162,"context_line":"    def test_set_container_acl(self, user, expected_return):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_a5945844","line":159,"in_reply_to":"9a41bdd9_5b7004a4","updated":"2015-07-16 20:39:11.000000000","message":"Done","commit_id":"569c3f3771a5d8550288261ce758da29f5b66687"}]}
