)]}'
{".coveragerc":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"69f4aad456e8970b862407c25b1df3f9f328e477","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a4dcd0f_5b022340","side":"PARENT","updated":"2015-08-03 14:09:39.000000000","message":"uh... why is this being deleted?","commit_id":"0659d561189b70fe7939bd1a9b7b252841782629"}],"barbican/api/controllers/orders.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"69f4aad456e8970b862407c25b1df3f9f328e477","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self.order \u003d order"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            self.order \u003d objects.Order.get_if_exist(order)"},{"line_number":75,"context_line":"        # To be deleted?"},{"line_number":76,"context_line":"        self.order_repo \u003d repo.get_order_repository()"},{"line_number":77,"context_line":"        self.queue \u003d queue_resource or async_client.TaskClient()"},{"line_number":78,"context_line":"        self.type_order_validator \u003d validators.TypeOrderValidator()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_3b7e37af","line":75,"updated":"2015-08-03 14:09:39.000000000","message":"This is unnecessary, the way it\u0027s being done is that this object is being created on the _lookup function of the OrdersControllers which is below this class. You actually even changed that function yourself. If that _lookup would fail to get this object, it should return a 404. So it seems to me like that section enclosed in the comment should actually be deleted.","commit_id":"4ef4506e4fca3c24b84de96c8ae310b83ea63c07"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"69f4aad456e8970b862407c25b1df3f9f328e477","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                                        suppress_exception\u003dTrue)"},{"line_number":147,"context_line":"        # order \u003d self.order_repo.get(entity_id\u003dorder_id,"},{"line_number":148,"context_line":"        #                             external_project_id\u003dctx.project,"},{"line_number":149,"context_line":"        #                             suppress_exception\u003dTrue)"},{"line_number":150,"context_line":"        if not order:"},{"line_number":151,"context_line":"            _order_not_found()"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_3e1aa56f","line":149,"updated":"2015-08-03 14:09:39.000000000","message":"please don\u0027t leave commented code.","commit_id":"4ef4506e4fca3c24b84de96c8ae310b83ea63c07"}],"barbican/tasks/resources.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"69f4aad456e8970b862407c25b1df3f9f328e477","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        name \u003d self.get_name()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        result \u003d None"},{"line_number":91,"context_line":"        # Retrieve the target entity (such as an models.Order instance)."},{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            entity \u003d self.retrieve_entity(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_febe7dd3","line":90,"updated":"2015-08-03 14:09:39.000000000","message":"why?","commit_id":"4ef4506e4fca3c24b84de96c8ae310b83ea63c07"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"69f4aad456e8970b862407c25b1df3f9f328e477","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                LOG.exception(u._LE(\"Problem handling an error for task \u0027%s\u0027, \""},{"line_number":116,"context_line":"                                    \"raising original \""},{"line_number":117,"context_line":"                                    \"exception.\"), name)"},{"line_number":118,"context_line":"                raise e_orig"},{"line_number":119,"context_line":"        # Handle successful conclusion of processing."},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            self.handle_success(entity, result, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_beb8f5e6","line":118,"updated":"2015-08-03 14:09:39.000000000","message":"This seems quite unnecessary and distract the reader from the real intent of your CR","commit_id":"4ef4506e4fca3c24b84de96c8ae310b83ea63c07"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"69f4aad456e8970b862407c25b1df3f9f328e477","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self.helper \u003d _OrderTaskHelper()"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def retrieve_entity(self, order, *args, **kwargs):"},{"line_number":244,"context_line":"        return order"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def handle_processing(self, order, *args, **kwargs):"},{"line_number":247,"context_line":"        return self.handle_order(order)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_1ead6988","line":244,"updated":"2015-08-03 14:09:39.000000000","message":"well, if you have already changed a bunch of code why not remove this function entirely?","commit_id":"4ef4506e4fca3c24b84de96c8ae310b83ea63c07"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"69f4aad456e8970b862407c25b1df3f9f328e477","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        result_follow_on \u003d common.FollowOnProcessingStatusDTO()"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        order_type \u003d order.get(\u0027type\u0027)"},{"line_number":267,"context_line":"        meta_info \u003d order.get(\u0027meta\u0027)"},{"line_number":268,"context_line":"        if order.get(\u0027creator_id\u0027):"},{"line_number":269,"context_line":"            meta_info.setdefault(\u0027creator_id\u0027, order.get(\u0027creator_id\u0027))"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_de94e1e9","line":267,"updated":"2015-08-03 14:09:39.000000000","message":"wouldn\u0027t it be according to the new contract you introduced, that order should be an order object? Then why do an order.get(key)? It used to be the case that order_info was a json struct, that\u0027s why the gets were needed.","commit_id":"4ef4506e4fca3c24b84de96c8ae310b83ea63c07"}]}
