)]}'
{"barbican/model/migration/alembic_migrations/versions/795737bb3c3_change_tenants_to_projects.py":[{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"ab05b1baddce38e7716a66979d7be0b0d0f99d7c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                    new_column_name\u003d\u0027project_id\u0027)"},{"line_number":30,"context_line":"    op.create_foreign_key(fk_new, table,"},{"line_number":31,"context_line":"                          \u0027projects\u0027, [\u0027project_id\u0027], [\u0027id\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def _change_fk_to_tenant(ctx, con, table, fk_old):"},{"line_number":35,"context_line":"    _drop_constraint(ctx, con, table, fk_old)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_02a8e775","line":32,"updated":"2015-08-06 18:16:31.000000000","message":"The _change_fk_to_tenant method was only called in the downgrade method so I think it should also be removed.","commit_id":"addd203666f236760c2465ebe4e144ea1bbf85d1"}],"barbican/tests/model/repositories/test_repositories.py":[{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"c3558022faf800be56878cefdf0115e3cf129462","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        self.assertTrue(result)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"class TestWalkMigrations(utils.BaseTestCase):"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_2e57e126","line":330,"updated":"2015-08-07 14:58:56.000000000","message":"I don\u0027t know if this is a big need but should the tile be changed to conform to other tests? Like \"WhenTestingMigrations\" or something along that line.","commit_id":"18ddab0dae3aae728c030f862d526b38bc8d3513"}],"doc/source/contribute/database_migrations.rst":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"5457095fed5b54cc019f8819ab757631d87058fe","unresolved":false,"context_lines":[{"line_number":159,"context_line":"   Note that only the first 20 characters of the description are used."},{"line_number":160,"context_line":"3. You can then edit this file per tutorial and the `Alembic Operation"},{"line_number":161,"context_line":"   Reference`_ page for available operations you may make from the version"},{"line_number":162,"context_line":"   files. **You must properly fill in the** ``upgrade()``**methods.**"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Applying Changes"},{"line_number":165,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_1424e5c2","line":162,"updated":"2015-08-11 15:42:08.000000000","message":"This does not get rendered correctly -- probably needs a space between `` and **.","commit_id":"bf2857a9cb068708b604a93ae7abbd7d1206323f"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"bd357cf94ff8c5ebb30aeb4d1be39f1db7510166","unresolved":false,"context_lines":[{"line_number":159,"context_line":"   Note that only the first 20 characters of the description are used."},{"line_number":160,"context_line":"3. You can then edit this file per tutorial and the `Alembic Operation"},{"line_number":161,"context_line":"   Reference`_ page for available operations you may make from the version"},{"line_number":162,"context_line":"   files. **You must properly fill in the** ``upgrade()``**methods.**"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Applying Changes"},{"line_number":165,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_d2cbd6a2","line":162,"in_reply_to":"1a4dcd0f_1424e5c2","updated":"2015-08-12 03:00:36.000000000","message":"Done","commit_id":"bf2857a9cb068708b604a93ae7abbd7d1206323f"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"5457095fed5b54cc019f8819ab757631d87058fe","unresolved":false,"context_lines":[{"line_number":175,"context_line":"above be used to update the database schema per the \u0027Manually\u0027 section. Also,"},{"line_number":176,"context_line":"automatic database updates from the Barbican application should be disabled by"},{"line_number":177,"context_line":"adding/updating ``db_auto_create \u003d False`` in the ``barbican.conf``"},{"line_number":178,"context_line":"configuration file."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Via Application"},{"line_number":181,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_373803ee","line":178,"updated":"2015-08-11 15:42:08.000000000","message":"Please add here, something like:\n\n**Note** : Before attempting any upgrade, you should make a full database backup of your production data. As of Kilo, database downgrades are not supported in OpenStack, and the only method available to get back to a prior database version will be to restore from backup.","commit_id":"bf2857a9cb068708b604a93ae7abbd7d1206323f"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"bd357cf94ff8c5ebb30aeb4d1be39f1db7510166","unresolved":false,"context_lines":[{"line_number":175,"context_line":"above be used to update the database schema per the \u0027Manually\u0027 section. Also,"},{"line_number":176,"context_line":"automatic database updates from the Barbican application should be disabled by"},{"line_number":177,"context_line":"adding/updating ``db_auto_create \u003d False`` in the ``barbican.conf``"},{"line_number":178,"context_line":"configuration file."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Via Application"},{"line_number":181,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_524fc633","line":178,"in_reply_to":"1a4dcd0f_373803ee","updated":"2015-08-12 03:00:36.000000000","message":"Done","commit_id":"bf2857a9cb068708b604a93ae7abbd7d1206323f"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"5457095fed5b54cc019f8819ab757631d87058fe","unresolved":false,"context_lines":[{"line_number":231,"context_line":"2. Restore databases from backup."},{"line_number":232,"context_line":"3. Roll back packages."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"The upgrade instructions provided in earlier sections ensure that you have"},{"line_number":235,"context_line":"proper backups of your databases and configuration files. Read through this"},{"line_number":236,"context_line":"section carefully and verify that you have the requisite backups to restore."},{"line_number":237,"context_line":"Rolling back upgrades is a tricky process because distributions tend to put"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_b71df3bf","line":234,"updated":"2015-08-11 15:42:08.000000000","message":"Because these instructions are from the Downgrade tutorial linked below, this references \u0027upgrade instructions provided in earlier sections\u0027, but the earlier sections in this document don\u0027t really mention needing backups.  I\u0027d suggest making this section more of a brief summary, linking to the Downgrade tutorial, and adding a few lines in the earlier sections about needing backups.","commit_id":"bf2857a9cb068708b604a93ae7abbd7d1206323f"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"bd357cf94ff8c5ebb30aeb4d1be39f1db7510166","unresolved":false,"context_lines":[{"line_number":231,"context_line":"2. Restore databases from backup."},{"line_number":232,"context_line":"3. Roll back packages."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"The upgrade instructions provided in earlier sections ensure that you have"},{"line_number":235,"context_line":"proper backups of your databases and configuration files. Read through this"},{"line_number":236,"context_line":"section carefully and verify that you have the requisite backups to restore."},{"line_number":237,"context_line":"Rolling back upgrades is a tricky process because distributions tend to put"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_555c9018","line":234,"in_reply_to":"1a4dcd0f_b71df3bf","updated":"2015-08-12 03:00:36.000000000","message":"Done","commit_id":"bf2857a9cb068708b604a93ae7abbd7d1206323f"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"ddfb5285812d11c356df166926936fb744f6b8eb","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Rolling back upgrades is a tricky process because distributions tend to put"},{"line_number":230,"context_line":"much more effort into testing upgrades than downgrades. Broken downgrades"},{"line_number":231,"context_line":"often take significantly more effort to troubleshoot and, hopefully, resolve"},{"line_number":232,"context_line":"than broken upgrades. Only you can weigh the risks of trying to push a failed"},{"line_number":233,"context_line":"upgrade forward versus rolling it back. Generally, consider rolling back as the"},{"line_number":234,"context_line":"very last option."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a4dcd0f_cfa1d2f8","line":231,"updated":"2015-08-12 14:31:24.000000000","message":"Using hopefully seems odd here, since it refers to downgrades requiring \"significantly more effort\". Suggest cutting \"hopefully\" and leaving just \"...troubleshoot and resolve...\".","commit_id":"ed7598ff70750371372c75a75147b6cf0ac4820c"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"ddfb5285812d11c356df166926936fb744f6b8eb","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"**Note** : The backup tutorial reference file only updated to Juno, the DB backup"},{"line_number":241,"context_line":"will be similar for Kilo, the link will be updated when the reference has"},{"line_number":242,"context_line":"updated."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"For more information and examples about downgrade operation please"},{"line_number":245,"context_line":"see `Downgrade tutorial`_ as reference."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a4dcd0f_4f8dc27a","line":242,"updated":"2015-08-12 14:31:24.000000000","message":"This note is a couple of sentences but is formatted as a single sentence. Suggest reformatting for clarity.","commit_id":"ed7598ff70750371372c75a75147b6cf0ac4820c"}]}
