)]}'
{"etc/barbican/barbican.conf":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"022eb4805ba361338c5c5e8f9de314881b3c1c1d","unresolved":false,"context_lines":[{"line_number":307,"context_line":"[certificate]"},{"line_number":308,"context_line":"namespace \u003d barbican.certificate.plugin"},{"line_number":309,"context_line":"enabled_certificate_plugins \u003d simple_certificate"},{"line_number":310,"context_line":"enabled_certificate_plugins \u003d snakeoil_ca"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"[certificate_event]"},{"line_number":313,"context_line":"namespace \u003d barbican.certificate.event.plugin"}],"source_content_type":"text/plain","patch_set":20,"id":"da20952f_0a408206","line":310,"updated":"2015-09-09 17:07:17.000000000","message":"Looks like this was left over from debugging/testing?","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"1ccb77269b337861e5780af73ed4a94fc0b67b69","unresolved":false,"context_lines":[{"line_number":307,"context_line":"[certificate]"},{"line_number":308,"context_line":"namespace \u003d barbican.certificate.plugin"},{"line_number":309,"context_line":"enabled_certificate_plugins \u003d simple_certificate"},{"line_number":310,"context_line":"enabled_certificate_plugins \u003d snakeoil_ca"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"[certificate_event]"},{"line_number":313,"context_line":"namespace \u003d barbican.certificate.event.plugin"}],"source_content_type":"text/plain","patch_set":20,"id":"da20952f_2ab8e674","line":310,"in_reply_to":"da20952f_0a408206","updated":"2015-09-09 17:15:53.000000000","message":"No this is deliberate,  This is what is read when running the functional tests.  This is a multistring option.","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a9b3c03eefe95e62a75bb9894edac88bc56a8d0a","unresolved":false,"context_lines":[{"line_number":307,"context_line":"[certificate]"},{"line_number":308,"context_line":"namespace \u003d barbican.certificate.plugin"},{"line_number":309,"context_line":"enabled_certificate_plugins \u003d simple_certificate"},{"line_number":310,"context_line":"enabled_certificate_plugins \u003d snakeoil_ca"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"[certificate_event]"},{"line_number":313,"context_line":"namespace \u003d barbican.certificate.event.plugin"}],"source_content_type":"text/plain","patch_set":20,"id":"da20952f_4d78d4f8","line":310,"in_reply_to":"da20952f_0a408206","updated":"2015-09-09 17:26:58.000000000","message":"This also confused me initially. But no, the snakeoil CA plugin is now officially being tested in the functional tests :D.\n\nSince enabled_certificate_plugins is a MultiStrOpt as defined by oslo.cfg. This syntax is correct, and thus there are two plugins set up.","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"}],"functionaltests/api/v1/functional/test_cas.py":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"022eb4805ba361338c5c5e8f9de314881b3c1c1d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    return \u0027snakeoil_ca\u0027 in CONF.certificate.enabled_certificate_plugins"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def convert_to_X509Name(dn):"},{"line_number":51,"context_line":"    target \u003d crypto.X509Name()"},{"line_number":52,"context_line":"    fields \u003d dn.split(\u0027,\u0027)"},{"line_number":53,"context_line":"    for field in fields:"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_2a0ea68c","line":50,"updated":"2015-09-09 17:07:17.000000000","message":"This looks like the same code that was used in the last merge request: https://review.openstack.org/#/c/220011/19/barbican/plugin/snakeoil_ca.py\n\nIt would be nice if that code could be shared, so that the code isn\u0027t duplicated, but you\u0027re planning on exchanging it with cryptography code,  right?  Are you planning on doing that after the rest of this code is in?","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"1ccb77269b337861e5780af73ed4a94fc0b67b69","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    return \u0027snakeoil_ca\u0027 in CONF.certificate.enabled_certificate_plugins"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def convert_to_X509Name(dn):"},{"line_number":51,"context_line":"    target \u003d crypto.X509Name()"},{"line_number":52,"context_line":"    fields \u003d dn.split(\u0027,\u0027)"},{"line_number":53,"context_line":"    for field in fields:"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_ea718edf","line":50,"in_reply_to":"da20952f_2a0ea68c","updated":"2015-09-09 17:15:53.000000000","message":"yes -- this will all be replaced with cryptography after all this is merged in.  As this code is only used in either tests or the development CA, I\u0027m going to prioritize getting all the required functionality in first.","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"022eb4805ba361338c5c5e8f9de314881b3c1c1d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.simple_cmc_data \u003d copy.deepcopy(order_simple_cmc_request_data)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # we need to prime the pump ie. populate the CA table by sending"},{"line_number":89,"context_line":"        # in an order (just in case)"},{"line_number":90,"context_line":"        self.send_test_order()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_2a5c667c","line":89,"updated":"2015-09-09 17:07:17.000000000","message":"By priming the pump, does that mean you are ensuring that everything actually is configured correctly?  Or is there some strange race condition where the first order might fail?","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"1ccb77269b337861e5780af73ed4a94fc0b67b69","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.simple_cmc_data \u003d copy.deepcopy(order_simple_cmc_request_data)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # we need to prime the pump ie. populate the CA table by sending"},{"line_number":89,"context_line":"        # in an order (just in case)"},{"line_number":90,"context_line":"        self.send_test_order()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_6a1a5e7e","line":89,"in_reply_to":"da20952f_2a5c667c","updated":"2015-09-09 17:15:53.000000000","message":"The way things work now.  The ca table is populated by interrogating the plugin when the first cert order is created.\n\nI have no idea which tst will run first - and its likely the pump will already be primed, but just in case ..","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"3b0764b0cd41e2796bed73dcf67827f10a5d215d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        # self.verify_signing_cert("},{"line_number":168,"context_line":"        #    ca_ref\u003dca_ref,"},{"line_number":169,"context_line":"        #    subject_dn\u003dconvert_to_X509Name(self.subca_subject),"},{"line_number":170,"context_line":"        #    issuer_dn\u003droot_subject)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @testtools.skipIf(not is_snakeoil_enabled(),"},{"line_number":173,"context_line":"                      \"This test is only usable with snakeoil\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_16ad129b","line":170,"updated":"2015-09-09 16:38:13.000000000","message":"Do these commented blocks need to stay?","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"022eb4805ba361338c5c5e8f9de314881b3c1c1d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        # self.verify_signing_cert("},{"line_number":168,"context_line":"        #    ca_ref\u003dca_ref,"},{"line_number":169,"context_line":"        #    subject_dn\u003dconvert_to_X509Name(self.subca_subject),"},{"line_number":170,"context_line":"        #    issuer_dn\u003droot_subject)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @testtools.skipIf(not is_snakeoil_enabled(),"},{"line_number":173,"context_line":"                      \"This test is only usable with snakeoil\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_aa4876b4","line":170,"in_reply_to":"da20952f_16ad129b","updated":"2015-09-09 17:07:17.000000000","message":"+1, if they are going to be used by a later merge request, please add a TODO","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"1ccb77269b337861e5780af73ed4a94fc0b67b69","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        # self.verify_signing_cert("},{"line_number":168,"context_line":"        #    ca_ref\u003dca_ref,"},{"line_number":169,"context_line":"        #    subject_dn\u003dconvert_to_X509Name(self.subca_subject),"},{"line_number":170,"context_line":"        #    issuer_dn\u003droot_subject)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @testtools.skipIf(not is_snakeoil_enabled(),"},{"line_number":173,"context_line":"                      \"This test is only usable with snakeoil\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_0da41c06","line":170,"in_reply_to":"da20952f_aa4876b4","updated":"2015-09-09 17:15:53.000000000","message":"Ok - I\u0027ll add a TODO.  Yes the plan to add this code in a merge request next week.","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"3b0764b0cd41e2796bed73dcf67827f10a5d215d","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        # self.verify_signing_cert("},{"line_number":185,"context_line":"        #    ca_ref\u003dchild_ref,"},{"line_number":186,"context_line":"        #    subject_dn\u003dconvert_to_X509Name(self.subca_subca_subject),"},{"line_number":187,"context_line":"        #    issuer_dn\u003dparent_subject)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_create_subca_with_invalid_parent_ca_id(self):"},{"line_number":190,"context_line":"        ca_model \u003d self.get_snakeoil_subca_model()"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_b6946644","line":187,"updated":"2015-09-09 16:38:13.000000000","message":"Ditto.","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"1ccb77269b337861e5780af73ed4a94fc0b67b69","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        # self.verify_signing_cert("},{"line_number":185,"context_line":"        #    ca_ref\u003dchild_ref,"},{"line_number":186,"context_line":"        #    subject_dn\u003dconvert_to_X509Name(self.subca_subca_subject),"},{"line_number":187,"context_line":"        #    issuer_dn\u003dparent_subject)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_create_subca_with_invalid_parent_ca_id(self):"},{"line_number":190,"context_line":"        ca_model \u003d self.get_snakeoil_subca_model()"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_2d7ec06a","line":187,"in_reply_to":"da20952f_b6946644","updated":"2015-09-09 17:15:53.000000000","message":"same as above.","commit_id":"53e681638f74715ad121fba7b93922ff880f024c"}]}
