)]}'
{"barbican/tests/common/test_validators.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"31cc6a22f9833456bcf37656c8da081c54b703f4","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            self.secret_req,"},{"line_number":260,"context_line":"        )"},{"line_number":261,"context_line":"        self.assertEqual(\u0027bit_length\u0027, exception.invalid_property)"},{"line_number":262,"context_line":"        self.assertIn(\u0027bit_length\u0027, exception.message)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_should_raise_bit_length_greater_than_max(self):"},{"line_number":265,"context_line":"        self.secret_req[\u0027bit_length\u0027] \u003d 32768"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_ffadd39b","line":262,"updated":"2015-10-27 05:57:42.000000000","message":"Can you also add a test with negative values?","commit_id":"af7965026786e23e1d8556be8fd02f9174aceb92"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e2b7a714258d44933ab262093fd2f18df1a8b8a2","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            self.secret_req,"},{"line_number":260,"context_line":"        )"},{"line_number":261,"context_line":"        self.assertEqual(\u0027bit_length\u0027, exception.invalid_property)"},{"line_number":262,"context_line":"        self.assertIn(\u0027bit_length\u0027, exception.message)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_should_raise_bit_length_greater_than_max(self):"},{"line_number":265,"context_line":"        self.secret_req[\u0027bit_length\u0027] \u003d 32768"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_d39a94c5","line":262,"in_reply_to":"1a26ad4f_533a04cf","updated":"2015-10-27 06:19:02.000000000","message":"missed it. Sorry, still need more morning coffee haha.","commit_id":"af7965026786e23e1d8556be8fd02f9174aceb92"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"807ad386616c4baf5ba4486a63a10f1493285c1b","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            self.secret_req,"},{"line_number":260,"context_line":"        )"},{"line_number":261,"context_line":"        self.assertEqual(\u0027bit_length\u0027, exception.invalid_property)"},{"line_number":262,"context_line":"        self.assertIn(\u0027bit_length\u0027, exception.message)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_should_raise_bit_length_greater_than_max(self):"},{"line_number":265,"context_line":"        self.secret_req[\u0027bit_length\u0027] \u003d 32768"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_533a04cf","line":262,"in_reply_to":"3a29b11f_ffadd39b","updated":"2015-10-27 06:16:59.000000000","message":"Thanks for the review.\nI think its already there at line no 222\ndef test_should_raise_negative_bit_length(self):\n\nAm i right?","commit_id":"af7965026786e23e1d8556be8fd02f9174aceb92"}]}