)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"75ff6fc26329dc5c49ebdf301ad193019dde350b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nimish \u003cjnimish77@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-30 22:18:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated(into the Github repository) the added  filter to secret list for acl secrets."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the previous commit the author added a neat feature to allow users"},{"line_number":10,"context_line":"to get a list of secrets for which they are on the ACL."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a26ad4f_94eb0b78","line":7,"updated":"2015-11-02 11:41:39.000000000","message":"Can you remove the stuff in the parentheses? seems unnecessary, and on the other hand, this platform is not github.","commit_id":"c8bc989d26d0dd9d67f34b45be2aebfb7702aa1e"}],"barbican/api/controllers/secrets.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"b73f539ebf2fbbfdae836fae88d499052647914a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        transport_key_model \u003d self.transport_key_repo.get("},{"line_number":153,"context_line":"            entity_id\u003dtransport_key_id,"},{"line_number":154,"context_line":"            suppress_exception\u003dTrue,"},{"line_number":155,"context_line":"\t    acl_only\u003dkw.get(\u0027acl_only\u0027, None),"},{"line_number":156,"context_line":"\t    user_id\u003duser_id)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return transport_key_model.transport_key"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_25f0a766","line":155,"updated":"2015-11-03 05:02:20.000000000","message":"kw is not declared anywhere else. Should be \"kwargs\".","commit_id":"c8bc989d26d0dd9d67f34b45be2aebfb7702aa1e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"75ff6fc26329dc5c49ebdf301ad193019dde350b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            entity_id\u003dtransport_key_id,"},{"line_number":154,"context_line":"            suppress_exception\u003dTrue,"},{"line_number":155,"context_line":"\t    acl_only\u003dkw.get(\u0027acl_only\u0027, None),"},{"line_number":156,"context_line":"\t    user_id\u003duser_id)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return transport_key_model.transport_key"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_f44cbfc9","line":156,"updated":"2015-11-02 11:41:39.000000000","message":"can you use spaces and not tabs?","commit_id":"c8bc989d26d0dd9d67f34b45be2aebfb7702aa1e"},{"author":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"change_message_id":"76d5b6dc8bcfba5cb3807351a2c4669928d9b7a6","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            entity_id\u003dtransport_key_id,"},{"line_number":154,"context_line":"            suppress_exception\u003dTrue,"},{"line_number":155,"context_line":"\t    acl_only\u003dkw.get(\u0027acl_only\u0027, None),"},{"line_number":156,"context_line":"\t    user_id\u003duser_id)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return transport_key_model.transport_key"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_d73e658b","line":156,"in_reply_to":"1a26ad4f_f44cbfc9","updated":"2015-11-02 11:55:01.000000000","message":"+1","commit_id":"c8bc989d26d0dd9d67f34b45be2aebfb7702aa1e"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"b73f539ebf2fbbfdae836fae88d499052647914a","unresolved":false,"context_lines":[{"line_number":155,"context_line":"\t    acl_only\u003dkw.get(\u0027acl_only\u0027, None),"},{"line_number":156,"context_line":"\t    user_id\u003duser_id)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return transport_key_model.transport_key"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @pecan.expose()"},{"line_number":161,"context_line":"    @utils.allow_all_content_types"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_e5b38f98","line":158,"updated":"2015-11-03 05:02:20.000000000","message":"use spaces instead of tabs.","commit_id":"c8bc989d26d0dd9d67f34b45be2aebfb7702aa1e"}],"barbican/model/repositories.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"75ff6fc26329dc5c49ebdf301ad193019dde350b","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        if secret_type:"},{"line_number":626,"context_line":"            query \u003d query.filter(models.Secret.secret_type \u003d\u003d secret_type)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"\tif acl_only and acl_only.lower() \u003d\u003d \u0027true\u0027 and user_id:"},{"line_number":629,"context_line":"            query \u003d query.join(models.SecretACL)"},{"line_number":630,"context_line":"            query \u003d query.join(models.SecretACLUser)"},{"line_number":631,"context_line":"            query \u003d query.filter(models.SecretACLUser.user_id \u003d\u003d user_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_b4c96728","line":628,"updated":"2015-11-02 11:41:39.000000000","message":"same here, please use spaces instead of tabs","commit_id":"c8bc989d26d0dd9d67f34b45be2aebfb7702aa1e"}],"barbican/tests/api/controllers/test_acls.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"75ff6fc26329dc5c49ebdf301ad193019dde350b","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            \u0027/secrets/?acl_only\u003dTrUe\u0027)"},{"line_number":524,"context_line":"        self.assertEqual(200, resp.status_int)"},{"line_number":525,"context_line":"        secret_list \u003d resp.json.get(\u0027secrets\u0027)"},{"line_number":526,"context_line":"        self.assertEqual(len(secret_list), 2)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        self.assertNotIn(secret_uuid_no_acl, secret_list)"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_14e13b9a","line":526,"updated":"2015-11-02 11:41:39.000000000","message":"wasn\u0027t the correct order expected value then seen value? Why was this changed?","commit_id":"c8bc989d26d0dd9d67f34b45be2aebfb7702aa1e"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"de88b66a8c38d4d0532151bc336ea881034c01f6","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            \u0027/secrets/?acl_only\u003dTrUe\u0027)"},{"line_number":524,"context_line":"        self.assertEqual(200, resp.status_int)"},{"line_number":525,"context_line":"        secret_list \u003d resp.json.get(\u0027secrets\u0027)"},{"line_number":526,"context_line":"        self.assertEqual(len(secret_list), 2)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        self.assertNotIn(secret_uuid_no_acl, secret_list)"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_15a8431f","line":526,"in_reply_to":"1a26ad4f_14e13b9a","updated":"2015-11-02 20:58:11.000000000","message":"Yes, the correct order is assertEqual(expected,observed) as documented in: https://bugs.launchpad.net/barbican/+bug/1259292\nSo I also think this change is unnecessary.","commit_id":"c8bc989d26d0dd9d67f34b45be2aebfb7702aa1e"}]}
