)]}'
{"barbican/plugin/crypto/manager.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"0a1f99292972e7be7f715e98b32150c58cb84b34","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_PLUGIN_MANAGER \u003d None"},{"line_number":27,"context_line":"_PLUGIN_MANAGER_LOCK \u003d threading.Lock()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d config.new_config()"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_b942993c","line":27,"updated":"2016-01-11 16:55:53.000000000","message":"some other areas use threading.RLock (reentrant).  Not sure that it matters here as we shouldn\u0027t come into this code from the same thread...the lock is intended to prevent different threads from stepping on each other.","commit_id":"7b54d07cc99ddc802bf05ab9d7d1b95c2a128918"},{"author":{"_account_id":14926,"name":"Jeff Feng","email":"jianhua@us.ibm.com","username":"jhfeng"},"change_message_id":"31e1d5b71617a86a5940e2b2cd37ea0b3fa97c76","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_PLUGIN_MANAGER \u003d None"},{"line_number":27,"context_line":"_PLUGIN_MANAGER_LOCK \u003d threading.Lock()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d config.new_config()"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4bcff555","line":27,"in_reply_to":"fa69d971_b942993c","updated":"2016-01-11 22:17:53.000000000","message":"looked on this, seems it\u0027s better to use RLOCK which can only be released by original thread who acquired the lock. LOCK can be released by any thread.\nI\u0027ll make change in next revision.\nThanks for pointing this out.","commit_id":"7b54d07cc99ddc802bf05ab9d7d1b95c2a128918"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"0a1f99292972e7be7f715e98b32150c58cb84b34","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    \"\"\"Return a singleton crypto plugin manager.\"\"\""},{"line_number":117,"context_line":"    global _PLUGIN_MANAGER"},{"line_number":118,"context_line":"    global _PLUGIN_MANAGER_LOCK"},{"line_number":119,"context_line":"    if not _PLUGIN_MANAGER:"},{"line_number":120,"context_line":"        with _PLUGIN_MANAGER_LOCK:"},{"line_number":121,"context_line":"            if not _PLUGIN_MANAGER:"},{"line_number":122,"context_line":"                _PLUGIN_MANAGER \u003d _CryptoPluginManager()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_b9cff97d","line":119,"updated":"2016-01-11 16:55:53.000000000","message":"I don\u0027t think you need this IF statement since you are checking it on line 121 (after you have the lock).  Its ever-so-slightly more inefficient to get the lock each time, but this isn\u0027t a performance-critical path so I\u0027d rather see it be more readable.","commit_id":"7b54d07cc99ddc802bf05ab9d7d1b95c2a128918"},{"author":{"_account_id":14926,"name":"Jeff Feng","email":"jianhua@us.ibm.com","username":"jhfeng"},"change_message_id":"31e1d5b71617a86a5940e2b2cd37ea0b3fa97c76","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    \"\"\"Return a singleton crypto plugin manager.\"\"\""},{"line_number":117,"context_line":"    global _PLUGIN_MANAGER"},{"line_number":118,"context_line":"    global _PLUGIN_MANAGER_LOCK"},{"line_number":119,"context_line":"    if not _PLUGIN_MANAGER:"},{"line_number":120,"context_line":"        with _PLUGIN_MANAGER_LOCK:"},{"line_number":121,"context_line":"            if not _PLUGIN_MANAGER:"},{"line_number":122,"context_line":"                _PLUGIN_MANAGER \u003d _CryptoPluginManager()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_69ce455c","line":119,"in_reply_to":"fa69d971_b9cff97d","updated":"2016-01-11 22:17:53.000000000","message":"actually this get_manager() will be called in code path for each request. so having line 119 can prevent acquiring lock and save cost. \nI\u0027d like keep this line although it\u0027s not readable perfectly.","commit_id":"7b54d07cc99ddc802bf05ab9d7d1b95c2a128918"}],"barbican/tests/plugin/crypto/test_manager.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"b921e49357ca7b2e1243d69efae2c4b96117e62e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from barbican.tests import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class myThread(threading.Thread):"},{"line_number":25,"context_line":"    def __init__(self, index, results):"},{"line_number":26,"context_line":"        threading.Thread.__init__(self)"},{"line_number":27,"context_line":"        self.index \u003d index"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_4517b344","line":24,"updated":"2015-11-12 17:34:57.000000000","message":"For consistency, please use a cap \u0027M\u0027 as first character of the class name.","commit_id":"c3c04861f8f7b58b2dc93e0ad90e4aa04cb1ee8f"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"b921e49357ca7b2e1243d69efae2c4b96117e62e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        for i in range(10):"},{"line_number":110,"context_line":"            t \u003d myThread(i, results)"},{"line_number":111,"context_line":"            t.start()"},{"line_number":112,"context_line":"        # verify all threads return one and same pulgin manager"},{"line_number":113,"context_line":"        for i in range(10):"},{"line_number":114,"context_line":"            self.assertIsInstance(results[i], cm._CryptoPluginManager)"},{"line_number":115,"context_line":"            self.assertEqual(results[0], results[i])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_458a5365","line":112,"updated":"2015-11-12 17:34:57.000000000","message":"nit: pulgin -\u003e plugin","commit_id":"c3c04861f8f7b58b2dc93e0ad90e4aa04cb1ee8f"}]}
