)]}'
{"barbican/common/validators.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"5c9a11e49a8e4a54a9c06339d7cc4f7a1946f555","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                    \"maxLength\": 255"},{"line_number":401,"context_line":"                },"},{"line_number":402,"context_line":"                \"expiration\": {\"type\": \"string\", \"maxLength\": 255},"},{"line_number":403,"context_line":"                \"pass_phrase\": {\"type\": \"string\", \"maxLength\": 255},"},{"line_number":404,"context_line":"                \"request_type\": {\"type\": \"string\", \"maxLength\": 255},"},{"line_number":405,"context_line":"                \"subject_dn\": {\"type\": \"string\", \"maxLength\": 255},"},{"line_number":406,"context_line":"                \"source_container_ref\": {\"type\": \"string\", \"maxLength\": 255},"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_b11bd01a","line":403,"updated":"2016-01-04 18:24:03.000000000","message":"Should be \"passphrase\".","commit_id":"3dc0e6ffb0c591d61860d4b72136670645d59024"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"b365ce6e7abb58d1a4762a9e2344920876457eaa","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                    \"required\": True,"},{"line_number":388,"context_line":"                    \"enum\": [\u0027key\u0027, \u0027asymmetric\u0027, \u0027certificate\u0027]"},{"line_number":389,"context_line":"                }"},{"line_number":390,"context_line":"            }"},{"line_number":391,"context_line":"        }"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def validate(self, json_data, parent_schema\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_918c8c36","line":390,"updated":"2016-01-04 18:24:08.000000000","message":"Should I add each possible property for this schema, which can get huge, since there are many items which are relevant. See http://docs.openstack.org/developer/barbican/api/reference/certificates.html and http://docs.openstack.org/developer/barbican/api/reference/cas.html","commit_id":"d5ad670c8b797c4e8bc183b3fa8297448e146521"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"cad149e5517020f611811b82e06949b55851cc45","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def __init__(self):"},{"line_number":377,"context_line":"        self.name \u003d \u0027Order\u0027"},{"line_number":378,"context_line":"        self.schema \u003d {"},{"line_number":379,"context_line":"            \"type\": \"object\","},{"line_number":380,"context_line":"            \"$schema\": \"http://json-schema.org/draft-03/schema\","},{"line_number":381,"context_line":"            \"properties\": {"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_0b181d74","line":378,"updated":"2016-01-06 06:21:40.000000000","message":"Should I add each possible property for this schema, which can get huge, since there are many items which are relevant. See http://docs.openstack.org/developer/barbican/api/reference/certificates.html and http://docs.openstack.org/developer/barbican/api/reference/cas.html\n\nI will add this in the next patch if necessary.","commit_id":"9a7057d40fbcc5bdd3b0e3bbf5ef65c907671b60"},{"author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"change_message_id":"425590017ee356e0abaa8f5426fd14c157f2d369","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def __init__(self):"},{"line_number":377,"context_line":"        self.name \u003d \u0027Order\u0027"},{"line_number":378,"context_line":"        self.schema \u003d {"},{"line_number":379,"context_line":"            \"type\": \"object\","},{"line_number":380,"context_line":"            \"$schema\": \"http://json-schema.org/draft-03/schema\","},{"line_number":381,"context_line":"            \"properties\": {"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_51e6c615","line":378,"in_reply_to":"fa69d971_0b181d74","updated":"2016-01-06 07:47:18.000000000","message":"I think it\u0027s necessary because it\u0027s a part of your work. :)","commit_id":"9a7057d40fbcc5bdd3b0e3bbf5ef65c907671b60"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"4569e781cb3f5c519af8b6d5aa321140c7db7184","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def __init__(self):"},{"line_number":377,"context_line":"        self.name \u003d \u0027Order\u0027"},{"line_number":378,"context_line":"        self.schema \u003d {"},{"line_number":379,"context_line":"            \"type\": \"object\","},{"line_number":380,"context_line":"            \"$schema\": \"http://json-schema.org/draft-03/schema\","},{"line_number":381,"context_line":"            \"properties\": {"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_4080008b","line":378,"in_reply_to":"fa69d971_51e6c615","updated":"2016-01-07 03:53:21.000000000","message":"thanks ting. I\u0027ll update this soon.","commit_id":"9a7057d40fbcc5bdd3b0e3bbf5ef65c907671b60"}],"barbican/tests/common/test_validators.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"b46488cc420843044c11773f6cfeac14233a3ea0","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"                          self.validator.validate,"},{"line_number":1378,"context_line":"                          self.order_req)"},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"    def test_should_raise_with_bad_request_type(self):"},{"line_number":1381,"context_line":"        self.meta[\u0027request_type\u0027] \u003d \u0027bad_request_type\u0027"},{"line_number":1382,"context_line":"        self._set_order()"},{"line_number":1383,"context_line":"        self.assertRaises(excep.InvalidCertificateRequestType,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_1d2d94a7","side":"PARENT","line":1380,"updated":"2016-03-08 06:35:45.000000000","message":"why was this test removed? It seems to make sense.","commit_id":"c5526e2b69616b1c1b4942b517391db0b28fa02e"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"3d2d3a493fa08db3cdeff7f417c6dedc5b7e7faa","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"                          self.validator.validate,"},{"line_number":1378,"context_line":"                          self.order_req)"},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"    def test_should_raise_with_bad_request_type(self):"},{"line_number":1381,"context_line":"        self.meta[\u0027request_type\u0027] \u003d \u0027bad_request_type\u0027"},{"line_number":1382,"context_line":"        self._set_order()"},{"line_number":1383,"context_line":"        self.assertRaises(excep.InvalidCertificateRequestType,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_b5bf58fa","side":"PARENT","line":1380,"in_reply_to":"5aef4532_1d2d94a7","updated":"2016-03-08 06:42:09.000000000","message":"It may have been removed when I was rebasing. I\u0027ll take a look at the other files.","commit_id":"c5526e2b69616b1c1b4942b517391db0b28fa02e"}]}