)]}'
{"barbican/common/validators.py":[{"author":{"_account_id":19673,"name":"Michael Perng","email":"mperng@us.ibm.com","username":"mp"},"change_message_id":"f0bc2388542696b9148561a64e0db13a2ab88e9a","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        self.schema \u003d {"},{"line_number":685,"context_line":"            \"type\": \"object\","},{"line_number":686,"context_line":"            \"properties\": {"},{"line_number":687,"context_line":"                \"name\": {\"type\": [\"string\", \"null\"]},"},{"line_number":688,"context_line":"                \"type\": {"},{"line_number":689,"context_line":"                    \"type\": \"string\","},{"line_number":690,"context_line":"                    # TODO(hgedikli): move this to a common location"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_18976e91","line":687,"range":{"start_line":687,"start_character":1,"end_line":687,"end_character":53},"updated":"2016-01-08 15:36:49.000000000","message":"Hi Ting, my patch changes this line of code.","commit_id":"8d9a142ebb445e97b1bd6ff5d2e2a02dee5684de"}],"barbican/tests/common/test_validators.py":[{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"57582d52031619fb4db53e4842b2889e262aa878","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        )"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        self.assertEqual(\u0027name\u0027, exception.invalid_property)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def test_should_raise_no_type(self):"},{"line_number":631,"context_line":"        del self.container_req[\u0027type\u0027]"},{"line_number":632,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_1e780ff8","line":629,"updated":"2016-01-07 16:48:39.000000000","message":"The test for a numeric name on a container is already present on line 664. So I think this test should be removed. \n\nI was under the impression your patch was preventing a user from adding a secret whose name is not following the schema correctly to the container because that\u0027s the change made in validators. \n\nSo wouldn\u0027t the added test be something like?\n\ntest_should_raise_nonstring_secret_name(self):\n    self.container_req[\u0027secret_refs\u0027][0][\u0027name\u0027] \u003d 5\n    ...","commit_id":"8d9a142ebb445e97b1bd6ff5d2e2a02dee5684de"},{"author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"change_message_id":"5e3d5ae215c50023d174a065ec8869228bda08d8","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        )"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        self.assertEqual(\u0027name\u0027, exception.invalid_property)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def test_should_raise_no_type(self):"},{"line_number":631,"context_line":"        del self.container_req[\u0027type\u0027]"},{"line_number":632,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6fb945ec","line":629,"in_reply_to":"fa69d971_1e780ff8","updated":"2016-01-07 23:22:12.000000000","message":"It present, too. in 720","commit_id":"8d9a142ebb445e97b1bd6ff5d2e2a02dee5684de"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"ba2343716887a49cd95e11eecf7de77f673526b6","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        )"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        self.assertEqual(\u0027name\u0027, exception.invalid_property)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def test_should_raise_no_type(self):"},{"line_number":631,"context_line":"        del self.container_req[\u0027type\u0027]"},{"line_number":632,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_38cd925d","line":629,"in_reply_to":"fa69d971_6fb945ec","updated":"2016-01-08 15:35:03.000000000","message":"I think the test in 720 isn\u0027t testing against a secrets name but against a secrets secret_ref. \n\nself.container_req[\u0027secret_refs\u0027][0][\u0027secret_ref\u0027] \u003d 123\n\nYour test would be something like: \nself.container_req[\u0027secret_refs\u0027][0][\u0027name\u0027] \u003d 123\n\nUnless I\u0027m missing something.","commit_id":"8d9a142ebb445e97b1bd6ff5d2e2a02dee5684de"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"fccd3049ae4cd9afd3dbfd51dcb021d60c697130","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        self.assertEqual(\u0027name\u0027, exception.invalid_property)"},{"line_number":628,"context_line":"        self.assertIn(\u0027name\u0027, exception.message)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def test_should_raise_nonstring_secret_name(self):"},{"line_number":631,"context_line":"        self.secret_refs[0][\"name\"] \u003d 5"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        exception \u003d self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_08821153","line":630,"updated":"2016-01-20 17:24:51.000000000","message":"The tests look good to me, \n\nhttps://github.com/openstack/barbican/blob/master/barbican/common/exception.py#L352-L363\n\nsecret_refs does have an invalid property and the results are correct.\n\nIn the future you can test multiple values using:\n\n@utils.parameterized_dataset({\n        \u0027integer\u0027: 5,\n        \u0027too_long\u0027: \"a\" * 256,\n        \u0027boolean\u0027: True,\n    })\ndef test_should_raise_invalid_object_name(self, name):\nself.container_req[\u0027name\u0027] \u003d name\n....\n\nto put all similar tests into one, checking that all those are InvalidObjects.","commit_id":"bdb6195adf0eca6e223f9ad5dfb53bb0249fddeb"},{"author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"change_message_id":"cc16fc9f41e06ba53bd3d1faf09ec73ca92909ae","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        self.assertEqual(\u0027name\u0027, exception.invalid_property)"},{"line_number":628,"context_line":"        self.assertIn(\u0027name\u0027, exception.message)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def test_should_raise_nonstring_secret_name(self):"},{"line_number":631,"context_line":"        self.secret_refs[0][\"name\"] \u003d 5"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        exception \u003d self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_fbdace77","line":630,"in_reply_to":"9a68dd71_08821153","updated":"2016-01-21 02:17:02.000000000","message":"amazing. Thank you very much!","commit_id":"bdb6195adf0eca6e223f9ad5dfb53bb0249fddeb"}]}
