)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d2f6ae4b9b5cc44ae5ad6abdd2bc2ffce853613d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tobias Zatti \u003cTobias_Zatti@symantec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-08 11:12:58 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Applied Jason Fritchers changes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed PEP8 violation"},{"line_number":10,"context_line":"Implemented minor changes proposed by Fernando Diaz"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a5ae5dd_943adf97","line":7,"updated":"2016-02-08 10:23:42.000000000","message":"This section is unhelpful in the commit message. The title should be an overall description of what\u0027s going on in the CR.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a8c6ba52acfe2faffc93e9f0b20cccada24be96f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tobias Zatti \u003cTobias_Zatti@symantec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-08 11:12:58 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Applied Jason Fritchers changes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed PEP8 violation"},{"line_number":10,"context_line":"Implemented minor changes proposed by Fernando Diaz"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a5ae5dd_3603b80f","line":7,"in_reply_to":"5a5ae5dd_943adf97","updated":"2016-02-09 04:34:04.000000000","message":"The whole commit message should just be a \u0027title\u0027 to the patch then a new line then a \u0027paragraph\u0027 describing the patch. \n\ntitle \u003d 50 chars, no period\nbody \u003d 72 wrapped\n\nsee https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d2f6ae4b9b5cc44ae5ad6abdd2bc2ffce853613d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Applied Jason Fritchers changes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed PEP8 violation"},{"line_number":10,"context_line":"Implemented minor changes proposed by Fernando Diaz"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added documentation and changed imports"},{"line_number":13,"context_line":"Added symcws dependency (the Symantec library)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a5ae5dd_5440e706","line":10,"updated":"2016-02-08 10:23:42.000000000","message":"This is also unnecessary.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d2f6ae4b9b5cc44ae5ad6abdd2bc2ffce853613d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Added symcws dependency (the Symantec library)"},{"line_number":14,"context_line":"Fixed a parameter name from testapi to useTestAPI"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Worked in proposals from Christopher Solis."},{"line_number":17,"context_line":"Added lines relevant to Symantec plugin to global barbican.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Added initial version of the Symantec plugin. Now PEP-8 conform."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a5ae5dd_144fcf37","line":16,"updated":"2016-02-08 10:23:42.000000000","message":"And so is this.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a8c6ba52acfe2faffc93e9f0b20cccada24be96f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Added lines relevant to Symantec plugin to global barbican.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Added initial version of the Symantec plugin. Now PEP-8 conform."},{"line_number":20,"context_line":"The Symantec plugin will require a Symantec library, which will be available through pypi and will rest on another, separate github repository."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Please review for functional aspects."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a5ae5dd_169a3cc6","line":20,"updated":"2016-02-09 04:34:04.000000000","message":"Do not go over 72 chars.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d2f6ae4b9b5cc44ae5ad6abdd2bc2ffce853613d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Fixed PEP-8 violations."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I1e8076a3743e6d696c1c5933ef61614a0dc83d9c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a5ae5dd_1476ef6f","line":28,"updated":"2016-02-08 10:23:42.000000000","message":"Several change ids? Seems that something is wrong here.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a8c6ba52acfe2faffc93e9f0b20cccada24be96f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Fixed PEP-8 violations."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I1e8076a3743e6d696c1c5933ef61614a0dc83d9c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a5ae5dd_36865866","line":28,"in_reply_to":"5a5ae5dd_1476ef6f","updated":"2016-02-09 04:34:04.000000000","message":"Same id is mentioned twice, just remove 1.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":19673,"name":"Michael Perng","email":"mperng@us.ibm.com","username":"mp"},"change_message_id":"7094af6814caab8db6ec0191eea5060c748832d6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implemented Symantec plugin made from Symantec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed PEP8 violation"},{"line_number":10,"context_line":"Implemented minor changes proposed by Fernando Diaz"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added documentation and changed imports"},{"line_number":13,"context_line":"Added symcws dependency (the Symantec library)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a57f1b5_d79f955d","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":51},"updated":"2016-02-10 16:17:29.000000000","message":"This is unnecessary. Please see comment from commit 8.","commit_id":"67b24732b39fc9f8b363430460ec9e8bdf4bde49"},{"author":{"_account_id":19143,"name":"Tobias Zatti","email":"Tobias_Zatti@symantec.com","username":"tzatti"},"change_message_id":"c1ceec039addfe9d4fadbe1dcacce610a6e89821","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implemented Symantec plugin made from Symantec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed PEP8 violation"},{"line_number":10,"context_line":"Implemented minor changes proposed by Fernando Diaz"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added documentation and changed imports"},{"line_number":13,"context_line":"Added symcws dependency (the Symantec library)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a57f1b5_00107ea7","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":51},"in_reply_to":"3a57f1b5_d79f955d","updated":"2016-02-11 08:59:54.000000000","message":"Thanks! I actually missed this one and thought it was already removed.","commit_id":"67b24732b39fc9f8b363430460ec9e8bdf4bde49"},{"author":{"_account_id":19673,"name":"Michael Perng","email":"mperng@us.ibm.com","username":"mp"},"change_message_id":"7094af6814caab8db6ec0191eea5060c748832d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tobias Zatti \u003cTobias_Zatti@symantec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-10 16:32:12 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implemented Symantec plugin made from Symantec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed PEP8 violation"},{"line_number":10,"context_line":"Implemented minor changes proposed by Fernando Diaz"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added documentation and changed imports"},{"line_number":13,"context_line":"Added symcws dependency (the Symantec library)"},{"line_number":14,"context_line":"Still unclear where to post this requirement."},{"line_number":15,"context_line":"Fixed a parameter name from testapi to useTestAPI"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Added lines relevant to Symantec plugin to global barbican.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Added initial version of the Symantec plugin. Now PEP-8 conform."},{"line_number":20,"context_line":"The Symantec plugin will require a Symantec library,"},{"line_number":21,"context_line":"which will be available through pypi and will rest on another,"},{"line_number":22,"context_line":"separate github repository."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Please review for functional aspects."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I1e8076a3743e6d696c1c5933ef61614a0dc83d9c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a57f1b5_d74eb5c0","line":26,"range":{"start_line":7,"start_character":0,"end_line":26,"end_character":52},"updated":"2016-02-10 16:17:29.000000000","message":"Please review this guideline for git commit message structure:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"67b24732b39fc9f8b363430460ec9e8bdf4bde49"}],"barbican/plugin/symantec.py":[{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"69c9cd46c44cc827f6070783bf9dae584d7a514b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"symantec_plugin_group \u003d cfg.OptGroup(name\u003d\u0027symantec_plugin\u0027,"},{"line_number":28,"context_line":"                                     title\u003d\u0027Symantec Plugin Options\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"symantec_plugin_opts \u003d ["},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027username\u0027,"},{"line_number":32,"context_line":"               help\u003du._(\u0027Symantec username for authentication\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_51dbba7c","line":29,"updated":"2016-02-03 22:00:32.000000000","message":"Should these values be configurable in the conf file? I don\u0027t see them in the default conf file.","commit_id":"2cdd0269f4ca68802d22c24be88b0570fca9e457"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"69c9cd46c44cc827f6070783bf9dae584d7a514b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            \u003d self._ca_create_order(order_id, order_meta, plugin_meta)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        status \u003d cert.CertificateStatus.CA_UNAVAILABLE_FOR_REQUEST"},{"line_number":105,"context_line":"        message \u003d error_msg"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        if successful:"},{"line_number":108,"context_line":"            status \u003d cert.CertificateStatus.WAITING_FOR_CA"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_31263ecf","line":105,"updated":"2016-02-03 22:00:32.000000000","message":"Is there a reason this assignment is needed? If message is set to error_msg up here then there\u0027s no reason for the assignment again in line 111 which means line 113 can be changed to cert.ResultDTO(status\u003dstatus, status_message\u003derror_msg) for clarity and line 105 can be deleted.\n\nMuch similar to the way you changed the code in cancel_certificate_request around lines 156","commit_id":"2cdd0269f4ca68802d22c24be88b0570fca9e457"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"69c9cd46c44cc827f6070783bf9dae584d7a514b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            status \u003d cert.CertificateStatus.CLIENT_DATA_ISSUE_SEEN"},{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            status \u003d cert.CertificateStatus.CLIENT_DATA_ISSUE_SEEN"},{"line_number":141,"context_line":"        message \u003d error_msg"},{"line_number":142,"context_line":"        return cert.ResultDTO(status\u003dstatus, status_message\u003dmessage)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def cancel_certificate_request(self, order_id, order_meta, plugin_meta,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_ec3449df","line":141,"updated":"2016-02-03 22:00:32.000000000","message":"Same comment as above.","commit_id":"2cdd0269f4ca68802d22c24be88b0570fca9e457"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"69c9cd46c44cc827f6070783bf9dae584d7a514b","unresolved":false,"context_lines":[{"line_number":552,"context_line":"                         \u0027SignatureHashAlgorithm\u0027: algo,"},{"line_number":553,"context_line":"                         \u0027OriginalPartnerOrderID\u0027: order_id},"},{"line_number":554,"context_line":"                orderChanges\u003dorderChanges"},{"line_number":555,"context_line":"            )"},{"line_number":556,"context_line":"            if order_data.OrderResponseHeader.SuccessCode \u003c 0:"},{"line_number":557,"context_line":"                return False, order_data.OrderResponseHeader.Errors, True"},{"line_number":558,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_ccf38d72","line":555,"updated":"2016-02-03 22:00:32.000000000","message":"I think these if else statements can be outside after the except block. It looks like the try block is just testing if the above attempt to reissue the certificate worked and the rest is determining what to return.","commit_id":"2cdd0269f4ca68802d22c24be88b0570fca9e457"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"dba0a0be9447b47c90658ffbf137acd71dadfb63","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               help\u003du._(\u0027Symantec password for authentication\u0027)),"},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027partnercode\u0027,"},{"line_number":36,"context_line":"               help\u003du._(\u0027Symantec partner code for authentication\u0027)),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027testmode\u0027,"},{"line_number":38,"context_line":"               help\u003du._(\u0027If true, the sandbox environment will be used instead \\"},{"line_number":39,"context_line":"                of production. This requires a dedicated sandbox account!\u0027))"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_0e52c6dd","line":37,"updated":"2016-02-04 17:33:41.000000000","message":"This should be a BoolOpt\n\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L54","commit_id":"84dbc671c6fbd342a7af9c021331e96106d59300"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"dba0a0be9447b47c90658ffbf137acd71dadfb63","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    cfg.StrOpt(\u0027partnercode\u0027,"},{"line_number":36,"context_line":"               help\u003du._(\u0027Symantec partner code for authentication\u0027)),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027testmode\u0027,"},{"line_number":38,"context_line":"               help\u003du._(\u0027If true, the sandbox environment will be used instead \\"},{"line_number":39,"context_line":"                of production. This requires a dedicated sandbox account!\u0027))"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_ee1baa19","line":38,"updated":"2016-02-04 17:33:41.000000000","message":"Can remove the \\ and space it like below:\n\n\nhelp\u003du._(\u0027If true, the sandbox environment will be used instead \u0027\n         \u0027of production. This requires a dedicated sandbox account!\u0027))","commit_id":"84dbc671c6fbd342a7af9c021331e96106d59300"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"dba0a0be9447b47c90658ffbf137acd71dadfb63","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if self.partnercode is None:"},{"line_number":63,"context_line":"            raise ValueError(u._(\"partnercode is required\"))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        if self.testmode is None:"},{"line_number":66,"context_line":"            raise ValueError(u._(\"testmode is required\"))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # We can\u0027t read booleans off the config file."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_8eba366d","line":65,"updated":"2016-02-04 17:33:41.000000000","message":"Can remove this and default the test value to \"default\u003dFalse\" in line 37","commit_id":"84dbc671c6fbd342a7af9c021331e96106d59300"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"dba0a0be9447b47c90658ffbf137acd71dadfb63","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if self.testmode is None:"},{"line_number":66,"context_line":"            raise ValueError(u._(\"testmode is required\"))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # We can\u0027t read booleans off the config file."},{"line_number":69,"context_line":"        # This means we need to treat them as a string."},{"line_number":70,"context_line":"        testmode \u003d False"},{"line_number":71,"context_line":"        if self.testmode.lower() \u003d\u003d \u0027true\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_0ef9664d","line":68,"updated":"2016-02-04 17:33:41.000000000","message":"booleans can  be read from conf file. see line 37.\nThe value would look in the conf as follows:\n\ntestmode \u003d true\ntestmode \u003d false","commit_id":"84dbc671c6fbd342a7af9c021331e96106d59300"},{"author":{"_account_id":12920,"name":"Jason Fritcher","email":"jason_fritcher@symantec.com","username":"jfritcher"},"change_message_id":"b90803ce5bec295c783c126d1cd9281f2bc7e015","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        # Default all options to None so that non required arguments don\u0027t"},{"line_number":214,"context_line":"        # have to be entered."},{"line_number":215,"context_line":"        orgName \u003d order_meta[\"OrganizationName\"] if \\"},{"line_number":216,"context_line":"            \"OrganizationName\" in order_meta else None"},{"line_number":217,"context_line":"        country \u003d order_meta[\"Country\"] if \"Country\" in order_meta else None"},{"line_number":218,"context_line":"        region \u003d order_meta[\"Region\"] if \"Region\" in order_meta else None"},{"line_number":219,"context_line":"        city \u003d order_meta[\"City\"] if \"City\" in order_meta else None"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_98a240fb","line":216,"updated":"2016-02-05 19:58:50.000000000","message":"All of your instances of this pattern where you\u0027re trying to get a value from a dict, but want a default returned if the key doesn\u0027t exist can be simplified like so...\n\norgName \u003d order_meta.get(\"OrganizationName\", None)\n\nThis change will make the code much easier to read.","commit_id":"c17a670f8b086185fe03e652e9cedb5693369177"},{"author":{"_account_id":12920,"name":"Jason Fritcher","email":"jason_fritcher@symantec.com","username":"jfritcher"},"change_message_id":"b90803ce5bec295c783c126d1cd9281f2bc7e015","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        try:"},{"line_number":400,"context_line":"            orginfo \u003d self._create_orginfo(order_meta)"},{"line_number":401,"context_line":"        except KeyError as e:"},{"line_number":402,"context_line":"            return False, e, False"},{"line_number":403,"context_line":"        try:"},{"line_number":404,"context_line":"            order_data \u003d self.api.QuickOrder("},{"line_number":405,"context_line":"                    order_meta[\"ProductCode\"],"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_9841e065","line":402,"updated":"2016-02-05 19:58:50.000000000","message":"Can these try blocks be combined? Two try blocks right next to each other with the same except blocks looks cluttered.","commit_id":"c17a670f8b086185fe03e652e9cedb5693369177"},{"author":{"_account_id":12920,"name":"Jason Fritcher","email":"jason_fritcher@symantec.com","username":"jfritcher"},"change_message_id":"b90803ce5bec295c783c126d1cd9281f2bc7e015","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        if \"OrderChanges\" in order_meta:"},{"line_number":521,"context_line":"            orderChanges \u003d order_meta[\"OrderChanges\"]"},{"line_number":522,"context_line":"        else:"},{"line_number":523,"context_line":"            orderChanges \u003d None"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Allow the user to change the Signature Hash Algorithm or not"},{"line_number":526,"context_line":"        if \"SignatureHashAlgorithm\" in order_meta:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_78dae4e9","line":523,"updated":"2016-02-05 19:58:50.000000000","message":"All instances of this pattern can be replaced with the following...\n\norderChanges \u003d order_meta.get(\"OrderChanges\", None)\n\nMakes things easier to read and is more compact.","commit_id":"c17a670f8b086185fe03e652e9cedb5693369177"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d2f6ae4b9b5cc44ae5ad6abdd2bc2ffce853613d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from barbican import i18n as u"},{"line_number":21,"context_line":"from barbican.plugin.interface import certificate_manager as cert"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from symcws import symcws"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.new_config()"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_b4c03b51","line":23,"updated":"2016-02-08 10:23:42.000000000","message":"You might want to add this to test-requirements.txt","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"57807806742204fdd82a789f88f724bd494aff32","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from barbican import i18n as u"},{"line_number":21,"context_line":"from barbican.plugin.interface import certificate_manager as cert"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from symcws import symcws"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.new_config()"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_c4381aa3","line":23,"in_reply_to":"3a57f1b5_c373694c","updated":"2016-02-11 09:08:24.000000000","message":"yeah, that\u0027s what we\u0027re using test-requiremnts.txt for. Either way, you need to propose symcws to the requirements repo of OpenStack.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":19143,"name":"Tobias Zatti","email":"Tobias_Zatti@symantec.com","username":"tzatti"},"change_message_id":"885f2eebdd5c395c846a3957bf1530fc19518e30","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from barbican import i18n as u"},{"line_number":21,"context_line":"from barbican.plugin.interface import certificate_manager as cert"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from symcws import symcws"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.new_config()"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_c373694c","line":23,"in_reply_to":"5a5ae5dd_363bb89e","updated":"2016-02-11 09:00:03.000000000","message":"Would I need to create my own requirements.txt or use the global one?\nThere\u0027s a requirement for symcws, which requires suds. If a user does not need the Symantec plugin, they don\u0027t have to install those packages.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a8c6ba52acfe2faffc93e9f0b20cccada24be96f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from barbican import i18n as u"},{"line_number":21,"context_line":"from barbican.plugin.interface import certificate_manager as cert"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from symcws import symcws"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.new_config()"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_363bb89e","line":23,"in_reply_to":"5a5ae5dd_b4c03b51","updated":"2016-02-09 04:34:04.000000000","message":"maybe requirements.txt since it is an interface for Symantec\u0027s official API library and test mode can be False in self.api \u003d symcws(useTestAPI\u003dtestmode, verbose\u003dFalse)","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d2f6ae4b9b5cc44ae5ad6abdd2bc2ffce853613d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.StrOpt(\u0027username\u0027,"},{"line_number":32,"context_line":"               help\u003du._(\u0027Symantec username for authentication\u0027)),"},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027password\u0027,"},{"line_number":34,"context_line":"               help\u003du._(\u0027Symantec password for authentication\u0027)),"},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027partnercode\u0027,"},{"line_number":36,"context_line":"               help\u003du._(\u0027Symantec partner code for authentication\u0027)),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027testmode\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_34f8cbc2","line":34,"updated":"2016-02-08 10:23:42.000000000","message":"why is the secret attribute being removed from here? That might end up as a security issue.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a8c6ba52acfe2faffc93e9f0b20cccada24be96f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.StrOpt(\u0027username\u0027,"},{"line_number":32,"context_line":"               help\u003du._(\u0027Symantec username for authentication\u0027)),"},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027password\u0027,"},{"line_number":34,"context_line":"               help\u003du._(\u0027Symantec password for authentication\u0027)),"},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027partnercode\u0027,"},{"line_number":36,"context_line":"               help\u003du._(\u0027Symantec partner code for authentication\u0027)),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027testmode\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_16047cc4","line":34,"in_reply_to":"5a5ae5dd_34f8cbc2","updated":"2016-02-09 04:34:04.000000000","message":"correct, we don\u0027t wanna log the password anywhere.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d2f6ae4b9b5cc44ae5ad6abdd2bc2ffce853613d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            raise ValueError(u._(\"partnercode is required\"))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        testmode \u003d False"},{"line_number":67,"context_line":"        if self.testmode.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":68,"context_line":"            testmode \u003d True"},{"line_number":69,"context_line":"        # Create and configure the Symantec API plugin"},{"line_number":70,"context_line":"        self.api \u003d symcws(useTestAPI\u003dtestmode, verbose\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_7484030a","line":67,"updated":"2016-02-08 10:23:42.000000000","message":"where does self.testmode comes from? Seems to me that you meant to use self.useTestAPI","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a8c6ba52acfe2faffc93e9f0b20cccada24be96f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            raise ValueError(u._(\"partnercode is required\"))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        testmode \u003d False"},{"line_number":67,"context_line":"        if self.testmode.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":68,"context_line":"            testmode \u003d True"},{"line_number":69,"context_line":"        # Create and configure the Symantec API plugin"},{"line_number":70,"context_line":"        self.api \u003d symcws(useTestAPI\u003dtestmode, verbose\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_76a9307b","line":67,"in_reply_to":"5a5ae5dd_7484030a","updated":"2016-02-09 04:34:04.000000000","message":"I still don\u0027t think this is needed. In line 37, we see test mode as a BoolOpt. We can set it to default to False, if not it just reads it from the conf file.\n\nline 37:\ncfg.BoolOpt(\u0027testmode\u0027,\n                default\u003dFalse,\n                help\u003du._(\u0027If true, the sandbox environment will be used \u0027\n                         \u0027instead of production. This requires a dedicated \u0027\n                         \u0027sandbox account!\u0027))\n\nthen remove this line.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a8c6ba52acfe2faffc93e9f0b20cccada24be96f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        return \"Symantec CA\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_default_signing_cert(self):"},{"line_number":77,"context_line":"        # TODO(chellygel) Add code to get the signing cert"},{"line_number":78,"context_line":"        return None"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def get_default_intermediates(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_963e2c28","line":77,"updated":"2016-02-09 04:34:04.000000000","message":"raise NotImplementedError","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a8c6ba52acfe2faffc93e9f0b20cccada24be96f","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def get_default_intermediates(self):"},{"line_number":81,"context_line":"        # TODO(chellygel) Add code to get the cert chain"},{"line_number":82,"context_line":"        return None"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def issue_certificate_request(self, order_id, order_meta, plugin_meta,"},{"line_number":85,"context_line":"                                  barbican_meta_dto):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_b63b2838","line":82,"updated":"2016-02-09 04:34:04.000000000","message":"raise NotImplementedError","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d2f6ae4b9b5cc44ae5ad6abdd2bc2ffce853613d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                   barbican_meta_dto):"},{"line_number":111,"context_line":"        \"\"\"Update the order meta-data"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        :param order_ixd: ID associated with the order"},{"line_number":114,"context_line":"        :param order_meta: Dict of meta-data associated with the order."},{"line_number":115,"context_line":"        :param plugin_meta: Plugin meta-data previously set by calls to"},{"line_number":116,"context_line":"                            this plugin. Plugins may also update/add"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_f4a793a4","line":113,"range":{"start_line":113,"start_character":22,"end_line":113,"end_character":23},"updated":"2016-02-08 10:23:42.000000000","message":"typo?","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d2f6ae4b9b5cc44ae5ad6abdd2bc2ffce853613d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                status \u003d cert.CertificateStatus.REQUEST_CANCELED"},{"line_number":180,"context_line":"            elif error_msg \u003d\u003d \"PENDING_REISSUE\":"},{"line_number":181,"context_line":"                status \u003d cert.CertificateStatus.WAITING_FOR_CA"},{"line_number":182,"context_line":"            else:"},{"line_number":183,"context_line":"                status \u003d cert.CertificateStatus.CERTIFICATE_GENERATED"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            status \u003d cert.CertificateStatus.WAITING_FOR_CA"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_942e5ff9","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":17},"updated":"2016-02-08 10:23:42.000000000","message":"are the above the only other states the request could give? what if you check if error message is empty and then it can go to the status CERTIFICATE_GENERATED. Because it seems that any other error message will lead to this.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"},{"author":{"_account_id":19143,"name":"Tobias Zatti","email":"Tobias_Zatti@symantec.com","username":"tzatti"},"change_message_id":"885f2eebdd5c395c846a3957bf1530fc19518e30","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                status \u003d cert.CertificateStatus.REQUEST_CANCELED"},{"line_number":180,"context_line":"            elif error_msg \u003d\u003d \"PENDING_REISSUE\":"},{"line_number":181,"context_line":"                status \u003d cert.CertificateStatus.WAITING_FOR_CA"},{"line_number":182,"context_line":"            else:"},{"line_number":183,"context_line":"                status \u003d cert.CertificateStatus.CERTIFICATE_GENERATED"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            status \u003d cert.CertificateStatus.WAITING_FOR_CA"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_235a7d84","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":17},"in_reply_to":"5a5ae5dd_942e5ff9","updated":"2016-02-11 09:00:03.000000000","message":"These are the only states that are possible if the state is \"successful\".\nError messages could also be warnings, even though the order was successful, therefore it doesn\u0027t make sense to check if the error message is empty. If the success code is \u003e\u003d 0, the order was successful.","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"}],"doc/source/api/userguide/symantec_setup.rst":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"dba0a0be9447b47c90658ffbf137acd71dadfb63","unresolved":false,"context_lines":[{"line_number":1,"context_line":"**************************"},{"line_number":2,"context_line":"Symantec Setup - User Guide"},{"line_number":3,"context_line":"**************************"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_c9f2686f","line":1,"updated":"2016-02-04 17:33:41.000000000","message":"Lines should not exceed 80 char. It won\u0027t check pep8 because it is not a .py file. Shorter lines make it more readable.\n\nmake the * fill in to the last letter","commit_id":"84dbc671c6fbd342a7af9c021331e96106d59300"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"dba0a0be9447b47c90658ffbf137acd71dadfb63","unresolved":false,"context_lines":[{"line_number":6,"context_line":"The plugin also covers all certificate lifecycle operations like Reissues, Revocation, Cancellation of an order and querying the order status."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Installing the Symantec requirements"},{"line_number":9,"context_line":"******************************"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Symantec offers a python package on PyPI, which is an interface for their official API library. The packages are available through easy_install and pip and can be downloaded using"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_29045c48","line":9,"updated":"2016-02-04 17:33:41.000000000","message":"same as 1","commit_id":"84dbc671c6fbd342a7af9c021331e96106d59300"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"dba0a0be9447b47c90658ffbf137acd71dadfb63","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Configuring Barbican to Communicate with the Symantec API"},{"line_number":19,"context_line":"**************************************************************"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"In order for Barbican to interact with the Symantec plugin, the user needs to enter their partner credentials in the Barbican config file (/etc/barbican/barbican.conf)."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_09f9604d","line":19,"updated":"2016-02-04 17:33:41.000000000","message":"same as 1","commit_id":"84dbc671c6fbd342a7af9c021331e96106d59300"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"dba0a0be9447b47c90658ffbf137acd71dadfb63","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Configuring Barbican to Communicate with the Symantec API"},{"line_number":19,"context_line":"**************************************************************"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"In order for Barbican to interact with the Symantec plugin, the user needs to enter their partner credentials in the Barbican config file (/etc/barbican/barbican.conf)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"If you are not sure what your credentials are, please talk to your Channel Account Manager at Symantec."},{"line_number":24,"context_line":"If the **testmode** parameter is set to True, the plugin will use the test API instead of production. Please note that your production credentials do not work in pilot and vice versa."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_44dadf79","line":21,"updated":"2016-02-04 17:33:41.000000000","message":"``/etc/barbican/barbican.conf``","commit_id":"84dbc671c6fbd342a7af9c021331e96106d59300"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"dba0a0be9447b47c90658ffbf137acd71dadfb63","unresolved":false,"context_lines":[{"line_number":21,"context_line":"In order for Barbican to interact with the Symantec plugin, the user needs to enter their partner credentials in the Barbican config file (/etc/barbican/barbican.conf)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"If you are not sure what your credentials are, please talk to your Channel Account Manager at Symantec."},{"line_number":24,"context_line":"If the **testmode** parameter is set to True, the plugin will use the test API instead of production. Please note that your production credentials do not work in pilot and vice versa."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Be sure to restart Barbican once these changes are made."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_24b1e347","line":24,"updated":"2016-02-04 17:33:41.000000000","message":"``testmode``","commit_id":"84dbc671c6fbd342a7af9c021331e96106d59300"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"dba0a0be9447b47c90658ffbf137acd71dadfb63","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Be sure to restart Barbican once these changes are made."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. code-block:: bash"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    [symantec_plugin]"},{"line_number":31,"context_line":"    username \u003d \u0027myusername\u0027"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_8480d747","line":28,"updated":"2016-02-04 17:33:41.000000000","message":"..code-block:: ini","commit_id":"84dbc671c6fbd342a7af9c021331e96106d59300"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a8c6ba52acfe2faffc93e9f0b20cccada24be96f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"certificates for Symantec, Thawte, GeoTrust and RapidSSL certificates using"},{"line_number":7,"context_line":"Symantec\u0027s Reseller API."},{"line_number":8,"context_line":"The plugin also covers all certificate lifecycle operations like Reissues,"},{"line_number":9,"context_line":"Revocation, Cancellation of an order and querying the order status."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Installing the Symantec requirements"},{"line_number":12,"context_line":"************************************"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a5ae5dd_36d41846","line":9,"range":{"start_line":9,"start_character":36,"end_line":9,"end_character":37},"updated":"2016-02-09 04:34:04.000000000","message":"add \u0027,\u0027","commit_id":"a5d826e131d1da5e1de05be0e058e2300dc2ed01"}],"test-requirements.txt":[{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"3b244a87435290fb5a4bc59a9be7562020c37bf9","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Symantec Plugin requirements"},{"line_number":26,"context_line":"suds\u003e\u003d0.4"},{"line_number":27,"context_line":"requests\u003e\u003d2.7"},{"line_number":28,"context_line":"suds_requests\u003e\u003d0.3"},{"line_number":29,"context_line":"symcws\u003e\u003d1.4"}],"source_content_type":"text/plain","patch_set":13,"id":"3a57f1b5_f7a1dff8","line":27,"updated":"2016-02-12 21:52:12.000000000","message":"requests is already on line 12. I think that\u0027s why one of the gates is breaking.","commit_id":"6f80830bd892b3f243e1857321e3281a1c6dbbf1"}]}
