)]}'
{"barbican/tests/plugin/test_kmip.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"991bbc20fc8a2cc64e83966d8f15043b35bfb927","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            key_spec.bit_length \u003d x"},{"line_number":221,"context_line":"            self.assertTrue(self.secret_store.generate_supports(key_spec))"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def test_generate_supports_with_uppercase_algo(self):"},{"line_number":224,"context_line":"        key_spec \u003d secret_store.KeySpec(\u0027AES\u0027, 192, \u0027mode\u0027)"},{"line_number":225,"context_line":"        self.assertTrue(self.secret_store.generate_supports(key_spec))"},{"line_number":226,"context_line":"\t\t\t"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_16a48a06","line":223,"updated":"2016-02-19 03:19:42.000000000","message":"can we spell out algorithm?  I will just comment here but its in many places.","commit_id":"1782849fb06e7b50a5ac105bb8c09a1cbe0afdeb"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"991bbc20fc8a2cc64e83966d8f15043b35bfb927","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    def test_generate_supports_with_uppercase_algo(self):"},{"line_number":224,"context_line":"        key_spec \u003d secret_store.KeySpec(\u0027AES\u0027, 192, \u0027mode\u0027)"},{"line_number":225,"context_line":"        self.assertTrue(self.secret_store.generate_supports(key_spec))"},{"line_number":226,"context_line":"\t\t\t"},{"line_number":227,"context_line":"    def test_generate_supports_with_invalid_alg(self):"},{"line_number":228,"context_line":"        key_spec \u003d secret_store.KeySpec(\u0027invalid_alg\u0027, 56, \u0027mode\u0027)"},{"line_number":229,"context_line":"        self.assertFalse(self.secret_store.generate_supports(key_spec))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_96b89a2c","line":226,"updated":"2016-02-19 03:19:42.000000000","message":"spaces here.  See the pep8 errors listed at http://logs.openstack.org/26/282126/1/check/gate-barbican-pep8/52f1911/console.html#_2016-02-19_02_52_31_187","commit_id":"1782849fb06e7b50a5ac105bb8c09a1cbe0afdeb"}],"functionaltests/api/v1/smoke/test_orders.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"991bbc20fc8a2cc64e83966d8f15043b35bfb927","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def get_diff_valid_order_create_data():"},{"line_number":37,"context_line":"    return {\u0027type\u0027: \u0027key\u0027,"},{"line_number":38,"context_line":"            \"meta\": {"},{"line_number":39,"context_line":"                \"name\": \"barbican functional test secret name\","}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_f6f646f8","line":36,"updated":"2016-02-19 03:19:42.000000000","message":"diff means different?  If so then lets spell it out.","commit_id":"1782849fb06e7b50a5ac105bb8c09a1cbe0afdeb"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"51128efaf67b9798ea1c68e73904cad704102544","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def get_diff_valid_order_create_data():"},{"line_number":37,"context_line":"    return {\u0027type\u0027: \u0027key\u0027,"},{"line_number":38,"context_line":"            \"meta\": {"},{"line_number":39,"context_line":"                \"name\": \"barbican functional test secret name\","}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_b42e71a3","line":36,"in_reply_to":"dae33548_f6f646f8","updated":"2016-02-19 07:52:04.000000000","message":"Actually this function name doesn\u0027t really tell me much. \"different valid order\".. different from what?","commit_id":"1782849fb06e7b50a5ac105bb8c09a1cbe0afdeb"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"991bbc20fc8a2cc64e83966d8f15043b35bfb927","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                        order_resp.model.status \u003d\u003d \"PENDING\")"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":157,"context_line":"    def test_order_get_uppercase_algo(self):"},{"line_number":158,"context_line":"        \"\"\"Covers getting an order with uppercase algo and length."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"         Assumes that the order status will be active or pending."}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_f69c865f","line":157,"updated":"2016-02-19 03:19:42.000000000","message":"I would say this isn\u0027t a smoke test but rather a normal functional test.  Think about moving it from smoke to functional.  There are also some existing parameterized functional tests that you can extend by just adding a line of data - see https://github.com/openstack/barbican/blob/master/functionaltests/api/v1/functional/test_orders.py#L389","commit_id":"1782849fb06e7b50a5ac105bb8c09a1cbe0afdeb"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"339fbd91c3fc4ea035f05a6de3bc97553b31a7dd","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                        order_resp.model.status \u003d\u003d \"PENDING\")"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":157,"context_line":"    def test_order_get_uppercase_algo(self):"},{"line_number":158,"context_line":"        \"\"\"Covers getting an order with uppercase algo and length."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"         Assumes that the order status will be active or pending."}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_99151d9d","line":157,"in_reply_to":"dae33548_5408c52d","updated":"2016-02-22 00:24:32.000000000","message":"Good point sir!\n\nSmoke test should be the really basic, simple \"happy path\" types of tests - enough for someone to run them and be able to say \"hey, it looks like the basic stuff is working\".  Tests that cover more interesting things - like variations of parameters should go under the functional.  That\u0027s where all of the heavy lifting is done.","commit_id":"1782849fb06e7b50a5ac105bb8c09a1cbe0afdeb"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"51128efaf67b9798ea1c68e73904cad704102544","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                        order_resp.model.status \u003d\u003d \"PENDING\")"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":157,"context_line":"    def test_order_get_uppercase_algo(self):"},{"line_number":158,"context_line":"        \"\"\"Covers getting an order with uppercase algo and length."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"         Assumes that the order status will be active or pending."}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_5408c52d","line":157,"in_reply_to":"dae33548_f69c865f","updated":"2016-02-19 07:52:04.000000000","message":"Steve: I think it would be more beneficial to the reviewer if you would explain why this wouldn\u0027t be considered a smoke test.","commit_id":"1782849fb06e7b50a5ac105bb8c09a1cbe0afdeb"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"991bbc20fc8a2cc64e83966d8f15043b35bfb927","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        self.assertEqual(create_resp.status_code, 202)"},{"line_number":169,"context_line":"        self.assertIsNotNone(order_ref)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # get the order "},{"line_number":172,"context_line":"        order_resp \u003d self.behaviors.get_order(order_ref)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # verify the order"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_b6d31e5f","line":171,"updated":"2016-02-19 03:19:42.000000000","message":"nit - space","commit_id":"1782849fb06e7b50a5ac105bb8c09a1cbe0afdeb"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"991bbc20fc8a2cc64e83966d8f15043b35bfb927","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.assertEqual(order_resp.model.type, \u0027key\u0027)"},{"line_number":178,"context_line":"        self.assertTrue(order_resp.model.status \u003d\u003d \"ACTIVE\" or"},{"line_number":179,"context_line":"                        order_resp.model.status \u003d\u003d \"PENDING\")"},{"line_number":180,"context_line":"        if order_resp.model.status \u003d\u003d \"ACTIVE\":"},{"line_number":181,"context_line":"            self.assertIsNotNone(order_resp.model.secret_ref)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @testcase.attr(\u0027positive\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_96753a34","line":180,"updated":"2016-02-19 03:19:42.000000000","message":"you can also poll for ACTIVE order state - see https://github.com/openstack/barbican/blob/master/functionaltests/api/v1/functional/test_orders.py#L94","commit_id":"1782849fb06e7b50a5ac105bb8c09a1cbe0afdeb"}]}