)]}'
{"barbican/cmd/db_manage.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            \u0027clean\u0027,"},{"line_number":108,"context_line":"            help\u003d\u0027Clean up soft deletions in the database\u0027)"},{"line_number":109,"context_line":"        create_parser.add_argument("},{"line_number":110,"context_line":"            \u0027--min_num_days_keep_soft_deletions\u0027, \u0027-d\u0027,"},{"line_number":111,"context_line":"            type\u003dint,"},{"line_number":112,"context_line":"            default\u003d90,"},{"line_number":113,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_b41eda6d","line":110,"updated":"2016-02-29 15:46:27.000000000","message":"See my comment in the docs page.","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            \u0027clean\u0027,"},{"line_number":108,"context_line":"            help\u003d\u0027Clean up soft deletions in the database\u0027)"},{"line_number":109,"context_line":"        create_parser.add_argument("},{"line_number":110,"context_line":"            \u0027--min_num_days_keep_soft_deletions\u0027, \u0027-d\u0027,"},{"line_number":111,"context_line":"            type\u003dint,"},{"line_number":112,"context_line":"            default\u003d90,"},{"line_number":113,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_5a4175a8","line":110,"in_reply_to":"9aed3d3a_b41eda6d","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"27ca27730e91d99e5c2d24c4c8eedfc4c7c00149","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u0027--min_num_days_keep_soft_deletions\u0027, \u0027-d\u0027,"},{"line_number":111,"context_line":"            type\u003dint,"},{"line_number":112,"context_line":"            default\u003d90,"},{"line_number":113,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions\u0027)"},{"line_number":114,"context_line":"        create_parser.add_argument(\u0027--clean_unassociated_projects\u0027, \u0027-p\u0027,"},{"line_number":115,"context_line":"                                   action\u003d\"store_true\","},{"line_number":116,"context_line":"                                   help\u003d\u0027remove projects that have no \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_88a9447e","line":113,"updated":"2016-02-26 22:36:46.000000000","message":"Can you put 90 in the output of the help? That way the user is aware of the default value. I think inside help you can put this, %(default)s, and that will output the default value.","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u0027--min_num_days_keep_soft_deletions\u0027, \u0027-d\u0027,"},{"line_number":111,"context_line":"            type\u003dint,"},{"line_number":112,"context_line":"            default\u003d90,"},{"line_number":113,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions\u0027)"},{"line_number":114,"context_line":"        create_parser.add_argument(\u0027--clean_unassociated_projects\u0027, \u0027-p\u0027,"},{"line_number":115,"context_line":"                                   action\u003d\"store_true\","},{"line_number":116,"context_line":"                                   help\u003d\u0027remove projects that have no \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_918e4877","line":113,"in_reply_to":"9aed3d3a_88a9447e","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            type\u003dint,"},{"line_number":112,"context_line":"            default\u003d90,"},{"line_number":113,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions\u0027)"},{"line_number":114,"context_line":"        create_parser.add_argument(\u0027--clean_unassociated_projects\u0027, \u0027-p\u0027,"},{"line_number":115,"context_line":"                                   action\u003d\"store_true\","},{"line_number":116,"context_line":"                                   help\u003d\u0027remove projects that have no \u0027"},{"line_number":117,"context_line":"                                        \u0027associated resources\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_34764ad7","line":114,"updated":"2016-02-29 15:46:27.000000000","message":"change \u0027_\u0027 to \u0027-\u0027.","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            type\u003dint,"},{"line_number":112,"context_line":"            default\u003d90,"},{"line_number":113,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions\u0027)"},{"line_number":114,"context_line":"        create_parser.add_argument(\u0027--clean_unassociated_projects\u0027, \u0027-p\u0027,"},{"line_number":115,"context_line":"                                   action\u003d\"store_true\","},{"line_number":116,"context_line":"                                   help\u003d\u0027remove projects that have no \u0027"},{"line_number":117,"context_line":"                                        \u0027associated resources\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_45ee4023","line":114,"in_reply_to":"9aed3d3a_34764ad7","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"27ca27730e91d99e5c2d24c4c8eedfc4c7c00149","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                   default\u003d\u0027/var/log/barbican/\u0027"},{"line_number":126,"context_line":"                                   \u0027barbican-clean.log\u0027,"},{"line_number":127,"context_line":"                                   type\u003dstr,"},{"line_number":128,"context_line":"                                   help\u003d\u0027set log file location\u0027)"},{"line_number":129,"context_line":"        create_parser.set_defaults(func\u003dself.clean)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def revision(self, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_48f45c86","line":128,"updated":"2016-02-26 22:36:46.000000000","message":"Same here. Put default location in help output. Also, when I ran the script to clean I got an error that the log file does not exist. Should the user create the file then run this or should the script just create the file? And if a file already exists where the log file is, say I ran it twice in the past 180 days, will the old log file get overwritten?","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                   default\u003d\u0027/var/log/barbican/\u0027"},{"line_number":126,"context_line":"                                   \u0027barbican-clean.log\u0027,"},{"line_number":127,"context_line":"                                   type\u003dstr,"},{"line_number":128,"context_line":"                                   help\u003d\u0027set log file location\u0027)"},{"line_number":129,"context_line":"        create_parser.set_defaults(func\u003dself.clean)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def revision(self, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_71ec64f3","line":128,"in_reply_to":"9aed3d3a_48f45c86","updated":"2016-03-01 18:35:27.000000000","message":"I will use the default setting in the barbican.conf file, then allow the user to set an alternative log location.","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                   default\u003d\u0027/var/log/barbican/\u0027"},{"line_number":126,"context_line":"                                   \u0027barbican-clean.log\u0027,"},{"line_number":127,"context_line":"                                   type\u003dstr,"},{"line_number":128,"context_line":"                                   help\u003d\u0027set log file location\u0027)"},{"line_number":129,"context_line":"        create_parser.set_defaults(func\u003dself.clean)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def revision(self, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_f4cce2bc","line":128,"in_reply_to":"9aed3d3a_48f45c86","updated":"2016-02-29 15:46:27.000000000","message":"Set the log to the default Barbican log file.","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                   default\u003d\u0027/var/log/barbican/\u0027"},{"line_number":126,"context_line":"                                   \u0027barbican-clean.log\u0027,"},{"line_number":127,"context_line":"                                   type\u003dstr,"},{"line_number":128,"context_line":"                                   help\u003d\u0027set log file location\u0027)"},{"line_number":129,"context_line":"        create_parser.set_defaults(func\u003dself.clean)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def revision(self, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_3a3e3128","line":128,"in_reply_to":"9aed3d3a_f4cce2bc","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"5ddefd26c40b8b3d2d95475a6b611afa821e8685","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            \u0027clean\u0027,"},{"line_number":108,"context_line":"            help\u003d\u0027Clean up soft deletions in the database\u0027)"},{"line_number":109,"context_line":"        create_parser.add_argument("},{"line_number":110,"context_line":"            \u0027--min-days\u0027, \u0027-d\u0027,"},{"line_number":111,"context_line":"            type\u003dint,"},{"line_number":112,"context_line":"            default\u003d90,"},{"line_number":113,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions. default is\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_5bda0ae9","line":110,"updated":"2016-03-03 17:22:21.000000000","message":"I think the --min-days flag should be changed to \u0027-m\u0027. That\u0027s what it is in the barbican_manage module so it would be consistent. Also \u0027-d\u0027 is also the flag for the \u0027--dburl\u0027 parameter.","commit_id":"ec8f7b24b2f97868e42941c3e7b55481601d1299"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"2e5337d6c4297fb9ab409369b8f146e847f74005","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            \u0027clean\u0027,"},{"line_number":108,"context_line":"            help\u003d\u0027Clean up soft deletions in the database\u0027)"},{"line_number":109,"context_line":"        create_parser.add_argument("},{"line_number":110,"context_line":"            \u0027--min-days\u0027, \u0027-d\u0027,"},{"line_number":111,"context_line":"            type\u003dint,"},{"line_number":112,"context_line":"            default\u003d90,"},{"line_number":113,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions. default is\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_ecfcf7b9","line":110,"in_reply_to":"7af24918_5bda0ae9","updated":"2016-03-03 18:15:43.000000000","message":"Done","commit_id":"ec8f7b24b2f97868e42941c3e7b55481601d1299"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"6fcd9b7a1433929ec57984d0d15dbec55d5b675b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            \u0027clean\u0027,"},{"line_number":108,"context_line":"            help\u003d\u0027Clean up soft deletions in the database\u0027)"},{"line_number":109,"context_line":"        create_parser.add_argument("},{"line_number":110,"context_line":"            \u0027--min-days\u0027, \u0027-m\u0027,"},{"line_number":111,"context_line":"            type\u003dint,"},{"line_number":112,"context_line":"            default\u003d90,"},{"line_number":113,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions. default is\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_66c0fb50","line":110,"updated":"2016-03-03 21:06:33.000000000","message":"I would move this up to line 109. That way we keep it consistent with the rest of the arguments below.","commit_id":"7f38fa9291f08e58ead17604b9bf17ac6d41c997"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"1e653f397d8f4fccad7865a0293010a5673ca5b7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            \u0027clean\u0027,"},{"line_number":108,"context_line":"            help\u003d\u0027Clean up soft deletions in the database\u0027)"},{"line_number":109,"context_line":"        create_parser.add_argument("},{"line_number":110,"context_line":"            \u0027--min-days\u0027, \u0027-m\u0027,"},{"line_number":111,"context_line":"            type\u003dint,"},{"line_number":112,"context_line":"            default\u003d90,"},{"line_number":113,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions. default is\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_3a08c3d9","line":110,"in_reply_to":"7af24918_66c0fb50","updated":"2016-03-03 22:53:09.000000000","message":"Done","commit_id":"7f38fa9291f08e58ead17604b9bf17ac6d41c997"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"0104353803bd2f3a792744b26a5f0f2cc693baea","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        create_parser.add_argument("},{"line_number":110,"context_line":"            \u0027--min-days\u0027, \u0027-m\u0027, type\u003dint, default\u003d90,"},{"line_number":111,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions. default is\u0027"},{"line_number":112,"context_line":"                 \u0027 90 %(default)s days.\u0027)"},{"line_number":113,"context_line":"        create_parser.add_argument(\u0027--clean-unassociated-projects\u0027, \u0027-p\u0027,"},{"line_number":114,"context_line":"                                   action\u003d\"store_true\","},{"line_number":115,"context_line":"                                   help\u003d\u0027Remove projects that have no \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_c8ebd5da","line":112,"updated":"2016-03-03 23:54:17.000000000","message":"With the %{} slot now, is the static \u002790\u0027 required anymore?","commit_id":"81212ac72d87c16acbebc764dc17319ea16d4096"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"2595994bbf751bbb281d04ef62016b078887f760","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        create_parser.add_argument("},{"line_number":110,"context_line":"            \u0027--min-days\u0027, \u0027-m\u0027, type\u003dint, default\u003d90,"},{"line_number":111,"context_line":"            help\u003d\u0027minimum number of days to keep soft deletions. default is\u0027"},{"line_number":112,"context_line":"                 \u0027 90 %(default)s days.\u0027)"},{"line_number":113,"context_line":"        create_parser.add_argument(\u0027--clean-unassociated-projects\u0027, \u0027-p\u0027,"},{"line_number":114,"context_line":"                                   action\u003d\"store_true\","},{"line_number":115,"context_line":"                                   help\u003d\u0027Remove projects that have no \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_0ce771ac","line":112,"in_reply_to":"7af24918_c8ebd5da","updated":"2016-03-04 15:41:29.000000000","message":"Done","commit_id":"81212ac72d87c16acbebc764dc17319ea16d4096"}],"barbican/model/clean.py":[{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"27ca27730e91d99e5c2d24c4c8eedfc4c7c00149","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    tables and removes them."},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    LOG.debug(\"Cleaning up unassociated projects\")"},{"line_number":46,"context_line":"    session \u003d repo.get_session()"},{"line_number":47,"context_line":"    project_children_tables \u003d [models.KEKDatum,"},{"line_number":48,"context_line":"                               models.Secret,"},{"line_number":49,"context_line":"                               models.ContainerConsumerMetadatum,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_0b240ead","line":46,"updated":"2016-02-26 22:36:46.000000000","message":"I think you need to add models.Orders to the list of project_children_tables. Orders are also associated with a project.","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    tables and removes them."},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    LOG.debug(\"Cleaning up unassociated projects\")"},{"line_number":46,"context_line":"    session \u003d repo.get_session()"},{"line_number":47,"context_line":"    project_children_tables \u003d [models.KEKDatum,"},{"line_number":48,"context_line":"                               models.Secret,"},{"line_number":49,"context_line":"                               models.ContainerConsumerMetadatum,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_914c88c9","line":46,"in_reply_to":"9aed3d3a_0b240ead","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    return delete_count"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def cleanup_parent_with_no_child(parent_model, child_model,"},{"line_number":70,"context_line":"                                 threshold_date\u003dNone):"},{"line_number":71,"context_line":"    \"\"\"Clean up soft deletions in parent that do not have references in child"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_ee289335","line":69,"updated":"2016-02-29 15:46:27.000000000","message":"Please add some :param and :return","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    return delete_count"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def cleanup_parent_with_no_child(parent_model, child_model,"},{"line_number":70,"context_line":"                                 threshold_date\u003dNone):"},{"line_number":71,"context_line":"    \"\"\"Clean up soft deletions in parent that do not have references in child"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_a56a267f","line":69,"in_reply_to":"9aed3d3a_ee289335","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    return delete_count"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def cleanup_softdeletes(model, threshold_date\u003dNone):"},{"line_number":100,"context_line":"    \"\"\"Removes soft deletions from a table\"\"\""},{"line_number":101,"context_line":"    LOG.debug(\"Cleaning soft deletes: %s\", model.__name__)"},{"line_number":102,"context_line":"    session \u003d repo.get_session()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_0e8177c3","line":99,"updated":"2016-02-29 15:46:27.000000000","message":"Please add some :param and :return","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    return delete_count"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def cleanup_softdeletes(model, threshold_date\u003dNone):"},{"line_number":100,"context_line":"    \"\"\"Removes soft deletions from a table\"\"\""},{"line_number":101,"context_line":"    LOG.debug(\"Cleaning soft deletes: %s\", model.__name__)"},{"line_number":102,"context_line":"    session \u003d repo.get_session()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_250d76e8","line":99,"in_reply_to":"9aed3d3a_0e8177c3","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    return delete_count"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def cleanup_all(threshold_date\u003dNone):"},{"line_number":114,"context_line":"    \"\"\"Cleans up the main soft deletable  resources."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    This function contains an order of calls to"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_8e7587fb","line":113,"updated":"2016-02-29 15:46:27.000000000","message":"Please add some :param and :return","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    return delete_count"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def cleanup_all(threshold_date\u003dNone):"},{"line_number":114,"context_line":"    \"\"\"Cleans up the main soft deletable  resources."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    This function contains an order of calls to"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_65cc9e6a","line":113,"in_reply_to":"9aed3d3a_8e7587fb","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    return total"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def _soft_delete_expired_secrets(threshold_date):"},{"line_number":153,"context_line":"    \"\"\"Sof delete exipred secrets.\"\"\""},{"line_number":154,"context_line":"    current_time \u003d timeutils.utcnow()"},{"line_number":155,"context_line":"    session \u003d repo.get_session()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_0ecfb729","line":152,"updated":"2016-02-29 15:46:27.000000000","message":"Please add some :param and :return","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    return total"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def _soft_delete_expired_secrets(threshold_date):"},{"line_number":153,"context_line":"    \"\"\"Sof delete exipred secrets.\"\"\""},{"line_number":154,"context_line":"    current_time \u003d timeutils.utcnow()"},{"line_number":155,"context_line":"    session \u003d repo.get_session()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_055dd278","line":152,"in_reply_to":"9aed3d3a_0ecfb729","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"27ca27730e91d99e5c2d24c4c8eedfc4c7c00149","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def _soft_delete_expired_secrets(threshold_date):"},{"line_number":153,"context_line":"    \"\"\"Sof delete exipred secrets.\"\"\""},{"line_number":154,"context_line":"    current_time \u003d timeutils.utcnow()"},{"line_number":155,"context_line":"    session \u003d repo.get_session()"},{"line_number":156,"context_line":"    query \u003d session.query(models.Secret.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_a8ab681c","line":153,"updated":"2016-02-26 22:36:46.000000000","message":"nit: mispellings in this comment.","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def _soft_delete_expired_secrets(threshold_date):"},{"line_number":153,"context_line":"    \"\"\"Sof delete exipred secrets.\"\"\""},{"line_number":154,"context_line":"    current_time \u003d timeutils.utcnow()"},{"line_number":155,"context_line":"    session \u003d repo.get_session()"},{"line_number":156,"context_line":"    query \u003d session.query(models.Secret.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_da9625ef","line":153,"in_reply_to":"9aed3d3a_a8ab681c","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    return acl_total"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def _soft_delete_expired_secret_children(threshold_date):"},{"line_number":203,"context_line":"    current_time \u003d timeutils.utcnow()"},{"line_number":204,"context_line":"    \"\"\"Soft delete the children tables of expired secrets\"\"\""},{"line_number":205,"context_line":"    secret_and_children \u003d [models.SecretStoreMetadatum,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_d4055e7a","line":202,"updated":"2016-02-29 15:46:27.000000000","message":"Please add some :param and :return","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    return acl_total"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def _soft_delete_expired_secret_children(threshold_date):"},{"line_number":203,"context_line":"    current_time \u003d timeutils.utcnow()"},{"line_number":204,"context_line":"    \"\"\"Soft delete the children tables of expired secrets\"\"\""},{"line_number":205,"context_line":"    secret_and_children \u003d [models.SecretStoreMetadatum,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_a52d06aa","line":202,"in_reply_to":"9aed3d3a_d4055e7a","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    return update_count, acl_total"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def soft_delete_expired_secrets(threshold_date):"},{"line_number":238,"context_line":"    \"\"\"Soft deletes secrets that are past expiration date."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    The expired secrets and its children are marked for deletion."}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_14fce670","line":237,"updated":"2016-02-29 15:46:27.000000000","message":"Please add some :param and :return","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    return update_count, acl_total"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def soft_delete_expired_secrets(threshold_date):"},{"line_number":238,"context_line":"    \"\"\"Soft deletes secrets that are past expiration date."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    The expired secrets and its children are marked for deletion."}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_c07ab887","line":237,"in_reply_to":"9aed3d3a_14fce670","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":257,"context_line":"class BarbicanDBCleanCommands(object):"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @staticmethod"},{"line_number":260,"context_line":"    def clean(sql_url, min_num_days, do_clean_unassociated_projects,"},{"line_number":261,"context_line":"              do_soft_delete_expired_secrets, verbose, log_file):"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        if not verbose:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_34f76a8c","line":260,"updated":"2016-02-29 15:46:27.000000000","message":"Please add some :param and :return","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"27ca27730e91d99e5c2d24c4c8eedfc4c7c00149","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    def clean(sql_url, min_num_days, do_clean_unassociated_projects,"},{"line_number":261,"context_line":"              do_soft_delete_expired_secrets, verbose, log_file):"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        if not verbose:"},{"line_number":264,"context_line":"            # Do not show log level info in terminal output by default"},{"line_number":265,"context_line":"            CONF.set_override(\u0027use_stderr\u0027, False)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_2b10f200","line":263,"updated":"2016-02-26 22:36:46.000000000","message":"You override verbose, you should clear it at the end.","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    def clean(sql_url, min_num_days, do_clean_unassociated_projects,"},{"line_number":261,"context_line":"              do_soft_delete_expired_secrets, verbose, log_file):"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        if not verbose:"},{"line_number":264,"context_line":"            # Do not show log level info in terminal output by default"},{"line_number":265,"context_line":"            CONF.set_override(\u0027use_stderr\u0027, False)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_ffccbbbc","line":263,"in_reply_to":"9aed3d3a_2b10f200","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"d31099fe50654c7bd30c53e46d7e20430ab7bb43","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                elapsed_time)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"            if not verbose:"},{"line_number":315,"context_line":"                print(finish_messg)"},{"line_number":316,"context_line":"            else:"},{"line_number":317,"context_line":"                LOG.info(finish_messg)"},{"line_number":318,"context_line":"                CONF.clear_override(\u0027use_stderr\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_19dc1272","line":315,"updated":"2016-02-29 18:27:01.000000000","message":"Why are you not just LOG.info-ing this, rather than print-ing?","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                elapsed_time)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"            if not verbose:"},{"line_number":315,"context_line":"                print(finish_messg)"},{"line_number":316,"context_line":"            else:"},{"line_number":317,"context_line":"                LOG.info(finish_messg)"},{"line_number":318,"context_line":"                CONF.clear_override(\u0027use_stderr\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_0367804d","line":315,"in_reply_to":"9aed3d3a_19dc1272","updated":"2016-03-01 18:35:27.000000000","message":"Thx for the review! \nSo I want to do this:\n\nLog file will always have more information. It will have alot of INFO entries.\n\nUser will be able to set verbose -V. If user does not set it, the user will only see the total number of entries removed and time taken for deletion.\n\nIf user sets verbose, then all the INFO entries will be print out to the screen.","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"6fcd9b7a1433929ec57984d0d15dbec55d5b675b","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    :param verbose: If True, print more information to the terminal"},{"line_number":306,"context_line":"    :param log_file: If set, override the log_file configured"},{"line_number":307,"context_line":"    \"\"\""},{"line_number":308,"context_line":"    # TODO(edtubill) Make unit test for this method"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    if not verbose:"},{"line_number":311,"context_line":"        # The verbose flag prints out the INFO logs to the screen. Otherwise"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_81953134","line":308,"updated":"2016-03-03 21:06:33.000000000","message":"Sounds good.","commit_id":"7f38fa9291f08e58ead17604b9bf17ac6d41c997"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"0104353803bd2f3a792744b26a5f0f2cc693baea","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            elapsed_time)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if not verbose:"},{"line_number":363,"context_line":"            print(finish_messg)"},{"line_number":364,"context_line":"            CONF.clear_override(\u0027use_stderr\u0027)"},{"line_number":365,"context_line":"        else:"},{"line_number":366,"context_line":"            LOG.info(finish_messg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_68e601e9","line":363,"updated":"2016-03-03 23:54:17.000000000","message":"I\u0027m still not liking the print statements here. I always feel like using \u0027print\u0027 is for POC/demo/script code, whereas using the logger is the standard way to get text out of an app. So verbose mode just dumps more low level data to the standard output...so more LOG.debug() lines seen than LOG.info() lines. So controlling the verbosity level here would be more of setting the min logging level to debug or info rather than an \u0027if\u0027 check.","commit_id":"81212ac72d87c16acbebc764dc17319ea16d4096"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"2595994bbf751bbb281d04ef62016b078887f760","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            elapsed_time)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if not verbose:"},{"line_number":363,"context_line":"            print(finish_messg)"},{"line_number":364,"context_line":"            CONF.clear_override(\u0027use_stderr\u0027)"},{"line_number":365,"context_line":"        else:"},{"line_number":366,"context_line":"            LOG.info(finish_messg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_cd3903a6","line":363,"in_reply_to":"7af24918_68e601e9","updated":"2016-03-04 15:41:29.000000000","message":"I will get rid of the print statements and change the verbose to set the logging level to debug","commit_id":"81212ac72d87c16acbebc764dc17319ea16d4096"}],"doc/source/admin-guide-cloud/database_cleaning.rst":[{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"5ddefd26c40b8b3d2d95475a6b611afa821e8685","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"```barbican-manage db clean --min-days 180``` (```-m```) will go"},{"line_number":17,"context_line":"through the database and remove soft deleted entries that are at least 90 days"},{"line_number":18,"context_line":"old since deletion. The default value is 90 days."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"```barbican-manage db clean --clean-unassociated-projects``` (```-p```) will go"},{"line_number":21,"context_line":"through the database and remove projects that have no associated resources."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_dd0bb2d4","line":18,"updated":"2016-03-03 17:22:21.000000000","message":"It\u0027d be nice to add a sentence explaining that in order to delete all soft-deleted entries up to today \u0027-m 0\u0027 will work.","commit_id":"ec8f7b24b2f97868e42941c3e7b55481601d1299"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"2e5337d6c4297fb9ab409369b8f146e847f74005","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"```barbican-manage db clean --min-days 180``` (```-m```) will go"},{"line_number":17,"context_line":"through the database and remove soft deleted entries that are at least 90 days"},{"line_number":18,"context_line":"old since deletion. The default value is 90 days."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"```barbican-manage db clean --clean-unassociated-projects``` (```-p```) will go"},{"line_number":21,"context_line":"through the database and remove projects that have no associated resources."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_6f29f989","line":18,"in_reply_to":"7af24918_dd0bb2d4","updated":"2016-03-03 18:15:43.000000000","message":"Done","commit_id":"ec8f7b24b2f97868e42941c3e7b55481601d1299"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"5ddefd26c40b8b3d2d95475a6b611afa821e8685","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"```barbican-manage db clean --soft-delete-expired-secrets``` (```-e```) will go"},{"line_number":25,"context_line":"through the database and soft delete any secrets that are past"},{"line_number":26,"context_line":"their expiration date. The default value is False."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"```barbican-manage db clean --verbose``` (```-V```) will print more information"},{"line_number":29,"context_line":"out into the terminal."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_a0531938","line":26,"updated":"2016-03-03 17:22:21.000000000","message":"If I put both \u0027-e\u0027 and \u0027-m 0\u0027 then the secret will not just be soft deleted but hard deleted. I think that\u0027s worth adding to the documentation. That if you tell clean to soft delete an expired secret and the secret is also older than the minimum days required to delete it, then the secret will be hard deleted.","commit_id":"ec8f7b24b2f97868e42941c3e7b55481601d1299"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"2e5337d6c4297fb9ab409369b8f146e847f74005","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"```barbican-manage db clean --soft-delete-expired-secrets``` (```-e```) will go"},{"line_number":25,"context_line":"through the database and soft delete any secrets that are past"},{"line_number":26,"context_line":"their expiration date. The default value is False."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"```barbican-manage db clean --verbose``` (```-V```) will print more information"},{"line_number":29,"context_line":"out into the terminal."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_af1f8159","line":26,"in_reply_to":"7af24918_a0531938","updated":"2016-03-03 18:15:43.000000000","message":"Done","commit_id":"ec8f7b24b2f97868e42941c3e7b55481601d1299"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"5ddefd26c40b8b3d2d95475a6b611afa821e8685","unresolved":false,"context_lines":[{"line_number":57,"context_line":"will clean unassociated projects, and will soft delete secrets that are"},{"line_number":58,"context_line":"expired."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"```00 03 01 * * barbican-manage db clean -d 30``` -Runs a job every month at 3AM"},{"line_number":61,"context_line":"which will remove soft deleted entries that are at least 30 days old since"},{"line_number":62,"context_line":"deletion."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_7b6a66b4","line":60,"updated":"2016-03-03 17:22:21.000000000","message":"-d should be -m","commit_id":"ec8f7b24b2f97868e42941c3e7b55481601d1299"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"2e5337d6c4297fb9ab409369b8f146e847f74005","unresolved":false,"context_lines":[{"line_number":57,"context_line":"will clean unassociated projects, and will soft delete secrets that are"},{"line_number":58,"context_line":"expired."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"```00 03 01 * * barbican-manage db clean -d 30``` -Runs a job every month at 3AM"},{"line_number":61,"context_line":"which will remove soft deleted entries that are at least 30 days old since"},{"line_number":62,"context_line":"deletion."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_8f2285a1","line":60,"in_reply_to":"7af24918_7b6a66b4","updated":"2016-03-03 18:15:43.000000000","message":"Done","commit_id":"ec8f7b24b2f97868e42941c3e7b55481601d1299"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"5ddefd26c40b8b3d2d95475a6b611afa821e8685","unresolved":false,"context_lines":[{"line_number":61,"context_line":"which will remove soft deleted entries that are at least 30 days old since"},{"line_number":62,"context_line":"deletion."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"```05 01 07 * 6 barbican-manage db clean -d 180 -p -e -L /tmp/barbican-clean-command.log```"},{"line_number":65,"context_line":"-Runs a job every month at 1:05AM on the 7th day of the month and every Saturday."},{"line_number":66,"context_line":"Entries that are 180 days old since soft deletion will be removed from the"},{"line_number":67,"context_line":"database. Unassociated projects will be removed. Expired secrets will be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_5b67aae8","line":64,"updated":"2016-03-03 17:22:21.000000000","message":"Same as comment above.","commit_id":"ec8f7b24b2f97868e42941c3e7b55481601d1299"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"2e5337d6c4297fb9ab409369b8f146e847f74005","unresolved":false,"context_lines":[{"line_number":61,"context_line":"which will remove soft deleted entries that are at least 30 days old since"},{"line_number":62,"context_line":"deletion."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"```05 01 07 * 6 barbican-manage db clean -d 180 -p -e -L /tmp/barbican-clean-command.log```"},{"line_number":65,"context_line":"-Runs a job every month at 1:05AM on the 7th day of the month and every Saturday."},{"line_number":66,"context_line":"Entries that are 180 days old since soft deletion will be removed from the"},{"line_number":67,"context_line":"database. Unassociated projects will be removed. Expired secrets will be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_ef3d09c5","line":64,"in_reply_to":"7af24918_5b67aae8","updated":"2016-03-03 18:15:43.000000000","message":"Done","commit_id":"ec8f7b24b2f97868e42941c3e7b55481601d1299"},{"author":{"_account_id":14926,"name":"Jeff Feng","email":"jianhua@us.ibm.com","username":"jhfeng"},"change_message_id":"92b1ed69f305f32cf5604532038e2607d0783d9e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The command ```barbican-manage db clean``` can be used to clean up the database."},{"line_number":13,"context_line":"By default, it will remove soft deletions that are at least 90 days old since"},{"line_number":14,"context_line":"deletion"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"```barbican-manage db clean --min-days 180``` (```-m```) will go"},{"line_number":17,"context_line":"through the database and remove soft deleted entries that are at least 90 days"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7af24918_976610eb","line":14,"updated":"2016-03-03 22:35:46.000000000","message":"I think a --dry-run option should be useful for hard-deletion option. Has it been discussed in bp reviewing ?","commit_id":"7f38fa9291f08e58ead17604b9bf17ac6d41c997"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"1e653f397d8f4fccad7865a0293010a5673ca5b7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The command ```barbican-manage db clean``` can be used to clean up the database."},{"line_number":13,"context_line":"By default, it will remove soft deletions that are at least 90 days old since"},{"line_number":14,"context_line":"deletion"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"```barbican-manage db clean --min-days 180``` (```-m```) will go"},{"line_number":17,"context_line":"through the database and remove soft deleted entries that are at least 90 days"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7af24918_dae1df2b","line":14,"in_reply_to":"7af24918_976610eb","updated":"2016-03-03 22:53:09.000000000","message":"It has not been discussed, but that sounds like a nice feature.\nDo you know what kind of information you would like to see during the dry run?","commit_id":"7f38fa9291f08e58ead17604b9bf17ac6d41c997"},{"author":{"_account_id":14926,"name":"Jeff Feng","email":"jianhua@us.ibm.com","username":"jhfeng"},"change_message_id":"8b790ecdfbcc508a09fb4a4c47efe2fe23498c35","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The command ```barbican-manage db clean``` can be used to clean up the database."},{"line_number":13,"context_line":"By default, it will remove soft deletions that are at least 90 days old since"},{"line_number":14,"context_line":"deletion"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"```barbican-manage db clean --min-days 180``` (```-m```) will go"},{"line_number":17,"context_line":"through the database and remove soft deleted entries that are at least 90 days"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7af24918_7d088528","line":14,"in_reply_to":"7af24918_dae1df2b","updated":"2016-03-03 23:08:16.000000000","message":"mainly under each project name, which secret(s) will be hard-deleted by clean operation. It gives admin last chance to review what\u0027s the impact of running clean operation. The information should be readable and meaningful. So secret name not secret uuid should be displayed, total number of secrets to be removed will be useful also.\n\n\nif it wasn\u0027t discussed in bp reviewing, don\u0027t worry it in this CR. We can add it later when community ask this feature.","commit_id":"7f38fa9291f08e58ead17604b9bf17ac6d41c997"}],"doc/source/contribute/database_cleaning.rst":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Database Cleaning"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Entries in the Barbican database are soft deleted and can build up over time."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aed3d3a_8e7f47aa","line":1,"updated":"2016-02-29 15:46:27.000000000","message":"Add this page to the index","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Database Cleaning"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Entries in the Barbican database are soft deleted and can build up over time."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aed3d3a_da05857a","line":1,"in_reply_to":"9aed3d3a_8e7f47aa","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"By default, it will remove soft deletions that are at least 90 days old since"},{"line_number":14,"context_line":"deletion and will try to save a log in ```/var/log/barbican/barbican-clean.log```."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"```barbican-db-manage clean --min_num_days_keep_soft_deletions 180``` (```-d```) will go"},{"line_number":17,"context_line":"through the database and remove soft deleted entries that are at least 90 days"},{"line_number":18,"context_line":"old since deletion. The default value is 90 days."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aed3d3a_b1e38cd8","line":16,"updated":"2016-02-29 15:46:27.000000000","message":"consider renaming this to something shorter. Maybe just \"min_days\"\nAlso change \u0027_\u0027 to \u0027-\u0027","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":13,"context_line":"By default, it will remove soft deletions that are at least 90 days old since"},{"line_number":14,"context_line":"deletion and will try to save a log in ```/var/log/barbican/barbican-clean.log```."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"```barbican-db-manage clean --min_num_days_keep_soft_deletions 180``` (```-d```) will go"},{"line_number":17,"context_line":"through the database and remove soft deleted entries that are at least 90 days"},{"line_number":18,"context_line":"old since deletion. The default value is 90 days."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aed3d3a_da83c554","line":16,"in_reply_to":"9aed3d3a_b1e38cd8","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e41796355034600e59e103564df36b854742d1eb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"through the database and remove soft deleted entries that are at least 90 days"},{"line_number":18,"context_line":"old since deletion. The default value is 90 days."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"```barbican-db-manage clean --clean_unassociated_projects``` (```-p```) will go through"},{"line_number":21,"context_line":"the database and remove projects that have no associated resources."},{"line_number":22,"context_line":"The default value is False."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aed3d3a_b10a6c88","line":20,"updated":"2016-02-29 15:46:27.000000000","message":"change \u0027_\u0027 to \u0027-\u0027","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"429d6f688138fc4bbd74d8a34a14561f8117e010","unresolved":false,"context_lines":[{"line_number":17,"context_line":"through the database and remove soft deleted entries that are at least 90 days"},{"line_number":18,"context_line":"old since deletion. The default value is 90 days."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"```barbican-db-manage clean --clean_unassociated_projects``` (```-p```) will go through"},{"line_number":21,"context_line":"the database and remove projects that have no associated resources."},{"line_number":22,"context_line":"The default value is False."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aed3d3a_fa004968","line":20,"in_reply_to":"9aed3d3a_b10a6c88","updated":"2016-03-01 18:35:27.000000000","message":"Done","commit_id":"d47b7cdf9262ded1f735a6cfacf9d89b0c98134f"}]}
