)]}'
{"barbican/plugin/interface/secret_store.py":[{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"0d056fdc74053611490b5446bded9141ad0ae1d1","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class SecretStoreSupportedPluginNotFound(exception.BarbicanException):"},{"line_number":68,"context_line":"    \"\"\"Raised if no plugins are found that support the requested operation.\"\"\""},{"line_number":69,"context_line":"    message \u003d u._(\"Secret store plugin not found for requested operation.\")"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class SecretContentTypeNotSupportedException(exception.BarbicanHTTPException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_0f09b131","line":69,"updated":"2016-03-02 16:11:58.000000000","message":"Could we just also make this a 400 error instead of changing the exception returned in this patch? Returning SecretStorePluginNotFound implies that no plugins are installed where as SecretStoreSupportedPluginNotFound implies exactly what this patch is trying to solve, the situation where KMIP is installed but doesn\u0027t support the request.","commit_id":"9bd1840e241861dfff4dd24bf39e1913e1b0ea99"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"818e9b398f5fb2e3e5b5a24435183042eb1737a3","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class SecretStoreSupportedPluginNotFound(exception.BarbicanException):"},{"line_number":68,"context_line":"    \"\"\"Raised if no plugins are found that support the requested operation.\"\"\""},{"line_number":69,"context_line":"    message \u003d u._(\"Secret store plugin not found for requested operation.\")"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class SecretContentTypeNotSupportedException(exception.BarbicanHTTPException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_68a24c9c","line":69,"in_reply_to":"7af24918_0f09b131","updated":"2016-03-04 20:07:55.000000000","message":"+1 for Chris\u0027s suggestion","commit_id":"9bd1840e241861dfff4dd24bf39e1913e1b0ea99"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"a24e73870b50ae5c0faf3d6b1631a2e5b7f3d5f1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        super(SecretStorePluginNotFound, self).__init__(message)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class SecretStoreSupportedPluginNotFound(exception.BarbicanException):"},{"line_number":68,"context_line":"    \"\"\"Raised if no plugins are found that support the requested operation.\"\"\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    client_message \u003d u._(\"Secret store supported plugin not found.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_45e6be15","line":67,"range":{"start_line":67,"start_character":51,"end_line":67,"end_character":68},"updated":"2016-03-09 17:21:01.000000000","message":"I think this is supposed to be a BarbicanHTTPException because there is a client_message and status_code.","commit_id":"c7eb23f58c98af6e6f256e894209f8482e1c4c81"}]}
