)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"201cc4f191bee0db06f8d5e782192b8f973cdf3e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Krotscheck \u003ckrotscheck@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-03 10:08:29 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Moved CORS middleware configuration into oslo-config-generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default values needed for barbican\u0027s implementation of cors"},{"line_number":10,"context_line":"middleware have been moved from paste.ini into the configuration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7af24918_a5059d15","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":62},"updated":"2016-03-04 19:56:37.000000000","message":"This title is a little confusing to me because Barbican doesn\u0027t use oslo-config-generator. Am I missing something?","commit_id":"29e145f78ebecdfdbea43d4e499dd2c65a9d16e2"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"29fc0ec11580964cb231364751c24579d74b17c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Krotscheck \u003ckrotscheck@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-03 10:08:29 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Moved CORS middleware configuration into oslo-config-generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default values needed for barbican\u0027s implementation of cors"},{"line_number":10,"context_line":"middleware have been moved from paste.ini into the configuration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_a0ef3eaf","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":62},"in_reply_to":"7af24918_a5059d15","updated":"2016-03-07 14:47:27.000000000","message":"Ah. yes. My bad.","commit_id":"29e145f78ebecdfdbea43d4e499dd2c65a9d16e2"}],"barbican/common/config.py":[{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"a7a9286eb191d956702083c83d428e7f404d8838","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            raise"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"def set_middleware_defaults():"},{"line_number":229,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":230,"context_line":"    # CORS Defaults"},{"line_number":231,"context_line":"    # TODO(krotscheck): Update with https://review.openstack.org/#/c/285368/"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_09b95515","line":228,"updated":"2016-03-03 17:44:31.000000000","message":"Is there a reason to have this method instead of just making a cors_opt_group and cors_opts section above and registering the group and opts in new_config() above? \n\nIt would be more consistent and there would be no need for this extra method being called in barbican_manage. It would be taken care of when new_config() gets called every time.","commit_id":"e1eb151a9147f0928a978e61ef942d3eaa4d2532"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"54cd524f95e936164e7d7daf8ee9c7f006a9b3f9","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            raise"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"def set_middleware_defaults():"},{"line_number":229,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":230,"context_line":"    # CORS Defaults"},{"line_number":231,"context_line":"    # TODO(krotscheck): Update with https://review.openstack.org/#/c/285368/"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_6c8bc71f","line":228,"in_reply_to":"7af24918_09b95515","updated":"2016-03-03 18:03:44.000000000","message":"Yes. It imposes a maintenance burden on the project, as this list_opt will now have to be manually kept in sync with the opts in oslo_middleware. By using the oslo_middleware.cors.set_defaults() method (see TODO), this maintenance burden, especially regarding backwards compatibility, is placed on oslo team.\n\nAlso, oslo.config tends to raise breaking exceptions if it encounters properties already registered, and these configuration options are registered in the middleware, not here.\n\nFor more details, I\u0027d recommend talking to dhellmann or someone on the oslo team.","commit_id":"e1eb151a9147f0928a978e61ef942d3eaa4d2532"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"201cc4f191bee0db06f8d5e782192b8f973cdf3e","unresolved":false,"context_lines":[{"line_number":232,"context_line":"def set_middleware_defaults():"},{"line_number":233,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":234,"context_line":"    # CORS Defaults"},{"line_number":235,"context_line":"    # TODO(krotscheck): Update with https://review.openstack.org/#/c/285368/"},{"line_number":236,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":237,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":238,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_e52fa5a5","line":235,"updated":"2016-03-04 19:56:37.000000000","message":"To clarify, this patch works correctly now, but the TODO will just make things a little nicer?","commit_id":"29e145f78ebecdfdbea43d4e499dd2c65a9d16e2"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"29fc0ec11580964cb231364751c24579d74b17c5","unresolved":false,"context_lines":[{"line_number":232,"context_line":"def set_middleware_defaults():"},{"line_number":233,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":234,"context_line":"    # CORS Defaults"},{"line_number":235,"context_line":"    # TODO(krotscheck): Update with https://review.openstack.org/#/c/285368/"},{"line_number":236,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":237,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":238,"context_line":"                                    \u0027X-Openstack-Request-Id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_20032e75","line":235,"in_reply_to":"7af24918_e52fa5a5","updated":"2016-03-07 14:47:27.000000000","message":"The work in this TODO will offload any future backwards-compatibility work onto the oslo team (namely, me). Say, if for some reason \u0027allow_headers\u0027 changes names, we can handle the case statement in oslo_middleware.config way easier than landing a patch in every single project again.","commit_id":"29e145f78ebecdfdbea43d4e499dd2c65a9d16e2"}],"setup.cfg":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6d5ec2d21b6db80c8dd9c40e85362605f8ed5828","unresolved":false,"context_lines":[{"line_number":47,"context_line":"barbican.test.crypto.plugin \u003d"},{"line_number":48,"context_line":"    test_crypto \u003d barbican.tests.crypto.test_plugin:TestCryptoPlugin"},{"line_number":49,"context_line":"oslo.config.opts.defaults \u003d"},{"line_number":50,"context_line":"    oslo.middleware \u003d barbican.common.config:set_middleware_defaults"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[build_sphinx]"},{"line_number":53,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"3afc51ec_24185d84","line":50,"updated":"2016-03-11 20:21:10.000000000","message":"see https://review.openstack.org/#/c/291887/","commit_id":"e134b6fcaf3ab1709c5f65c3ddc1a55992a6f347"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"4f8ac0d0a547f08189518606022ec51f62f7ae36","unresolved":false,"context_lines":[{"line_number":49,"context_line":"barbican.test.crypto.plugin \u003d"},{"line_number":50,"context_line":"    test_crypto \u003d barbican.tests.crypto.test_plugin:TestCryptoPlugin"},{"line_number":51,"context_line":"oslo.config.opts.defaults \u003d"},{"line_number":52,"context_line":"    barbican.api \u003d barbican.common.config:set_middleware_defaults"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"[build_sphinx]"},{"line_number":55,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"3afc51ec_b28bcb1d","line":52,"updated":"2016-03-14 14:58:10.000000000","message":"nitpicky, but could you change \"barbican.api\" to use underscores (to match the others) and to something cors-specific, like barbican_middleware_defaults","commit_id":"7dce25095c540342e862c668a5089ddee862d662"}]}