)]}'
{"barbican/model/repositories.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"330095ba7718a10f4a2cd502eab427020d166286","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"def _create_engine(connection, **engine_args):"},{"line_number":218,"context_line":"    LOG.debug(\u0027Sql connection: please check \"sql_connection\" property in barbican configuration file; Args: %s\u0027, engine_args)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    engine \u003d sqlalchemy.create_engine(connection, **engine_args)"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_da76dd04","line":218,"updated":"2016-04-07 17:29:54.000000000","message":"line too long, will give pep8 failure.  Also, do we know that there are no passwords/etc in the engine args?","commit_id":"1f53c021b9dc3dacccb7b1ce0dc921dff07ce2fe"},{"author":{"_account_id":18623,"name":"Pankaj Khandar","email":"pankaj.khandar@gmail.com","username":"Pan"},"change_message_id":"8810eab7e8b686a5d5122130df08716c8e2cc7b9","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"def _create_engine(connection, **engine_args):"},{"line_number":218,"context_line":"    LOG.debug(\u0027Sql connection: please check \"sql_connection\" property in barbican configuration file; Args: %s\u0027, engine_args)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    engine \u003d sqlalchemy.create_engine(connection, **engine_args)"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_f49db5bc","line":218,"in_reply_to":"9a061dce_da76dd04","updated":"2016-04-07 18:14:12.000000000","message":"No password or sensitive information in args, this is what i have \nSql connection: please check \"sql_connection\" property in barbican configuration file; Args: {\u0027pool_recycle\u0027: 3600, \u0027convert_unicode\u0027: True, \u0027echo\u0027: False}","commit_id":"1f53c021b9dc3dacccb7b1ce0dc921dff07ce2fe"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"f2cf648a735735af5858efb701b630ad75af65e6","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    LOG.info(\u0027Setting up database engine and session factory\u0027)"},{"line_number":94,"context_line":"    LOG.debug(\u0027Sql connection: please check \"sql_connection\" property in \u0027"},{"line_number":95,"context_line":"              \u0027barbican configuration file\u0027)"},{"line_number":96,"context_line":"    if CONF.debug:"},{"line_number":97,"context_line":"        sa_logger \u003d logging.getLogger(\u0027sqlalchemy.engine\u0027)"},{"line_number":98,"context_line":"        sa_logger.setLevel(logging.DEBUG)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_03158d9a","line":95,"updated":"2016-04-07 20:25:08.000000000","message":"As there is no conf value logged, do we need this line (94-95)? May be we can remove it as we already have a line before to identify code block execution.","commit_id":"8f2d449afa25fe7854d8810a4abd2093c9d62ff0"},{"author":{"_account_id":18623,"name":"Pankaj Khandar","email":"pankaj.khandar@gmail.com","username":"Pan"},"change_message_id":"92fe82978de4c0471265ca9d3114dbf08fc9712b","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    LOG.info(\u0027Setting up database engine and session factory\u0027)"},{"line_number":94,"context_line":"    LOG.debug(\u0027Sql connection: please check \"sql_connection\" property in \u0027"},{"line_number":95,"context_line":"              \u0027barbican configuration file\u0027)"},{"line_number":96,"context_line":"    if CONF.debug:"},{"line_number":97,"context_line":"        sa_logger \u003d logging.getLogger(\u0027sqlalchemy.engine\u0027)"},{"line_number":98,"context_line":"        sa_logger.setLevel(logging.DEBUG)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_be05d414","line":95,"in_reply_to":"9a061dce_03158d9a","updated":"2016-04-07 21:00:22.000000000","message":"Agree, not needed","commit_id":"8f2d449afa25fe7854d8810a4abd2093c9d62ff0"}]}
