)]}'
{"barbican/api/controllers/__init__.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"c020801049806148398c61988950dbf6e75c2d90","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            except policy.PolicyNotAuthorized as pna:"},{"line_number":110,"context_line":"                status, message \u003d api.generate_safe_exception_message("},{"line_number":111,"context_line":"                    operation_name, pna)"},{"line_number":112,"context_line":"                LOG.error(message)"},{"line_number":113,"context_line":"                pecan.abort(status, message)"},{"line_number":114,"context_line":"            except Exception as e:"},{"line_number":115,"context_line":"                # In case intervening modules have disabled logging."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_98e9c31d","line":112,"updated":"2016-04-17 20:24:35.000000000","message":"This should be LOG.exception[1]\n\n[1]https://github.com/openstack/oslo.log/blob/c47a91dbbb586c27d8521b1016bf7901c47b1c90/doc/source/examples/usage.py#L83","commit_id":"5e9856fb43c2228783ff777e0ddfd50e54bbb62b"},{"author":{"_account_id":18623,"name":"Pankaj Khandar","email":"pankaj.khandar@gmail.com","username":"Pan"},"change_message_id":"e39bf302d5b4f652f240d3249af31a7595c60a52","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            except policy.PolicyNotAuthorized as pna:"},{"line_number":110,"context_line":"                status, message \u003d api.generate_safe_exception_message("},{"line_number":111,"context_line":"                    operation_name, pna)"},{"line_number":112,"context_line":"                LOG.error(message)"},{"line_number":113,"context_line":"                pecan.abort(status, message)"},{"line_number":114,"context_line":"            except Exception as e:"},{"line_number":115,"context_line":"                # In case intervening modules have disabled logging."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_ecba98e0","line":112,"in_reply_to":"1a122d0e_393cd0e1","updated":"2016-04-18 16:07:51.000000000","message":"John, Any suggestion on how to suppress the payload from the expception trace?","commit_id":"5e9856fb43c2228783ff777e0ddfd50e54bbb62b"},{"author":{"_account_id":18623,"name":"Pankaj Khandar","email":"pankaj.khandar@gmail.com","username":"Pan"},"change_message_id":"4319089a46840807fb61c7d7ea2aac9833d095ff","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            except policy.PolicyNotAuthorized as pna:"},{"line_number":110,"context_line":"                status, message \u003d api.generate_safe_exception_message("},{"line_number":111,"context_line":"                    operation_name, pna)"},{"line_number":112,"context_line":"                LOG.error(message)"},{"line_number":113,"context_line":"                pecan.abort(status, message)"},{"line_number":114,"context_line":"            except Exception as e:"},{"line_number":115,"context_line":"                # In case intervening modules have disabled logging."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_b85d9feb","line":112,"in_reply_to":"1a122d0e_98e9c31d","updated":"2016-04-17 20:42:46.000000000","message":"Diaz, Exception will dump the input payload which have a Secret and sensitive Data. If you have other suggestion to avoid dumping secret in log please let me know. Please refer to https://bugs.launchpad.net/barbican/+bug/1568648 for details trace. thanks","commit_id":"5e9856fb43c2228783ff777e0ddfd50e54bbb62b"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"e61619c4e470f68c44be48bd0403de80cb43785e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            except policy.PolicyNotAuthorized as pna:"},{"line_number":110,"context_line":"                status, message \u003d api.generate_safe_exception_message("},{"line_number":111,"context_line":"                    operation_name, pna)"},{"line_number":112,"context_line":"                LOG.error(message)"},{"line_number":113,"context_line":"                pecan.abort(status, message)"},{"line_number":114,"context_line":"            except Exception as e:"},{"line_number":115,"context_line":"                # In case intervening modules have disabled logging."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_393cd0e1","line":112,"in_reply_to":"1a122d0e_b85d9feb","updated":"2016-04-18 16:00:17.000000000","message":"I would agree with Fernando in that we don\u0027t want to swallow the root cause exception/trace wrt to logs. I would prefer suppressing the payload from the stack trace if possible.","commit_id":"5e9856fb43c2228783ff777e0ddfd50e54bbb62b"},{"author":{"_account_id":18623,"name":"Pankaj Khandar","email":"pankaj.khandar@gmail.com","username":"Pan"},"change_message_id":"0e6e5fff6c45273cf96eb386afa0cc789b370871","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            except policy.PolicyNotAuthorized as pna:"},{"line_number":110,"context_line":"                status, message \u003d api.generate_safe_exception_message("},{"line_number":111,"context_line":"                    operation_name, pna)"},{"line_number":112,"context_line":"                LOG.error(message)"},{"line_number":113,"context_line":"                pecan.abort(status, message)"},{"line_number":114,"context_line":"            except Exception as e:"},{"line_number":115,"context_line":"                # In case intervening modules have disabled logging."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_ec60d837","line":112,"in_reply_to":"1a122d0e_ecba98e0","updated":"2016-04-18 16:12:33.000000000","message":"Diaz, John, Even tough we are creating a safe message, because of oslo policy exception trace will dump the args,kwargs stuff in log. Please let me know any other option here other than just print safe \"message\" via LOG.error(). thanks!","commit_id":"5e9856fb43c2228783ff777e0ddfd50e54bbb62b"}]}
