)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"575d88d04688e281992bc1db566018dc4d696bb0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"new private key and certificate are created. They are configured for"},{"line_number":12,"context_line":"the client-side of the KMIP connection. The PyKMIP server is installed"},{"line_number":13,"context_line":"and configured to use the same key pair."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib804fa97545f14ed866bfd73bb251e85923a2e4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_dfaef32c","line":14,"updated":"2016-04-20 12:49:04.000000000","message":"Please add `Depends-on: \u003cchange-id\u003e` for the global requirements update.","commit_id":"4196a9783cf4c6a53e32fdaf36c6d3987f355f42"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"a083a42411a057f2ff4829201572452934566132","unresolved":false,"context_lines":[{"line_number":11,"context_line":"new private key and certificate are created. They are configured for"},{"line_number":12,"context_line":"the client-side of the KMIP connection. The PyKMIP server is installed"},{"line_number":13,"context_line":"and configured to use the same key pair."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib804fa97545f14ed866bfd73bb251e85923a2e4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_e6d81582","line":14,"in_reply_to":"1a122d0e_dfaef32c","updated":"2016-05-03 13:12:29.000000000","message":"Done","commit_id":"4196a9783cf4c6a53e32fdaf36c6d3987f355f42"}],"devstack/lib/barbican":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0d8855d0ff65524f56f1442138a8c5ad584ea3f0","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    sudo chown ${USER} ${PYKMIP_LOG_DIR}"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]"},{"line_number":372,"context_line":"    then"},{"line_number":373,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":374,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY} -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":375,"context_line":"        chmod 400 ${PYKMIP_KEY}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1a122d0e_4873af4d","line":372,"range":{"start_line":372,"start_character":4,"end_line":372,"end_character":8},"updated":"2016-04-18 19:45:58.000000000","message":"For consistency, I think it would be better to move the \"then\" into the same line as the \"if\"","commit_id":"45e50a0d1c96747c525065ae57e872822f7dc1dc"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"3909d0cca218648915b22a319fe1251a107e22f6","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    sudo chown ${USER} ${PYKMIP_LOG_DIR}"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]"},{"line_number":372,"context_line":"    then"},{"line_number":373,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":374,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY} -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":375,"context_line":"        chmod 400 ${PYKMIP_KEY}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1a122d0e_cc04ce4b","line":372,"range":{"start_line":372,"start_character":4,"end_line":372,"end_character":8},"in_reply_to":"1a122d0e_4873af4d","updated":"2016-04-19 13:42:10.000000000","message":"Done","commit_id":"45e50a0d1c96747c525065ae57e872822f7dc1dc"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"d32d30f01d14f2b14aae72218afc53c9f3d71d61","unresolved":false,"context_lines":[{"line_number":363,"context_line":"function install_pykmip {"},{"line_number":364,"context_line":"    pip_install \u0027pykmip\u0027"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    [ ! -d ${PYKMIP_CONF_DIR} ] \u0026\u0026 sudo mkdir ${PYKMIP_CONF_DIR}"},{"line_number":367,"context_line":"    sudo chown ${USER} ${PYKMIP_CONF_DIR}"},{"line_number":368,"context_line":"    [ ! -d ${PYKMIP_LOG_DIR} ] \u0026\u0026 sudo mkdir ${PYKMIP_LOG_DIR}"},{"line_number":369,"context_line":"    sudo chown ${USER} ${PYKMIP_LOG_DIR}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_47608201","line":366,"range":{"start_line":366,"start_character":4,"end_line":366,"end_character":64},"updated":"2016-04-19 22:09:06.000000000","message":"I think it be more conventional to say `sudo mkdir -p ${PYKMIP_CONF_DIR}`","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"0914fa3b47776e0847a10794ae5d0ad1effd7271","unresolved":false,"context_lines":[{"line_number":363,"context_line":"function install_pykmip {"},{"line_number":364,"context_line":"    pip_install \u0027pykmip\u0027"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    [ ! -d ${PYKMIP_CONF_DIR} ] \u0026\u0026 sudo mkdir ${PYKMIP_CONF_DIR}"},{"line_number":367,"context_line":"    sudo chown ${USER} ${PYKMIP_CONF_DIR}"},{"line_number":368,"context_line":"    [ ! -d ${PYKMIP_LOG_DIR} ] \u0026\u0026 sudo mkdir ${PYKMIP_LOG_DIR}"},{"line_number":369,"context_line":"    sudo chown ${USER} ${PYKMIP_LOG_DIR}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_9bfaef41","line":366,"range":{"start_line":366,"start_character":4,"end_line":366,"end_character":64},"in_reply_to":"1a122d0e_47608201","updated":"2016-04-20 00:19:15.000000000","message":"I tried to stay consistent with the other code that also creates the directories. Checkout lines 81-87. Plus I also kind of like the check to make sure the directory is not there.\n\nI probably should still add the -p option because the other ones do that as well. Plus it will fix bugs in case parent dirs do not exist.","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"12e3eaf11df1f7566881ac01861eb4965a7f64f4","unresolved":false,"context_lines":[{"line_number":363,"context_line":"function install_pykmip {"},{"line_number":364,"context_line":"    pip_install \u0027pykmip\u0027"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    [ ! -d ${PYKMIP_CONF_DIR} ] \u0026\u0026 sudo mkdir ${PYKMIP_CONF_DIR}"},{"line_number":367,"context_line":"    sudo chown ${USER} ${PYKMIP_CONF_DIR}"},{"line_number":368,"context_line":"    [ ! -d ${PYKMIP_LOG_DIR} ] \u0026\u0026 sudo mkdir ${PYKMIP_LOG_DIR}"},{"line_number":369,"context_line":"    sudo chown ${USER} ${PYKMIP_LOG_DIR}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_ff576f55","line":366,"range":{"start_line":366,"start_character":4,"end_line":366,"end_character":64},"in_reply_to":"1a122d0e_9bfaef41","updated":"2016-04-20 12:48:52.000000000","message":"Odd that there\u0027s an explicit check for existence and `-p` since the latter automatically creates the directory (and parents) if it doesn\u0027t already exist, but best to be consistent I suppose.","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"d32d30f01d14f2b14aae72218afc53c9f3d71d61","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    [ ! -d ${PYKMIP_CONF_DIR} ] \u0026\u0026 sudo mkdir ${PYKMIP_CONF_DIR}"},{"line_number":367,"context_line":"    sudo chown ${USER} ${PYKMIP_CONF_DIR}"},{"line_number":368,"context_line":"    [ ! -d ${PYKMIP_LOG_DIR} ] \u0026\u0026 sudo mkdir ${PYKMIP_LOG_DIR}"},{"line_number":369,"context_line":"    sudo chown ${USER} ${PYKMIP_LOG_DIR}"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_a737d6fd","line":368,"range":{"start_line":368,"start_character":4,"end_line":368,"end_character":62},"updated":"2016-04-19 22:09:06.000000000","message":"same here","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"fdd9de850c31ea1e2f11a86ebf0d0a8c43e2c7fc","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    sudo chown ${USER} ${PYKMIP_LOG_DIR}"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY} -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":374,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":375,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_170fdd37","line":372,"updated":"2016-04-19 19:48:52.000000000","message":"Interesting choices for the state and locality. Are values required or can they be left empty?","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"d32d30f01d14f2b14aae72218afc53c9f3d71d61","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    sudo chown ${USER} ${PYKMIP_LOG_DIR}"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY} -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":374,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":375,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_e73d4ede","line":372,"in_reply_to":"1a122d0e_170fdd37","updated":"2016-04-19 22:09:06.000000000","message":"+1","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"0914fa3b47776e0847a10794ae5d0ad1effd7271","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    sudo chown ${USER} ${PYKMIP_LOG_DIR}"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY} -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":374,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":375,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_fba16347","line":372,"in_reply_to":"1a122d0e_170fdd37","updated":"2016-04-20 00:19:15.000000000","message":"I\u0027m not sure if required. I wanted something that looks like a real certificate.","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"fdd9de850c31ea1e2f11a86ebf0d0a8c43e2c7fc","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY} -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":374,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":375,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"},{"line_number":376,"context_line":"[server]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_92013b08","line":373,"updated":"2016-04-19 19:48:52.000000000","message":"Wrap line?","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"d32d30f01d14f2b14aae72218afc53c9f3d71d61","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY} -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":374,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":375,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"},{"line_number":376,"context_line":"[server]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_272466c3","line":373,"in_reply_to":"1a122d0e_92013b08","updated":"2016-04-19 22:09:06.000000000","message":"+1","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"0914fa3b47776e0847a10794ae5d0ad1effd7271","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY} -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":374,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":375,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"},{"line_number":376,"context_line":"[server]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_9ba82f22","line":373,"in_reply_to":"1a122d0e_92013b08","updated":"2016-04-20 00:19:15.000000000","message":"Done","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"d32d30f01d14f2b14aae72218afc53c9f3d71d61","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY} -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":374,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":375,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"},{"line_number":376,"context_line":"[server]"},{"line_number":377,"context_line":"hostname\u003d127.0.0.1"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_c719328a","line":374,"range":{"start_line":374,"start_character":8,"end_line":374,"end_character":13},"updated":"2016-04-19 22:09:06.000000000","message":"Does this need a `sudo`?","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"0914fa3b47776e0847a10794ae5d0ad1effd7271","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY} -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":374,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":375,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"},{"line_number":376,"context_line":"[server]"},{"line_number":377,"context_line":"hostname\u003d127.0.0.1"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a122d0e_7b8ef3d0","line":374,"range":{"start_line":374,"start_character":8,"end_line":374,"end_character":13},"in_reply_to":"1a122d0e_c719328a","updated":"2016-04-20 00:19:15.000000000","message":"I don\u0027t believe so. The key is created above with the openssl command that is running as $USER. This means the $USER should own the key and can chmod it. No errors were thrown when I ran through testing.","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"309c2a6d6ebde16f58068b26edaec2df68ae08b2","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"# start_pykmip - start the PyKMIP server"},{"line_number":399,"context_line":"function start_pykmip {"},{"line_number":400,"context_line":"    run_process pykmip \"pykmip-server -f \\\u0027${PYKMIP_CONF}\\\u0027 -l \\\u0027${PYKMIP_LOG_DIR}/pykmip-devstack.log\\\u0027\""},{"line_number":401,"context_line":"}"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"# Dogtag functions"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1a122d0e_78cad0a2","line":400,"range":{"start_line":400,"start_character":16,"end_line":400,"end_character":22},"updated":"2016-04-22 19:37:29.000000000","message":"Should this process be called something like pykmip-server to be more specific?  Just pykmip is kind of vague.","commit_id":"4196a9783cf4c6a53e32fdaf36c6d3987f355f42"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"a083a42411a057f2ff4829201572452934566132","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"# start_pykmip - start the PyKMIP server"},{"line_number":399,"context_line":"function start_pykmip {"},{"line_number":400,"context_line":"    run_process pykmip \"pykmip-server -f \\\u0027${PYKMIP_CONF}\\\u0027 -l \\\u0027${PYKMIP_LOG_DIR}/pykmip-devstack.log\\\u0027\""},{"line_number":401,"context_line":"}"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"# Dogtag functions"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1a122d0e_26e32d35","line":400,"range":{"start_line":400,"start_character":16,"end_line":400,"end_character":22},"in_reply_to":"1a122d0e_78cad0a2","updated":"2016-05-03 13:12:29.000000000","message":"Done","commit_id":"4196a9783cf4c6a53e32fdaf36c6d3987f355f42"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"9b2edecf30d902c48226a2ae7c267b12a9121901","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY}\\"},{"line_number":374,"context_line":"            -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":375,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":376,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"},{"line_number":377,"context_line":"[server]"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1a122d0e_06f7118d","line":374,"updated":"2016-05-03 13:25:38.000000000","message":"lib/tls has a make_cert function that can replace this openssl call.","commit_id":"e9d62b079dc72e71db9419ff28f8c08788e3efc8"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"315b428f08b8cda35d4f1a25e517cd47dd92a141","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY}\\"},{"line_number":374,"context_line":"            -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":375,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":376,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"},{"line_number":377,"context_line":"[server]"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1a122d0e_a7760dd6","line":374,"in_reply_to":"1a122d0e_06f7118d","updated":"2016-05-03 18:24:59.000000000","message":"How does it work? I\u0027m not familiar with it but it seems more complicated like I have to make several calls. Can you help?","commit_id":"e9d62b079dc72e71db9419ff28f8c08788e3efc8"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"c567f233b5511e92369565275d2b05d618b3098e","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    if [ ! -e ${PYKMIP_KEY} ]; then"},{"line_number":372,"context_line":"        local subject\u003d\u0027/C\u003dUS/ST\u003dMissouri/L\u003dEthlyn/O\u003dOpenKMIP/OU\u003dOrg/CN\u003dlocalhost\u0027"},{"line_number":373,"context_line":"        openssl req -x509 -newkey rsa:2048 -keyout ${PYKMIP_KEY}\\"},{"line_number":374,"context_line":"            -out ${PYKMIP_CERT} -days 365 -nodes -subj ${subject}"},{"line_number":375,"context_line":"        chmod 400 ${PYKMIP_KEY}"},{"line_number":376,"context_line":"        cat \u003e ${PYKMIP_CONF} \u003c\u003cEOF"},{"line_number":377,"context_line":"[server]"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1a122d0e_4df1f4cc","line":374,"in_reply_to":"1a122d0e_a7760dd6","updated":"2016-05-04 14:20:51.000000000","message":"Assuming you just need a cert is is probably fine to use $DEVSTACK_CERT. Unfortunately right now that contains both the cert and key. I have a review, https://review.openstack.org/#/c/301172, which splits this out.\n\nOtherwise the call looks like:\n\nmake_cert $INT_CA_DIR $CERT_NAME HOSTNAME \"SAN\"\n\nwhere $CERT_NAME is the filename for your cert. This isn\u0027t a full path. You\u0027ll find the resulting cert and key in $DATA_DIR/$CERT_NAME.pem\n\n$INT_CA_DIR is defined in lib/tls so it should just work.\n\nSAN is optional.","commit_id":"e9d62b079dc72e71db9419ff28f8c08788e3efc8"}],"test-requirements.txt":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"db834629a52c79f746aba9dfa861ae90cf139205","unresolved":false,"context_lines":[{"line_number":5,"context_line":"hacking\u003c0.11,\u003e\u003d0.10.0"},{"line_number":6,"context_line":"mock\u003e\u003d1.2 # BSD"},{"line_number":7,"context_line":"oslotest\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":8,"context_line":"pykmip\u003e\u003d0.5.0 # Apache 2.0 License"},{"line_number":9,"context_line":"testrepository\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":10,"context_line":"testtools\u003e\u003d1.4.0 # MIT"},{"line_number":11,"context_line":"fixtures\u003c2.0,\u003e\u003d1.3.1 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":2,"id":"1a122d0e_5854effd","line":8,"updated":"2016-04-19 15:47:18.000000000","message":"Hey Nate, is this needed? Global reqs is still at 0.4.0","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"fdd9de850c31ea1e2f11a86ebf0d0a8c43e2c7fc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"hacking\u003c0.11,\u003e\u003d0.10.0"},{"line_number":6,"context_line":"mock\u003e\u003d1.2 # BSD"},{"line_number":7,"context_line":"oslotest\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":8,"context_line":"pykmip\u003e\u003d0.5.0 # Apache 2.0 License"},{"line_number":9,"context_line":"testrepository\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":10,"context_line":"testtools\u003e\u003d1.4.0 # MIT"},{"line_number":11,"context_line":"fixtures\u003c2.0,\u003e\u003d1.3.1 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":2,"id":"1a122d0e_7751f135","line":8,"in_reply_to":"1a122d0e_5854effd","updated":"2016-04-19 19:48:52.000000000","message":"Yes, it is needed, and I think that requires a global requirements update.","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"0914fa3b47776e0847a10794ae5d0ad1effd7271","unresolved":false,"context_lines":[{"line_number":5,"context_line":"hacking\u003c0.11,\u003e\u003d0.10.0"},{"line_number":6,"context_line":"mock\u003e\u003d1.2 # BSD"},{"line_number":7,"context_line":"oslotest\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":8,"context_line":"pykmip\u003e\u003d0.5.0 # Apache 2.0 License"},{"line_number":9,"context_line":"testrepository\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":10,"context_line":"testtools\u003e\u003d1.4.0 # MIT"},{"line_number":11,"context_line":"fixtures\u003c2.0,\u003e\u003d1.3.1 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":2,"id":"1a122d0e_db4bc785","line":8,"in_reply_to":"1a122d0e_7751f135","updated":"2016-04-20 00:19:15.000000000","message":"I will submit a new patch to global requirements.","commit_id":"1f7ef53cbd7b431d0db63df4a223c2f92d871938"}]}
